v2.01: Minor Bug Fixes and Improvements
commit : 2a3d6ecde8a86154cfaba067dfcbe459ef2aa8e1
author : David Steele <[email protected]>
date : Mon, 19 Mar 2018 21:49:41 -0400
committer: David Steele <[email protected]>
date : Mon, 19 Mar 2018 21:49:41 -0400
Bug Fixes:
* Fix --target-action and --recovery-option options being reported as invalid when restoring with --type=immediate. (Reported by Brad Nicholson.)
* Immediately error when a secure option (e.g. repo1-s3-key) is passed on the command line. Since pgBackRest would not pass secure options on to sub-processes an obscure error was thrown. The new error is much clearer and provides hints about how to fix the problem. Update command documentation to omit secure options that cannot be specified on the command-line. (Reported by Brad Nicholson.)
* Fix issue passing --no-config to embedded Perl. (Reported by Ibrahim Edib Kokdemir.)
* Fix issue where specifying log-level-stderr > warn would cause a local/remote process to error on exit due to output found on stderr when none was expected. The max value for a local/remote process is now error since there is no reason for these processes to emit warnings. (Reported by Clinton Adams.)
* Fix manifest test in the check command when tablespaces are present. (Fixed by Cynthia Shang. Reported by Thomas Flatley.)
Improvements:
* Error when multiple arguments are set in the config file for an option that does not accept multiple arguments. (Contributed by Cynthia Shang.)
* Remove extraneous sudo commands from src/Makefile. (Contributed by Adrian Vondendriesch.)
M README.md
M doc/resource/exe.cache
M doc/xml/release.xml
M lib/pgBackRest/Version.pm
M libc/lib/pgBackRest/LibCAuto.pm
M src/version.h
Remove hard-coded release version from loadTest.c.
commit : 45c6a0e864189a309ad3e5c0f643b46dd50fb303
author : David Steele <[email protected]>
date : Mon, 19 Mar 2018 21:03:42 -0400
committer: David Steele <[email protected]>
date : Mon, 19 Mar 2018 21:03:42 -0400
M test/src/module/config/loadTest.c
Always autogenerate code if --smart is not specified.
commit : 5b0748cf93d49d52bf74290e05c208fc88017a26
author : David Steele <[email protected]>
date : Mon, 19 Mar 2018 20:25:55 -0400
committer: David Steele <[email protected]>
date : Mon, 19 Mar 2018 20:25:55 -0400
M test/test.pl
Fix manifest test in the check command when tablespaces are present.
commit : f0a4264f77a7d9cb1dc5434e3c76c8313c600c79
author : Cynthia Shang <[email protected]>
date : Mon, 19 Mar 2018 19:54:03 -0400
committer: David Steele <[email protected]>
date : Mon, 19 Mar 2018 19:54:03 -0400
Fixed by Cynthia Shang.
Reported by Thomas Flatley.
M doc/xml/release.xml
M lib/pgBackRest/Check/Check.pm
M test/expect/real-all-001.log
M test/expect/real-all-004.log
M test/expect/real-all-006.log
M test/lib/pgBackRestTest/Env/Host/HostBackupTest.pm
M test/lib/pgBackRestTest/Module/Real/RealAllTest.pm
Remove --smart from --expect tests.
commit : 8e9e97728c5f58790ba91305f465b04d8a7a061a
author : David Steele <[email protected]>
date : Mon, 19 Mar 2018 17:38:44 -0400
committer: David Steele <[email protected]>
date : Mon, 19 Mar 2018 17:38:44 -0400
This ensures that new binaries are built before running the tests.
M doc/xml/release.xml
M test/test.pl
Fix issue where specifying log-level-stderr > warn would cause a local/remote process to error on exit due to output found on stderr when none was expected.
commit : 2c1687721e57b1917dc3f3bed62aa01b59078f5c
author : David Steele <[email protected]>
date : Mon, 19 Mar 2018 13:08:42 -0400
committer: David Steele <[email protected]>
date : Mon, 19 Mar 2018 13:08:42 -0400
The max value for a local/remote process is now error since there's no reason for these processes to emit warnings.
Reported by Clinton Adams.
M build/lib/pgBackRestBuild/Config/Build.pm
M build/lib/pgBackRestBuild/Config/Data.pm
M doc/xml/release.xml
M src/config/config.auto.c
M src/config/config.c
M src/config/config.h
M src/config/load.c
M test/src/module/config/configTest.c
M test/src/module/config/loadTest.c
Use clang for static code analysis during lint testing.
commit : 0c313713b1f40f09a970bee70e4e1ca3bcbbe082
author : David Steele <[email protected]>
date : Sun, 18 Mar 2018 13:32:19 -0400
committer: David Steele <[email protected]>
date : Sun, 18 Mar 2018 13:32:19 -0400
Nothing found except for some functions that should have been marked __noreturn__.
M doc/xml/release.xml
M src/common/error.c
M src/common/error.h
M src/common/memContext.c
M src/common/regExp.c
M src/config/parse.c
M test/lib/pgBackRestTest/Common/ContainerTest.pm
M test/test.pl
M test/travis.pl
Enable -Wformat=2 and -Wformat-nonliteral and silence new warnings.
commit : f0451c1494d0886c8fc24734eb8f98d403ce91dc
author : David Steele <[email protected]>
date : Thu, 15 Mar 2018 13:53:03 -0400
committer: David Steele <[email protected]>
date : Thu, 15 Mar 2018 13:53:03 -0400
M doc/xml/release.xml
M src/Makefile
M test/lib/pgBackRestTest/Common/JobTest.pm
M test/src/module/common/typeListTest.c
M test/src/module/common/typeStringListTest.c
M test/src/module/config/configTest.c
M test/src/module/config/defineTest.c
Immediately error when a secure option (e.g. repo1-s3-key) is passed on the command line.
commit : 8a1ce42c30e7e9ac79b1f7b66aa870d84c7419de
author : David Steele <[email protected]>
date : Thu, 15 Mar 2018 12:02:09 -0400
committer: David Steele <[email protected]>
date : Thu, 15 Mar 2018 12:02:09 -0400
Since pgBackRest would not pass secure options on to sub-processes an obscure error was thrown. The new error is much clearer and provides hints about how to fix the problem.
Update command documentation to omit secure options that cannot be specified on the command-line.
Reported by Brad Nicholson.
M doc/lib/BackRestDoc/Common/DocConfig.pm
M doc/xml/release.xml
M src/config/parse.c
M test/src/module/config/parseTest.c
Config test code writes secure options to a file instead of passing on the command-line.
commit : dd3ce7081070aca3a5c915af2a7e642c3ebece4b
author : David Steele <[email protected]>
date : Thu, 15 Mar 2018 11:09:46 -0400
committer: David Steele <[email protected]>
date : Thu, 15 Mar 2018 11:09:46 -0400
M doc/xml/release.xml
M test/lib/pgBackRestTest/Env/ConfigEnvTest.pm
M test/src/module/config/parseTest.c
Improve conversion of C exceptions to Exception objects.
commit : 4fb75c9cc1c594d462adb31b8146e789ce639fb3
author : David Steele <[email protected]>
date : Thu, 15 Mar 2018 11:03:28 -0400
committer: David Steele <[email protected]>
date : Thu, 15 Mar 2018 11:03:28 -0400
Colons in the message would prevent all of the message from being loaded into the Exception object.
M doc/xml/release.xml
M lib/pgBackRest/Common/Exception.pm
M test/test.pl
Check int size in common/type.h.
commit : 599e291b366e0c0217c81fad44a3f7cdbd800d98
author : David Steele <[email protected]>
date : Wed, 14 Mar 2018 14:34:06 -0400
committer: David Steele <[email protected]>
date : Wed, 14 Mar 2018 14:34:06 -0400
This ensures that integers are at least 32-bits without having to run the test suite.
M doc/xml/release.xml
M src/common/type.h
Simplify table of contents on command page by only listing commands.
commit : e7fd94ee23f7b0b353f926c55086c9163f6f4881
author : David Steele <[email protected]>
date : Wed, 14 Mar 2018 11:10:46 -0400
committer: David Steele <[email protected]>
date : Wed, 14 Mar 2018 11:10:46 -0400
Suggested by Stephen Frost.
M doc/lib/BackRestDoc/Common/DocConfig.pm
M doc/xml/release.xml
Improve debugging.
commit : 4b6cd92a4ca8de743ddf3d62e71e548ead06644b
author : David Steele <[email protected]>
date : Mon, 12 Mar 2018 17:15:14 -0400
committer: David Steele <[email protected]>
date : Mon, 12 Mar 2018 17:15:14 -0400
* Replace remaining NDEBUG blocks with the more granular DEBUG_UNIT.
* Remove some debug memset() calls in MemContext since valgrind is more useful for these checks.
M doc/xml/release.xml
M src/common/debug.h
M src/common/log.c
M src/common/log.h
M src/common/memContext.c
M test/lib/pgBackRestTest/Common/JobTest.pm
Add ASSERT_DEBUG() macro for debugging.
commit : cced6ec03aa212310a940e643cc8f2b484d95a8c
author : David Steele <[email protected]>
date : Mon, 12 Mar 2018 14:31:22 -0400
committer: David Steele <[email protected]>
date : Mon, 12 Mar 2018 14:31:22 -0400
Replace all current assert() calls except in tests that can't use the debug code.
M doc/xml/release.xml
M src/command/command.c
A src/common/debug.h
M src/common/log.c
M src/common/log.h
M src/config/config.c
M src/config/parse.c
M test/lib/pgBackRestTest/Common/DefineTest.pm
M test/src/common/harnessTest.c
M test/src/common/logTest.c
M test/src/common/logTest.h
A test/src/module/common/debugOffTest.c
A test/src/module/common/debugOnTest.c
M test/src/module/common/errorTest.c
M test/src/module/common/typeTest.c
M test/src/module/postgres/pageChecksumTest.c
M test/src/test.c
Port most of Config::Config::configLoad() from Perl to C.
commit : dd31ae832d6d5278079d5e84c471b0258f51940b
author : Cynthia Shang <[email protected]>
date : Mon, 12 Mar 2018 11:25:20 -0400
committer: David Steele <[email protected]>
date : Mon, 12 Mar 2018 11:25:20 -0400
Contributed by Cynthia Shang.
M doc/xml/release.xml
M lib/pgBackRest/Config/Config.pm
M src/config/config.h
M src/config/load.c
M test/expect/expire-expire-001.log
M test/expect/mock-stanza-001.log
M test/expect/mock-stanza-002.log
M test/expect/mock-stanza-003.log
M test/src/module/config/loadTest.c
Improve logging.
commit : 03f1082e86ac82477f09f212332e9c82946d28ad
author : David Steele <[email protected]>
date : Mon, 12 Mar 2018 10:55:58 -0400
committer: David Steele <[email protected]>
date : Mon, 12 Mar 2018 10:55:58 -0400
Move command begin to C except when it must be called after another command in Perl (e.g. expire after backup). Command begin logs correctly for complex data types like hash and list. Specify which commands will log to file immediately and set the default log level for log messages that are common to all commands. File logging is initiated from C.
M build/lib/pgBackRestBuild/Config/Build.pm
M build/lib/pgBackRestBuild/Config/Data.pm
M doc/xml/release.xml
M lib/pgBackRest/Archive/Push/Async.pm
M lib/pgBackRest/Common/Log.pm
M lib/pgBackRest/Config/Config.pm
M lib/pgBackRest/Main.pm
M libc/Makefile.PL
M src/command/archive/push/push.c
M src/command/command.c
M src/common/exit.c
M src/common/log.c
M src/common/log.h
M src/config/config.auto.c
M src/config/config.c
M src/config/config.h
M src/config/define.c
M src/config/load.c
M src/config/parse.c
M src/main.c
M test/expect/mock-all-001.log
M test/expect/mock-all-002.log
M test/lib/pgBackRestTest/Common/DefineTest.pm
M test/lib/pgBackRestTest/Common/JobTest.pm
M test/lib/pgBackRestTest/Env/Host/HostBackupTest.pm
M test/src/common/harnessTest.c
M test/src/common/logTest.c
M test/src/module/archive/pushTest.c
M test/src/module/command/commandTest.c
M test/src/module/common/exitTest.c
M test/src/module/common/logTest.c
M test/src/module/config/configTest.c
M test/src/module/config/loadTest.c
M test/src/test.c
Update pip before installing awscli.
commit : 94494a632f0d217810a0cd0da462529c6c60b032
author : David Steele <[email protected]>
date : Mon, 12 Mar 2018 09:47:32 -0400
committer: David Steele <[email protected]>
date : Mon, 12 Mar 2018 09:47:32 -0400
M doc/xml/release.xml
M test/lib/pgBackRestTest/Common/ContainerTest.pm
Improve code generation performance.
commit : f047cd0dfd3de01ff4ea678f394af8302e89e7c0
author : David Steele <[email protected]>
date : Fri, 9 Mar 2018 23:00:20 -0500
committer: David Steele <[email protected]>
date : Fri, 9 Mar 2018 23:00:20 -0500
M build/lib/pgBackRestBuild/Build.pm
M doc/xml/release.xml
M libc/build/lib/pgBackRestLibC/Build.pm
A test/lib/pgBackRestTest/Common/BuildTest.pm
M test/test.pl
Improve bin and libc build performance.
commit : b987f05f3529654515e5cddee4057fe5f83cfd20
author : David Steele <[email protected]>
date : Fri, 9 Mar 2018 21:24:30 -0500
committer: David Steele <[email protected]>
date : Fri, 9 Mar 2018 21:24:30 -0500
M doc/xml/release.xml
M test/test.pl
Build with -DNDEBUG by default but disable for testing.
commit : c32ee346128182b9742417c27b0ae9c5bd768cb8
author : David Steele <[email protected]>
date : Fri, 9 Mar 2018 18:28:34 -0500
committer: David Steele <[email protected]>
date : Fri, 9 Mar 2018 18:28:34 -0500
M doc/xml/release.xml
M src/Makefile
M test/test.pl
Move logic for setting Perl configuration defaults to C.
commit : fbe4c40386d9b8666514703996b5734d2719b652
author : David Steele <[email protected]>
date : Fri, 9 Mar 2018 09:30:50 -0500
committer: David Steele <[email protected]>
date : Fri, 9 Mar 2018 09:30:50 -0500
M doc/xml/release.xml
M lib/pgBackRest/Config/Config.pm
M src/perl/config.c
M test/src/module/perl/configTest.c
Set config before Main::main() call to avoid secrets being exposed in a stack trace.
commit : 919635b6f42eff1c1de0638626314caf4b0e2f2a
author : David Steele <[email protected]>
date : Thu, 8 Mar 2018 16:24:16 -0500
committer: David Steele <[email protected]>
date : Thu, 8 Mar 2018 16:24:16 -0500
M doc/xml/release.xml
M lib/pgBackRest/Config/Config.pm
M lib/pgBackRest/Main.pm
M src/perl/exec.c
M test/lib/pgBackRestTest/Env/ConfigEnvTest.pm
M test/src/module/perl/execTest.c
Error when multiple arguments are set in the config file for an option that does not accept multiple arguments.
commit : 34898ce471214e234e14d9532bbb34b8095381cc
author : Cynthia Shang <[email protected]>
date : Thu, 8 Mar 2018 14:15:05 -0500
committer: David Steele <[email protected]>
date : Thu, 8 Mar 2018 14:15:05 -0500
Contributed by Cynthia Shang.
M doc/xml/release.xml
M src/config/parse.c
M test/src/module/config/parseTest.c
Add new test for Common::Io::Process.
commit : e331564c9025077a0f3922408a90d5f8f18baed1
author : David Steele <[email protected]>
date : Thu, 8 Mar 2018 12:36:55 -0500
committer: David Steele <[email protected]>
date : Thu, 8 Mar 2018 12:36:55 -0500
Show that output on stderr will raise an exception on close() even if the exit code is 0.
M doc/xml/release.xml
M test/lib/pgBackRestTest/Common/DefineTest.pm
M test/lib/pgBackRestTest/Module/Common/CommonIoProcessTest.pm
Fix issue passing --no-config to embedded Perl.
commit : 62a9bdbd4c25b9801bcc6a4892d442f38e6d4da5
author : David Steele <[email protected]>
date : Thu, 8 Mar 2018 10:43:09 -0500
committer: David Steele <[email protected]>
date : Thu, 8 Mar 2018 10:43:09 -0500
Reported by Ibrahim Edib Kokdemir.
M doc/xml/release.xml
M src/perl/config.c
M test/src/module/perl/configTest.c
Fix --target-action and --recovery-option options being reported as invalid when restoring with --type=immediate.
commit : 5e0ce3e996db90c44eba835093549f9634525f21
author : David Steele <[email protected]>
date : Tue, 6 Mar 2018 17:12:16 -0500
committer: David Steele <[email protected]>
date : Tue, 6 Mar 2018 17:12:16 -0500
Reported by Brad Nicholson.
M build/lib/pgBackRestBuild/Config/Data.pm
M doc/xml/release.xml
M src/config/define.auto.c
Show index in examples for indexed options, i.e. repo-*, pg-*.
commit : 4c8ed3530c05e2a88a1515a1cdd31ac3871b4bc2
author : David Steele <[email protected]>
date : Tue, 6 Mar 2018 14:20:12 -0500
committer: David Steele <[email protected]>
date : Tue, 6 Mar 2018 14:20:12 -0500
Suggested by Stephen Frost.
M doc/lib/BackRestDoc/Common/DocConfig.pm
M doc/xml/release.xml
Add cfgOptionTest().
commit : 45ffe37e4ff3fd955a10bad93c17f443793855b8
author : Cynthia Shang <[email protected]>
date : Mon, 5 Mar 2018 18:51:48 -0500
committer: David Steele <[email protected]>
date : Mon, 5 Mar 2018 18:51:48 -0500
Update cfgOption() calls that are better implemented as cfgOptionTest().
Contributed by Cynthia Shang.
M doc/xml/release.xml
M src/config/config.c
M src/config/config.h
M src/config/load.c
M src/perl/config.c
M test/lib/pgBackRestTest/Common/DefineTest.pm
M test/src/module/config/configTest.c
M test/src/module/config/parseTest.c
Remove references to the C library being optional.
commit : a50b1eb5be64c0ea68c468cbe0b793be93136c33
author : David Steele <[email protected]>
date : Mon, 5 Mar 2018 10:03:10 -0500
committer: David Steele <[email protected]>
date : Mon, 5 Mar 2018 10:03:10 -0500
M doc/xml/reference.xml
M doc/xml/release.xml
M doc/xml/user-guide.xml
M src/config/define.auto.c
Improve code documentation in config module.
commit : c07aa2ae1940f2c6cf0f7a2e701b20e2d0c32ff9
author : David Steele <[email protected]>
date : Fri, 2 Mar 2018 22:42:02 -0500
committer: David Steele <[email protected]>
date : Fri, 2 Mar 2018 22:42:02 -0500
M doc/xml/release.xml
M src/config/config.h
M test/src/module/config/parseTest.c
Enable -Wconversion and silence new warnings.
commit : 406acf9cba16fc93fdcd7d6ee93483ef8ef5d073
author : David Steele <[email protected]>
date : Fri, 2 Mar 2018 12:07:12 -0500
committer: David Steele <[email protected]>
date : Fri, 2 Mar 2018 12:07:12 -0500
M doc/xml/release.xml
M src/Makefile
M src/cipher/block.c
M src/cipher/block.h
M src/cipher/random.c
M src/cipher/random.h
M src/command/archive/push/push.c
M src/command/help/help.c
M src/common/encode.c
M src/common/encode.h
M src/common/encode/base64.c
M src/common/encode/base64.h
M src/common/error.c
M src/common/ini.c
M src/common/log.c
M src/common/memContext.c
M src/common/time.c
M src/common/type/string.c
M src/common/type/stringList.c
M src/common/type/variant.c
M src/config/config.c
M src/config/config.h
M src/config/define.c
M src/config/define.h
M src/config/load.c
M src/config/load.h
M src/config/parse.c
M src/config/parse.h
M src/main.c
M src/perl/exec.c
M src/postgres/pageChecksum.c
M src/postgres/pageChecksum.h
M src/storage/helper.c
M src/storage/storage.c
M test/lib/pgBackRestTest/Common/JobTest.pm
M test/src/module/cipher/blockTest.c
M test/src/module/cipher/randomTest.c
M test/src/module/common/typeBufferTest.c
M test/src/module/common/waitTest.c
M test/src/module/config/parseTest.c
M test/src/module/postgres/pageChecksumTest.c
Remove extraneous sudo commands from src/Makefile.
commit : 6ca6424fb1b32fb43eafc481d179508e958e5e7e
author : Adrian Vondendriesch <[email protected]>
date : Thu, 1 Mar 2018 15:42:12 -0500
committer: David Steele <[email protected]>
date : Thu, 1 Mar 2018 15:42:12 -0500
Contributed by Adrian Vondendriesch.
M doc/xml/release.xml
M src/Makefile
Remove Debian package patch now that it has been merged upstream.
commit : af805af044317265a786214bed4c506977e934b4
author : David Steele <[email protected]>
date : Thu, 1 Mar 2018 16:55:32 -0500
committer: David Steele <[email protected]>
date : Thu, 1 Mar 2018 16:55:32 -0500
M doc/xml/release.xml
D test/patch/debian-package.patch
Disable console display of coverage for C files.
commit : 5d1722b8ef7dd86ef717ce0425fb5b55d73f5f1d
author : David Steele <[email protected]>
date : Thu, 1 Mar 2018 13:32:51 -0500
committer: David Steele <[email protected]>
date : Thu, 1 Mar 2018 13:32:51 -0500
Devel::Cover does not handle it well.
M doc/xml/release.xml
M test/test.pl
Remove RHEL package patch since upstream has been updated.
commit : 57d70a5649c2d4f0500c495d0fb065d1eda06e4b
author : David Steele <[email protected]>
date : Thu, 1 Mar 2018 13:31:03 -0500
committer: David Steele <[email protected]>
date : Thu, 1 Mar 2018 13:31:03 -0500
D test/patch/rhel-package.patch
Add CentOS/RHEL package builds.
commit : 5b491b3035502819a31e1200636c8d2757a78a18
author : David Steele <[email protected]>
date : Mon, 26 Feb 2018 19:32:27 -0500
committer: David Steele <[email protected]>
date : Mon, 26 Feb 2018 19:32:27 -0500
M doc/xml/release.xml
M test/lib/pgBackRestTest/Common/ContainerTest.pm
A test/patch/rhel-package.patch
M test/test.pl
Enable -Wswitch-enum and silence new warnings.
commit : f9c1a3b156a07ecfd4916fe0386f90022406d721
author : David Steele <[email protected]>
date : Mon, 26 Feb 2018 10:43:49 -0500
committer: David Steele <[email protected]>
date : Mon, 26 Feb 2018 10:43:49 -0500
M doc/xml/release.xml
M src/Makefile
M src/common/type/variant.c
M src/config/parse.c
Fix incorrect enum types in config.c that throw warnings under clang.
commit : c8df690931561c4b172d2ea48e68a0597e0a272b
author : David Steele <[email protected]>
date : Mon, 26 Feb 2018 10:02:33 -0500
committer: David Steele <[email protected]>
date : Mon, 26 Feb 2018 10:02:33 -0500
Found by Douglas J Hunley.
M doc/xml/release.xml
M lib/pgBackRest/Version.pm
M libc/lib/pgBackRest/LibCAuto.pm
M src/config/config.c
M src/config/config.h
M src/version.h
Remove github CNAME file.
commit : 09223a733dd8a4b9fc3deeec72ee5a168a9c625d
author : David Steele <[email protected]>
date : Fri, 23 Feb 2018 23:44:10 -0500
committer: David Steele <[email protected]>
date : Fri, 23 Feb 2018 23:44:10 -0500
M doc/release.pl
Update how versions are displayed in the documentation.
commit : 1f954b324ae8c2ae43af1da2a97090dde586fb8f
author : David Steele <[email protected]>
date : Fri, 23 Feb 2018 23:42:29 -0500
committer: David Steele <[email protected]>
date : Fri, 23 Feb 2018 23:42:29 -0500
M doc/xml/user-guide.xml