pgBackRest 2.44 commit log

commit   : cc2ffd8264bb4e10e6b289ce3978452018f725e8    
  
author   : David Steele <[email protected]>    
date     : Mon, 28 Nov 2022 17:47:48 +0800    
  
committer: David Steele <[email protected]>    
date     : Mon, 28 Nov 2022 17:47:48 +0800    

Bug Fixes:  
  
* Fix missing reference in diff/incr backup. (Reviewed by Stefan Fercot. Reported by Marcel Borger, ulfedf, jaymefSO.)  
  
Improvements:  
  
* Add hint when an option is specified without an index. (Reviewed by Stefan Fercot.)  

commit   : c4bf775099c85e3cd081f9c1ce35efd4c71d9161    
  
author   : David Steele <[email protected]>    
date     : Mon, 28 Nov 2022 16:42:35 +0800    
  
committer: GitHub <[email protected]>    
date     : Mon, 28 Nov 2022 16:42:35 +0800    

When loading prior manifests without the new reference list, the code failed to add the current backup to the reference list. Since the current backup is never explicitly referenced, building references from the file list was not sufficient to generate a complete list.
  

  
The main problem here was a bad test, fixed in 28f6604. This masked the issue and prevented it from being found. Now it is clear in the test that the current label is missing from the reference list.
  

  
Fix by adding the current label to the reference list if a reference list is not stored in the manifest.

commit   : 28f660482aa5abb97850a9d7c89c2e5e9f23a4c9    
  
author   : David Steele <[email protected]>    
date     : Sat, 26 Nov 2022 10:48:02 +0800    
  
committer: David Steele <[email protected]>    
date     : Sat, 26 Nov 2022 10:48:02 +0800    

Changing the label of a manifest that already had a label was not a good test and it ended up masking a bug where the current backup label was not being added to the reference list on manifest load, since manifestBackupLabelSet() added the label to the reference list. In fact, manifestBackupLabelSet() should never be called after a manifest load or even after the label has been set.  
  
Add an assertion to prevent manifestBackupLabelSet() being called when the label is already set.  
  
The bug exposed here will be fixed in a subsequent commit.  

commit   : 3f363cb3aed1a7c6836ee6c32eae600129a6f6b8    
  
author   : David Steele <[email protected]>    
date     : Tue, 22 Nov 2022 15:04:13 +0800    
  
committer: GitHub <[email protected]>    
date     : Tue, 22 Nov 2022 15:04:13 +0800    

Hopefully this will make it a little clearer to the user what is wrong when they specify an indexed option without an index.
  

  
Also fix an ambiguous use of cfgParseOptionP(). The prior code worked in that it set prefixMatch = true but it was not very readable.

commit   : 27460862e77b7fba327c92448b2ec8ad41f2016c    
  
author   : David Steele <[email protected]>    
date     : Tue, 22 Nov 2022 10:29:32 +0800    
  
committer: David Steele <[email protected]>    
date     : Tue, 22 Nov 2022 10:29:32 +0800    

commit   : 092e254794c6d9eba9fc3175357bc91257f2eedf    
  
author   : David Steele <[email protected]>    
date     : Tue, 22 Nov 2022 10:27:20 +0800    
  
committer: David Steele <[email protected]>    
date     : Tue, 22 Nov 2022 10:27:20 +0800