PostgreSQL 10.7 commit log

Stamp 10.7.

commit   : a093e1444955d6ee1d7cfda68932c19d5613d87a    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 11 Feb 2019 16:19:36 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 11 Feb 2019 16:19:36 -0500    

Click here for diff

M configure
M configure.in
M doc/bug.template
M src/include/pg_config.h.win32
M src/interfaces/libpq/libpq.rc.in
M src/port/win32ver.rc

Translation updates

commit   : ff3ac5903d1f45f3267c45683b0883758e24ead8    
  
author   : Peter Eisentraut <peter@eisentraut.org>    
date     : Mon, 11 Feb 2019 14:25:01 +0100    
  
committer: Peter Eisentraut <peter@eisentraut.org>    
date     : Mon, 11 Feb 2019 14:25:01 +0100    

Click here for diff

Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git  
Source-Git-Hash: da5fe0060d012477d807c1b60f1ff2188947a72f  

M src/backend/po/de.po
M src/backend/po/fr.po
M src/backend/po/ru.po
M src/backend/po/sv.po
M src/bin/initdb/po/de.po
M src/bin/initdb/po/fr.po
M src/bin/initdb/po/he.po
M src/bin/initdb/po/ru.po
M src/bin/initdb/po/sv.po
M src/bin/initdb/po/tr.po
M src/bin/pg_basebackup/po/he.po
M src/bin/pg_basebackup/po/ru.po
M src/bin/pg_ctl/po/he.po
M src/bin/pg_ctl/po/ru.po
M src/bin/pg_dump/po/he.po
M src/bin/pg_dump/po/ru.po
M src/bin/pg_dump/po/sv.po
M src/bin/pg_resetwal/po/ru.po
M src/bin/pg_rewind/po/de.po
M src/bin/pg_rewind/po/fr.po
M src/bin/pg_rewind/po/ja.po
M src/bin/pg_rewind/po/ru.po
M src/bin/pg_rewind/po/sv.po
M src/bin/pg_upgrade/po/de.po
M src/bin/pg_upgrade/po/fr.po
M src/bin/pg_upgrade/po/ru.po
M src/bin/pg_upgrade/po/sv.po
M src/bin/pg_waldump/po/ru.po
M src/bin/psql/po/he.po
M src/bin/psql/po/ja.po
M src/bin/psql/po/ru.po
M src/bin/scripts/po/he.po
M src/bin/scripts/po/ru.po
M src/interfaces/ecpg/ecpglib/po/ru.po
M src/interfaces/libpq/po/he.po
M src/interfaces/libpq/po/ru.po
M src/pl/plpgsql/src/po/ru.po
M src/pl/plpython/po/ru.po

Adjust error message

commit   : eb69147e67ab90dbd9b3a25ebec9a36d7930de35    
  
author   : Peter Eisentraut <peter@eisentraut.org>    
date     : Mon, 11 Feb 2019 10:31:36 +0100    
  
committer: Peter Eisentraut <peter@eisentraut.org>    
date     : Mon, 11 Feb 2019 10:31:36 +0100    

Click here for diff

We usually don't use "namespace" in user-facing error messages.  Also,  
in master this was replaced by another error message referring to  
"temporary objects", so we might as well use that here to avoid  
introducing too many variants.  
  
Discussion: https://www.postgresql.org/message-id/bbd3f8d9-e3d5-e5aa-4305-7f0121c3fa94@2ndquadrant.com  

M src/backend/access/transam/xact.c
M src/test/modules/test_extensions/expected/test_extensions.out
M src/test/regress/expected/temp.out

Release notes for 11.2, 10.7, 9.6.12, 9.5.16, 9.4.21.

commit   : 638befaae1cedbb509695a8bc227f36d9dd8dbcb    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sun, 10 Feb 2019 15:44:04 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sun, 10 Feb 2019 15:44:04 -0500    

Click here for diff

M doc/src/sgml/release-10.sgml

Solve cross-version-upgrade testing problem induced by 1fb57af92.

commit   : 7cbfd8eb166dd7ab06201f29b72a467233fd7c43    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sat, 9 Feb 2019 21:02:06 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sat, 9 Feb 2019 21:02:06 -0500    

Click here for diff

Renaming varchar_transform to varchar_support had a side effect  
I hadn't foreseen: the core regression tests leave around a  
transform object that relies on that function, so the name  
change breaks cross-version upgrade tests, because the name  
used in the older branches doesn't match.  
  
Since the dependency on varchar_transform was chosen with the  
aid of a dartboard anyway (it would surely not work as a  
language transform support function), fix by just choosing  
a different random builtin function with the right signature.  
Also add some comments explaining why this isn't horribly unsafe.  
  
I chose to make the same substitution in a couple of other  
copied-and-pasted test cases, for consistency, though those  
aren't directly contributing to the testing problem.  
  
Per buildfarm.  Back-patch, else it doesn't fix the problem.  

M src/bin/pg_dump/t/002_pg_dump.pl
M src/test/modules/test_ddl_deparse/expected/create_transform.out
M src/test/modules/test_ddl_deparse/sql/create_transform.sql
M src/test/regress/expected/object_address.out
M src/test/regress/sql/object_address.sql

Repair unsafe/unportable snprintf usage in pg_restore.

commit   : 73668c590cf5c5719ac0d0481201fd4fd79454bb    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sat, 9 Feb 2019 19:45:38 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sat, 9 Feb 2019 19:45:38 -0500    

Click here for diff

warn_or_exit_horribly() was blithely passing a potentially-NULL  
string pointer to a %s format specifier.  That works (at least  
to the extent of not crashing) on some platforms, but not all,  
and since we switched to our own snprintf.c it doesn't work  
for us anywhere.  
  
Of the three string fields being handled this way here, I think  
that only "owner" is supposed to be nullable ... but considering  
that this is error-reporting code, it has very little business  
assuming anything, so put in defenses for all three.  
  
Per a crash observed on buildfarm member crake and then  
reproduced here.  Because of the portability aspect,  
back-patch to all supported versions.  

M src/bin/pg_dump/pg_backup_archiver.c

Call set_rel_pathlist_hook before generate_gather_paths, not after.

commit   : dc0eb137fec20c4f2d168dfcb6bda001a27ad548    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sat, 9 Feb 2019 11:41:09 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sat, 9 Feb 2019 11:41:09 -0500    

Click here for diff

The previous ordering of these steps satisfied the nominal requirement  
that set_rel_pathlist_hook could editorialize on the whole set of Paths  
constructed for a base relation.  In practice, though, trying to change  
the set of partial paths was impossible.  Adding one didn't work because  
(a) it was too late to be included in Gather paths made by the core code,  
and (b) calling add_partial_path after generate_gather_paths is unsafe,  
because it might try to delete a path it thinks is dominated, but that  
is already embedded in some Gather path(s).  Nor could the hook safely  
remove partial paths, for the same reason that they might already be  
embedded in Gathers.  
  
Better to call extensions first, let them add partial paths as desired,  
and then gather.  In v11 and up, we already doubled down on that ordering  
by postponing gathering even further for single-relation queries; so even  
if the hook wished to editorialize on Gather path construction, it could  
not.  
  
Report and patch by KaiGai Kohei.  Back-patch to 9.6 where Gather paths  
were added.  
  
Discussion: https://postgr.es/m/CAOP8fzahwpKJRTVVTqo2AE=mDTz_efVzV6Get_0=U3SO+-ha1A@mail.gmail.com  

M doc/src/sgml/custom-scan.sgml
M src/backend/optimizer/path/allpaths.c

Defend against null error message reported by libxml2.

commit   : 0d7d71b64d70b2db51f6339d6fb86fc4e01f7335    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 8 Feb 2019 13:30:42 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 8 Feb 2019 13:30:42 -0500    

Click here for diff

While this isn't really supposed to happen, it can occur in OOM  
situations and perhaps others.  Instead of crashing, substitute  
"(no message provided)".  
  
I didn't worry about localizing this text, since we aren't  
localizing anything else here; besides, if we're on the edge of  
OOM, it's unlikely gettext() would work.  
  
Report and fix by Sergio Conde Gómez in bug #15624.  
  
Discussion: https://postgr.es/m/15624-4dea54091a2864e6@postgresql.org  

M src/backend/utils/adt/xml.c

Doc: fix thinko in description of how to escape a backslash in bytea.

commit   : b25155021014bfce9627229c8fa5a5f3eeac6ead    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 8 Feb 2019 12:49:36 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 8 Feb 2019 12:49:36 -0500    

Click here for diff

Also clean up some discussion that had been left in a very confused  
state thanks to half-hearted adjustments for the change to  
standard_conforming_strings being the default.  
  
Discussion: https://postgr.es/m/154954987367.1297.4358910045409218@wrigleys.postgresql.org  

M doc/src/sgml/datatype.sgml

Ensure that foreign scans with lateral refs are planned correctly.

commit   : e3101a0317a9171ced56b91e30d8929094d182eb    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 7 Feb 2019 13:10:46 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 7 Feb 2019 13:10:46 -0500    

Click here for diff

As reported in bug #15613 from Srinivasan S A, file_fdw and postgres_fdw  
neglected to mark plain baserel foreign paths as parameterized when the  
relation has lateral_relids.  Other FDWs have surely copied this mistake,  
so rather than just patching those two modules, install a band-aid fix  
in create_foreignscan_path to rectify the mistake centrally.  
  
Although the band-aid is enough to fix the visible symptom, correct  
the calls in file_fdw and postgres_fdw anyway, so that they are valid  
examples for external FDWs.  
  
Also, since the band-aid isn't enough to make this work for parameterized  
foreign joins, throw an elog(ERROR) if such a case is passed to  
create_foreignscan_path.  This shouldn't pose much of a problem for  
existing external FDWs, since it's likely they aren't trying to make such  
paths anyway (though some of them may need a defense against joins with  
lateral_relids, similar to the one this patch installs into postgres_fdw).  
  
Add some assertions in relnode.c to catch future occurrences of the same  
error --- in particular, as backstop against core-code mistakes like the  
one fixed by commit bdd9a99aa.  
  
Discussion: https://postgr.es/m/15613-092be1be9576c728@postgresql.org  

M contrib/file_fdw/file_fdw.c
M contrib/postgres_fdw/expected/postgres_fdw.out
M contrib/postgres_fdw/postgres_fdw.c
M contrib/postgres_fdw/sql/postgres_fdw.sql
M src/backend/optimizer/util/pathnode.c
M src/backend/optimizer/util/relnode.c

Fix searchpath and module location for pg_rewind and ssl TAP tests

commit   : bbcafabb4462e8c8fc19bb191e16f3a78bb446aa    
  
author   : Andrew Dunstan <andrew@dunslane.net>    
date     : Thu, 7 Feb 2019 10:22:49 -0500    
  
committer: Andrew Dunstan <andrew@dunslane.net>    
date     : Thu, 7 Feb 2019 10:22:49 -0500    

Click here for diff

The modules RewindTest.pm and ServerSetup.pm are really only useful for  
TAP tests, so they really belong in the TAP test directories. In  
addition, ServerSetup.pm is renamed to SSLServer.pm.  
  
The test scripts have their own directories added to the search path so  
that the relocated modules will be found, regardless of where the tests  
are run from, even on modern perl where "." is no longer in the  
searchpath.  
  
Discussion: https://postgr.es/m/e4b0f366-269c-73c3-9c90-d9cb0f4db1f9@2ndQuadrant.com  
  
Backpatch as appropriate to 9.5  

M src/bin/pg_rewind/t/001_basic.pl
M src/bin/pg_rewind/t/002_databases.pl
M src/bin/pg_rewind/t/003_extrafiles.pl
M src/bin/pg_rewind/t/004_pg_xlog_symlink.pl
M src/bin/pg_rewind/t/005_same_timeline.pl
R100 src/bin/pg_rewind/RewindTest.pm src/bin/pg_rewind/t/RewindTest.pm
M src/test/ssl/t/001_ssltests.pl
R099 src/test/ssl/ServerSetup.pm src/test/ssl/t/SSLServer.pm

Propagate lateral-reference information to indirect descendant relations.

commit   : a6ea72779a984cd724c41812316f5d5a40f91aaa    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 6 Feb 2019 12:44:58 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 6 Feb 2019 12:44:58 -0500    

Click here for diff

create_lateral_join_info() computes a bunch of information about lateral  
references between base relations, and then attempts to propagate those  
markings to appendrel children of the original base relations.  But the  
original coding neglected the possibility of indirect descendants  
(grandchildren etc).  During v11 development we noticed that this was  
wrong for partitioned-table cases, but failed to realize that it was just  
as wrong for any appendrel.  While the case can't arise for appendrels  
derived from traditional table inheritance (because we make a flat  
appendrel for that), nested appendrels can arise from nested UNION ALL  
subqueries.  Failure to mark the lower-level relations as having lateral  
references leads to confusion in add_paths_to_append_rel about whether  
unparameterized paths can be built.  It's not very clear whether that  
leads to any user-visible misbehavior; the lack of field reports suggests  
that it may cause nothing worse than minor cost misestimation.  Still,  
it's a bug, and it leads to failures of Asserts that I intend to add  
later.  
  
To fix, we need to propagate information from all appendrel parents,  
not just those that are RELOPT_BASERELs.  We can still do it in one  
pass, if we rely on the append_rel_list to be ordered with ancestor  
relationships before descendant ones; add assertions checking that.  
While fixing this, we can make a small performance improvement by  
traversing the append_rel_list just once instead of separately for  
each appendrel parent relation.  
  
Noted while investigating bug #15613, though this patch does not fix  
that (which is why I'm not committing the related Asserts yet).  
  
Discussion: https://postgr.es/m/3951.1549403812@sss.pgh.pa.us  

M src/backend/optimizer/plan/initsplan.c

Unify searchpath and do file logic in MSVC build scripts.

commit   : 1f28906bfe4c769325bb6e9ca29e4869099e7e6c    
  
author   : Andrew Dunstan <andrew@dunslane.net>    
date     : Wed, 6 Feb 2019 07:32:35 -0500    
  
committer: Andrew Dunstan <andrew@dunslane.net>    
date     : Wed, 6 Feb 2019 07:32:35 -0500    

Click here for diff

Commit f83419b739 failed to notice that mkvcbuild.pl and build.pl use  
different searchpath and do-file logic, breaking the latter, so it is  
adjusted to use the same logic as mkvcbuild.pl.  

M src/tools/msvc/build.pl

Fix included file path for modern perl

commit   : 1a6244216dcc576db617872b7bb6322cdeace4a0    
  
author   : Andrew Dunstan <andrew@dunslane.net>    
date     : Tue, 5 Feb 2019 18:57:12 -0500    
  
committer: Andrew Dunstan <andrew@dunslane.net>    
date     : Tue, 5 Feb 2019 18:57:12 -0500    

Click here for diff

Contrary to the comment on 772d4b76, only paths starting with "./" or  
"../" are considered relative to the current working directory by perl's  
"do" function. So this patch converts all the relevant cases to use "./"  
paths. This only affects MSVC.  
  
Backpatch to all live branches.  

M src/tools/msvc/Install.pm
M src/tools/msvc/build.pl
M src/tools/msvc/install.pl
M src/tools/msvc/mkvcbuild.pl
M src/tools/msvc/pgbison.pl
M src/tools/msvc/pgflex.pl
M src/tools/msvc/vcregress.pl

Keep perl style checker happy

commit   : 171207100e6c331a365178356843132d68e563a6    
  
author   : Andrew Dunstan <andrew@dunslane.net>    
date     : Tue, 5 Feb 2019 15:16:55 -0500    
  
committer: Andrew Dunstan <andrew@dunslane.net>    
date     : Tue, 5 Feb 2019 15:16:55 -0500    

Click here for diff

It doesn't like code before "use strict;".  

M src/backend/catalog/genbki.pl

Update time zone data files to tzdata release 2018i.

commit   : 09c5f045c98bce231fbc1b89383aee7bef40f732    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Tue, 5 Feb 2019 10:58:53 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Tue, 5 Feb 2019 10:58:53 -0500    

Click here for diff

DST law changes in Kazakhstan, Metlakatla, and São Tomé and Príncipe.  
Kazakhstan's Qyzylorda zone is split in two, creating a new zone  
Asia/Qostanay, as some areas did not change UTC offset.  
Historical corrections for Hong Kong and numerous Pacific islands.  

M src/timezone/data/tzdata.zi

Fix searchpath for modern Perl for genbki.pl

commit   : 1fbb9bda08e01877d7da6a4196d203f8f4eebefc    
  
author   : Andrew Dunstan <andrew@dunslane.net>    
date     : Tue, 5 Feb 2019 09:59:46 -0500    
  
committer: Andrew Dunstan <andrew@dunslane.net>    
date     : Tue, 5 Feb 2019 09:59:46 -0500    

Click here for diff

This was fixed for MSVC tools by commit 1df92eeafefac4, but per  
buildfarm member bowerbird genbki.pl needs the same treatment.  
  
Backpatch to all live branches.  

M src/backend/catalog/genbki.pl

Doc: in each release branch, keep only that branch’s own release notes.

commit   : 2b24271153ec4879f6870771e4e4dca70f01d187    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 4 Feb 2019 19:18:50 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 4 Feb 2019 19:18:50 -0500    

Click here for diff

Historically we've had each release branch include all prior branches'  
notes, including minor-release changes, back to the beginning of the  
project.  That's basically an O(N^2) proposition, and it was starting to  
catch up with us: as of HEAD the back-branch release notes alone accounted  
for nearly 30% of the documentation.  While there's certainly some value  
in easy access to back-branch notes, this is getting out of hand.  
  
Hence, switch over to the rule that each branch contains only its own  
release notes.  So as to not make older notes too hard to find, each  
branch will provide URLs for the immediately preceding branches'  
release notes on the project website.  
  
There might be value in providing aggregated notes across all branches  
somewhere on the website, but that's a task for another day.  
  
Discussion: https://postgr.es/m/cbd4aeb5-2d9c-8b84-e968-9e09393d4c83@postgresql.org  

M doc/src/sgml/filelist.sgml
D doc/src/sgml/release-7.4.sgml
D doc/src/sgml/release-8.0.sgml
D doc/src/sgml/release-8.1.sgml
D doc/src/sgml/release-8.2.sgml
D doc/src/sgml/release-8.3.sgml
D doc/src/sgml/release-8.4.sgml
D doc/src/sgml/release-9.0.sgml
D doc/src/sgml/release-9.1.sgml
D doc/src/sgml/release-9.2.sgml
D doc/src/sgml/release-9.3.sgml
D doc/src/sgml/release-9.4.sgml
D doc/src/sgml/release-9.5.sgml
D doc/src/sgml/release-9.6.sgml
D doc/src/sgml/release-old.sgml
M doc/src/sgml/release.sgml

Fix dumping of matviews with indirect dependencies on primary keys.

commit   : dc42602f1f6d78197b72db2fac354361506d9f21    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 4 Feb 2019 17:20:02 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 4 Feb 2019 17:20:02 -0500    

Click here for diff

Commit 62215de29 turns out to have been not quite on-the-mark.  
When we are forced to postpone dumping of a materialized view into  
the dump's post-data section (because it depends on a unique index  
that isn't created till that section), we may also have to postpone  
dumping other matviews that depend on said matview.  The previous fix  
didn't reliably work for such cases: it'd break the dependency loops  
properly, producing a workable object ordering, but it didn't  
necessarily mark all the matviews as "postponed_def".  This led to  
harmless bleating about "archive items not in correct section order",  
as reported by Tom Cassidy in bug #15602.  Less harmlessly,  
selective-restore options such as --section might misbehave due to  
the matview dump objects not being properly labeled.  
  
The right way to fix it is to consider that each pre-data dependency  
we break amounts to moving the no-longer-dependent object into  
post-data, and hence we should mark that object if it's a matview.  
  
Back-patch to all supported versions, since the issue's been there  
since matviews were introduced.  
  
Discussion: https://postgr.es/m/15602-e895445f73dc450b@postgresql.org  

M src/bin/pg_dump/pg_dump_sort.c

Move port-specific parts of with_temp_install to port makefile.

commit   : e101878d0b436d4b491661b3cc6ee48e5417c627    
  
author   : Andrew Gierth <rhodiumtoad@postgresql.org>    
date     : Mon, 4 Feb 2019 18:47:33 +0000    
  
committer: Andrew Gierth <rhodiumtoad@postgresql.org>    
date     : Mon, 4 Feb 2019 18:47:33 +0000    

Click here for diff

Rather than define ld_library_path_ver with a big nested $(if), just  
put the overriding values in the makefiles for the relevant ports.  
  
Also add a variable for port makefiles to append their own stuff to  
with_temp_install, and use it to set LD_LIBRARY_PATH_RPATH=1 on  
FreeBSD which is needed to make LD_LIBRARY_PATH override DT_RPATH  
if DT_RUNPATH is not set (which seems to depend in unpredictable ways  
on the choice of compiler, at least on my system).  
  
Backpatch for the benefit of anyone doing regression tests on FreeBSD.  
(For other platforms there should be no functional change.)  

M src/Makefile.global.in
M src/makefiles/Makefile.aix
M src/makefiles/Makefile.darwin
M src/makefiles/Makefile.freebsd
M src/makefiles/Makefile.hpux

Add PG_CFLAGS, PG_CXXFLAGS, and PG_LDFLAGS variables to PGXS

commit   : da14c9b1904870cf6a2e0add7af83576db7b2fe5    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Sun, 3 Feb 2019 17:48:46 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Sun, 3 Feb 2019 17:48:46 +0900    

Click here for diff

Add PG_CFLAGS, PG_CXXFLAGS, and PG_LDFLAGS variables to pgxs.mk which  
will be appended or prepended to the corresponding make variables.  
Notably, there was previously no way to pass custom CXXFLAGS to third  
party extension module builds, COPT and PROFILE supporting only CFLAGS  
and LDFLAGS.  
  
Backpatch all the way down to ease integration with existing  
extensions.  
  
Author: Christoph Berg  
Reviewed-by: Andres Freund, Tom Lane, Michael Paquier  
Discussion: https://postgr.es/m/20181113104005.GA32154@msg.credativ.de  
Backpatch-through: 9.4  

M doc/src/sgml/extend.sgml
M src/makefiles/pgxs.mk

Avoid possible deadlock while locking multiple heap pages.

commit   : 1ca33fc7b5111748222d1ac20b8b8ebb49bb75e6    
  
author   : Amit Kapila <akapila@postgresql.org>    
date     : Sat, 2 Feb 2019 08:46:32 +0530    
  
committer: Amit Kapila <akapila@postgresql.org>    
date     : Sat, 2 Feb 2019 08:46:32 +0530    

Click here for diff

To avoid deadlock, backend acquires a lock on heap pages in block  
number order.  In certain cases, lock on heap pages is dropped and  
reacquired.  In this case, the locks are dropped for reading in  
corresponding VM page/s. The issue is we re-acquire locks in bufferId  
order whereas the intention was to acquire in blockid order.  
  
This commit ensures that we will always acquire locks on heap pages in  
blockid order.  
  
Reported-by: Nishant Fnu  
Author: Nishant Fnu  
Reviewed-by: Amit Kapila and Robert Haas  
Backpatch-through: 9.4  
Discussion: https://postgr.es/m/5883C831-2ED1-47C8-BFAC-2D5BAE5A8CAE@amazon.com  

M src/backend/access/heap/hio.c

Fix use of dangling pointer in heap_delete() when logging replica identity

commit   : 478e0069fb8bc30d7e0c1a8fc390ed041e1b67c9    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Fri, 1 Feb 2019 10:35:46 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Fri, 1 Feb 2019 10:35:46 +0900    

Click here for diff

When logging the replica identity of a deleted tuple, XLOG_HEAP_DELETE  
records include references of the old tuple.  Its data is stored in an  
intermediate variable used to register this information for the WAL  
record, but this variable gets away from the stack when the record gets  
actually inserted.  
  
Spotted by clang's AddressSanitizer.  
  
Author: Stas Kelvish  
Discussion: https://postgr.es/m/085C8825-AD86-4E93-AF80-E26CDF03D1EA@postgrespro.ru  
Backpatch-through: 9.4  

M src/backend/access/heap/heapam.c

Fix a crash in logical replication

commit   : 2bac1d8c9848ec7045380401ae758003fe064bbc    
  
author   : Peter Eisentraut <peter@eisentraut.org>    
date     : Mon, 28 Jan 2019 22:09:33 +0100    
  
committer: Peter Eisentraut <peter@eisentraut.org>    
date     : Mon, 28 Jan 2019 22:09:33 +0100    

Click here for diff

The bug was that determining which columns are part of the replica  
identity index using RelationGetIndexAttrBitmap() would run  
eval_const_expressions() on index expressions and predicates across  
all indexes of the table, which in turn might require a snapshot, but  
there wasn't one set, so it crashes.  There were actually two separate  
bugs, one on the publisher and one on the subscriber.  
  
To trigger the bug, a table that is part of a publication or  
subscription needs to have an index with a predicate or expression  
that lends itself to constant expressions simplification.  
  
The fix is to avoid the constant expressions simplification in  
RelationGetIndexAttrBitmap(), so that it becomes safe to call in these  
contexts.  The constant expressions simplification comes from the  
calls to RelationGetIndexExpressions()/RelationGetIndexPredicate() via  
BuildIndexInfo().  But RelationGetIndexAttrBitmap() calling  
BuildIndexInfo() is overkill.  The latter just takes pg_index catalog  
information, packs it into the IndexInfo structure, which former then  
just unpacks again and throws away.  We can just do this directly with  
less overhead and skip the troublesome calls to  
eval_const_expressions().  This also removes the awkward  
cross-dependency between relcache.c and index.c.  
  
Bug: #15114  
Reported-by: Петър Славов <pet.slavov@gmail.com>  
Reviewed-by: Noah Misch <noah@leadboat.com>  
Reviewed-by: Michael Paquier <michael@paquier.xyz>  
Discussion: https://www.postgresql.org/message-id/flat/152110589574.1223.17983600132321618383@wrigleys.postgresql.org/  

M src/backend/utils/cache/relcache.c
A src/test/subscription/t/100_bugs.pl

Improve wording about WAL files in tar mode of pg_basebackup

commit   : 11b63452814ca011c271d484ee2be56b72f34d1f    
  
author   : Magnus Hagander <magnus@hagander.net>    
date     : Tue, 29 Jan 2019 10:42:41 +0100    
  
committer: Magnus Hagander <magnus@hagander.net>    
date     : Tue, 29 Jan 2019 10:42:41 +0100    

Click here for diff

Author: Alex Kliukin  
Reviewed-By: Michael Paquier, Magnus Hagander  

M doc/src/sgml/ref/pg_basebackup.sgml

Fix psql’s “\g target” meta-command to work with COPY TO STDOUT.

commit   : 8e97a97b3206c18d155a925349b5f57052912509    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sat, 26 Jan 2019 14:15:42 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sat, 26 Jan 2019 14:15:42 -0500    

Click here for diff

Previously, \g would successfully execute the COPY command, but  
the target specification if any was ignored, so that the data was  
always dumped to the regular query output target.  This seems like  
a clear bug, so let's not just fix it but back-patch it.  
  
While at it, adjust the documentation for \copy to recommend  
"COPY ... TO STDOUT \g foo" as a plausible alternative.  
  
Back-patch to 9.5.  The problem exists much further back, but the  
code associated with \g was refactored enough in 9.5 that we'd  
need a significantly different patch for 9.4, and it doesn't  
seem worth the trouble.  
  
Daniel Vérité, reviewed by Fabien Coelho  
  
Discussion: https://postgr.es/m/15dadc39-e050-4d46-956b-dcc4ed098753@manitou-mail.org  

M doc/src/sgml/ref/psql-ref.sgml
M src/bin/psql/common.c
M src/bin/psql/copy.c

Allow UNLISTEN in hot-standby mode.

commit   : e8ec19cd13a5794ed8a9cd2fb187bcbfc48811d8    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 25 Jan 2019 21:14:31 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 25 Jan 2019 21:14:31 -0500    

Click here for diff

Since LISTEN is (still) disallowed, UNLISTEN must be a no-op in a  
hot-standby session, and so there's no harm in allowing it.  This  
change allows client code to not worry about whether it's connected  
to a primary or standby server when performing session-state-reset  
type activities.  (Note that DISCARD ALL, which includes UNLISTEN,  
was already allowed, making it inconsistent to reject UNLISTEN.)  
  
Per discussion, back-patch to all supported versions.  
  
Shay Rojansky, reviewed by Mi Tar  
  
Discussion: https://postgr.es/m/CADT4RqCf2gA_TJtPAjnGzkC3ZiexfBZiLmA-mV66e4UyuVv8bA@mail.gmail.com  

M doc/src/sgml/high-availability.sgml
M src/backend/tcop/utility.c
M src/test/regress/expected/hs_standby_allowed.out
M src/test/regress/expected/hs_standby_disallowed.out
M src/test/regress/sql/hs_standby_allowed.sql
M src/test/regress/sql/hs_standby_disallowed.sql

Remove infinite-loop hazards in ecpg test suite.

commit   : 5b5cb3b0eb31e300ac4eaf616a6f83431531d57b    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 24 Jan 2019 16:46:55 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 24 Jan 2019 16:46:55 -0500    

Click here for diff

A report from Andrew Dunstan showed that an ecpglib breakage that  
causes repeated query failures could lead to infinite loops in some  
ecpg test scripts, because they contain "while(1)" loops with no  
exit condition other than successful test completion.  That might  
be all right for manual testing, but it seems entirely unacceptable  
for automated test environments such as our buildfarm.  We don't  
want buildfarm owners to have to intervene manually when a test  
goes wrong.  
  
To fix, just change all those while(1) loops to exit after at most  
100 iterations (which is more than any of them expect to iterate).  
This seems sufficient since we'd see discrepancies in the test output  
if any loop executed the wrong number of times.  
  
I tested this by dint of intentionally breaking ecpg_do_prologue  
to always fail, and verifying that the tests still got to completion.  
  
Back-patch to all supported branches, since the whole point of this  
exercise is to protect the buildfarm against future mistakes.  
  
Discussion: https://postgr.es/m/18693.1548302004@sss.pgh.pa.us  

M src/interfaces/ecpg/test/compat_informix/test_informix.pgc
M src/interfaces/ecpg/test/expected/compat_informix-test_informix.c
M src/interfaces/ecpg/test/expected/pgtypeslib-nan_test.c
M src/interfaces/ecpg/test/expected/preproc-autoprep.c
M src/interfaces/ecpg/test/expected/preproc-outofscope.c
M src/interfaces/ecpg/test/expected/preproc-variable.c
M src/interfaces/ecpg/test/expected/sql-fetch.c
M src/interfaces/ecpg/test/expected/sql-quote.c
M src/interfaces/ecpg/test/pgtypeslib/nan_test.pgc
M src/interfaces/ecpg/test/preproc/autoprep.pgc
M src/interfaces/ecpg/test/preproc/outofscope.pgc
M src/interfaces/ecpg/test/preproc/variable.pgc
M src/interfaces/ecpg/test/sql/fetch.pgc
M src/interfaces/ecpg/test/sql/quote.pgc

Blind attempt to fix _configthreadlocale() failures on MinGW.

commit   : dd815a94ccf589001458f353ccb62ca348d1a894    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 23 Jan 2019 22:46:45 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 23 Jan 2019 22:46:45 -0500    

Click here for diff

Apparently, some builds of MinGW contain a version of  
_configthreadlocale() that always returns -1, indicating failure.  
Rather than treating that as a curl-up-and-die condition, soldier on  
as though the function didn't exist.  This leaves us without thread  
safety on such MinGW versions, but we didn't have it anyway.  
  
Discussion: https://postgr.es/m/d06a16bc-52d6-9f0d-2379-21242d7dbe81@2ndQuadrant.com  

M src/interfaces/ecpg/ecpglib/descriptor.c
M src/interfaces/ecpg/ecpglib/execute.c

Fix misc typos in comments.

commit   : 2146718b3cf99f32cc0b09d9b7c0a14463f25fd4    
  
author   : Heikki Linnakangas <heikki.linnakangas@iki.fi>    
date     : Wed, 23 Jan 2019 13:39:00 +0200    
  
committer: Heikki Linnakangas <heikki.linnakangas@iki.fi>    
date     : Wed, 23 Jan 2019 13:39:00 +0200    

Click here for diff

Spotted mostly by Fabien Coelho.  
  
Discussion: https://www.postgresql.org/message-id/alpine.DEB.2.21.1901230947050.16643@lancre  

M contrib/pgcrypto/pgp-decrypt.c
M src/include/port.h
M src/pl/plpython/plpy_elog.c

Avoid thread-safety problem in ecpglib.

commit   : 6106f9dd71ff5f80fdaa41aa0e39f550967e2040    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 21 Jan 2019 23:18:58 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 21 Jan 2019 23:18:58 -0500    

Click here for diff

ecpglib attempts to force the LC_NUMERIC locale to "C" while reading  
server output, to avoid problems with strtod() and related functions.  
Historically it's just issued setlocale() calls to do that, but that  
has major problems if we're in a threaded application.  setlocale()  
itself is not required by POSIX to be thread-safe (and indeed is not,  
on recent OpenBSD).  Moreover, its effects are process-wide, so that  
we could cause unexpected results in other threads, or another thread  
could change our setting.  
  
On platforms having uselocale(), which is required by POSIX:2008,  
we can avoid these problems by using uselocale() instead.  Windows  
goes its own way as usual, but we can make it safe by using  
_configthreadlocale().  Platforms having neither continue to use the  
old code, but that should be pretty much nobody among current systems.  
  
(Subsequent buildfarm results show that recent NetBSD versions still  
lack uselocale(), but it's not a big problem because they also do not  
support non-"C" settings for LC_NUMERIC.)  
  
Back-patch of commits 8eb4a9312 and ee27584c4.  
  
Michael Meskes and Tom Lane; thanks also to Takayuki Tsunakawa.  
  
Discussion: https://postgr.es/m/31420.1547783697@sss.pgh.pa.us  

M configure
M configure.in
M src/include/pg_config.h.in
M src/include/pg_config.h.win32
M src/interfaces/ecpg/ecpglib/descriptor.c
M src/interfaces/ecpg/ecpglib/execute.c
M src/interfaces/ecpg/ecpglib/extern.h

Remove useless bms_copy step in RelationGetIndexAttrBitmap.

commit   : 5aa03f99fe7cfb1072849960465a040e834a25e2    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 21 Jan 2019 18:33:32 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 21 Jan 2019 18:33:32 -0500    

Click here for diff

Seems to be from a bad case of copy-and-paste-itis in commit 665d1fad9.  
It wouldn't be quite so annoying if it didn't contradict the comment  
half a dozen lines above.  
  
David Rowley  
  
Discussion: https://postgr.es/m/CAKJS1f95Dyf8Qkdz4W+PbCmT-HTb54tkqUCC8isa2RVgSJ_pXQ@mail.gmail.com  

M src/backend/utils/cache/relcache.c

Flush relcache entries when their FKs are meddled with

commit   : 3037b28b89b44fccfcfddb2254655f45b3005f82    
  
author   : Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Mon, 21 Jan 2019 19:34:11 -0300    
  
committer: Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Mon, 21 Jan 2019 19:34:11 -0300    

Click here for diff

Back in commit 100340e2dcd0, we made relcache entries keep lists of the  
foreign keys applying to the relation -- but we forgot to update  
CacheInvalidateHeapTuple to flush those entries when new FKs got created  
or existing ones updated/deleted.  No bugs appear to have been reported  
that would be explained by this ommission, but I noticed the problem  
while working on an unrelated bugfix which clearly showed it.  Fix by  
adding relcache flush on relevant foreign key changes.  
  
Backpatch to 9.6, like the aforementioned commit.  
  
Discussion: https://postgr.es/m/201901211927.7mmhschxlejh@alvherre.pgsql  
Reviewed-by: Tom Lane  

M src/backend/utils/cache/inval.c

Add ‘id’ to Acknowledgments section

commit   : c2f557d4fa93664855a4e0a9cebe0c73d9998b84    
  
author   : Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Mon, 21 Jan 2019 14:41:44 -0300    
  
committer: Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Mon, 21 Jan 2019 14:41:44 -0300    

Click here for diff

Per note from Erik Rijkers  
Discussion: https://postgr.es/m/3db724af16ee009ab7f812a6a1d9354e@xs4all.nl  

M doc/src/sgml/release-10.sgml

Revert “Add valgrind suppressions for wcsrtombs optimizations”

commit   : 6831aba29f5b52cb3ef26d37838e27aaac56ff5d    
  
author   : Tomas Vondra <tomas.vondra@postgresql.org>    
date     : Sat, 19 Jan 2019 20:45:31 +0100    
  
committer: Tomas Vondra <tomas.vondra@postgresql.org>    
date     : Sat, 19 Jan 2019 20:45:31 +0100    

Click here for diff

This reverts commit 5b16a353543ecec36ffda68269defb7b1b002f60.  
  
Per discussion, it's not desirable to add valgrind suppressions for  
outside our own code base (e.g. glibc in this case), especially when  
the suppressions may be platform-specific. There are better ways to  
deal with that, e.g. by providing local suppressions.  
  
Discussion: https://www.postgresql.org/message-id/flat/90ac0452-e907-e7a4-b3c8-15bd33780e62%402ndquadrant.com  

M src/tools/valgrind.supp

Fix outdated comment

commit   : 7cfd1dd031fe3baf6a500c98b62069ce317b664f    
  
author   : Peter Eisentraut <peter@eisentraut.org>    
date     : Sat, 19 Jan 2019 09:34:24 +0100    
  
committer: Peter Eisentraut <peter@eisentraut.org>    
date     : Sat, 19 Jan 2019 09:34:24 +0100    

Click here for diff

The issue the comment is referring to was fixed by  
08859bb5c2cebc132629ca838113d27bb31b990c.  

M src/backend/executor/execReplication.c

Use our own getopt() on OpenBSD.

commit   : 139e4274263a7efa230353e7b857cfa75703044a    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 18 Jan 2019 15:06:26 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 18 Jan 2019 15:06:26 -0500    

Click here for diff

Recent OpenBSD (at least 5.9 and up) has a version of getopt(3)  
that will not cope with the "-:" spec we use to accept double-dash  
options in postgres.c and postmaster.c.  Admittedly, that's a hack  
because POSIX only requires getopt() to allow alphanumeric option  
characters.  I have no desire to find another way, however, so  
let's just do what we were already doing on Solaris: force use  
of our own src/port/getopt.c implementation.  
  
In passing, improve some of the comments around said implementation.  
  
Per buildfarm and local testing.  Back-patch to all supported branches.  
  
Discussion: https://postgr.es/m/30197.1547835700@sss.pgh.pa.us  

M configure
M configure.in
M src/include/pg_getopt.h
M src/port/getopt.c

Enforce non-parallel plan when calling current_schema() in newly-added test

commit   : 08b53281f4444efb2d5bcc44d6293b05d1aa1335    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Fri, 18 Jan 2019 10:51:52 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Fri, 18 Jan 2019 10:51:52 +0900    

Click here for diff

current_schema() gets called in the recently-added regression test from  
c5660e0, and can be used in a parallel context, causing its call to fail  
when creating a temporary schema.  
  
Per buildfarm members crake and lapwing.  
  
Discussion: https://postgr.es/m/20190118005949.GD1883@paquier.xyz  

M src/test/regress/expected/temp.out
M src/test/regress/sql/temp.sql

Restrict the use of temporary namespace in two-phase transactions

commit   : b15160bc716e62ba0b30dc0ce35ab6cb82773707    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Fri, 18 Jan 2019 09:21:58 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Fri, 18 Jan 2019 09:21:58 +0900    

Click here for diff

Attempting to use a temporary table within a two-phase transaction is  
forbidden for ages.  However, there have been uncovered grounds for  
a couple of other object types and commands which work on temporary  
objects with two-phase commit.  In short, trying to create, lock or drop  
an object on a temporary schema should not be authorized within a  
two-phase transaction, as it would cause its state to create  
dependencies with other sessions, causing all sorts of side effects with  
the existing session or other sessions spawned later on trying to use  
the same temporary schema name.  
  
Regression tests are added to cover all the grounds found, the original  
report mentioned function creation, but monitoring closer there are many  
other patterns with LOCK, DROP or CREATE EXTENSION which are involved.  
One of the symptoms resulting in combining both is that the session  
which used the temporary schema is not able to shut down completely,  
waiting for being able to drop the temporary schema, something that it  
cannot complete because of the two-phase transaction involved with  
temporary objects.  In this case the client is able to disconnect but  
the session remains alive on the backend-side, potentially blocking  
connection backend slots from being used.  Other problems reported could  
also involve server crashes.  
  
This is back-patched down to v10, which is where 9b013dc has introduced  
MyXactFlags, something that this patch relies on.  
  
Reported-by: Alexey Bashtanov  
Author: Michael Paquier  
Reviewed-by: Masahiko Sawada  
Discussion: https://postgr.es/m/5d910e2e-0db8-ec06-dd5f-baec420513c3@imap.cc  
Backpatch-through: 10  

M doc/src/sgml/ref/prepare_transaction.sgml
M src/backend/access/transam/xact.c
M src/backend/catalog/namespace.c
M src/backend/commands/dropcmds.c
M src/backend/commands/extension.c
M src/backend/commands/lockcmds.c
M src/include/access/xact.h
M src/test/modules/test_extensions/expected/test_extensions.out
M src/test/modules/test_extensions/sql/test_extensions.sql
M src/test/regress/expected/temp.out
M src/test/regress/sql/temp.sql

Replace references to mailinglists with @lists.postgresql.org

commit   : 729c6c3f9267bb4fefd95636faa117efacc57d42    
  
author   : Magnus Hagander <magnus@hagander.net>    
date     : Thu, 17 Jan 2019 13:52:51 +0100    
  
committer: Magnus Hagander <magnus@hagander.net>    
date     : Thu, 17 Jan 2019 13:52:51 +0100    

Click here for diff

The namespace for all lists have changed a while ago, so all references  
should use the correct address.  

M doc/src/sgml/installation.sgml
M doc/src/sgml/problems.sgml
M doc/src/sgml/stylesheet-hh.xsl
M doc/src/sgml/stylesheet-html-common.xsl
M doc/src/sgml/xml2.sgml

Remove references to Majordomo

commit   : d6e88993591c3b301c498380b7071cd649afc472    
  
author   : Magnus Hagander <magnus@hagander.net>    
date     : Thu, 17 Jan 2019 13:47:24 +0100    
  
committer: Magnus Hagander <magnus@hagander.net>    
date     : Thu, 17 Jan 2019 13:47:24 +0100    

Click here for diff

Lists are not handled by Majordomo anymore and haven't been for  
a while, so remove the reference and instead direct people to the  
list server.  

M doc/src/sgml/problems.sgml

Postpone aggregate checks until after collation is assigned.

commit   : 409230a721cf32a2df4fd02338e785b3993f9c7a    
  
author   : Andrew Gierth <rhodiumtoad@postgresql.org>    
date     : Thu, 17 Jan 2019 05:33:01 +0000    
  
committer: Andrew Gierth <rhodiumtoad@postgresql.org>    
date     : Thu, 17 Jan 2019 05:33:01 +0000    

Click here for diff

Previously, parseCheckAggregates was run before  
assign_query_collations, but this causes problems if any expression  
has already had a collation assigned by some transform function (e.g.  
transformCaseExpr) before parseCheckAggregates runs. The differing  
collations would cause expressions not to be recognized as equal to  
the ones in the GROUP BY clause, leading to spurious errors about  
unaggregated column references.  
  
The result was that CASE expr WHEN val ... would fail when "expr"  
contained a GROUPING() expression or matched one of the group by  
expressions, and where collatable types were involved; whereas the  
supposedly identical CASE WHEN expr = val ... would succeed.  
  
Backpatch all the way; this appears to have been wrong ever since  
collations were introduced.  
  
Per report from Guillaume Lelarge, analysis and patch by me.  
  
Discussion: https://postgr.es/m/CAECtzeVSO_US8C2Khgfv54ZMUOBR4sWq+6_bLrETnWExHT=rFg@mail.gmail.com  
Discussion: https://postgr.es/m/87muo0k0c7.fsf@news-spur.riddles.org.uk  

M src/backend/parser/analyze.c
M src/test/regress/expected/aggregates.out
M src/test/regress/expected/groupingsets.out
M src/test/regress/sql/aggregates.sql
M src/test/regress/sql/groupingsets.sql

Fix typos in documentation and for one wait event

commit   : 3607dd39ba3d31d30696acacaf76d4a97dbd842f    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Tue, 15 Jan 2019 08:47:14 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Tue, 15 Jan 2019 08:47:14 +0900    

Click here for diff

These have been found while cross-checking for the use of unique words  
in the documentation, and a wait event was not getting generated in a way  
consistent to what the documentation provided.  
  
Author: Alexander Lakhin  
Discussion: https://postgr.es/m/9b5a3a85-899a-ae62-dbab-1e7943aa5ab1@gmail.com  

M doc/src/sgml/func.sgml
M doc/src/sgml/libpq.sgml
M doc/src/sgml/ref/pg_dump.sgml
M src/backend/postmaster/pgstat.c

fix typo

commit   : b3a5f01b75f765e0958118acb9f054d3dca3b23c    
  
author   : Andrew Dunstan <andrew@dunslane.net>    
date     : Sun, 13 Jan 2019 16:43:14 -0500    
  
committer: Andrew Dunstan <andrew@dunslane.net>    
date     : Sun, 13 Jan 2019 16:43:14 -0500    

Click here for diff

M src/Makefile.global.in

Make DLSUFFIX easily discoverable by build scripts

commit   : d68d670027469d61f5f0e51e9623e987b6605be8    
  
author   : Andrew Dunstan <andrew@dunslane.net>    
date     : Sun, 13 Jan 2019 15:59:35 -0500    
  
committer: Andrew Dunstan <andrew@dunslane.net>    
date     : Sun, 13 Jan 2019 15:59:35 -0500    

Click here for diff

This will enable things like the buildfarm client to discover more  
reliably if certain libraries have been installed.  
  
Discussion: https://postgr.es/m/859e7c91-7ef4-d4b4-2ca2-8046e0cbee09@2ndQuadrant.com  
  
Backpatch to all live branches.  

M src/Makefile.global.in

configure: Update python search order

commit   : cd1873160d9b9b7002814efeff28bb5c21daadce    
  
author   : Peter Eisentraut <peter@eisentraut.org>    
date     : Fri, 11 Jan 2019 15:45:15 +0100    
  
committer: Peter Eisentraut <peter@eisentraut.org>    
date     : Fri, 11 Jan 2019 15:45:15 +0100    

Click here for diff

Some systems don't ship with "python" by default anymore, only  
"python3" or "python2" or some combination, so include those in the  
configure search.  
  
Discussion: https://www.postgresql.org/message-id/flat/1457.1543184081%40sss.pgh.pa.us#c9cc1199338fd6a257589c6dcea6cf8d  

M config/python.m4
M configure
M doc/src/sgml/installation.sgml

Fix up confusion over how to use EXTRA_INSTALL.

commit   : 10ab85254d28a9347390405ee594d1b2f496912f    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 11 Jan 2019 17:39:30 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 11 Jan 2019 17:39:30 -0500    

Click here for diff

Some makefiles were trying to do this:  
  
temp-install: EXTRA_INSTALL=contrib/test_decoding  
  
but that no longer works as of commit aa019da52: the macro is now  
consulted by the checkprep target, one level down, and apparently  
gmake doesn't propagate such macro settings recursively.  
  
The problem is masked since 42e61c774 because pgxs.mk also sets up  
EXTRA_INSTALL, and correctly applies it to the checkprep target.  
  
Unfortunately I'd not risked back-patching that to before v11.  
Since aa019da52 was pushed back to v10, it broke test_decoding  
there (the only module for which this actually makes a difference  
at present).  
  
Hence, back-patch 42e61c774 to v10.  Also, remove some demonstrably  
useless settings of EXTRA_INSTALL in v10 and v11 (they'd already  
been cleaned up in HEAD).  
  
Per buildfarm.  
  
Discussion: https://postgr.es/m/CAEepm=1pEJdwv6DSGmOfpX0EaX7L7sT28c1nXpqvQvmLfEWb1g@mail.gmail.com  

M contrib/test_decoding/Makefile
M src/makefiles/pgxs.mk
M src/test/modules/snapshot_too_old/Makefile
M src/test/recovery/Makefile

Avoid sharing PARAM_EXEC slots between different levels of NestLoop.

commit   : 2977a312df7121ac3caffd47ed2aae4eee8b1b80    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 11 Jan 2019 15:53:34 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 11 Jan 2019 15:53:34 -0500    

Click here for diff

Up to now, createplan.c attempted to share PARAM_EXEC slots for  
NestLoopParams across different plan levels, if the same underlying Var  
was being fed down to different righthand-side subplan trees by different  
NestLoops.  This was, I think, more of an artifact of using subselect.c's  
PlannerParamItem infrastructure than an explicit design goal, but anyway  
that was the end result.  
  
This works well enough as long as the plan tree is executing synchronously,  
but the feature whereby Gather can execute the parallelized subplan locally  
breaks it.  An upper NestLoop node might execute for a row retrieved from  
a parallel worker, and assign a value for a PARAM_EXEC slot from that row,  
while the leader's copy of the parallelized subplan is suspended with a  
different active value of the row the Var comes from.  When control  
eventually returns to the leader's subplan, it gets the wrong answers if  
the same PARAM_EXEC slot is being used within the subplan, as reported  
in bug #15577 from Bartosz Polnik.  
  
This is pretty reminiscent of the problem fixed in commit 46c508fbc, and  
the proper fix seems to be the same: don't try to share PARAM_EXEC slots  
across different levels of controlling NestLoop nodes.  
  
This requires decoupling NestLoopParam handling from PlannerParamItem  
handling, although the logic remains somewhat similar.  To avoid bizarre  
division of labor between subselect.c and createplan.c, I decided to move  
all the param-slot-assignment logic for both cases out of those files  
and put it into a new file paramassign.c.  Hopefully it's a bit better  
documented now, too.  
  
A regression test case for this might be nice, but we don't know a  
test case that triggers the problem with a suitably small amount  
of data.  
  
Back-patch to 9.6 where we added Gather nodes.  It's conceivable that  
related problems exist in older branches; but without some evidence  
for that, I'll leave the older branches alone.  
  
Discussion: https://postgr.es/m/15577-ca61ab18904af852@postgresql.org  

M src/backend/optimizer/plan/createplan.c
M src/backend/optimizer/plan/planner.c
M src/backend/optimizer/plan/subselect.c
M src/backend/optimizer/util/Makefile
A src/backend/optimizer/util/paramassign.c
A src/include/optimizer/paramassign.h
M src/include/optimizer/subselect.h

doc: Correct documentation of install-time environment variables

commit   : cbb3e08467fcb3d4ae01ee0c7758b40fe34a0eb5    
  
author   : Peter Eisentraut <peter@eisentraut.org>    
date     : Fri, 11 Jan 2019 17:21:45 +0100    
  
committer: Peter Eisentraut <peter@eisentraut.org>    
date     : Fri, 11 Jan 2019 17:21:45 +0100    

Click here for diff

Since approximately PostgreSQL 10, it is no longer required that  
environment variables at installation time such as PERL, PYTHON, TCLSH  
be "full path names", so change that phrasing in the installation  
instructions.  (The exact time of change appears to differ for PERL  
and the others, but it works consistently in PostgreSQL 10.)  
  
Also while we're here document the defaults for PERL and PYTHON, but  
since the search list for TCLSH is so long, let's leave that out so we  
don't need to maintain a copy of that list in the installation  
instructions.  

M doc/src/sgml/installation.sgml

Doc: update our docs about kernel IPC parameters on *BSD.

commit   : f3ff9cb0a3a71c321c79e28b4c63058a64590fe9    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Tue, 8 Jan 2019 12:03:54 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Tue, 8 Jan 2019 12:03:54 -0500    

Click here for diff

runtime.sgml said that you couldn't change SysV IPC parameters on OpenBSD  
except by rebuilding the kernel.  That's definitely wrong in OpenBSD 6.x,  
and excavation in their man pages says it changed in OpenBSD 3.3.  
  
Update NetBSD and OpenBSD sections to recommend adjustment of the SEMMNI  
and SEMMNS settings, which are painfully small by default on those  
platforms.  (The discussion thread contemplated recommending that  
people select POSIX semaphores instead, but the performance consequences  
of that aren't really clear, so I'll refrain.)  
  
Remove pointless discussion of SEMMNU and SEMMAP from the FreeBSD  
section.  Minor other wordsmithing.  
  
Discussion: https://postgr.es/m/27582.1546928073@sss.pgh.pa.us  

M doc/src/sgml/runtime.sgml

doc: document that INFO messages always go to client.

commit   : dd4143d06519344eaf35d7b23648461a33026f0b    
  
author   : Andrew Gierth <rhodiumtoad@postgresql.org>    
date     : Mon, 7 Jan 2019 18:19:46 +0000    
  
committer: Andrew Gierth <rhodiumtoad@postgresql.org>    
date     : Mon, 7 Jan 2019 18:19:46 +0000    

Click here for diff

In passing add a couple of links to the message severity table.  
  
Backpatch because it's always been this way.  
  
Author: Karl O. Pinc <kop@meme.com>  

M doc/src/sgml/config.sgml

Improve ANALYZE’s handling of concurrent-update scenarios.

commit   : 708931c2d2e81bc1b931136f45063624dd1b99c1    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 3 Jan 2019 17:00:08 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 3 Jan 2019 17:00:08 -0500    

Click here for diff

This patch changes the rule for whether or not a tuple seen by ANALYZE  
should be included in its sample.  
  
When we last touched this logic, in commit 51e1445f1, we weren't  
thinking very hard about tuples being UPDATEd by a long-running  
concurrent transaction.  In such a case, we might see the pre-image as  
either LIVE or DELETE_IN_PROGRESS depending on timing; and we might see  
the post-image not at all, or as INSERT_IN_PROGRESS.  Since the existing  
code will not sample either DELETE_IN_PROGRESS or INSERT_IN_PROGRESS  
tuples, this leads to concurrently-updated rows being omitted from the  
sample entirely.  That's not very helpful, and it's especially the wrong  
thing if the concurrent transaction ends up rolling back.  
  
The right thing seems to be to sample DELETE_IN_PROGRESS rows just as if  
they were live.  This makes the "sample it" and "count it" decisions the  
same, which seems good for consistency.  It's clearly the right thing  
if the concurrent transaction ends up rolling back; in effect, we are  
sampling as though IN_PROGRESS transactions haven't happened yet.  
Also, this combination of choices ensures maximum robustness against  
the different combinations of whether and in which state we might see the  
pre- and post-images of an update.  
  
It's slightly annoying that we end up recording immediately-out-of-date  
stats in the case where the transaction does commit, but on the other  
hand the stats are fine for columns that didn't change in the update.  
And the alternative of sampling INSERT_IN_PROGRESS rows instead seems  
like a bad idea, because then the sampling would be inconsistent with  
the way rows are counted for the stats report.  
  
Per report from Mark Chambers; thanks to Jeff Janes for diagnosing  
what was happening.  Back-patch to all supported versions.  
  
Discussion: https://postgr.es/m/CAFh58O_Myr6G3tcH3gcGrF-=OExB08PJdWZcSBcEcovaiPsrHA@mail.gmail.com  

M src/backend/commands/analyze.c

Update ssl test certificates and keys

commit   : 114635e552353585a53120539a6bdefba2324362    
  
author   : Peter Eisentraut <peter@eisentraut.org>    
date     : Thu, 3 Jan 2019 15:06:53 +0100    
  
committer: Peter Eisentraut <peter@eisentraut.org>    
date     : Thu, 3 Jan 2019 15:06:53 +0100    

Click here for diff

Debian testing and newer now require that RSA and DHE keys are at  
least 2048 bit long and no longer allow SHA-1 for signatures in  
certificates.  This is currently causing the ssl tests to fail there  
because the test certificates and keys have been created in violation  
of those conditions.  
  
Update the parameters to create the test files and create a new set of  
test files.  
  
Author: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>  
Reported-by: Michael Paquier <michael@paquier.xyz>  
Discussion: https://www.postgresql.org/message-id/flat/20180917131340.GE31460%40paquier.xyz  

M src/test/ssl/Makefile
M src/test/ssl/cas.config
M src/test/ssl/ssl/both-cas-1.crt
M src/test/ssl/ssl/both-cas-2.crt
M src/test/ssl/ssl/client+client_ca.crt
M src/test/ssl/ssl/client-revoked.crt
M src/test/ssl/ssl/client-revoked.key
M src/test/ssl/ssl/client.crl
M src/test/ssl/ssl/client.crt
M src/test/ssl/ssl/client.key
M src/test/ssl/ssl/client_ca.crt
M src/test/ssl/ssl/client_ca.key
M src/test/ssl/ssl/root+client.crl
M src/test/ssl/ssl/root+client_ca.crt
M src/test/ssl/ssl/root+server.crl
M src/test/ssl/ssl/root+server_ca.crt
M src/test/ssl/ssl/root.crl
M src/test/ssl/ssl/root_ca.crt
M src/test/ssl/ssl/root_ca.key
M src/test/ssl/ssl/server-cn-and-alt-names.crt
M src/test/ssl/ssl/server-cn-and-alt-names.key
M src/test/ssl/ssl/server-cn-only.crt
M src/test/ssl/ssl/server-cn-only.key
M src/test/ssl/ssl/server-multiple-alt-names.crt
M src/test/ssl/ssl/server-multiple-alt-names.key
M src/test/ssl/ssl/server-no-names.crt
M src/test/ssl/ssl/server-no-names.key
M src/test/ssl/ssl/server-revoked.crt
M src/test/ssl/ssl/server-revoked.key
M src/test/ssl/ssl/server-single-alt-name.crt
M src/test/ssl/ssl/server-single-alt-name.key
M src/test/ssl/ssl/server-ss.crt
M src/test/ssl/ssl/server-ss.key
M src/test/ssl/ssl/server.crl
M src/test/ssl/ssl/server_ca.crt
M src/test/ssl/ssl/server_ca.key

Don’t believe MinMaxExpr is leakproof without checking.

commit   : 64edc788b4a509427eb407b0d8faac75bac5e02b    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 2 Jan 2019 16:33:48 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 2 Jan 2019 16:33:48 -0500    

Click here for diff

MinMaxExpr invokes the btree comparison function for its input datatype,  
so it's only leakproof if that function is.  Many such functions are  
indeed leakproof, but others are not, and we should not just assume that  
they are.  Hence, adjust contain_leaked_vars to verify the leakproofness  
of the referenced function explicitly.  
  
I didn't add a regression test because it would need to depend on  
some particular comparison function being leaky, and that's a moving  
target, per discussion.  
  
This has been wrong all along, so back-patch to supported branches.  
  
Discussion: https://postgr.es/m/31042.1546194242@sss.pgh.pa.us  

M src/backend/optimizer/util/clauses.c

commit   : afd090a00d50efa807e5f286c27d6d916c24590e    
  
author   : Bruce Momjian <bruce@momjian.us>    
date     : Wed, 2 Jan 2019 12:44:25 -0500    
  
committer: Bruce Momjian <bruce@momjian.us>    
date     : Wed, 2 Jan 2019 12:44:25 -0500    

Click here for diff

Backpatch-through: certain files through 9.4  

M COPYRIGHT
M doc/src/sgml/legal.sgml

Fix generation of padding message before encrypting Elgamal in pgcrypto

commit   : 962da60591dfa01b335e0bc7c1fd0b74ea10bf97    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Tue, 1 Jan 2019 10:39:34 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Tue, 1 Jan 2019 10:39:34 +0900    

Click here for diff

fe0a0b5, which has added a stronger random source in Postgres, has  
introduced a thinko when creating a padding message which gets encrypted  
for Elgamal.  The padding message cannot have zeros, which are replaced  
by random bytes.  However if pg_strong_random() failed, the message  
would finish by being considered in correct shape for encryption with  
zeros.  
  
Author: Tom Lane  
Reviewed-by: Michael Paquier  
Discussion: https://postgr.es/m/20186.1546188423@sss.pgh.pa.us  
Backpatch-through: 10  

M contrib/pgcrypto/pgp-pubenc.c

Process EXTRA_INSTALL serially, during the first temp-install.

commit   : bedda9fbb76897c987c720aed6551dff48d4cfb4    
  
author   : Noah Misch <noah@leadboat.com>    
date     : Mon, 31 Dec 2018 13:54:38 -0800    
  
committer: Noah Misch <noah@leadboat.com>    
date     : Mon, 31 Dec 2018 13:54:38 -0800    

Click here for diff

This closes a race condition in "make -j check-world"; the symptom was  
EEXIST errors.  Back-patch to v10, before which parallel check-world had  
worse problems.  
  
Discussion: https://postgr.es/m/20181224221601.GA3227827@rfd.leadboat.com  

M GNUmakefile.in
M src/Makefile.global.in
M src/makefiles/pgxs.mk

Send EXTRA_INSTALL errors to install.log, not stderr.

commit   : e7ebc8c285f12b0f50924a69627a40050c85a1e2    
  
author   : Noah Misch <noah@leadboat.com>    
date     : Mon, 31 Dec 2018 13:53:05 -0800    
  
committer: Noah Misch <noah@leadboat.com>    
date     : Mon, 31 Dec 2018 13:53:05 -0800    

Click here for diff

We already redirected other temp-install stderr and all temp-install  
stdout in this way.  Back-patch to v10, like the next commit.  
  
Discussion: https://postgr.es/m/20181224221601.GA3227827@rfd.leadboat.com  

M src/Makefile.global.in

pg_regress: Promptly detect failed postmaster startup.

commit   : 7c97b0f55e751297a5e30c0de28a779b945aa706    
  
author   : Noah Misch <noah@leadboat.com>    
date     : Mon, 31 Dec 2018 13:50:32 -0800    
  
committer: Noah Misch <noah@leadboat.com>    
date     : Mon, 31 Dec 2018 13:50:32 -0800    

Click here for diff

Detect it the way pg_ctl's wait_for_postmaster() does.  When pg_regress  
spawned a postmaster that failed startup, we were detecting that only  
with "pg_regress: postmaster did not respond within 60 seconds".  
Back-patch to 9.4 (all supported versions).  
  
Reviewed by Tom Lane.  
  
Discussion: https://postgr.es/m/20181231172922.GA199150@gust.leadboat.com  

M src/test/regress/pg_regress.c

pg_rewind: Add missing newline to error message

commit   : af99ad191a3cee6fd565552574acb07fad53eb37    
  
author   : Peter Eisentraut <peter@eisentraut.org>    
date     : Sat, 29 Dec 2018 13:02:51 +0100    
  
committer: Peter Eisentraut <peter@eisentraut.org>    
date     : Sat, 29 Dec 2018 13:02:51 +0100    

Click here for diff

M src/bin/pg_rewind/pg_rewind.c

Fix latent problem with pg_jrand48().

commit   : f256995e33d2d1074c767a0b38a2a2ed2a583161    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 28 Dec 2018 14:08:24 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 28 Dec 2018 14:08:24 -0500    

Click here for diff

POSIX specifies that jrand48() returns a signed 32-bit value (in the  
range [-2^31, 2^31)), but our code was returning an unsigned 32-bit  
value (in the range [0, 2^32)).  This doesn't actually matter to any  
existing call site, because they all cast the "long" result to int32  
or uint32; but it will doubtless bite somebody in the future.  
To fix, cast the arithmetic result to int32 explicitly before the  
compiler widens it to long (if widening is needed).  
  
While at it, upgrade this file's far-short-of-project-style comments.  
Had there been some peer pressure to document pg_jrand48() properly,  
maybe this thinko wouldn't have gotten committed to begin with.  
  
Backpatch to v10 where pg_jrand48() was added, just in case somebody  
back-patches a fix that uses it and depends on the standard behavior.  
  
Discussion: https://postgr.es/m/17235.1545951602@sss.pgh.pa.us  

M src/port/erand48.c

Have DISCARD ALL/TEMP remove leftover temp tables

commit   : 3c4ca21093b5d0662389777df853f6f3a36ee476    
  
author   : Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Thu, 27 Dec 2018 16:17:40 -0300    
  
committer: Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Thu, 27 Dec 2018 16:17:40 -0300    

Click here for diff

Previously, it would only remove temp tables created in the same  
session; but if the session uses the BackendId of a previously crashed  
backend that left temp tables around, those would not get removed.  
Since autovacuum would not drop them either (because it sees that the  
BackendId is in use by the current session) these can cause annoying  
xid-wraparound warnings.  
  
Apply to branches 9.4 to 10.  This is not a problem since version 11,  
because commit 943576bddcb5 added state tracking that makes autovacuum  
realize that those temp tables are not ours, so it removes them.  
  
This is useful to handle in DISCARD, because even though it does not  
handle all situations, it does handle the common one where a connection  
pooler keeps the same session open for an indefinitely long time.  
  
Discussion: https://postgr.es/m/20181226190834.wsk2wzott5yzrjiq@alvherre.pgsql  
Reviewed-by: Takayuki Tsunakawa, Michaël Paquier  

M src/backend/catalog/namespace.c

Make autovacuum more selective about temp tables to keep

commit   : a6ca47cd2f3fd6bfc368543583db7d569a09422b    
  
author   : Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Thu, 27 Dec 2018 16:00:39 -0300    
  
committer: Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Thu, 27 Dec 2018 16:00:39 -0300    

Click here for diff

When temp tables are in danger of XID wraparound, autovacuum drops them;  
however, it preserves those that are owned by a working session.  This  
is desirable, except when the session is connected to a different  
database (because the temp tables cannot be from that session), so make  
it only keep the temp tables only if the backend is in the same database  
as the temp tables.  
  
This is not bulletproof: it fails to detect temp tables left by a  
session whose backend ID is reused in the same database but the new  
session does not use temp tables.  Commit 943576bddcb5 fixes that case  
too, for branches 11 and up (which is why we don't apply this fix to  
those branches), but back-patching that one is not universally agreed  
on.  
  
Discussion: https://postgr.es/m/20181214162843.37g6h3txto43akrb@alvherre.pgsql  
Reviewed-by: Takayuki Tsunakawa, Michaël Paquier  

M src/backend/postmaster/autovacuum.c

Ignore inherited temp relations from other sessions when truncating

commit   : d4486700b58387e6b4d0304a61d0d89f1031595c    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Thu, 27 Dec 2018 10:17:13 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Thu, 27 Dec 2018 10:17:13 +0900    

Click here for diff

Inheritance trees can include temporary tables if the parent is  
permanent, which makes possible the presence of multiple temporary  
children from different sessions.  Trying to issue a TRUNCATE on the  
parent in this scenario causes a failure, so similarly to any other  
queries just ignore such cases, which makes TRUNCATE work  
transparently.  
  
This makes truncation behave similarly to any other DML query working on  
the parent table with queries which need to be issues on children.  A  
set of isolation tests is added to cover basic cases.  
  
Reported-by: Zhou Digoal  
Author: Amit Langote, Michael Paquier  
Discussion: https://postgr.es/m/15565-ce67a48d0244436a@postgresql.org  
Backpatch-through: 9.4  

M src/backend/commands/tablecmds.c
A src/test/isolation/expected/inherit-temp.out
M src/test/isolation/isolation_schedule
A src/test/isolation/specs/inherit-temp.spec

Fix portability failure introduced in commits d2b0b60e7 et al.

commit   : 9939ea16c2dcf98e7fe05666ed3c3d547a655250    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 26 Dec 2018 15:30:10 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 26 Dec 2018 15:30:10 -0500    

Click here for diff

I made a frontend fprintf() format use %m, forgetting that that's only  
safe in HEAD not the back branches; prior to 96bf88d52 and d6c55de1f,  
it would work on glibc platforms but not elsewhere.  Revert to using  
%s ... strerror(errno) as the code did before.  
  
We could have left HEAD as-is, but for code consistency across branches,  
I chose to apply this patch there too.  
  
Per Coverity and a few buildfarm members.  

M src/common/psprintf.c

Prioritize history files when archiving

commit   : 0857575774a25a9778abd1b6f500b61092766418    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Mon, 24 Dec 2018 20:25:57 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Mon, 24 Dec 2018 20:25:57 +0900    

Click here for diff

At the end of recovery for the post-promotion process, a new history  
file is created followed by the last partial segment of the previous  
timeline.  Based on the timing, the archiver would first try to archive  
the last partial segment and then the history file.  This can delay the  
detection of a new timeline taken, particularly depending on the time it  
takes to transfer the last partial segment as it delays the moment the  
history file of the new timeline gets archived.  This can cause promoted  
standbys to use the same timeline as one already taken depending on the  
circumstances if multiple instances look at archives at the same  
location.  
  
This commit changes the order of archiving so as history files are  
archived in priority over other file types, which reduces the likelihood  
of the same timeline being taken (still not reducing the window to  
zero), and it makes the archiver behave more consistently with the  
startup process doing its post-promotion business.  
  
Author: David Steele  
Reviewed-by: Michael Paquier, Kyotaro Horiguchi  
Discussion: https://postgr.es/m/929068cf-69e1-bba2-9dc0-e05986aed471@pgmasters.net  
Backpatch-through: 9.5  

M src/backend/postmaster/pgarch.c

Disable WAL-skipping optimization for COPY on views

commit   : 15f69279e0e85bc4b3cf9593ad090515e500613c    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Sun, 23 Dec 2018 16:43:56 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Sun, 23 Dec 2018 16:43:56 +0900    

Click here for diff

COPY can skip writing WAL when loading data on a table which has been  
created in the same transaction as the one loading the data, however  
this cannot work on views as this would result in trying to flush  
relation files which do not exist.  So disable the optimization so as  
commands are able to work the same way with any configuration of  
wal_level.  
  
A test is added to cover this case, which needs to have wal_level set to  
minimal to allow the problem to show up, and that is not the default  
configuration.  
  
Reported-by: Etsuro Fujita  
Author: Michael Paquier  
Reviewed-by: Etsuro Fujita  
Discussion: https://postgr.es/m/15552-c64aa14c5c22f63c@postgresql.org  
Backpatch-through: 10, where support for COPY on views has been added,  
while v11 has added support for COPY on foreign tables.  

M src/backend/commands/copy.c
M src/test/regress/expected/copy2.out
M src/test/regress/sql/copy2.sql

commit   : 669d9eae8531c5d84bc2f6d8f8c9b93d50345403    
  
author   : Peter Eisentraut <peter_e@gmx.net>    
date     : Sat, 22 Dec 2018 07:21:40 +0100    
  
committer: Peter Eisentraut <peter_e@gmx.net>    
date     : Sat, 22 Dec 2018 07:21:40 +0100    

Click here for diff

This has never been correct since this code was introduced.  

M src/bin/initdb/initdb.c
M src/bin/pg_basebackup/pg_basebackup.c

Check for conflicting queries during replay of gistvacuumpage()

commit   : e36e25275fb8ae9440611e23a54b2f0158c56980    
  
author   : Alexander Korotkov <akorotkov@postgresql.org>    
date     : Fri, 21 Dec 2018 02:33:48 +0300    
  
committer: Alexander Korotkov <akorotkov@postgresql.org>    
date     : Fri, 21 Dec 2018 02:33:48 +0300    

Click here for diff

013ebc0a7b implements so-called GiST microvacuum.  That is gistgettuple() marks  
index tuples as dead when kill_prior_tuple is set.  Later, when new tuple  
insertion claims page space, those dead index tuples are physically deleted  
from page.  When this deletion is replayed on standby, it might conflict with  
read-only queries.  But 013ebc0a7b doesn't handle this.  That may lead to  
disappearance of some tuples from read-only snapshots on standby.  
  
This commit implements resolving of conflicts between replay of GiST microvacuum  
and standby queries.  On the master we implement new WAL record type  
XLOG_GIST_DELETE, which comprises necessary information.  On stable releases  
we've to be tricky to keep WAL compatibility.  Information required for conflict  
processing is just appended to data of XLOG_GIST_PAGE_UPDATE record.  So,  
PostgreSQL version, which doesn't know about conflict processing, will just  
ignore that.  
  
Reported-by: Andres Freund  
Diagnosed-by: Andres Freund  
Discussion: https://postgr.es/m/20181212224524.scafnlyjindmrbe6%40alap3.anarazel.de  
Author: Alexander Korotkov  
Backpatch-through: 9.6  

M src/backend/access/gist/gist.c
M src/backend/access/gist/gistbuild.c
M src/backend/access/gist/gistvacuum.c
M src/backend/access/gist/gistxlog.c
M src/include/access/gist_private.h

Fix lock level used for partition when detaching it

commit   : 1c142612c846cd01ed0615041e09e6fab7d44571    
  
author   : Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Thu, 20 Dec 2018 16:42:13 -0300    
  
committer: Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Thu, 20 Dec 2018 16:42:13 -0300    

Click here for diff

For probably bogus reasons, we acquire only AccessShareLock on the  
partition when we try to detach it from its parent partitioned table.  
This can cause ugly things to happen if another transaction is doing  
any sort of DDL to the partition concurrently.  
  
Upgrade that lock to ShareUpdateExclusiveLock, which per discussion  
seems to be the minimum needed.  
  
Reported by Robert Haas.  
  
Discussion: https://postgr.es/m/CA+TgmoYruJQ+2qnFLtF1xQtr71pdwgfxy3Ziy-TxV28M6pEmyA@mail.gmail.com  

M src/backend/commands/tablecmds.c

Doc: fix ancient mistake in search_path documentation.

commit   : 164d439550dd4b29b8c0bf317779ac8d4b4c2d8f    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 20 Dec 2018 13:55:11 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 20 Dec 2018 13:55:11 -0500    

Click here for diff

"$user" in a search_path string is replaced by CURRENT_USER not  
SESSION_USER.  (It actually was SESSION_USER in the initial implementation,  
but we changed it shortly later, and evidently forgot to fix the docs to  
match.)  
  
Noted by antonov@stdpr.ru  
  
Discussion: https://postgr.es/m/159151fb45d490c8d31ea9707e9ba99d@stdpr.ru  

M doc/src/sgml/config.sgml

Fix ADD IF NOT EXISTS used in conjunction with ALTER TABLE ONLY

commit   : 9e6cd794c282499aa0d2d31166c023cda0682e67    
  
author   : Greg Stark <stark@mit.edu>    
date     : Wed, 19 Dec 2018 18:28:35 -0500    
  
committer: Greg Stark <stark@mit.edu>    
date     : Wed, 19 Dec 2018 18:28:35 -0500    

Click here for diff

The flag for IF NOT EXISTS was only being passed down in the normal  
recursing case. It's been this way since originally added in 9.6 in  
commit 2cd40adb85 so backpatch back to 9.6.  

M src/backend/commands/tablecmds.c
M src/test/regress/expected/alter_table.out
M src/test/regress/sql/alter_table.sql

Doc: fix incorrect example of collecting arguments with fmgr macros.

commit   : 4aad9813e8040ea8ad7a149ee5724ee3631c6d55    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 19 Dec 2018 11:02:08 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 19 Dec 2018 11:02:08 -0500    

Click here for diff

Thinko in commit f66912b0a.  Back-patch to v10, as that was.  
  
Discussion: https://postgr.es/m/154522283371.15419.15167411691473730460@wrigleys.postgresql.org  

M doc/src/sgml/spi.sgml

Fix ancient thinko in mergejoin cost estimation.

commit   : d16567093f734004d0e54e54b2ebf041a6e8ae9c    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Tue, 18 Dec 2018 11:19:39 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Tue, 18 Dec 2018 11:19:39 -0500    

Click here for diff

"rescanratio" was computed as 1 + rescanned-tuples / total-inner-tuples,  
which is sensible if it's to be multiplied by total-inner-tuples or a cost  
value corresponding to scanning all the inner tuples.  But in reality it  
was (mostly) multiplied by inner_rows or a related cost, numbers that take  
into account the possibility of stopping short of scanning the whole inner  
relation thanks to a limited key range in the outer relation.  This'd  
still make sense if we could expect that stopping short would result in a  
proportional decrease in the number of tuples that have to be rescanned.  
It does not, however.  The argument that establishes the validity of our  
estimate for that number is independent of whether we scan all of the inner  
relation or stop short, and experimentation also shows that stopping short  
doesn't reduce the number of rescanned tuples.  So the correct calculation  
is 1 + rescanned-tuples / inner_rows, and we should be sure to multiply  
that by inner_rows or a corresponding cost value.  
  
Most of the time this doesn't make much difference, but if we have  
both a high rescan rate (due to lots of duplicate values) and an outer  
key range much smaller than the inner key range, then the error can  
be significant, leading to a large underestimate of the cost associated  
with rescanning.  
  
Per report from Vijaykumar Jain.  This thinko appears to go all the way  
back to the introduction of the rescan estimation logic in commit  
70fba7043, so back-patch to all supported branches.  
  
Discussion: https://postgr.es/m/CAE7uO5hMb_TZYJcZmLAgO6iD68AkEK6qCe7i=vZUkCpoKns+EQ@mail.gmail.com  

M src/backend/optimizer/path/costsize.c

commit   : b63df2deae8078c8ae6526e42e543832a8959e6b    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Tue, 18 Dec 2018 10:03:00 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Tue, 18 Dec 2018 10:03:00 +0900    

Click here for diff

The project has moved to a new place.  
  
Reported-by: Peter Neave  
Discussion: https://postgr.es/m/154474118231.5066.16352227860913505754@wrigleys.postgresql.org  

M doc/src/sgml/maintenance.sgml

Remove extra semicolons.

commit   : 0fe0b2f474ae80c2d8ac06ce0b75ce7ed626f1d7    
  
author   : Amit Kapila <akapila@postgresql.org>    
date     : Mon, 17 Dec 2018 14:29:49 +0530    
  
committer: Amit Kapila <akapila@postgresql.org>    
date     : Mon, 17 Dec 2018 14:29:49 +0530    

Click here for diff

Reported-by: David Rowley  
Author: David Rowley  
Reviewed-by: Amit Kapila  
Backpatch-through: 10  
Discussion: https://postgr.es/m/CAKJS1f8EneeYyzzvdjahVZ6gbAHFkHbSFB5m_C0Y6TUJs9Dgdg@mail.gmail.com  

M src/backend/commands/trigger.c

Fix use-after-free bug when renaming constraints

commit   : 91fc2a08830139d9c11b189a2407cfdf113f550f    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Mon, 17 Dec 2018 12:43:48 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Mon, 17 Dec 2018 12:43:48 +0900    

Click here for diff

This is an oversight from recent commit b13fd344.  While on it, tweak  
the previous test with a better name for the renamed primary key.  
  
Detected by buildfarm member prion which forces relation cache release  
with -DRELCACHE_FORCE_RELEASE.  Back-patch down to 9.4 as the previous  
commit.  

M src/backend/commands/tablecmds.c
M src/test/regress/expected/alter_table.out
M src/test/regress/sql/alter_table.sql

Make constraint rename issue relcache invalidation on target relation

commit   : da13d90a5fba051d16df3b4fdaac23abc9560f38    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Mon, 17 Dec 2018 10:36:21 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Mon, 17 Dec 2018 10:36:21 +0900    

Click here for diff

When a constraint gets renamed, it may have associated with it a target  
relation (for example domain constraints don't have one).  Not  
invalidating the target relation cache when issuing the renaming can  
result in issues with subsequent commands that refer to the old  
constraint name using the relation cache, causing various failures.  One  
pattern spotted was using CREATE TABLE LIKE after a constraint  
renaming.  
  
Reported-by: Stuart <sfbarbee@gmail.com>  
Author: Amit Langote  
Reviewed-by: Michael Paquier  
Discussion: https://postgr.es/m/2047094.V130LYfLq4@station53.ousa.org  

M src/backend/commands/tablecmds.c
M src/test/regress/expected/alter_table.out
M src/test/regress/sql/alter_table.sql

Make error handling in parallel pg_upgrade less bogus.

commit   : f4290113f50d1bcd67a9e51b74927c59592ad2ea    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sun, 16 Dec 2018 14:51:47 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sun, 16 Dec 2018 14:51:47 -0500    

Click here for diff

reap_child() basically ignored the possibility of either an error in  
waitpid() itself or a child process failure on signal.  We don't really  
need to do more than report and crash hard, but proceeding as though  
nothing is wrong is definitely Not Acceptable.  The error report for  
nonzero child exit status was pretty off-point, as well.  
  
Noted while fooling around with child-process failure detection  
logic elsewhere.  It's been like this a long time, so back-patch to  
all supported branches.  

M src/bin/pg_upgrade/parallel.c

Improve detection of child-process SIGPIPE failures.

commit   : 34010ac2fa187ce032a7b243c829c7ef5f047e20    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sun, 16 Dec 2018 14:32:14 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sun, 16 Dec 2018 14:32:14 -0500    

Click here for diff

Commit ffa4cbd62 added logic to detect SIGPIPE failure of a COPY child  
process, but it only worked correctly if the SIGPIPE occurred in the  
immediate child process.  Depending on the shell in use and the  
complexity of the shell command string, we might instead get back  
an exit code of 128 + SIGPIPE, representing a shell error exit  
reporting SIGPIPE in the child process.  
  
We could just hack up ClosePipeToProgram() to add the extra case,  
but it seems like this is a fairly general issue deserving a more  
general and better-documented solution.  I chose to add a couple  
of functions in src/common/wait_error.c, which is a natural place  
to know about wait-result encodings, that will test for either a  
specific child-process signal type or any child-process signal failure.  
Then, adjust other places that were doing ad-hoc tests of this type  
to use the common functions.  
  
In RestoreArchivedFile, this fixes a race condition affecting whether  
the process will report an error or just silently proc_exit(1): before,  
that depended on whether the intermediate shell got SIGTERM'd itself  
or reported a child process failing on SIGTERM.  
  
Like the previous patch, back-patch to v10; we could go further  
but there seems no real need to.  
  
Per report from Erik Rijkers.  
  
Discussion: https://postgr.es/m/f3683f87ab1701bea5d86a7742b22432@xs4all.nl  

M src/backend/access/transam/xlogarchive.c
M src/backend/commands/copy.c
M src/backend/postmaster/pgarch.c
M src/common/wait_error.c
M src/include/port.h

Fix bogus logic for skipping unnecessary partcollation dependencies.

commit   : 8b90174e3f0638ff542bef7f367429750d18b08c    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 13 Dec 2018 15:11:09 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 13 Dec 2018 15:11:09 -0500    

Click here for diff

The idea here is to not call recordDependencyOn for the default collation,  
since we know that's pinned.  But what the code actually did was to record  
the partition key's dependency on the opclass twice, instead.  
  
Evidently introduced by sloppy coding in commit 2186b608b.  Back-patch  
to v10 where that came in.  

M src/backend/catalog/heap.c

Prevent GIN deleted pages from being reclaimed too early

commit   : a0696d29551bf3cb5dbd2b72f89aed0bbf0dcab3    
  
author   : Alexander Korotkov <akorotkov@postgresql.org>    
date     : Thu, 13 Dec 2018 06:12:31 +0300    
  
committer: Alexander Korotkov <akorotkov@postgresql.org>    
date     : Thu, 13 Dec 2018 06:12:31 +0300    

Click here for diff

When GIN vacuum deletes a posting tree page, it assumes that no concurrent  
searchers can access it, thanks to ginStepRight() locking two pages at once.  
However, since 9.4 searches can skip parts of posting trees descending from the  
root.  That leads to the risk that page is deleted and reclaimed before  
concurrent search can access it.  
  
This commit prevents the risk of above by waiting for every transaction, which  
might wait to reference this page, to finish.  Due to binary compatibility  
we can't change GinPageOpaqueData to store corresponding transaction id.  
Instead we reuse page header pd_prune_xid field, which is unused in index pages.  
  
Discussion: https://postgr.es/m/31a702a.14dd.166c1366ac1.Coremail.chjischj%40163.com  
Author: Andrey Borodin, Alexander Korotkov  
Reviewed-by: Alexander Korotkov  
Backpatch-through: 9.4  

M src/backend/access/gin/README
M src/backend/access/gin/ginutil.c
M src/backend/access/gin/ginvacuum.c
M src/backend/access/gin/ginxlog.c
M src/include/access/ginblock.h
M src/include/access/ginxlog.h

Prevent deadlock in ginRedoDeletePage()

commit   : 865870374aff35b886afac12e71542a1b079a021    
  
author   : Alexander Korotkov <akorotkov@postgresql.org>    
date     : Thu, 13 Dec 2018 06:12:25 +0300    
  
committer: Alexander Korotkov <akorotkov@postgresql.org>    
date     : Thu, 13 Dec 2018 06:12:25 +0300    

Click here for diff

On standby ginRedoDeletePage() can work concurrently with read-only queries.  
Those queries can traverse posting tree in two ways.  
1) Using rightlinks by ginStepRight(), which locks the next page before  
   unlocking its left sibling.  
2) Using downlinks by ginFindLeafPage(), which locks at most one page at time.  
  
Original lock order was: page, parent, left sibling.  That lock order can  
deadlock with ginStepRight().  In order to prevent deadlock this commit changes  
lock order to: left sibling, page, parent.  Note, that position of parent in  
locking order seems insignificant, because we only lock one page at time while  
traversing downlinks.  
  
Reported-by: Chen Huajun  
Diagnosed-by: Chen Huajun, Peter Geoghegan, Andrey Borodin  
Discussion: https://postgr.es/m/31a702a.14dd.166c1366ac1.Coremail.chjischj%40163.com  
Author: Alexander Korotkov  
Backpatch-through: 9.4  

M src/backend/access/gin/ginxlog.c

Fix deadlock in GIN vacuum introduced by 218f51584d5

commit   : 2e3bd064e530bfe85257032919cfae20860708cc    
  
author   : Alexander Korotkov <akorotkov@postgresql.org>    
date     : Thu, 13 Dec 2018 06:12:11 +0300    
  
committer: Alexander Korotkov <akorotkov@postgresql.org>    
date     : Thu, 13 Dec 2018 06:12:11 +0300    

Click here for diff

Before 218f51584d5 if posting tree page is about to be deleted, then the whole  
posting tree is locked by LockBufferForCleanup() on root preventing all the  
concurrent inserts.  218f51584d5 reduced locking to the subtree containing  
page to be deleted.  However, due to concurrent parent split, inserter doesn't  
always holds pins on all the pages constituting path from root to the target  
leaf page.  That could cause a deadlock between GIN vacuum process and GIN  
inserter.  And we didn't find non-invasive way to fix this.  
  
This commit reverts VACUUM behavior to lock the whole posting tree before  
delete any page.  However, we keep another useful change by 218f51584d5: the  
tree is locked only if there are pages to be deleted.  
  
Reported-by: Chen Huajun  
Diagnosed-by: Chen Huajun, Andrey Borodin, Peter Geoghegan  
Discussion: https://postgr.es/m/31a702a.14dd.166c1366ac1.Coremail.chjischj%40163.com  
Author: Alexander Korotkov, based on ideas from Andrey Borodin and Peter Geoghegan  
Reviewed-by: Andrey Borodin  
Backpatch-through: 10  

M src/backend/access/gin/README
M src/backend/access/gin/ginvacuum.c

Repair bogus EPQ plans generated for postgres_fdw foreign joins.

commit   : 8a7f24b22fd3ef2b976f984d3675084120574618    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 12 Dec 2018 16:08:30 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 12 Dec 2018 16:08:30 -0500    

Click here for diff

postgres_fdw's postgresGetForeignPlan() assumes without checking that the  
outer_plan it's given for a join relation must have a NestLoop, MergeJoin,  
or HashJoin node at the top.  That's been wrong at least since commit  
4bbf6edfb (which could cause insertion of a Sort node on top) and it seems  
like a pretty unsafe thing to Just Assume even without that.  
  
Through blind good fortune, this doesn't seem to have any worse  
consequences today than strange EXPLAIN output, but it's clearly trouble  
waiting to happen.  
  
To fix, test the node type explicitly before touching Join-specific  
fields, and avoid jamming the new tlist into a node type that can't  
do projection.  Export a new support function from createplan.c  
to avoid building low-level knowledge about the latter into FDWs.  
  
Back-patch to 9.6 where the faulty coding was added.  Note that the  
associated regression test cases don't show any changes before v11,  
apparently because the tests back-patched with 4bbf6edfb don't actually  
exercise the problem case before then (there's no top-level Sort  
in those plans).  
  
Discussion: https://postgr.es/m/8946.1544644803@sss.pgh.pa.us  

M contrib/postgres_fdw/postgres_fdw.c
M src/backend/optimizer/plan/createplan.c
M src/include/optimizer/planmain.h

Repair bogus handling of multi-assignment Params in upper plan levels.

commit   : f9f63ed1f2e5c654926fdb44beabab8ff28e0387    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 12 Dec 2018 13:49:41 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 12 Dec 2018 13:49:41 -0500    

Click here for diff

Our support for multiple-set-clauses in UPDATE assumes that the Params  
referencing a MULTIEXPR_SUBLINK SubPlan will appear before that SubPlan  
in the targetlist of the plan node that calculates the updated row.  
(Yeah, it's a hack...)  In some PG branches it's possible that a Result  
node gets inserted between the primary calculation of the update tlist  
and the ModifyTable node.  setrefs.c did the wrong thing in this case  
and left the upper-level Params as Params, causing a crash at runtime.  
What it should do is replace them with "outer" Vars referencing the child  
plan node's output.  That's a result of careless ordering of operations  
in fix_upper_expr_mutator, so we can fix it just by reordering the code.  
  
Fix fix_join_expr_mutator similarly for consistency, even though join  
nodes could never appear in such a context.  (In general, it seems  
likely to be a bit cheaper to use Vars than Params in such situations  
anyway, so this patch might offer a tiny performance improvement.)  
  
The hazard extends back to 9.5 where the MULTIEXPR_SUBLINK stuff  
was introduced, so back-patch that far.  However, this may be a live  
bug only in 9.6.x and 10.x, as the other branches don't seem to want  
to calculate the final tlist below the Result node.  (That plan shape  
change between branches might be a mini-bug in itself, but I'm not  
really interested in digging into the reasons for that right now.  
Still, add a regression test memorializing what we expect there,  
so we'll notice if it changes again.)  
  
Per bug report from Eduards Bezverhijs.  
  
Discussion: https://postgr.es/m/b6cd572a-3e44-8785-75e9-c512a5a17a73@tieto.com  

M src/backend/optimizer/plan/setrefs.c
M src/test/regress/expected/update.out
M src/test/regress/sql/update.sql

Fix test_rls_hooks to assign expression collations properly.

commit   : 0226cd72ec46ae946db77e9904b5588ca54f3ec6    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Tue, 11 Dec 2018 11:48:00 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Tue, 11 Dec 2018 11:48:00 -0500    

Click here for diff

This module overlooked this necessary fixup step on the results of  
transformWhereClause().  It accidentally worked anyway, because the  
constructed expression involved type "name" which is not collatable,  
but it fell over while I was experimenting with changing "name" to  
be collatable.  
  
Back-patch, not because there's any live bug here in back branches,  
but because somebody might use this code as a model for some real  
application and then not understand why it doesn't work.  

M src/test/modules/test_rls_hooks/test_rls_hooks.c

Doc: improve documentation about ALTER LARGE OBJECT requirements.

commit   : b10997b5b3eec7fb9fe64d7543435552f327ee51    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Tue, 11 Dec 2018 11:21:36 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Tue, 11 Dec 2018 11:21:36 -0500    

Click here for diff

Unlike other ALTER ref pages, this one neglected to mention that  
ALTER OWNER requires being a member of the new owning role.  
Per bug #15546 from Stefan Kadow.  
  
Discussion: https://postgr.es/m/15546-0558c75fd2025e7c@postgresql.org  

M doc/src/sgml/ref/alter_large_object.sgml

Raise some timeouts to 180s, in test code.

commit   : eff12423391637b04b3426db57c5eda93161a0b8    
  
author   : Noah Misch <noah@leadboat.com>    
date     : Mon, 10 Dec 2018 20:15:42 -0800    
  
committer: Noah Misch <noah@leadboat.com>    
date     : Mon, 10 Dec 2018 20:15:42 -0800    

Click here for diff

Slow runs of buildfarm members chipmunk, hornet and mandrill saw the  
shorter timeouts expire.  The 180s timeout in poll_query_until has been  
trouble-free since 2a0f89cd717ce6d49cdc47850577823682167e87 introduced  
it two years ago, so use 180s more widely.  Back-patch to 9.6, where the  
first of these timeouts was introduced.  
  
Reviewed by Michael Paquier.  
  
Discussion: https://postgr.es/m/20181209001601.GC2973271@rfd.leadboat.com  

M src/test/isolation/README
M src/test/isolation/isolationtester.c
M src/test/recovery/t/006_logical_decoding.pl
M src/test/recovery/t/010_logical_decoding_timelines.pl

Add stack depth checks to key recursive functions in backend/nodes/*.c.

commit   : e60122b54daf6f0e93162161b41ecb9ab4655fa5    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 10 Dec 2018 11:12:43 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 10 Dec 2018 11:12:43 -0500    

Click here for diff

Although copyfuncs.c has a check_stack_depth call in its recursion,  
equalfuncs.c, outfuncs.c, and readfuncs.c lacked one.  This seems  
unwise.  
  
Likewise fix planstate_tree_walker(), in branches where that exists.  
  
Discussion: https://postgr.es/m/30253.1544286631@sss.pgh.pa.us  

M src/backend/nodes/equalfuncs.c
M src/backend/nodes/nodeFuncs.c
M src/backend/nodes/outfuncs.c
M src/backend/nodes/readfuncs.c

Make TupleDescInitBuiltinEntry throw error for unsupported types.

commit   : 9eaba23c414d9da1e767e1af0a80cb687dc358e2    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 10 Dec 2018 10:38:49 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 10 Dec 2018 10:38:49 -0500    

Click here for diff

Previously, it would just pass back a partially-uninitialized tupdesc,  
which doesn't seem like a safe or useful behavior.  
  
Backpatch to v10 where this code came in.  
  
Discussion: https://postgr.es/m/30830.1544384975@sss.pgh.pa.us  

M src/backend/access/common/tupdesc.c

Fix misapplication of pgstat_count_truncate to wrong relation.

commit   : 54f24ab76dedb69c03fe4b271c7f53a351637df3    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 7 Dec 2018 12:12:00 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 7 Dec 2018 12:12:00 -0500    

Click here for diff

The stanza of ExecuteTruncate[Guts] that truncates a target table's toast  
relation re-used the loop local variable "rel" to reference the toast rel.  
This was safe enough when written, but commit d42358efb added code below  
that that supposed "rel" still pointed to the parent table.  Therefore,  
the stats counter update was applied to the wrong relcache entry (the  
toast rel not the user rel); and if we were unlucky and that relcache  
entry had been flushed during reindex_relation, very bad things could  
ensue.  
  
(I'm surprised that CLOBBER_CACHE_ALWAYS testing hasn't found this.  
I'm even more surprised that the problem wasn't detected during the  
development of d42358efb; it must not have been tested in any case  
with a toast table, as the incorrect stats counts are very obvious.)  
  
To fix, replace use of "rel" in that code branch with a more local  
variable.  Adjust test cases added by d42358efb so that some of them  
use tables with toast tables.  
  
Per bug #15540 from Pan Bian.  Back-patch to 9.5 where d42358efb came in.  
  
Discussion: https://postgr.es/m/15540-01078812338195c0@postgresql.org  

M src/backend/commands/tablecmds.c
M src/test/regress/expected/stats.out
M src/test/regress/sql/stats.sql

Clean up sloppy coding in publicationcmds.c’s OpenTableList().

commit   : aaf7b3bd6f715078867092e7e95c94a1e4222646    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 7 Dec 2018 11:02:39 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 7 Dec 2018 11:02:39 -0500    

Click here for diff

Remove dead code (which would be incorrect if it weren't dead),  
per report from Pan Bian.  Add a CHECK_FOR_INTERRUPTS in the  
inner loop over child relations, because there's little point  
in having one in the outer loop if there's not one here too.  
Minor stylistic adjustments and comment improvements.  
  
Seems to be aboriginal to this code (cf commit 665d1fad9).  
Back-patch to v10 where that came in, not because any of this  
is significant, but just to keep the branches looking similar.  
  
Discussion: https://postgr.es/m/15539-06d00ef6b1e2e1bb@postgresql.org  

M src/backend/commands/publicationcmds.c

Improve our response to invalid format strings, and detect more cases.

commit   : 6dc46f8ca83dcec59469261cabad9d0d153ecf24    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 6 Dec 2018 15:08:44 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 6 Dec 2018 15:08:44 -0500    

Click here for diff

Places that are testing for *printf failure ought to include the format  
string in their error reports, since bad-format-string is one of the  
more likely causes of such failure.  This both makes it easier to find  
and repair the mistake, and provides at least some useful info to the  
user who stumbles across such a problem.  
  
Also, tighten snprintf.c to report EINVAL for an invalid flag or  
final character in a format %-spec (including the case where the  
%-spec is missing a final character altogether).  This seems like  
better project policy, and it also allows removing an instruction  
or two from the hot code path.  
  
Back-patch the error reporting change in pvsnprintf, since it should be  
harmless and may be helpful; but not the snprintf.c change.  
  
Per discussion of bug #15511 from Ertuğrul Kahveci, which reported an  
invalid translated format string.  These changes don't fix that error,  
but they should improve matters next time we make such a mistake.  
  
Discussion: https://postgr.es/m/15511-1d8b6a0bc874112f@postgresql.org  

M src/common/psprintf.c

Improve planner stats documentation

commit   : 23f9e3e36b1b58625f79a741c0fa6468c682da4e    
  
author   : Stephen Frost <sfrost@snowman.net>    
date     : Thu, 6 Dec 2018 11:38:56 -0500    
  
committer: Stephen Frost <sfrost@snowman.net>    
date     : Thu, 6 Dec 2018 11:38:56 -0500    

Click here for diff

It was pointed out that in the planner stats documentation under  
Extended Statistics, one of the sentences was a bit awkward.  Improve  
that by rewording it slightly.  
  
Discussion: https://postgr.es/m/154409976780.14137.2785644488950047100@wrigleys.postgresql.org  

M doc/src/sgml/perform.sgml

Fix invalid value of synchronous_commit in description of flush_lag

commit   : db35e959bbbddaf01c9aa1060ef60b34520e021d    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Wed, 5 Dec 2018 10:03:01 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Wed, 5 Dec 2018 10:03:01 +0900    

Click here for diff

"remote_flush" has never been a valid user-facing value, but "on" is.  
  
Author: Maksim Milyutin  
Discussion: https://postgr.es/m/27b3b80c-3615-2d76-02c5-44566b53136c@gmail.com  

M doc/src/sgml/monitoring.sgml

Document handling of invalid/ambiguous timestamp input near DST boundaries.

commit   : 764b0539b9751a9b9995cf070463cb2a3ec61777    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 29 Nov 2018 18:28:10 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 29 Nov 2018 18:28:10 -0500    

Click here for diff

The source code comments documented this, but the user-facing docs, not  
so much.  Add a section to Appendix B that discusses it.  
  
In passing, improve a couple other things in Appendix B --- notably,  
a long-obsolete claim that time zone abbreviations are looked up in  
a fixed table.  
  
Per bug #15527 from Michael Davidson.  
  
Discussion: https://postgr.es/m/15527-f1be0b4dc99ebbe7@postgresql.org  

M doc/src/sgml/datetime.sgml

Ensure static libraries have correct mod time even if ranlib messes it up.

commit   : bac66c6e7cf386aca929d28337da3fd4a22f11e2    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 29 Nov 2018 15:53:44 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 29 Nov 2018 15:53:44 -0500    

Click here for diff

In at least Apple's version of ranlib, the output file is updated to have  
a mod time equal to the max of the timestamps of its components, and that  
data only has seconds precision.  On a filesystem with sub-second file  
timestamp precision --- say, APFS --- this can result in the finished  
static library appearing older than its input files, which causes useless  
rebuilds and possible outright failures in parallel makes.  
  
We've only seen this reported in the field from people using Apple's  
ranlib with a non-Apple make, because Apple's make doesn't know about  
sub-second timestamps either so it doesn't decide rebuilds are needed.  
But Apple's ranlib presumably shares code with at least some BSDen,  
so it's not that unlikely that the same problem could arise elsewhere.  
  
To fix, just "touch" the output file after ranlib finishes.  
  
We seem to need this in only one place.  There are other calls of  
ranlib in our makefiles, but they are working on intermediate files  
whose timestamps are not actually important, or else on an installed  
static library for which sub-second timestamp precision is unlikely  
to matter either.  (Also, so far as I can tell, Apple's ranlib doesn't  
mess up the file timestamp in the latter usage anyhow.)  
  
In passing, change "ranlib" to "$(RANLIB)" in one place that was  
bypassing the make macro for no good reason.  
  
Per bug #15525 from Jack Kelly (via Alyssa Ross).  
Back-patch to all supported branches.  
  
Discussion: https://postgr.es/m/15525-a30da084f17a1faa@postgresql.org  

M src/Makefile.shlib

Fix minor typo in dsa.c.

commit   : 2e58a73a70d523b9eb426f77155bf206d8966259    
  
author   : Thomas Munro <tmunro@postgresql.org>    
date     : Thu, 29 Nov 2018 14:14:26 +1300    
  
committer: Thomas Munro <tmunro@postgresql.org>    
date     : Thu, 29 Nov 2018 14:14:26 +1300    

Click here for diff

Author: Takeshi Ideriha  
Discussion: https://postgr.es/m/4E72940DA2BF16479384A86D54D0988A6F3BF22D%40G01JPEXMBKW04  

M src/backend/utils/mmgr/dsa.c

Fix handling of synchronous replication for stopping WAL senders

commit   : 04e381a19929bed34c664233eb4357f0d7d78696    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Thu, 29 Nov 2018 09:12:45 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Thu, 29 Nov 2018 09:12:45 +0900    

Click here for diff

This fixes an oversight from c6c3334 which forgot that if a subset of  
WAL senders are stopping and in a sync state, other WAL senders could  
still be waiting for a WAL position to be synced while committing a  
transaction.  However the subset of stopping senders would not release  
waiters, potentially breaking synchronous replication guarantees.  This  
commit makes sure that even WAL senders stopping are able to release  
waiters and are tracked properly.  
  
On 9.4, this can also trigger an assertion failure when setting for  
example max_wal_senders to 1 where a WAL sender is not able to find  
itself as in synchronous state when the instance stops.  
  
Reported-by: Paul Guo  
Author: Paul Guo, Michael Paquier  
Discussion: https://postgr.es/m/CAEET0ZEv8VFqT3C-cQm6byOB4r4VYWcef1J21dOX-gcVhCSpmA@mail.gmail.com  
Backpatch-through: 9.4  

M src/backend/replication/syncrep.c

C comment: remove extra ‘*’

commit   : 7c688d068f55c9ed8159f6b5e68025f88cfc1abc    
  
author   : Bruce Momjian <bruce@momjian.us>    
date     : Wed, 28 Nov 2018 07:34:10 -0500    
  
committer: Bruce Momjian <bruce@momjian.us>    
date     : Wed, 28 Nov 2018 07:34:10 -0500    

Click here for diff

Reported-by: Etsuro Fujita  
  
Discussion: https://postgr.es/m/5BFE34DE.1080404@lab.ntt.co.jp  
  
Author: Etsuro Fujita  
  
Backpatch-through: 10  

M contrib/postgres_fdw/postgres_fdw.c

Don’t set PAM_RHOST for Unix sockets.

commit   : 96ed0b87045486ca0465f4ea444515754d0915a0    
  
author   : Thomas Munro <tmunro@postgresql.org>    
date     : Wed, 28 Nov 2018 14:00:57 +1300    
  
committer: Thomas Munro <tmunro@postgresql.org>    
date     : Wed, 28 Nov 2018 14:00:57 +1300    

Click here for diff

Since commit 2f1d2b7a we have set PAM_RHOST to "[local]" for Unix  
sockets.  This caused Linux PAM's libaudit integration to make DNS  
requests for that name.  It's not exactly clear what value PAM_RHOST  
should have in that case, but it seems clear that we shouldn't set it  
to an unresolvable name, so don't do that.  
  
Back-patch to 9.6.  Bug #15520.  
  
Author: Thomas Munro  
Reviewed-by: Peter Eisentraut  
Reported-by: Albert Schabhuetl  
Discussion: https://postgr.es/m/15520-4c266f986998e1c5%40postgresql.org  

M src/backend/libpq/auth.c

Do not decode TOAST data for table rewrites

commit   : 4e7395d83faf02d0b64b1da69d0c1be53b76f802    
  
author   : Tomas Vondra <tomas.vondra@postgresql.org>    
date     : Wed, 28 Nov 2018 01:11:15 +0100    
  
committer: Tomas Vondra <tomas.vondra@postgresql.org>    
date     : Wed, 28 Nov 2018 01:11:15 +0100    

Click here for diff

During table rewrites (VACUUM FULL and CLUSTER), the main heap is logged  
using XLOG / FPI records, and thus (correctly) ignored in decoding.  
But the associated TOAST table is WAL-logged as plain INSERT records,  
and so was logically decoded and passed to reorder buffer.  
  
That has severe consequences with TOAST tables of non-trivial size.  
Firstly, reorder buffer has to keep all those changes, possibly spilling  
them to a file, incurring I/O costs and disk space.  
  
Secondly, ReoderBufferCommit() was stashing all those TOAST chunks into  
a hash table, which got discarded only after processing the row from the  
main heap.  But as the main heap is not decoded for rewrites, this never  
happened, so all the TOAST data accumulated in memory, resulting either  
in excessive memory consumption or OOM.  
  
The fix is simple, as commit e9edc1ba already introduced infrastructure  
(namely HEAP_INSERT_NO_LOGICAL flag) to skip logical decoding of TOAST  
tables, but it only applied it to system tables.  So simply use it for  
all TOAST data in raw_heap_insert().  
  
That would however solve only the memory consumption issue - the TOAST  
changes would still be decoded and added to the reorder buffer, and  
spilled to disk (although without TOAST tuple data, so much smaller).  
But we can solve that by tweaking DecodeInsert() to just ignore such  
INSERT records altogether, using XLH_INSERT_CONTAINS_NEW_TUPLE flag,  
instead of skipping them later in ReorderBufferCommit().  
  
Review: Masahiko Sawada  
Discussion: https://www.postgresql.org/message-id/flat/1a17c643-e9af-3dba-486b-fbe31bc1823a%402ndquadrant.com  
Backpatch: 9.4-, where logical decoding was introduced  

M src/backend/access/heap/rewriteheap.c
M src/backend/replication/logical/decode.c
M src/backend/replication/logical/reorderbuffer.c

Fix ac218aa4f6 to work on versions before 9.5.

commit   : a0b4a638037c0a2160ff7c8b898a6c230cbcb9dc    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Mon, 26 Nov 2018 23:26:05 -0800    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Mon, 26 Nov 2018 23:26:05 -0800    

Click here for diff

Unfortunately ac218aa4f6 missed the fact that a reference to  
'pg_catalog.regnamespace'::regclass wouldn't work before that type is  
known. Fix that, by replacing the regtype usage with a join to  
pg_type.  
  
Reported-By: Tom Lane  
Author: Andres Freund  
Discussion: https://postgr.es/m/8863.1543297423@sss.pgh.pa.us  
Backpatch: 9.5-, like ac218aa4f6  

M src/bin/pg_upgrade/check.c

Update pg_upgrade test for reg* to include regrole and regnamespace.

commit   : 181d35af7bb074023156c802a6ae51208fcd7359    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Mon, 26 Nov 2018 17:00:43 -0800    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Mon, 26 Nov 2018 17:00:43 -0800    

Click here for diff

When the regrole (0c90f6769) and regnamespace (cb9fa802b) types were  
added in 9.5, pg_upgrade's check for reg* types wasn't updated. While  
regrole currently is safe, regnamespace is not.  
  
It seems unlikely that anybody uses regnamespace inside catalog tables  
across a pg_upgrade, but the tests should be correct nevertheless.  
  
While at it, reorder the types checked in the query to be  
alphabetical. Otherwise it's annoying to compare existing and tested  
for types.  
  
Author: Andres Freund  
Discussion: https://postgr.es/m/037e152a-cb25-3bcb-4f35-bdc9988f8204@2ndQuadrant.com  
Backpatch: 9.5-, as regrole/regnamespace  

M src/bin/pg_upgrade/check.c

doc: fix wording for plpgsql, add “and”

commit   : 41e0f89c00cd9d3f53364c0ed4dca6ae328ba9e2    
  
author   : Bruce Momjian <bruce@momjian.us>    
date     : Mon, 26 Nov 2018 19:41:19 -0500    
  
committer: Bruce Momjian <bruce@momjian.us>    
date     : Mon, 26 Nov 2018 19:41:19 -0500    

Click here for diff

Reported-by: Anthony Greene  
  
Discussion: https://postgr.es/m/CAPRNmnsSZ4QL75FUjcS8ND_oV+WjgyPbZ4ch2RUwmW6PWzF38w@mail.gmail.com  
  
Backpatch-through: 9.4  

M doc/src/sgml/plpgsql.sgml

Fix translation of special characters in psql’s LaTeX output modes.

commit   : 815409093740d1f6c65da16253636916c1805d91    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 26 Nov 2018 17:32:51 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 26 Nov 2018 17:32:51 -0500    

Click here for diff

latex_escaped_print() mistranslated \ and failed to provide any translation  
for # ^ and ~, all of which would typically lead to LaTeX document syntax  
errors.  In addition it didn't translate < > and |, which would typically  
render as unexpected characters.  
  
To some extent this represents shortcomings in ancient versions of LaTeX,  
which if memory serves had no easy way to render these control characters  
as ASCII text.  But that's been fixed for, um, decades.  In any case there  
is no value in emitting guaranteed-to-fail output for these characters.  
  
Noted while fooling with test cases added by commit 9a98984f4.  Back-patch  
the code change to all supported versions.  

M src/fe_utils/print.c

Fix sample output for hash_metapage_info query

commit   : fed0dd21d2473e9580fd70b05431abf861117edb    
  
author   : Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Mon, 26 Nov 2018 16:58:02 -0300    
  
committer: Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Mon, 26 Nov 2018 16:58:02 -0300    

Click here for diff

One output column was duplicated.  Couldn't resist fixing the version  
number while at it.  
  
Reported-by: Gianni Ciolli  

M doc/src/sgml/pageinspect.sgml

Revert “Fix typo in documentation of toast storage”

commit   : e6e8bd4cf77070c1672b27b6fa518ae5b2cea706    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Mon, 26 Nov 2018 16:43:19 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Mon, 26 Nov 2018 16:43:19 +0900    

Click here for diff

This reverts commit 058ef3a, per complains from Magnus Hagander and Vik  
Fearing.  

M doc/src/sgml/storage.sgml

Fix typo in documentation of toast storage

commit   : abcc9ceca611405838975014e2fd3db83ca3acfc    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Mon, 26 Nov 2018 15:49:23 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Mon, 26 Nov 2018 15:49:23 +0900    

Click here for diff

Author: Nawaz Ahmed  
Discussion: https://postgr.es/m/154319327168.1315.1846953598601966513@wrigleys.postgresql.org  

M doc/src/sgml/storage.sgml

Fix hstore hash function for empty hstores upgraded from 8.4.

commit   : bcbb682786a3a263d2201c105d52ff51fc23d98e    
  
author   : Andrew Gierth <rhodiumtoad@postgresql.org>    
date     : Sat, 24 Nov 2018 09:59:49 +0000    
  
committer: Andrew Gierth <rhodiumtoad@postgresql.org>    
date     : Sat, 24 Nov 2018 09:59:49 +0000    

Click here for diff

Hstore data generated on pg 8.4 and pg_upgraded to current versions  
remains in its original on-disk format unless modified. The same goes  
for values generated by the addon hstore-new module on pre-9.0  
versions. (The hstoreUpgrade function converts old values on the fly  
when read in, but the on-disk value is not modified by this.)  
  
Since old-format empty hstores (and hstore-new hstores) have  
representations compatible with the new format, hstoreUpgrade thought  
it could get away without modifying such values; but this breaks  
hstore_hash (and the new hstore_hash_extended) which assumes  
bit-perfect matching between semantically identical hstore values.  
Only one bit actually differs (the "new version" flag in the count  
field) but that of course is enough to break the hash.  
  
Fix by making hstoreUpgrade unconditionally convert all old values to  
new format.  
  
Backpatch all the way, even though this changes a hash value in some  
cases, because in those cases the hash value is already failing - for  
example, a hash join between old- and new-format empty hstores will be  
failing to match, or a hash index on an hstore column containing an  
old-format empty value will be failing to find the value since it will  
be searching for a hash derived from a new-format datum. (There are no  
known field reports of this happening, probably because hashing of  
hstores has only been useful in limited circumstances and there  
probably isn't much upgraded data being used this way.)  
  
Per concerns arising from discussion of commit eb6f29141be. Original  
bug is my fault.  
  
Discussion: https://postgr.es/m/60b1fd3b-7332-40f0-7e7f-f2f04f777747%402ndquadrant.com  

M contrib/hstore/hstore_compat.c

Update additional float4/8 expected-output files.

commit   : 74587148314a71343dc92917d7a8d02925ee93e5    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sat, 24 Nov 2018 13:53:12 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sat, 24 Nov 2018 13:53:12 -0500    

Click here for diff

I forgot that the back branches have more variant files than HEAD :-(.  
Per buildfarm.  
  
Discussion: https://postgr.es/m/15519-4fc785b483201ff1@postgresql.org  

M src/test/regress/expected/float4-exp-three-digits.out
M src/test/regress/expected/float8-exp-three-digits-win32.out
M src/test/regress/expected/float8-small-is-zero_1.out

Fix float-to-integer coercions to handle edge cases correctly.

commit   : c382a2b66909a78982636f3d192e43e8f48bf504    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sat, 24 Nov 2018 12:45:49 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sat, 24 Nov 2018 12:45:49 -0500    

Click here for diff

ftoi4 and its sibling coercion functions did their overflow checks in  
a way that looked superficially plausible, but actually depended on an  
assumption that the MIN and MAX comparison constants can be represented  
exactly in the float4 or float8 domain.  That fails in ftoi4, ftoi8,  
and dtoi8, resulting in a possibility that values near the MAX limit will  
be wrongly converted (to negative values) when they need to be rejected.  
  
Also, because we compared before rounding off the fractional part,  
the other three functions threw errors for values that really ought  
to get rounded to the min or max integer value.  
  
Fix by doing rint() first (requiring an assumption that it handles  
NaN and Inf correctly; but dtoi8 and ftoi8 were assuming that already),  
and by comparing to values that should coerce to float exactly, namely  
INTxx_MIN and -INTxx_MIN.  Also remove some random cosmetic discrepancies  
between these six functions.  
  
This back-patches commits cbdb8b4c0 and 452b637d4.  In the 9.4 branch,  
also back-patch the portion of 62e2a8dc2 that added PG_INTnn_MIN and  
related constants to c.h, so that these functions can rely on them.  
  
Per bug #15519 from Victor Petrovykh.  
  
Patch by me; thanks to Andrew Gierth for analysis and discussion.  
  
Discussion: https://postgr.es/m/15519-4fc785b483201ff1@postgresql.org  

M src/backend/utils/adt/float.c
M src/backend/utils/adt/int8.c
M src/test/regress/expected/float4.out
M src/test/regress/expected/float8-small-is-zero.out
M src/test/regress/expected/float8.out
M src/test/regress/sql/float4.sql
M src/test/regress/sql/float8.sql

Avoid crashes in contrib/intarray gist__int_ops (bug #15518)

commit   : e193fb9919234b07210b75bf9dfd436fd2b218b9    
  
author   : Andrew Gierth <rhodiumtoad@postgresql.org>    
date     : Fri, 23 Nov 2018 23:56:39 +0000    
  
committer: Andrew Gierth <rhodiumtoad@postgresql.org>    
date     : Fri, 23 Nov 2018 23:56:39 +0000    

Click here for diff

1. Integer overflow in internal_size could result in memory corruption  
in decompression since a zero-length array would be allocated and then  
written to. This leads to crashes or corruption when traversing an  
index which has been populated with sufficiently sparse values. Fix by  
using int64 for computations and checking for overflow.  
  
2. Integer overflow in g_int_compress could cause pessimal merge  
choices, resulting in unnecessarily large ranges (which would in turn  
trigger issue 1 above). Fix by using int64 again.  
  
3. Even without overflow, array sizes could become large enough to  
cause unexplained memory allocation errors. Fix by capping the sizes  
to a safe limit and report actual errors pointing at gist__intbig_ops  
as needed.  
  
4. Large inputs to the compression function always consist of large  
runs of consecutive integers, and the compression loop was processing  
these one at a time in an O(N^2) manner with a lot of overhead. The  
expected runtime of this function could easily exceed 6 months for a  
single call as a result. Fix by performing a linear-time first pass,  
which reduces the worst case to something on the order of seconds.  
  
Backpatch all the way, since this has been wrong forever.  
  
Per bug #15518 from report from irc user "dymk", analysis and patch by  
me.  
  
Discussion: https://postgr.es/m/15518-799e426c3b4f8358@postgresql.org  

M contrib/intarray/_int_gist.c
M contrib/intarray/_int_tool.c

doc: Fix typo

commit   : d0d7e9f473da06ed6979d12643aeb9f916f906b6    
  
author   : Peter Eisentraut <peter_e@gmx.net>    
date     : Fri, 23 Nov 2018 11:41:27 +0100    
  
committer: Peter Eisentraut <peter_e@gmx.net>    
date     : Fri, 23 Nov 2018 11:41:27 +0100    

Click here for diff

M doc/src/sgml/protocol.sgml

doc: adjust time zone names text, v2

commit   : e362b2e9d131f914cfce8ed6e6f4a8ab319cc495    
  
author   : Bruce Momjian <bruce@momjian.us>    
date     : Wed, 21 Nov 2018 17:20:15 -0500    
  
committer: Bruce Momjian <bruce@momjian.us>    
date     : Wed, 21 Nov 2018 17:20:15 -0500    

Click here for diff

Removed one too many words.  Fix for  
7906de847f229f391b9e6b5892b4b4a89f29edb4.  
  
Reported-by: Thomas Munro  
  
Backpatch-through: 9.4  

M doc/src/sgml/datatype.sgml

doc: adjust time zone names text

commit   : 2925d004140f1ee98b84b048fbfc633b9f15806b    
  
author   : Bruce Momjian <bruce@momjian.us>    
date     : Wed, 21 Nov 2018 16:55:40 -0500    
  
committer: Bruce Momjian <bruce@momjian.us>    
date     : Wed, 21 Nov 2018 16:55:40 -0500    

Click here for diff

Reported-by: Kevin <kcolagio@gmail.com>  
  
Discussion: https://postgr.es/m/154082462281.30897.14043119084654378035@wrigleys.postgresql.org  
  
Backpatch-through: 9.4  

M doc/src/sgml/datatype.sgml

doc: Clarify CREATE TYPE ENUM documentation

commit   : 7e89e61d1b2fbb3851e4da64b3dbd971a3cf0fa6    
  
author   : Peter Eisentraut <peter_e@gmx.net>    
date     : Tue, 13 Nov 2018 10:42:43 +0100    
  
committer: Peter Eisentraut <peter_e@gmx.net>    
date     : Tue, 13 Nov 2018 10:42:43 +0100    

Click here for diff

The documentation claimed that an enum type requires "one or more"  
labels, but since 1fd9883ff49, zero labels are also allowed.  
  
Reported-by: Lukas Eder <lukas.eder@gmail.com>  
Bug: #15356  

M doc/src/sgml/ref/create_type.sgml

Add needed #include.

commit   : 0064d0e9f44fadb9b8cbf9908356f7e22bb17d34    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 19 Nov 2018 17:28:05 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 19 Nov 2018 17:28:05 -0500    

Click here for diff

Per POSIX, WIFSIGNALED and related macros are provided by <sys/wait.h>.  
Apparently on Linux they're also pulled in by some other inclusions,  
but BSD-ish systems are pickier.  Fixes portability issue in ffa4cbd62.  
  
Per buildfarm.  

M src/backend/commands/copy.c

Handle EPIPE more sanely when we close a pipe reading from a program.

commit   : 8285fae0706f7ab148257e9b5bcfa1f636fa3685    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 19 Nov 2018 17:02:25 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 19 Nov 2018 17:02:25 -0500    

Click here for diff

Previously, any program launched by COPY TO/FROM PROGRAM inherited the  
server's setting of SIGPIPE handling, i.e. SIG_IGN.  Hence, if we were  
doing COPY FROM PROGRAM and closed the pipe early, the child process  
would see EPIPE on its output file and typically would treat that as  
a fatal error, in turn causing the COPY to report error.  Similarly,  
one could get a failure report from a query that didn't read all of  
the output from a contrib/file_fdw foreign table that uses file_fdw's  
PROGRAM option.  
  
To fix, ensure that child programs inherit SIG_DFL not SIG_IGN processing  
of SIGPIPE.  This seems like an all-around better situation since if  
the called program wants some non-default treatment of SIGPIPE, it would  
expect to have to set that up for itself.  Then in COPY, if it's COPY  
FROM PROGRAM and we stop reading short of detecting EOF, treat a SIGPIPE  
exit from the called program as a non-error condition.  This still allows  
us to report an error for any case where the called program gets SIGPIPE  
on some other file descriptor.  
  
As coded, we won't report a SIGPIPE if we stop reading as a result of  
seeing an in-band EOF marker (e.g. COPY BINARY EOF marker).  It's  
somewhat debatable whether we should complain if the called program  
continues to transmit data after an EOF marker.  However, it seems like  
we should avoid throwing error in any questionable cases, especially in a  
back-patched fix, and anyway it would take additional code to make such  
an error get reported consistently.  
  
Back-patch to v10.  We could go further back, since COPY FROM PROGRAM  
has been around awhile, but AFAICS the only way to reach this situation  
using core or contrib is via file_fdw, which has only supported PROGRAM  
sources since v10.  The COPY statement per se has no feature whereby  
it'd stop reading without having hit EOF or an error already.  Therefore,  
I don't see any upside to back-patching further that'd outweigh the  
risk of complaints about behavioral change.  
  
Per bug #15449 from Eric Cyr.  
  
Patch by me, review by Etsuro Fujita and Kyotaro Horiguchi  
  
Discussion: https://postgr.es/m/15449-1cf737dd5929450e@postgresql.org  

M src/backend/commands/copy.c
M src/backend/storage/file/fd.c

Fix configure’s AC_CHECK_DECLS tests to work correctly with clang.

commit   : 97b398ee5cb76963d1d409515232c294110f24b5    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 19 Nov 2018 12:01:47 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 19 Nov 2018 12:01:47 -0500    

Click here for diff

The test case that Autoconf uses to discover whether a function has  
been declared doesn't work reliably with clang, because clang reports  
a warning not an error if the name is a known built-in function.  
On some platforms, this results in a lot of compile-time warnings about  
strlcpy and related functions not having been declared.  
  
There is a fix for this (by Noah Misch) in the upstream Autoconf sources,  
but since they've not made a release in years and show no indication of  
doing so anytime soon, let's just absorb their fix directly.  We can  
revert this when and if we update to a newer Autoconf release.  
  
Back-patch to all supported branches.  
  
Discussion: https://postgr.es/m/26819.1542515567@sss.pgh.pa.us  

M aclocal.m4
A config/check_decls.m4
M configure
M configure.in

Disallow COPY FREEZE on partitioned tables

commit   : 85efd1a04175951a97b087908121403e4cf4ef7a    
  
author   : Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Mon, 19 Nov 2018 11:16:28 -0300    
  
committer: Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Mon, 19 Nov 2018 11:16:28 -0300    

Click here for diff

This didn't actually work: COPY would fail to flush the right files, and  
instead would try to flush a non-existing file, causing the whole  
transaction to fail.  
  
Cope by raising an error as soon as the command is sent instead, to  
avoid a nasty later surprise.  Of course, it would be much better to  
make it work, but we don't have a patch for that yet, and we don't know  
if we'll want to backpatch one when we do.  
  
Reported-by: Tomas Vondra  
Author: David Rowley  
Reviewed-by: Amit Langote, Steve Singer, Tomas Vondra  

M doc/src/sgml/perform.sgml
M doc/src/sgml/ref/copy.sgml
M src/backend/commands/copy.c
M src/test/regress/input/copy.source
M src/test/regress/output/copy.source

PANIC on fsync() failure.

commit   : afbe03f6547015790d13d21d5eb5083cc604eeec    
  
author   : Thomas Munro <tmunro@postgresql.org>    
date     : Mon, 19 Nov 2018 13:40:57 +1300    
  
committer: Thomas Munro <tmunro@postgresql.org>    
date     : Mon, 19 Nov 2018 13:40:57 +1300    

Click here for diff

On some operating systems, it doesn't make sense to retry fsync(),  
because dirty data cached by the kernel may have been dropped on  
write-back failure.  In that case the only remaining copy of the  
data is in the WAL.  A subsequent fsync() could appear to succeed,  
but not have flushed the data.  That means that a future checkpoint  
could apparently complete successfully but have lost data.  
  
Therefore, violently prevent any future checkpoint attempts by  
panicking on the first fsync() failure.  Note that we already  
did the same for WAL data; this change extends that behavior to  
non-temporary data files.  
  
Provide a GUC data_sync_retry to control this new behavior, for  
users of operating systems that don't eject dirty data, and possibly  
forensic/testing uses.  If it is set to on and the write-back error  
was transient, a later checkpoint might genuinely succeed (on a  
system that does not throw away buffers on failure); if the error is  
permanent, later checkpoints will continue to fail.  The GUC defaults  
to off, meaning that we panic.  
  
Back-patch to all supported releases.  
  
There is still a narrow window for error-loss on some operating  
systems: if the file is closed and later reopened and a write-back  
error occurs in the intervening time, but the inode has the bad  
luck to be evicted due to memory pressure before we reopen, we could  
miss the error.  A later patch will address that with a scheme  
for keeping files with dirty data open at all times, but we judge  
that to be too complicated to back-patch.  
  
Author: Craig Ringer, with some adjustments by Thomas Munro  
Reported-by: Craig Ringer  
Reviewed-by: Robert Haas, Thomas Munro, Andres Freund  
Discussion: https://postgr.es/m/20180427222842.in2e4mibx45zdth5%40alap3.anarazel.de  

M doc/src/sgml/config.sgml
M src/backend/access/heap/rewriteheap.c
M src/backend/access/transam/slru.c
M src/backend/access/transam/timeline.c
M src/backend/access/transam/xlog.c
M src/backend/replication/logical/snapbuild.c
M src/backend/storage/file/fd.c
M src/backend/storage/smgr/md.c
M src/backend/utils/cache/relmapper.c
M src/backend/utils/misc/guc.c
M src/backend/utils/misc/postgresql.conf.sample
M src/include/storage/fd.h

Don’t forget about failed fsync() requests.

commit   : 28117764db7ed0c9fc589dd9323c439235040b05    
  
author   : Thomas Munro <tmunro@postgresql.org>    
date     : Mon, 19 Nov 2018 13:40:50 +1300    
  
committer: Thomas Munro <tmunro@postgresql.org>    
date     : Mon, 19 Nov 2018 13:40:50 +1300    

Click here for diff

If fsync() fails, md.c must keep the request in its bitmap, so that  
future attempts will try again.  
  
Back-patch to all supported releases.  
  
Author: Thomas Munro  
Reviewed-by: Amit Kapila  
Reported-by: Andrew Gierth  
Discussion: https://postgr.es/m/87y3i1ia4w.fsf%40news-spur.riddles.org.uk  

M src/backend/storage/smgr/md.c

Add valgrind suppressions for wcsrtombs optimizations

commit   : 5b16a353543ecec36ffda68269defb7b1b002f60    
  
author   : Tomas Vondra <tomas.vondra@postgresql.org>    
date     : Sat, 17 Nov 2018 23:50:21 +0100    
  
committer: Tomas Vondra <tomas.vondra@postgresql.org>    
date     : Sat, 17 Nov 2018 23:50:21 +0100    

Click here for diff

wcsrtombs (called through wchar2char from common functions like lower,  
upper, etc.) uses various optimizations that may look like access to  
uninitialized data, triggering valgrind reports.  
  
For example AVX2 instructions load data in 256-bit chunks, and  gconv  
does something similar with 32-bit chunks.  This is faster than accessing  
the bytes one by one, and the uninitialized part of the buffer is not  
actually used. So suppress the bogus reports.  
  
The exact stack depends on possible optimizations - it might be AVX, SSE  
(as in the report by Aleksander Alekseev) or something else. Hence the  
last frame is wildcarded, to deal with this.  
  
Backpatch all the way back to 9.4.  
  
Author: Tomas Vondra  
Discussion: https://www.postgresql.org/message-id/flat/90ac0452-e907-e7a4-b3c8-15bd33780e62%402ndquadrant.com  
Discussion: https://www.postgresql.org/message-id/20180220150838.GD18315@e733.localdomain  

M src/tools/valgrind.supp

Doc: remove claim that all \pset format options are unique in 1 letter.

commit   : 5f2937734cd10a51f6e082f810846757538f690c    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 14 Nov 2018 16:29:57 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 14 Nov 2018 16:29:57 -0500    

Click here for diff

This hasn't been correct since 9.3 added "latex-longtable".  
  
I left the phraseology "Unique abbreviations are allowed" alone.  
It's correct as far as it goes, and we are studiously refraining  
from specifying exactly what happens if you give a non-unique  
abbreviation.  (The answer in the back branches is "you get a  
backwards-compatible choice", and the answer in HEAD will shortly  
be "you get an error", but there seems no need to mention such  
details here.)  
  
Daniel Vérité  
  
Discussion: https://postgr.es/m/cb7e1caf-3ea6-450d-af28-f524903a030c@manitou-mail.org  

M doc/src/sgml/ref/psql-ref.sgml

Second try at fixing numeric data passed through an ECPG SQLDA.

commit   : 2e8ed46599720113ce024f098e12652a1dfffe8e    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 14 Nov 2018 11:27:30 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 14 Nov 2018 11:27:30 -0500    

Click here for diff

In commit ecfd55795, I removed sqlda.c's checks for ndigits != 0 on the  
grounds that we should duplicate the state of the numeric value's digit  
buffer even when all the digits are zeroes.  However, that still isn't  
quite right, because another possible state of the digit buffer is  
buf == digits == NULL (this occurs for a NaN).  As the code now stands,  
it'll invoke memcpy with a NULL source address and zero bytecount,  
which we know a few platforms crash on.  Hence, reinstate the no-copy  
short-circuit, but make it test specifically for buf != NULL rather than  
some other condition.  In hindsight, the ndigits test (added by commit  
f2ae9f9c3) was almost certainly meant to fix the NaN case not the  
all-zeroes case as the associated thread alleged.  
  
As before, back-patch to all supported versions.  
  
Discussion: https://postgr.es/m/1803D792815FC24D871C00D17AE95905C71161@g01jpexmbkw24  

M src/interfaces/ecpg/ecpglib/sqlda.c
M src/interfaces/ecpg/test/expected/sql-sqlda.c
M src/interfaces/ecpg/test/expected/sql-sqlda.stderr
M src/interfaces/ecpg/test/expected/sql-sqlda.stdout
M src/interfaces/ecpg/test/sql/sqlda.pgc

Initialize TransactionState and user ID consistently at transaction start

commit   : 7f8356bd10b5b2a7dd092e158f5ffbf65e6a2c14    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Wed, 14 Nov 2018 16:48:10 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Wed, 14 Nov 2018 16:48:10 +0900    

Click here for diff

If a failure happens when a transaction is starting between the moment  
the transaction status is changed from TRANS_DEFAULT to TRANS_START and  
the moment the current user ID and security context flags are fetched  
via GetUserIdAndSecContext(), or before initializing its basic fields,  
then those may get reset to incorrect values when the transaction  
aborts, leaving the session in an inconsistent state.  
  
One problem reported is that failing a starting transaction at the first  
query of a session could cause several kinds of system crashes on the  
follow-up queries.  
  
In order to solve that, move the initialization of the transaction state  
fields and the call of GetUserIdAndSecContext() in charge of fetching  
the current user ID close to the point where the transaction status is  
switched to TRANS_START, where there cannot be any error triggered  
in-between, per an idea of Tom Lane.  This properly ensures that the  
current user ID, the security context flags and that the basic fields of  
TransactionState remain consistent even if the transaction fails while  
starting.  
  
Reported-by: Richard Guo  
Diagnosed-By: Richard Guo  
Author: Michael Paquier  
Reviewed-by: Tom Lane  
Discussion: https://postgr.es/m/CAN_9JTxECSb=pEPcb0a8d+6J+bDcOZ4=DgRo_B7Y5gRHJUM=Rw@mail.gmail.com  
Backpatch-through: 9.4  

M src/backend/access/transam/xact.c

Fix incorrect results for numeric data passed through an ECPG SQLDA.

commit   : 32060f6780bc09595a12cea8c992493af3785a2a    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Tue, 13 Nov 2018 15:46:08 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Tue, 13 Nov 2018 15:46:08 -0500    

Click here for diff

Numeric values with leading zeroes were incorrectly copied into a  
SQLDA (SQL Descriptor Area), leading to wrong results in ECPG programs.  
  
Report and patch by Daisuke Higuchi.  Back-patch to all supported  
versions.  
  
Discussion: https://postgr.es/m/1803D792815FC24D871C00D17AE95905C71161@g01jpexmbkw24  

M src/interfaces/ecpg/ecpglib/sqlda.c
M src/interfaces/ecpg/test/expected/sql-sqlda.c
M src/interfaces/ecpg/test/expected/sql-sqlda.stderr
M src/interfaces/ecpg/test/expected/sql-sqlda.stdout
M src/interfaces/ecpg/test/sql/sqlda.pgc

Fix the initialization of atomic variable introduced by the group clearing mechanism.

commit   : d1a2fa3d9901c1e8f6bba1cecbb4ecdd64f4849e    
  
author   : Amit Kapila <akapila@postgresql.org>    
date     : Tue, 13 Nov 2018 10:36:59 +0530    
  
committer: Amit Kapila <akapila@postgresql.org>    
date     : Tue, 13 Nov 2018 10:36:59 +0530    

Click here for diff

Commit 0e141c0fbb introduced initialization of atomic variable in  
InitProcess which means that it's not safe to look at it for backends that  
aren't currently in use.  Fix that by initializing the same during postmaster  
startup.  
  
Reported-by: Andres Freund  
Author: Amit Kapila  
Backpatch-through: 9.6  
Discussion:https://postgr.es/m/20181027104138.qmbbelopvy7cw2qv@alap3.anarazel.de  

M src/backend/storage/lmgr/proc.c

Fix possible buffer overrun in hba.c.

commit   : 5574a0181962195f355863940f1c010f8e9875f6    
  
author   : Thomas Munro <tmunro@postgresql.org>    
date     : Tue, 13 Nov 2018 16:27:13 +1300    
  
committer: Thomas Munro <tmunro@postgresql.org>    
date     : Tue, 13 Nov 2018 16:27:13 +1300    

Click here for diff

Coverty reports a possible buffer overrun in the code that populates the  
pg_hba_file_rules view.  It may not be a live bug due to restrictions  
on options that can be used together, but let's increase MAX_HBA_OPTIONS  
and correct a nearby misleading comment.  
  
Back-patch to 10 where this code arrived.  
  
Reported-by: Julian Hsiao  
Discussion: https://postgr.es/m/CADnGQpzbkWdKS2YHNifwAvX5VEsJ5gW49U4o-7UL5pzyTv4vTg%40mail.gmail.com  

M src/backend/libpq/hba.c

Limit the number of index clauses considered in choose_bitmap_and().

commit   : c6b3835c7b5ce893d7883d3be9103f1199d3706e    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 12 Nov 2018 11:19:04 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 12 Nov 2018 11:19:04 -0500    

Click here for diff

classify_index_clause_usage() is O(N^2) in the number of distinct index  
qual clauses it considers, because of its use of a simple search list to  
store them.  For nearly all queries, that's fine because only a few clauses  
will be considered.  But Alexander Kuzmenkov reported a machine-generated  
query with 80000 (!) index qual clauses, which caused this code to take  
forever.  Somewhat remarkably, this is the only O(N^2) behavior we now  
have for such a query, so let's fix it.  
  
We can get rid of the O(N^2) runtime for cases like this without much  
damage to the functionality of choose_bitmap_and() by separating out  
paths with "too many" qual or pred clauses, and deeming them to always  
be nonredundant with other paths.  Then their clauses needn't go into  
the search list, so it doesn't get too long, but we don't lose the  
ability to consider bitmap AND plans altogether.  I set the threshold  
for "too many" to be 100 clauses per path, which should be plenty to  
ensure no change in planning behavior for normal queries.  
  
There are other things we could do to make this go faster, but it's not  
clear that it's worth any additional effort.  80000 qual clauses require  
a whole lot of work in many other places, too.  
  
The code's been like this for a long time, so back-patch to all supported  
branches.  The troublesome query only works back to 9.5 (in 9.4 it fails  
with stack overflow in the parser); so I'm not sure that fixing this in  
9.4 has any real-world benefit, but perhaps it does.  
  
Discussion: https://postgr.es/m/90c5bdfa-d633-dabe-9889-3cf3e1acd443@postgrespro.ru  

M src/backend/optimizer/path/indxpath.c

Fix incorrect author name in release notes

commit   : 346686f81593fb7a0ab2494722b9e6ca053c5937    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Mon, 12 Nov 2018 23:00:55 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Mon, 12 Nov 2018 23:00:55 +0900    

Click here for diff

Author: Alexander Lakhin  
Discussion: https://postgr.es/m/2f55f6d2-3fb0-d4f6-5c47-18da3a1117e0@gmail.com  

M doc/src/sgml/release-10.sgml
M doc/src/sgml/release-9.5.sgml
M doc/src/sgml/release-9.6.sgml

Fix missing role dependencies for some schema and type ACLs.

commit   : 2d83863ea2739dc559ed490c284f5c1817db4752    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 9 Nov 2018 20:42:03 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 9 Nov 2018 20:42:03 -0500    

Click here for diff

This patch fixes several related cases in which pg_shdepend entries were  
never made, or were lost, for references to roles appearing in the ACLs of  
schemas and/or types.  While that did no immediate harm, if a referenced  
role were later dropped, the drop would be allowed and would leave a  
dangling reference in the object's ACL.  That still wasn't a big problem  
for normal database usage, but it would cause obscure failures in  
subsequent dump/reload or pg_upgrade attempts, taking the form of  
attempts to grant privileges to all-numeric role names.  (I think I've  
seen field reports matching that symptom, but can't find any right now.)  
  
Several cases are fixed here:  
  
1. ALTER DOMAIN SET/DROP DEFAULT would lose the dependencies for any  
existing ACL entries for the domain.  This case is ancient, dating  
back as far as we've had pg_shdepend tracking at all.  
  
2. If a default type privilege applies, CREATE TYPE recorded the  
ACL properly but forgot to install dependency entries for it.  
This dates to the addition of default privileges for types in 9.2.  
  
3. If a default schema privilege applies, CREATE SCHEMA recorded the  
ACL properly but forgot to install dependency entries for it.  
This dates to the addition of default privileges for schemas in v10  
(commit ab89e465c).  
  
Another somewhat-related problem is that when creating a relation  
rowtype or implicit array type, TypeCreate would apply any available  
default type privileges to that type, which we don't really want  
since such an object isn't supposed to have privileges of its own.  
(You can't, for example, drop such privileges once they've been added  
to an array type.)  
  
ab89e465c is also to blame for a race condition in the regression tests:  
privileges.sql transiently installed globally-applicable default  
privileges on schemas, which sometimes got absorbed into the ACLs of  
schemas created by concurrent test scripts.  This should have resulted  
in failures when privileges.sql tried to drop the role holding such  
privileges; but thanks to the bug fixed here, it instead led to dangling  
ACLs in the final state of the regression database.  We'd managed not to  
notice that, but it became obvious in the wake of commit da906766c, which  
allowed the race condition to occur in pg_upgrade tests.  
  
To fix, add a function recordDependencyOnNewAcl to encapsulate what  
callers of get_user_default_acl need to do; while the original call  
sites got that right via ad-hoc code, none of the later-added ones  
have.  Also change GenerateTypeDependencies to generate these  
dependencies, which requires adding the typacl to its parameter list.  
(That might be annoying if there are any extensions calling that  
function directly; but if there are, they're most likely buggy in the  
same way as the core callers were, so they need work anyway.)  While  
I was at it, I changed GenerateTypeDependencies to accept most of its  
parameters in the form of a Form_pg_type pointer, making its parameter  
list a bit less unwieldy and mistake-prone.  
  
The test race condition is fixed just by wrapping the addition and  
removal of default privileges into a single transaction, so that that  
state is never visible externally.  We might eventually prefer to  
separate out tests of default privileges into a script that runs by  
itself, but that would be a bigger change and would make the tests  
run slower overall.  
  
Back-patch relevant parts to all supported branches.  
  
Discussion: https://postgr.es/m/15719.1541725287@sss.pgh.pa.us  

M src/backend/catalog/aclchk.c
M src/backend/catalog/heap.c
M src/backend/catalog/pg_namespace.c
M src/backend/catalog/pg_proc.c
M src/backend/catalog/pg_type.c
M src/backend/commands/typecmds.c
M src/include/catalog/pg_type_fn.h
M src/include/utils/acl.h
M src/test/regress/expected/privileges.out
M src/test/regress/sql/privileges.sql

Fix dependency handling of partitions and inheritance for ON COMMIT

commit   : 52ea6a8209d6cb778640c87644db86a176a61254    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Fri, 9 Nov 2018 10:03:39 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Fri, 9 Nov 2018 10:03:39 +0900    

Click here for diff

This commit fixes a set of issues with ON COMMIT actions when used on  
partitioned tables and tables with inheritance children:  
- Applying ON COMMIT DROP on a partitioned table with partitions or on a  
table with inheritance children caused a failure at commit time, with  
complains about the children being already dropped as all relations are  
dropped one at the same time.  
- Applying ON COMMIT DELETE on a partition relying on a partitioned  
table which uses ON COMMIT DROP would cause the partition truncation to  
fail as the parent is removed first.  
  
The solution to the first problem is to handle the removal of all the  
dependencies in one go instead of dropping relations one-by-one, based  
on a suggestion from Álvaro Herrera.  So instead all the relation OIDs  
to remove are gathered and then processed in one round of multiple  
deletions.  
  
The solution to the second problem is to reorder the actions, with  
truncation happening first and relation drop done after.  Even if it  
means that a partition could be first truncated, then immediately  
dropped if its partitioned table is dropped, this has the merit to keep  
the code simple as there is no need to do existence checks on the  
relations to drop.  
  
Contrary to a manual TRUNCATE on a partitioned table, ON COMMIT DELETE  
does not cascade to its partitions.  The ON COMMIT action defined on  
each partition gets the priority.  
  
Author: Michael Paquier  
Reviewed-by: Amit Langote, Álvaro Herrera, Robert Haas  
Discussion: https://postgr.es/m/68f17907-ec98-1192-f99f-8011400517f5@lab.ntt.co.jp  
Backpatch-through: 10  

M doc/src/sgml/ref/create_table.sgml
M src/backend/commands/tablecmds.c
M src/test/regress/expected/temp.out
M src/test/regress/sql/temp.sql

Disallow setting client_min_messages higher than ERROR.

commit   : c09daa9104099422ea998e0398934ca82eb37898    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 8 Nov 2018 17:33:26 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 8 Nov 2018 17:33:26 -0500    

Click here for diff

Previously it was possible to set client_min_messages to FATAL or PANIC,  
which had the effect of suppressing transmission of regular ERROR messages  
to the client.  Perhaps that seemed like a useful option in the past, but  
the trouble with it is that it breaks guarantees that are explicitly made  
in our FE/BE protocol spec about how a query cycle can end.  While libpq  
and psql manage to cope with the omission, that's mostly because they  
are not very bright; client libraries that have more semantic knowledge  
are likely to get confused.  Notably, pgODBC doesn't behave very sanely.  
Let's fix this by getting rid of the ability to set client_min_messages  
above ERROR.  
  
In HEAD, just remove the FATAL and PANIC options from the set of allowed  
enum values for client_min_messages.  (This change also affects  
trace_recovery_messages, but that's OK since these aren't useful values  
for that variable either.)  
  
In the back branches, there was concern that rejecting these values might  
break applications that are explicitly setting things that way.  I'm  
pretty skeptical of that argument, but accommodate it by accepting these  
values and then internally setting the variable to ERROR anyway.  
  
In all branches, this allows a couple of tiny simplifications in the  
logic in elog.c, so do that.  
  
Also respond to the point that was made that client_min_messages has  
exactly nothing to do with the server's logging behavior, and therefore  
does not belong in the "When To Log" subsection of the documentation.  
The "Statement Behavior" subsection is a better match, so move it there.  
  
Jonah Harris and Tom Lane  
  
Discussion: https://postgr.es/m/7809.1541521180@sss.pgh.pa.us  
Discussion: https://postgr.es/m/15479-ef0f4cc2fd995ca2@postgresql.org  

M doc/src/sgml/config.sgml
M src/backend/utils/error/elog.c
M src/backend/utils/misc/guc.c
M src/backend/utils/misc/postgresql.conf.sample

Revise attribute handling code on partition creation

commit   : 21c9e4973cec9c3f0bb7a3f3c1649c4e4a0b9127    
  
author   : Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Thu, 8 Nov 2018 16:22:09 -0300    
  
committer: Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Thu, 8 Nov 2018 16:22:09 -0300    

Click here for diff

The original code to propagate NOT NULL and default expressions  
specified when creating a partition was mostly copy-pasted from  
typed-tables creation, but not being a great match it contained some  
duplicity, inefficiency and bugs.  
  
This commit fixes the bug that NOT NULL constraints declared in the  
parent table would not be honored in the partition.  One reported issue  
that is not fixed is that a DEFAULT declared in the child is not used  
when inserting through the parent.  That would amount to a behavioral  
change that's better not back-patched.  
  
This rewrite makes the code simpler:  
  
1. instead of checking for duplicate column names in its own block,  
reuse the original one that already did that;  
  
2. instead of concatenating the list of columns from parent and the one  
declared in the partition and scanning the result to (incorrectly)  
propagate defaults and not-null constraints, just scan the latter  
searching the former for a match, and merging sensibly.  This works  
because we know the list in the parent is already correct and there can  
only be one parent.  
  
This rewrite makes ColumnDef->is_from_parent unused, so it's removed  
on branch master; on released branches, it's kept as an unused field in  
order not to cause ABI incompatibilities.  
  
This commit also adds a test case for creating partitions with  
collations mismatching that on the parent table, something that is  
closely related to the code being patched.  No code change is introduced  
though, since that'd be a behavior change that could break some (broken)  
working applications.  
  
Amit Langote wrote a less invasive fix for the original  
NOT NULL/defaults bug, but while I kept the tests he added, I ended up  
not using his original code.  Ashutosh Bapat reviewed Amit's fix.  Amit  
reviewed mine.  
  
Author: Álvaro Herrera, Amit Langote  
Reviewed-by: Ashutosh Bapat, Amit Langote  
Reported-by: Jürgen Strobel (bug #15212)  
Discussion: https://postgr.es/m/152746742177.1291.9847032632907407358@wrigleys.postgresql.org  

M src/backend/commands/sequence.c
M src/backend/commands/tablecmds.c
M src/backend/nodes/equalfuncs.c
M src/backend/nodes/makefuncs.c
M src/backend/parser/gram.y
M src/backend/parser/parse_utilcmd.c
M src/include/nodes/parsenodes.h
M src/test/regress/expected/create_table.out
M src/test/regress/sql/create_table.sql

GUC: adjust effective_cache_size SQL descriptions

commit   : 018e5fee9aac2a8f8f14c2dc54d574524f239cbf    
  
author   : Bruce Momjian <bruce@momjian.us>    
date     : Tue, 6 Nov 2018 13:40:02 -0500    
  
committer: Bruce Momjian <bruce@momjian.us>    
date     : Tue, 6 Nov 2018 13:40:02 -0500    

Click here for diff

Follow on patch for commit 3e0f1a4741f564c1a2fa6e944729d6967355d8c7.  
  
Reported-by: Peter Eisentraut  
  
Discussion: https://postgr.es/m/369ec766-b947-51bd-4dad-6fb9e026439f@2ndquadrant.com  
  
Backpatch-through: 9.4  

M src/backend/utils/misc/guc.c

Rename rbtree.c functions to use “rbt” prefix not “rb” prefix.

commit   : b2e754c14e2741a076691e8c6f0099afffaa842e    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Tue, 6 Nov 2018 13:25:24 -0500    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Tue, 6 Nov 2018 13:25:24 -0500    

Click here for diff

The "rb" prefix is used by Ruby, so that our existing code results  
in name collisions that break plruby.  We discussed ways to prevent  
that by adjusting dynamic linker options, but it seems that at best  
we'd move the pain to other cases.  Renaming to avoid the collision  
is the only portable fix anyway.  Fortunately, our rbtree code is  
not (yet?) widely used --- in core, there's only a single usage  
in GIN --- so it seems likely that we can get away with a rename.  
  
I chose to do this basically as s/rb/rbt/g, except for places where  
there already was a "t" after "rb".  The patch could have been made  
smaller by only touching linker-visible symbols, but it would have  
resulted in oddly inconsistent-looking code.  Better to make it look  
like "rbt" was the plan all along.  
  
Back-patch to v10.  The rbtree.c code exists back to 9.5, but  
rb_iterate() which is the actual immediate source of pain was added  
in v10, so it seems like changing the names before that would have  
more risk than benefit.  
  
Per report from Pavel Raiskup.  
  
Discussion: https://postgr.es/m/4738198.8KVIIDhgEB@nb.usersys.redhat.com  

M src/backend/access/gin/ginbulk.c
M src/backend/lib/rbtree.c
M src/include/access/gin_private.h
M src/include/lib/rbtree.h