Stamp 11.12.
commit : fae98e3293de89f2fe8fc6e7c196d351378ce80e
author : Tom Lane <[email protected]>
date : Mon, 10 May 2021 16:45:49 -0400
committer: Tom Lane <[email protected]>
date : Mon, 10 May 2021 16:45:49 -0400
M configure
M configure.in
M doc/bug.template
M src/include/pg_config.h.win32
M src/interfaces/libpq/libpq.rc.in
M src/port/win32ver.rc
Last-minute updates for release notes.
commit : 6c1cfccf226645f4c01b4fee8df2c4e3392f2a32
author : Tom Lane <[email protected]>
date : Mon, 10 May 2021 13:10:29 -0400
committer: Tom Lane <[email protected]>
date : Mon, 10 May 2021 13:10:29 -0400
Security: CVE-2021-32027, CVE-2021-32028, CVE-2021-32029
M doc/src/sgml/release-11.sgml
Fix mishandling of resjunk columns in ON CONFLICT ... UPDATE tlists.
commit : b7d1f32ff6588be99844c140ec1aacb6e44f4b84
author : Tom Lane <[email protected]>
date : Mon, 10 May 2021 11:02:29 -0400
committer: Tom Lane <[email protected]>
date : Mon, 10 May 2021 11:02:29 -0400
It's unusual to have any resjunk columns in an ON CONFLICT ... UPDATE
list, but it can happen when MULTIEXPR_SUBLINK SubPlans are present.
If it happens, the ON CONFLICT UPDATE code path would end up storing
tuples that include the values of the extra resjunk columns. That's
fairly harmless in the short run, but if new columns are added to
the table then the values would become accessible, possibly leading
to malfunctions if they don't match the datatypes of the new columns.
This had escaped notice through a confluence of missing sanity checks,
including
* There's no cross-check that a tuple presented to heap_insert or
heap_update matches the table rowtype. While it's difficult to
check that fully at reasonable cost, we can easily add assertions
that there aren't too many columns.
* The output-column-assignment cases in execExprInterp.c lacked
any sanity checks on the output column numbers, which seems like
an oversight considering there are plenty of assertion checks on
input column numbers. Add assertions there too.
* We failed to apply nodeModifyTable's ExecCheckPlanOutput() to
the ON CONFLICT UPDATE tlist. That wouldn't have caught this
specific error, since that function is chartered to ignore resjunk
columns; but it sure seems like a bad omission now that we've seen
this bug.
In HEAD, the right way to fix this is to make the processing of
ON CONFLICT UPDATE tlists work the same as regular UPDATE tlists
now do, that is don't add "SET x = x" entries, and use
ExecBuildUpdateProjection to evaluate the tlist and combine it with
old values of the not-set columns. This adds a little complication
to ExecBuildUpdateProjection, but allows removal of a comparable
amount of now-dead code from the planner.
In the back branches, the most expedient solution seems to be to
(a) use an output slot for the ON CONFLICT UPDATE projection that
actually matches the target table, and then (b) invent a variant of
ExecBuildProjectionInfo that can be told to not store values resulting
from resjunk columns, so it doesn't try to store into nonexistent
columns of the output slot. (We can't simply ignore the resjunk columns
altogether; they have to be evaluated for MULTIEXPR_SUBLINK to work.)
This works back to v10. In 9.6, projections work much differently and
we can't cheaply give them such an option. The 9.6 version of this
patch works by inserting a JunkFilter when it's necessary to get rid
of resjunk columns.
In addition, v11 and up have the reverse problem when trying to
perform ON CONFLICT UPDATE on a partitioned table. Through a
further oversight, adjust_partition_tlist() discarded resjunk columns
when re-ordering the ON CONFLICT UPDATE tlist to match a partition.
This accidentally prevented the storing-bogus-tuples problem, but
at the cost that MULTIEXPR_SUBLINK cases didn't work, typically
crashing if more than one row has to be updated. Fix by preserving
resjunk columns in that routine. (I failed to resist the temptation
to add more assertions there too, and to do some minor code
beautification.)
Per report from Andres Freund. Back-patch to all supported branches.
Security: CVE-2021-32028
M src/backend/access/heap/heapam.c
M src/backend/executor/execExpr.c
M src/backend/executor/execExprInterp.c
M src/backend/executor/execPartition.c
M src/backend/executor/nodeModifyTable.c
M src/include/executor/executor.h
M src/test/regress/expected/update.out
M src/test/regress/sql/update.sql
Prevent integer overflows in array subscripting calculations.
commit : 06bfbe85409177bff7bc5376fb5fdd7a324227c3
author : Tom Lane <[email protected]>
date : Mon, 10 May 2021 10:44:38 -0400
committer: Tom Lane <[email protected]>
date : Mon, 10 May 2021 10:44:38 -0400
While we were (mostly) careful about ensuring that the dimensions of
arrays aren't large enough to cause integer overflow, the lower bound
values were generally not checked. This allows situations where
lower_bound + dimension overflows an integer. It seems that that's
harmless so far as array reading is concerned, except that array
elements with subscripts notionally exceeding INT_MAX are inaccessible.
However, it confuses various array-assignment logic, resulting in a
potential for memory stomps.
Fix by adding checks that array lower bounds aren't large enough to
cause lower_bound + dimension to overflow. (Note: this results in
disallowing cases where the last subscript position would be exactly
INT_MAX. In principle we could probably allow that, but there's a lot
of code that computes lower_bound + dimension and would need adjustment.
It seems doubtful that it's worth the trouble/risk to allow it.)
Somewhat independently of that, array_set_element() was careless
about possible overflow when checking the subscript of a fixed-length
array, creating a different route to memory stomps. Fix that too.
Security: CVE-2021-32027
M src/backend/executor/execExprInterp.c
M src/backend/utils/adt/array_userfuncs.c
M src/backend/utils/adt/arrayfuncs.c
M src/backend/utils/adt/arrayutils.c
M src/include/utils/array.h
Translation updates
commit : 2cdade0b853e1c0d238945385087dd9cda08a738
author : Peter Eisentraut <[email protected]>
date : Mon, 10 May 2021 14:28:42 +0200
committer: Peter Eisentraut <[email protected]>
date : Mon, 10 May 2021 14:28:42 +0200
Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git
Source-Git-Hash: 1fa14da66b52a841a7a795e300877515401bddee
M src/backend/po/de.po
M src/backend/po/fr.po
M src/bin/pg_dump/po/de.po
M src/bin/pg_upgrade/po/de.po
M src/bin/pg_upgrade/po/fr.po
M src/interfaces/libpq/po/de.po
M src/interfaces/libpq/po/fr.po
Release notes for 13.3, 12.7, 11.12, 10.17, 9.6.22.
commit : 18a1e4a6da06e4c61eabf7016b61bf742dbd7447
author : Tom Lane <[email protected]>
date : Sun, 9 May 2021 13:31:40 -0400
committer: Tom Lane <[email protected]>
date : Sun, 9 May 2021 13:31:40 -0400
M doc/src/sgml/release-11.sgml
AlterSubscription_refresh: avoid stomping on global variable
commit : b40865ebd41a84441a38e30028b890f0361ac888
author : Alvaro Herrera <[email protected]>
date : Fri, 7 May 2021 11:46:37 -0400
committer: Alvaro Herrera <[email protected]>
date : Fri, 7 May 2021 11:46:37 -0400
This patch replaces use of the global "wrconn" variable in
AlterSubscription_refresh with a local variable of the same name, making
it consistent with other functions in subscriptioncmds.c (e.g.
DropSubscription).
The global wrconn is only meant to be used for logical apply/tablesync worker.
Abusing it this way is known to cause trouble if an apply worker
manages to do a subscription refresh, such as reported by Jeremy Finzel
and diagnosed by Andres Freund back in November 2020, at
https://www.postgresql.org/message-id/[email protected]
Backpatch to 10. In branch master, also move the connection establishment
to occur outside the PG_TRY block; this way we can remove a test for NULL in
PG_FINALLY, and it also makes the code more consistent with similar code in
the same file.
Author: Peter Smith <[email protected]>
Reviewed-by: Bharath Rupireddy <[email protected]>
Reviewed-by: Japin Li <[email protected]>
Discussion: https://postgr.es/m/CAHut+Pu7Jv9L2BOEx_Z0UtJxfDevQSAUW2mJqWU+CtmDrEZVAg@mail.gmail.com
M src/backend/commands/subscriptioncmds.c
Document lock level used by ALTER TABLE VALIDATE CONSTRAINT
commit : 463ed8834e96f9987ebcd97550052f906ef02345
author : Alvaro Herrera <[email protected]>
date : Thu, 6 May 2021 17:17:56 -0400
committer: Alvaro Herrera <[email protected]>
date : Thu, 6 May 2021 17:17:56 -0400
Backpatch all the way back to 9.6.
Author: Simon Riggs <[email protected]>
Discussion: https://postgr.es/m/CANbhV-EwxvdhHuOLdfG2ciYrHOHXV=mm6=fD5aMhqcH09Li3Tg@mail.gmail.com
M doc/src/sgml/ref/alter_table.sgml
Have ALTER CONSTRAINT recurse on partitioned tables
commit : a25b98d2cf38e0f07898d08fb151b1915e2f4709
author : Alvaro Herrera <[email protected]>
date : Wed, 5 May 2021 12:14:21 -0400
committer: Alvaro Herrera <[email protected]>
date : Wed, 5 May 2021 12:14:21 -0400
When ALTER TABLE .. ALTER CONSTRAINT changes deferrability properties
changed in a partitioned table, we failed to propagate those changes
correctly to partitions and to triggers. Repair by adding a recursion
mechanism to affect all derived constraints and all derived triggers.
(In particular, recurse to partitions even if their respective parents
are already in the desired state: it is possible for the partitions to
have been altered individually.) Because foreign keys involve tables in
two sides, we cannot use the standard ALTER TABLE recursion mechanism,
so we invent our own by following pg_constraint.conparentid down.
When ALTER TABLE .. ALTER CONSTRAINT is invoked on the derived
pg_constraint object that's automaticaly created in a partition as a
result of a constraint added to its parent, raise an error instead of
pretending to work and then failing to modify all the affected triggers.
Before this commit such a command would be allowed but failed to affect
all triggers, so it would silently misbehave. (Restoring dumps of
existing databases is not affected, because pg_dump does not produce
anything for such a derived constraint anyway.)
Add some tests for the case.
Backpatch to 11, where foreign key support was added to partitioned
tables by commit 3de241dba86f. (A related change is commit f56f8f8da6af
in pg12 which added support for FKs *referencing* partitioned tables;
this is what forces us to use an ad-hoc recursion mechanism for this.)
Diagnosed by Tom Lane from bug report from Ron L Johnson. As of this
writing, no reviews were offered.
Discussion: https://postgr.es/m/[email protected]
Discussion: https://postgr.es/m/[email protected]
M src/backend/commands/tablecmds.c
M src/test/regress/expected/foreign_key.out
M src/test/regress/sql/foreign_key.sql
Doc: add an example of a self-referential foreign key to ddl.sgml.
commit : 4fd7c797672f87216ca7116238a52d72795be55e
author : Tom Lane <[email protected]>
date : Fri, 30 Apr 2021 15:37:57 -0400
committer: Tom Lane <[email protected]>
date : Fri, 30 Apr 2021 15:37:57 -0400
While we've always allowed such cases, the documentation didn't
say you could do it.
Discussion: https://postgr.es/m/[email protected]
M doc/src/sgml/ddl.sgml
Doc: update libpq's documentation for PQfn().
commit : d25997f898dd8c36fc7acad3f22366f18b548200
author : Tom Lane <[email protected]>
date : Fri, 30 Apr 2021 15:10:06 -0400
committer: Tom Lane <[email protected]>
date : Fri, 30 Apr 2021 15:10:06 -0400
Mention specifically that you can't call aggregates, window functions,
or procedures this way (the inability to call SRFs was already
mentioned).
Also, the claim that PQfn doesn't support NULL arguments or results
has been a lie since we invented protocol 3.0. Not sure why this
text was never updated for that, but do it now.
Discussion: https://postgr.es/m/[email protected]
M doc/src/sgml/libpq.sgml
Disallow calling anything but plain functions via the fastpath API.
commit : ebc2ff076ef24d58cd488dbd010ebeb052378625
author : Tom Lane <[email protected]>
date : Fri, 30 Apr 2021 14:10:26 -0400
committer: Tom Lane <[email protected]>
date : Fri, 30 Apr 2021 14:10:26 -0400
Reject aggregates, window functions, and procedures. Aggregates
failed anyway, though with a somewhat obscure error message.
Window functions would hit an Assert or null-pointer dereference.
Procedures seemed to work as long as you didn't try to do
transaction control, but (a) transaction control is sort of the
point of a procedure, and (b) it's not entirely clear that no
bugs lurk in that path. Given the lack of testing of this area,
it seems safest to be conservative in what we support.
Also reject proretset functions, as the fastpath protocol can't
support returning a set.
Also remove an easily-triggered assertion that the given OID
isn't 0; the subsequent lookups can handle that case themselves.
Per report from Theodor-Arsenij Larionov-Trichkin.
Back-patch to all supported branches. (The procedure angle
only applies in v11+, of course.)
Discussion: https://postgr.es/m/[email protected]
M src/backend/tcop/fastpath.c
Fix some more omissions in pg_upgrade's tests for non-upgradable types.
commit : 404946d40109fb247f51b553ac00198765c6c1cb
author : Tom Lane <[email protected]>
date : Thu, 29 Apr 2021 15:24:37 -0400
committer: Tom Lane <[email protected]>
date : Thu, 29 Apr 2021 15:24:37 -0400
Commits 29aeda6e4 et al closed up some oversights involving not checking
for non-upgradable types within container types, such as arrays and
ranges. However, I only looked at version.c, failing to notice that
there were substantially-equivalent tests in check.c. (The division
of responsibility between those files is less than clear...)
In addition, because genbki.pl does not guarantee that auto-generated
rowtype OIDs will hold still across versions, we need to consider that
the composite type associated with a system catalog or view is
non-upgradable. It seems unlikely that someone would have a user
column declared that way, but if they did, trying to read it in another
PG version would likely draw "no such pg_type OID" failures, thanks
to the type OID embedded in composite Datums.
To support the composite and reg*-type cases, extend the recursive
query that does the search to allow any base query that returns
a column of pg_type OIDs, rather than limiting it to exactly one
starting type.
As before, back-patch to all supported branches.
Discussion: https://postgr.es/m/[email protected]
M src/bin/pg_upgrade/check.c
M src/bin/pg_upgrade/pg_upgrade.h
M src/bin/pg_upgrade/version.c
Doc: fix discussion of how to get real Julian Dates.
commit : 7cd542023056b1bb2d6b14313f49fd91db1dcca7
author : Tom Lane <[email protected]>
date : Wed, 28 Apr 2021 10:03:28 -0400
committer: Tom Lane <[email protected]>
date : Wed, 28 Apr 2021 10:03:28 -0400
Somehow I'd convinced myself that rotating to UTC-12 was the way
to do this, but upon further review, it's definitely UTC+12.
Discussion: https://postgr.es/m/[email protected]
M doc/src/sgml/datetime.sgml
Fix use-after-release issue with pg_identify_object_as_address()
commit : 669f736666b394a2dadd4ab20ed0de4b81d5f146
author : Michael Paquier <[email protected]>
date : Wed, 28 Apr 2021 11:58:50 +0900
committer: Michael Paquier <[email protected]>
date : Wed, 28 Apr 2021 11:58:50 +0900
Spotted by buildfarm member prion, with -DRELCACHE_FORCE_RELEASE.
Introduced in f7aab36.
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 9.6
M src/backend/catalog/objectaddress.c
Fix pg_identify_object_as_address() with event triggers
commit : 5b717e13c90bf281b7cc65eefd032c8bf54c3448
author : Michael Paquier <[email protected]>
date : Wed, 28 Apr 2021 11:18:24 +0900
committer: Michael Paquier <[email protected]>
date : Wed, 28 Apr 2021 11:18:24 +0900
Attempting to use this function with event triggers failed, as, since
its introduction in a676201, this code has never associated an object
name with event triggers. This addresses the failure by adding the
event trigger name to the set defining its object address.
Note that regression tests are added within event_trigger and not
object_address to avoid issues with concurrent connections in parallel
schedules.
Author: Joel Jacobson
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 9.6
M src/backend/catalog/objectaddress.c
M src/test/regress/expected/event_trigger.out
M src/test/regress/sql/event_trigger.sql
Doc: document EXTRACT(JULIAN ...), improve Julian Date explanation.
commit : 4b610547c27a93289716e09721bbb4e33e8fdecf
author : Tom Lane <[email protected]>
date : Mon, 26 Apr 2021 11:50:35 -0400
committer: Tom Lane <[email protected]>
date : Mon, 26 Apr 2021 11:50:35 -0400
For some reason, the "julian" option for extract()/date_part() has
never gotten listed in the manual. Also, while Appendix B mentioned
in passing that we don't conform to the usual astronomical definition
that a Julian date starts at noon UTC, it was kind of vague about what
we do instead. Clarify that, and add an example showing how to get
the astronomical definition if you want it.
It's been like this for ages, so back-patch to all supported branches.
Discussion: https://postgr.es/m/[email protected]
M doc/src/sgml/datetime.sgml
M doc/src/sgml/func.sgml
doc: Fix obsolete description about pg_basebackup.
commit : 50b84aa26239986bbcdcad58de7c9ee01ed376c1
author : Fujii Masao <[email protected]>
date : Fri, 23 Apr 2021 15:45:46 +0900
committer: Fujii Masao <[email protected]>
date : Fri, 23 Apr 2021 15:45:46 +0900
Previously it was documented that if using "-X none" option there was
no guarantee that all required WAL files were archived at the end of
pg_basebackup when taking a backup from the standby. But this limitation
was removed by commit 52f8a59dd9. Now, even when taking a backup
from the standby, pg_basebackup can wait for all required WAL files
to be archived. Therefore this commit removes such obsolete
description from the docs.
Also this commit adds new description about the limitation when
taking a backup from the standby, into the docs. The limitation is that
pg_basebackup cannot force the standbfy to switch to a new WAL file
at the end of backup, which may cause pg_basebackup to wait a long
time for the last required WAL file to be switched and archived,
especially when write activity on the primary is low.
Back-patch to v10 where the issue was introduced.
Reported-by: Kyotaro Horiguchi
Author: Kyotaro Horiguchi, Fujii Masao
Reviewed-by: Kyotaro Horiguchi, Fujii Masao
Discussion: https://postgr.es/m/[email protected]
M doc/src/sgml/ref/pg_basebackup.sgml
Fix bugs in RETURNING in cross-partition UPDATE cases.
commit : 27835b5476642d6a4eeb06e32095d29daeb9c585
author : Tom Lane <[email protected]>
date : Thu, 22 Apr 2021 11:46:41 -0400
committer: Tom Lane <[email protected]>
date : Thu, 22 Apr 2021 11:46:41 -0400
If the source and destination partitions don't have identical
rowtypes (for example, one has dropped columns the other lacks),
then the planSlot contents will be different because of that.
If the query has a RETURNING list that tries to return resjunk
columns out of the planSlot, that is columns from tables that
were joined to the target table, we'd get errors or wrong answers.
That's because we used the RETURNING list generated for the
destination partition, which expects a planSlot matching that
partition's subplan.
The most practical fix seems to be to convert the updated destination
tuple back to the source partition's rowtype, and then apply the
RETURNING list generated for the source partition. This avoids making
fragile assumptions about whether the per-subpartition subplans
generated all the resjunk columns in the same order.
This has been broken since v11 introduced cross-partition UPDATE.
The lack of field complaints shows that non-identical partitions
aren't a common case; therefore, don't stress too hard about
making the conversion efficient.
There's no such bug in HEAD, because commit 86dc90056 got rid of
per-target-relation variance in the contents of the planSlot.
Hence, patch v11-v13 only.
Amit Langote and Etsuro Fujita, small changes by me
Discussion: https://postgr.es/m/CA+HiwqE_UK1jTSNrjb8mpTdivzd3dum6mK--xqKq0Y9VmfwWQA@mail.gmail.com
M src/backend/executor/nodeModifyTable.c
M src/test/regress/expected/update.out
M src/test/regress/sql/update.sql
fix silly perl error in commit d064afc720
commit : e34adb2e6960ba8e885797a413620b344f468933
author : Andrew Dunstan <[email protected]>
date : Wed, 21 Apr 2021 11:12:04 -0400
committer: Andrew Dunstan <[email protected]>
date : Wed, 21 Apr 2021 11:12:04 -0400
M src/test/perl/PostgresNode.pm
Only ever test for non-127.0.0.1 addresses on Windows in PostgresNode
commit : d673905d8951b4d8d52b91f07c5fa61e404489f6
author : Andrew Dunstan <[email protected]>
date : Wed, 21 Apr 2021 10:21:22 -0400
committer: Andrew Dunstan <[email protected]>
date : Wed, 21 Apr 2021 10:21:22 -0400
This has been found to cause hangs where tcp usage is forced.
Alexey Kodratov
Discussion: https://postgr.es/m/[email protected]
Backpatch to all live branches
M src/test/perl/PostgresNode.pm
Fix typo in comment
commit : 7311fa8a7096b3a00fc39a10c5a20d4cf0564bfa
author : Magnus Hagander <[email protected]>
date : Tue, 20 Apr 2021 14:35:16 +0200
committer: Magnus Hagander <[email protected]>
date : Tue, 20 Apr 2021 14:35:16 +0200
Author: Julien Rouhaud
Backpatch-through: 11
Discussion: https://postgr.es/m/20210420121659.odjueyd4rpilorn5@nol
M src/backend/lib/dshash.c
Allow TestLib::slurp_file to skip contents, and use as needed
commit : 4c9298130ae8d4f3ba4149fbda3b95f6c86258d9
author : Andrew Dunstan <[email protected]>
date : Fri, 16 Apr 2021 16:54:04 -0400
committer: Andrew Dunstan <[email protected]>
date : Fri, 16 Apr 2021 16:54:04 -0400
In order to avoid getting old logfile contents certain functions in
PostgresNode were doing one of two things. On Windows it rotated the
logfile and restarted the server, while elsewhere it truncated the log
file. Both of these are unnecessary. We borrow from the buildfarm which
does this instead: note the size of the logfile before we start, and
then when fetching the logfile skip to that position before accumulating
contents. This is spelled differently on Windows but the effect is the
same. This is largely centralized in TestLib's slurp_file function,
which has a new optional parameter, the offset to skip to before
starting to reading the file. Code in the client becomes much neater.
Backpatch to all live branches.
Michael Paquier, slightly modified by me.
Discussion: https://postgr.es/m/[email protected]
M src/test/perl/PostgresNode.pm
M src/test/perl/TestLib.pm
Fix some inappropriately-disallowed uses of ALTER ROLE/DATABASE SET.
commit : c7f0275fbd4f4891ce8f03a676ac825f2d0885cc
author : Tom Lane <[email protected]>
date : Tue, 13 Apr 2021 15:10:18 -0400
committer: Tom Lane <[email protected]>
date : Tue, 13 Apr 2021 15:10:18 -0400
Most GUC check hooks that inspect database state have special checks
that prevent them from throwing hard errors for state-dependent issues
when source == PGC_S_TEST. This allows, for example,
"ALTER DATABASE d SET default_text_search_config = foo" when the "foo"
configuration hasn't been created yet. Without this, we have problems
during dump/reload or pg_upgrade, because pg_dump has no idea about
possible dependencies of GUC values and can't ensure a safe restore
ordering.
However, check_role() and check_session_authorization() hadn't gotten
the memo about that, and would throw hard errors anyway. It's not
entirely clear what is the use-case for "ALTER ROLE x SET role = y",
but we've now heard two independent complaints about that bollixing
an upgrade, so apparently some people are doing it.
Hence, fix these two functions to act more like other check hooks
with similar needs. (But I did not change their insistence on
being inside a transaction, as it's still not apparent that setting
either GUC from the configuration file would be wise.)
Also fix check_temp_buffers, which had a different form of the disease
of making state-dependent checks without any exception for PGC_S_TEST.
A cursory survey of other GUC check hooks did not find any more issues
of this ilk. (There are a lot of interdependencies among
PGC_POSTMASTER and PGC_SIGHUP GUCs, which may be a bad idea, but
they're not relevant to the immediate concern because they can't be
set via ALTER ROLE/DATABASE.)
Per reports from Charlie Hornsby and Nathan Bossart. Back-patch
to all supported branches.
Discussion: https://postgr.es/m/HE1P189MB0523B31598B0C772C908088DB7709@HE1P189MB0523.EURP189.PROD.OUTLOOK.COM
Discussion: https://postgr.es/m/[email protected]
M src/backend/commands/variable.c
M src/backend/utils/misc/guc.c
Redesign the caching done by get_cached_rowtype().
commit : 22f2a98cf3ed73ece782c66917e4734b8f736374
author : Tom Lane <[email protected]>
date : Tue, 13 Apr 2021 13:37:07 -0400
committer: Tom Lane <[email protected]>
date : Tue, 13 Apr 2021 13:37:07 -0400
Previously, get_cached_rowtype() cached a pointer to a reference-counted
tuple descriptor from the typcache, relying on the ExprContextCallback
mechanism to release the tupdesc refcount when the expression tree
using the tupdesc was destroyed. This worked fine when it was designed,
but the introduction of within-DO-block COMMITs broke it. The refcount
is logged in a transaction-lifespan resource owner, but plpgsql won't
destroy simple expressions made within the DO block (before its first
commit) until the DO block is exited. That results in a warning about
a leaked tupdesc refcount when the COMMIT destroys the original resource
owner, and then an error about the active resource owner not holding a
matching refcount when the expression is destroyed.
To fix, get rid of the need to have a shutdown callback at all, by
instead caching a pointer to the relevant typcache entry. Those
survive for the life of the backend, so we needn't worry about the
pointer becoming stale. (For registered RECORD types, we can still
cache a pointer to the tupdesc, knowing that it won't change for the
life of the backend.) This mechanism has been in use in plpgsql
and expandedrecord.c since commit 4b93f5799, and seems to work well.
This change requires modifying the ExprEvalStep structs used by the
relevant expression step types, which is slightly worrisome for
back-patching. However, there seems no good reason for extensions
to be familiar with the details of these particular sub-structs.
Per report from Rohit Bhogate. Back-patch to v11 where within-DO-block
COMMITs became a thing.
Discussion: https://postgr.es/m/CAAV6ZkQRCVBh8qAY+SZiHnz+U+FqAGBBDaDTjF2yiKa2nJSLKg@mail.gmail.com
M src/backend/executor/execExpr.c
M src/backend/executor/execExprInterp.c
M src/include/executor/execExpr.h
M src/pl/plpgsql/src/expected/plpgsql_transaction.out
M src/pl/plpgsql/src/sql/plpgsql_transaction.sql
Use "-I." in directories holding Bison parsers, for Oracle compilers.
commit : c8da16ba17eab30c21e87ed804f8ed613428313e
author : Noah Misch <[email protected]>
date : Mon, 12 Apr 2021 19:24:41 -0700
committer: Noah Misch <[email protected]>
date : Mon, 12 Apr 2021 19:24:41 -0700
With the Oracle Developer Studio 12.6 compiler, #line directives alter
the current source file location for purposes of #include "..."
directives. Hence, a VPATH build failed with 'cannot find include file:
"specscanner.c"'. With two exceptions, parser-containing directories
already add "-I. -I$(srcdir)"; eliminate the exceptions. Back-patch to
9.6 (all supported versions).
M src/test/isolation/Makefile
Port regress-python3-mangle.mk to Solaris "sed".
commit : 4a3de4092b2f5b53d325f53f1307d21e24bb922a
author : Noah Misch <[email protected]>
date : Mon, 12 Apr 2021 19:24:21 -0700
committer: Noah Misch <[email protected]>
date : Mon, 12 Apr 2021 19:24:21 -0700
It doesn't support "\(foo\)*" like a POSIX "sed" implementation does;
see the Autoconf manual. Back-patch to 9.6 (all supported versions).
M src/pl/plpython/regress-python3-mangle.mk
Fix old bug with coercing the result of a COLLATE expression.
commit : fb2cca828ec84f58bf119b65a4d6051400fe9438
author : Tom Lane <[email protected]>
date : Mon, 12 Apr 2021 14:37:22 -0400
committer: Tom Lane <[email protected]>
date : Mon, 12 Apr 2021 14:37:22 -0400
There are hacks in parse_coerce.c to push down a requested coercion
to below any CollateExpr that may appear. However, we did that even
if the requested data type is non-collatable, leading to an invalid
expression tree in which CollateExpr is applied to a non-collatable
type. The fix is just to drop the CollateExpr altogether, reasoning
that it's useless.
This bug is ten years old, dating to the original addition of
COLLATE support. The lack of field complaints suggests that there
aren't a lot of user-visible consequences. We noticed the problem
because it would trigger an assertion in DefineVirtualRelation if
the invalid structure appears as an output column of a view; however,
in a non-assert build, you don't see a crash just a (subtly incorrect)
complaint about applying collation to a non-collatable type. I found
that by putting the incorrect structure further down in a view, I could
make a view definition that would fail dump/reload, per the added
regression test case. But CollateExpr doesn't do anything at run-time,
so this likely doesn't lead to any really exciting consequences.
Per report from Yulin Pei. Back-patch to all supported branches.
Discussion: https://postgr.es/m/HK0PR01MB22744393C474D503E16C8509F4709@HK0PR01MB2274.apcprd01.prod.exchangelabs.com
M src/backend/parser/parse_coerce.c
M src/test/regress/expected/collate.out
M src/test/regress/sql/collate.sql
Fix out-of-bound memory access for interval -> char conversion
commit : 5656f2c3dce529b688eeeb2e98357c961376af80
author : Michael Paquier <[email protected]>
date : Mon, 12 Apr 2021 11:31:35 +0900
committer: Michael Paquier <[email protected]>
date : Mon, 12 Apr 2021 11:31:35 +0900
Using Roman numbers (via "RM" or "rm") for a conversion to calculate a
number of months has never considered the case of negative numbers,
where a conversion could easily cause out-of-bound memory accesses. The
conversions in themselves were not completely consistent either, as
specifying 12 would result in NULL, but it should mean XII.
This commit reworks the conversion calculation to have a more
consistent behavior:
- If the number of months and years is 0, return NULL.
- If the number of months is positive, return the exact month number.
- If the number of months is negative, do a backward calculation, with
-1 meaning December, -2 November, etc.
Reported-by: Theodor Arsenij Larionov-Trichkin
Author: Julien Rouhaud
Discussion: https://postgr.es/m/[email protected]
backpatch-through: 9.6
M src/backend/utils/adt/formatting.c
M src/test/regress/expected/timestamp.out
M src/test/regress/sql/timestamp.sql
Fix typo
commit : 721b3a3a9368c0bd5e9b92892279f0fa441efeee
author : Magnus Hagander <[email protected]>
date : Fri, 9 Apr 2021 12:40:14 +0200
committer: Magnus Hagander <[email protected]>
date : Fri, 9 Apr 2021 12:40:14 +0200
Author: Daniel Westermann
Backpatch-through: 9.6
Discussion: https://postgr.es/m/GV0P278MB0483A7AA85BAFCC06D90F453D2739@GV0P278MB0483.CHEP278.PROD.OUTLOOK.COM
M src/backend/utils/misc/guc.c
Fix typos and grammar in documentation and code comments
commit : 7f493570af922277f43a867bd6e458f59e0d680c
author : Michael Paquier <[email protected]>
date : Fri, 9 Apr 2021 13:53:27 +0900
committer: Michael Paquier <[email protected]>
date : Fri, 9 Apr 2021 13:53:27 +0900
Comment fixes are applied on HEAD, and documentation improvements are
applied on back-branches where needed.
Author: Justin Pryzby
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 9.6
M doc/src/sgml/maintenance.sgml
M doc/src/sgml/ref/createuser.sgml
Don't add non-existent pages to bitmap from BRIN
commit : 7d3a53461ce8cc47b51156228dd3243740d06158
author : Tomas Vondra <[email protected]>
date : Wed, 7 Apr 2021 15:58:35 +0200
committer: Tomas Vondra <[email protected]>
date : Wed, 7 Apr 2021 15:58:35 +0200
The code in bringetbitmap() simply added the whole matching page range
to the TID bitmap, as determined by pages_per_range, even if some of the
pages were beyond the end of the heap. The query then might fail with
an error like this:
ERROR: could not open file "base/20176/20228.2" (target block
262144): previous segment is only 131021 blocks
In this case, the relation has 262093 pages (131072 and 131021 pages),
but we're trying to acess block 262144, i.e. first block of the 3rd
segment. At that point _mdfd_getseg() notices the preceding segment is
incomplete, and fails.
Hitting this in practice is rather unlikely, because:
* Most indexes use power-of-two ranges, so segments and page ranges
align perfectly (segment end is also a page range end).
* The table size has to be just right, with the last segment being
almost full - less than one page range from full segment, so that the
last page range actually crosses the segment boundary.
* Prefetch has to be enabled. The regular page access checks that
pages are not beyond heap end, but prefetch does not. On older
releases (before 12) the execution stops after hitting the first
non-existent page, so the prefetch distance has to be sufficient
to reach the first page in the next segment to trigger the issue.
Since 12 it's enough to just have prefetch enabled, the prefetch
distance does not matter.
Fixed by not adding non-existent pages to the TID bitmap. Backpatch
all the way back to 9.6 (BRIN indexes were introduced in 9.5, but that
release is EOL).
Backpatch-through: 9.6
M src/backend/access/brin/brin.c
Fix potential rare failure in the kerberos TAP tests
commit : c2c9d6756deaea91c60de8043a742c391a9e3f30
author : Michael Paquier <[email protected]>
date : Wed, 7 Apr 2021 19:59:41 +0900
committer: Michael Paquier <[email protected]>
date : Wed, 7 Apr 2021 19:59:41 +0900
Instead of writing a query to psql's stdin, which can cause a failure
where psql exits before writing, reporting a write failure with a broken
pipe, this changes the logic to use -c. This was not seen in the
buildfarm as no animals with a sensitive environment are running the
kerberos tests, but let's be safe.
HEAD is able to handle the situation as of 6d41dd0 for all the test
suites doing connection checks. f44b9b6 has fixed the same problem for
the LDAP tests.
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 11
M src/test/kerberos/t/001_auth.pl
Shut down transaction tracking at startup process exit.
commit : b59d3abaf4069454fc212660a00b0b1f45c77467
author : Fujii Masao <[email protected]>
date : Tue, 6 Apr 2021 02:25:37 +0900
committer: Fujii Masao <[email protected]>
date : Tue, 6 Apr 2021 02:25:37 +0900
Maxim Orlov reported that the shutdown of standby server could result in
the following assertion failure. The cause of this issue was that,
when the shutdown caused the startup process to exit, recovery-time
transaction tracking was not shut down even if it's already initialized,
and some locks the tracked transactions were holding could not be released.
At this situation, if other process was invoked and the PGPROC entry that
the startup process used was assigned to it, it found such unreleased locks
and caused the assertion failure, during the initialization of it.
TRAP: FailedAssertion("SHMQueueEmpty(&(MyProc->myProcLocks[i]))"
This commit fixes this issue by making the startup process shut down
transaction tracking and release all locks, at the exit of it.
Back-patch to all supported branches.
Reported-by: Maxim Orlov
Author: Fujii Masao
Reviewed-by: Maxim Orlov
Discussion: https://postgr.es/m/[email protected]
M src/backend/postmaster/startup.c
M src/backend/storage/ipc/standby.c
Use macro MONTHS_PER_YEAR instead of '12' in /ecpg/pgtypeslib
commit : 438d7f36ffcc91c81d4e6a4716e556d5bf4f9a78
author : Bruce Momjian <[email protected]>
date : Fri, 2 Apr 2021 16:42:29 -0400
committer: Bruce Momjian <[email protected]>
date : Fri, 2 Apr 2021 16:42:29 -0400
All other places already use MONTHS_PER_YEAR appropriately.
Backpatch-through: 9.6
M src/interfaces/ecpg/pgtypeslib/interval.c
Clarify documentation of RESET ROLE
commit : 9e1775a7dfd883865ad0ef6f9286d96522fed80d
author : Joe Conway <[email protected]>
date : Fri, 2 Apr 2021 13:48:50 -0400
committer: Joe Conway <[email protected]>
date : Fri, 2 Apr 2021 13:48:50 -0400
Command-line options, or previous "ALTER (ROLE|DATABASE) ...
SET ROLE ..." commands, can change the value of the default role
for a session. In the presence of one of these, RESET ROLE will
change the current user identifier to the default role rather
than the session user identifier. Fix the documentation to
reflect this reality. Backpatch to all supported versions.
Author: Nathan Bossart
Reviewed-By: Laurenz Albe, David G. Johnston, Joe Conway
Reported by: Nathan Bossart
Discussion: https://postgr.es/m/flat/925134DB-8212-4F60-8AB1-B1231D750CB4%40amazon.com
Backpatch-through: 9.6
M doc/src/sgml/ref/set_role.sgml
doc: Clarify how to generate backup files with non-exclusive backups
commit : eb5e380a08a2d5ce13cb64d405d2966ffb8944b7
author : Michael Paquier <[email protected]>
date : Fri, 2 Apr 2021 16:37:15 +0900
committer: Michael Paquier <[email protected]>
date : Fri, 2 Apr 2021 16:37:15 +0900
The current instructions describing how to write the backup_label and
tablespace_map files are confusing. For example, opening a file in text
mode on Windows and copy-pasting the file's contents would result in a
failure at recovery because of the extra CRLF characters generated. The
documentation was not stating that clearly, and per discussion this is
not considered as a supported scenario.
This commit extends a bit the documentation to mention that it may be
required to open the file in binary mode before writing its data.
Reported-by: Wang Shenhao
Author: David Steele
Reviewed-by: Andrew Dunstan, Magnus Hagander
Discussion: https://postgr.es/m/8373f61426074f2cb6be92e02f838389@G08CNEXMBPEKD06.g08.fujitsu.local
Backpatch-through: 9.6
M doc/src/sgml/backup.sgml
doc: mention that intervening major releases can be skipped
commit : 061003b27fde996b612d58cbdef6b1e0717e3063
author : Bruce Momjian <[email protected]>
date : Thu, 1 Apr 2021 21:17:24 -0400
committer: Bruce Momjian <[email protected]>
date : Thu, 1 Apr 2021 21:17:24 -0400
Also mention that you should read the intervening major releases notes.
This change was also applied to the website.
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 9.6
M doc/src/sgml/runtime.sgml
Fix pg_restore's misdesigned code for detecting archive file format.
commit : 25fe401d5350546c5f68cafc0ef7ce3cd4dde3b2
author : Tom Lane <[email protected]>
date : Thu, 1 Apr 2021 13:34:16 -0400
committer: Tom Lane <[email protected]>
date : Thu, 1 Apr 2021 13:34:16 -0400
Despite the clear comments pointing out that the duplicative code
segments in ReadHead() and _discoverArchiveFormat() needed to be
in sync, they were not: the latter did not bother to apply any of
the sanity checks in the former. We'd missed noticing this partly
because none of those checks would fail in scenarios we customarily
test, and partly because the oversight would be masked if both
segments execute, which they would in cases other than needing to
autodetect the format of a non-seekable stdin source. However,
in a case meeting all these requirements --- for example, trying
to read a newer-than-supported archive format from non-seekable
stdin --- pg_restore missed applying the version check and would
likely dump core or otherwise misbehave.
The whole thing is silly anyway, because there seems little reason
to duplicate the logic beyond the one-line verification that the
file starts with "PGDMP". There seems to have been an undocumented
assumption that multiple major formats (major enough to require
separate reader modules) would nonetheless share the first half-dozen
fields of the custom-format header. This seems unlikely, so let's
fix it by just nuking the duplicate logic in _discoverArchiveFormat().
Also get rid of the pointless attempt to seek back to the start of
the file after successful autodetection. That wastes cycles and
it means we have four behaviors to verify not two.
Per bug #16951 from Sergey Koposov. This has been broken for
decades, so back-patch to all supported versions.
Discussion: https://postgr.es/m/[email protected]
M src/bin/pg_dump/pg_backup_archiver.c
M src/bin/pg_dump/pg_backup_archiver.h
M src/bin/pg_dump/pg_backup_tar.c
doc: Clarify use of ACCESS EXCLUSIVE lock in various sections
commit : dd5d04e5da83577c7863d82ce35ba6b63ac17df9
author : Michael Paquier <[email protected]>
date : Thu, 1 Apr 2021 15:29:01 +0900
committer: Michael Paquier <[email protected]>
date : Thu, 1 Apr 2021 15:29:01 +0900
Some sections of the documentation used "exclusive lock" to describe
that an ACCESS EXCLUSIVE lock is taken during a given operation. This
can be confusing to the reader as ACCESS SHARE is allowed with an
EXCLUSIVE lock is used, but that would not be the case with what is
described on those parts of the documentation.
Author: Greg Rychlewski
Discussion: https://postgr.es/m/CAKemG7VptD=7fNWckFMsMVZL_zzvgDO6v2yVmQ+ZiBfc_06kCQ@mail.gmail.com
Backpatch-through: 9.6
M doc/src/sgml/ddl.sgml
M doc/src/sgml/hstore.sgml
M doc/src/sgml/indexam.sgml
M doc/src/sgml/maintenance.sgml
M doc/src/sgml/mvcc.sgml
M doc/src/sgml/pgrowlocks.sgml
M doc/src/sgml/ref/drop_index.sgml
M doc/src/sgml/ref/reindex.sgml
M doc/src/sgml/ref/vacuum.sgml
Add a docs section for obsoleted and renamed functions and settings
commit : 625f5aae7e42dd15b1aa51e13abe3ebe523e511a
author : Stephen Frost <[email protected]>
date : Wed, 31 Mar 2021 16:23:09 -0400
committer: Stephen Frost <[email protected]>
date : Wed, 31 Mar 2021 16:23:09 -0400
The new appendix groups information on renamed or removed settings,
commands, etc into an out-of-the-way part of the docs.
The original id elements are retained in each subsection to ensure that
the same filenames are produced for HTML docs. This prevents /current/
links on the web from breaking, and allows users of the web docs
to follow links from old version pages to info on the changes in the
new version. Prior to this change, a link to /current/ for renamed
sections like the recovery.conf docs would just 404. Similarly if
someone searched for recovery.conf they would find the pg11 docs,
but there would be no /12/ or /current/ link, so they couldn't easily
find out that it was removed in pg12 or how to adapt.
Index entries are also added so that there's a breadcrumb trail for
users to follow when they know the old name, but not what we changed it
to. So a user who is trying to find out how to set standby_mode in
PostgreSQL 12+, or where pg_resetxlog went, now has more chance of
finding that information.
Craig Ringer and Stephen Frost
Reviewed-by: Euler Taveira
Discussion: https://postgr.es/m/CAGRY4nzPNOyYQ_1-pWYToUVqQ0ThqP5jdURnJMZPm539fdizOg%40mail.gmail.com
Backpatch-through: 10
A doc/src/sgml/appendix-obsolete-pgreceivexlog.sgml
A doc/src/sgml/appendix-obsolete-pgresetxlog.sgml
A doc/src/sgml/appendix-obsolete-pgxlogdump.sgml
A doc/src/sgml/appendix-obsolete.sgml
M doc/src/sgml/filelist.sgml
M doc/src/sgml/postgres.sgml
Update obsolete comment.
commit : 1b4dd6aaff91d9eb710ab2f6e82ac7539769c527
author : Etsuro Fujita <[email protected]>
date : Tue, 30 Mar 2021 13:00:05 +0900
committer: Etsuro Fujita <[email protected]>
date : Tue, 30 Mar 2021 13:00:05 +0900
Back-patch to all supported branches.
Author: Etsuro Fujita
Discussion: https://postgr.es/m/CAPmGK17DwzaSf%2BB71dhL2apXdtG-OmD6u2AL9Cq2ZmAR0%2BzapQ%40mail.gmail.com
M contrib/postgres_fdw/postgres_fdw.c
doc: Define TLS as an acronym
commit : 31536bf93622664574c215bb5b757cbd1b6cc5da
author : Stephen Frost <[email protected]>
date : Sun, 28 Mar 2021 11:28:17 -0400
committer: Stephen Frost <[email protected]>
date : Sun, 28 Mar 2021 11:28:17 -0400
Commit c6763156589 added an acronym reference for "TLS" but the definition
was never added.
Author: Daniel Gustafsson
Reviewed-by: Michael Paquier
Backpatch-through: 9.6
Discussion: https://postgr.es/m/[email protected]
M doc/src/sgml/acronyms.sgml
Fix ndistinct estimates with system attributes
commit : 2a307df1bba7178b3903e01bee5012707f950473
author : Tomas Vondra <[email protected]>
date : Fri, 26 Mar 2021 22:34:53 +0100
committer: Tomas Vondra <[email protected]>
date : Fri, 26 Mar 2021 22:34:53 +0100
When estimating the number of groups using extended statistics, the code
was discarding information about system attributes. This led to strange
situation that
SELECT 1 FROM t GROUP BY ctid;
could have produced higher estimate (equal to pg_class.reltuples) than
SELECT 1 FROM t GROUP BY a, b, ctid;
with extended statistics on (a,b). Fixed by retaining information about
the system attribute.
Backpatch all the way to 10, where extended statistics were introduced.
Author: Tomas Vondra
Backpatch-through: 10
M src/backend/utils/adt/selfuncs.c
Remove StoreSingleInheritance reimplementation
commit : 83ba02c83e363362ff7d808085dfe236de78f61d
author : Alvaro Herrera <[email protected]>
date : Thu, 25 Mar 2021 10:47:38 -0300
committer: Alvaro Herrera <[email protected]>
date : Thu, 25 Mar 2021 10:47:38 -0300
I introduced this duplicate code in commit 8b08f7d4820f for no good
reason. Remove it, and backpatch to 11 where it was introduced.
Author: Álvaro Herrera <[email protected]>
M src/backend/commands/indexcmds.c
Fix bug in WAL replay of COMMIT_TS_SETTS record.
commit : 09cb8512ff11bd2c58b3d28bce9501e76bd12eff
author : Fujii Masao <[email protected]>
date : Thu, 25 Mar 2021 11:23:30 +0900
committer: Fujii Masao <[email protected]>
date : Thu, 25 Mar 2021 11:23:30 +0900
Previously the WAL replay of COMMIT_TS_SETTS record called
TransactionTreeSetCommitTsData() with the argument write_xlog=true,
which generated and wrote new COMMIT_TS_SETTS record.
This should not be acceptable because it's during recovery.
This commit fixes the WAL replay of COMMIT_TS_SETTS record
so that it calls TransactionTreeSetCommitTsData() with write_xlog=false
and doesn't generate new WAL during recovery.
Back-patch to all supported branches.
Reported-by: lx zou <[email protected]>
Author: Fujii Masao
Reviewed-by: Alvaro Herrera
Discussion: https://postgr.es/m/[email protected]
M src/backend/access/transam/commit_ts.c
Fix psql's \connect command some more.
commit : d75edab42c66cdc7b120d0d483ef73343d621eb4
author : Tom Lane <[email protected]>
date : Tue, 23 Mar 2021 14:27:50 -0400
committer: Tom Lane <[email protected]>
date : Tue, 23 Mar 2021 14:27:50 -0400
Jasen Betts reported yet another unintended side effect of commit
85c54287a: reconnecting with "\c service=whatever" did not have the
expected results. The reason is that starting from the output of
PQconndefaults() effectively allows environment variables (such
as PGPORT) to override entries in the service file, whereas the
normal priority is the other way around.
Not using PQconndefaults at all would require yet a third main code
path in do_connect's parameter setup, so I don't really want to fix
it that way. But we can have the logic effectively ignore all the
default values for just a couple more lines of code.
This patch doesn't change the behavior for "\c -reuse-previous=on
service=whatever". That remains significantly different from before
85c54287a, because many more parameters will be re-used, and thus
not be possible for service entries to replace. But I think this
is (mostly?) intentional. In any case, since libpq does not report
where it got parameter values from, it's hard to do differently.
Per bug #16936 from Jasen Betts. As with the previous patches,
back-patch to all supported branches. (9.5 is unfortunately now
out of support, so this won't get fixed there.)
Discussion: https://postgr.es/m/[email protected]
M src/bin/psql/command.c
Use correct spelling of statistics kind
commit : 16568c0a8aee85052cfd3e465d21d1e1d1b442e1
author : Tomas Vondra <[email protected]>
date : Tue, 23 Mar 2021 04:53:11 +0100
committer: Tomas Vondra <[email protected]>
date : Tue, 23 Mar 2021 04:53:11 +0100
A couple error messages and comments used 'statistic kind', not the
correct 'statistics kind'. Fix and backpatch all the way back to 10,
where extended statistics were introduced.
Backpatch-through: 10
M doc/src/sgml/catalogs.sgml
M src/backend/statistics/dependencies.c
M src/backend/statistics/extended_stats.c
M src/backend/statistics/mvdistinct.c
M src/include/nodes/relation.h
pg_waldump: Fix bug in per-record statistics.
commit : 4a2627c41cfe9962117df19165731e84be0879dd
author : Fujii Masao <[email protected]>
date : Tue, 23 Mar 2021 09:53:08 +0900
committer: Fujii Masao <[email protected]>
date : Tue, 23 Mar 2021 09:53:08 +0900
pg_waldump --stats=record identifies a record by a combination
of the RmgrId and the four bits of the xl_info field of the record.
But XACT records use the first bit of those four bits for an optional
flag variable, and the following three bits for the opcode to
identify a record. So previously the same type of XACT record
could have different four bits (three bits are the same but the
first one bit is different), and which could cause
pg_waldump --stats=record to show two lines of per-record statistics
for the same XACT record. This is a bug.
This commit changes pg_waldump --stats=record so that it processes
only XACT record differently, i.e., filters the opcode out of xl_info
and uses a combination of the RmgrId and those three bits as
the identifier of a record, only for XACT record. For other records,
the four bits of the xl_info field are still used.
Back-patch to all supported branches.
Author: Kyotaro Horiguchi
Reviewed-by: Shinya Kato, Fujii Masao
Discussion: https://postgr.es/m/[email protected]
M src/bin/pg_waldump/pg_waldump.c
Fix new TAP test for 2PC transactions and PITRs on Windows
commit : 66bd6fcf82540b714de3a7aded3e940dc17bd1bc
author : Michael Paquier <[email protected]>
date : Mon, 22 Mar 2021 09:51:22 +0900
committer: Michael Paquier <[email protected]>
date : Mon, 22 Mar 2021 09:51:22 +0900
The test added by 595b9cb forgot that on Windows it is necessary to set
up pg_hba.conf (see PostgresNode::set_replication_conf) with a specific
entry or base backups fail. Any node that requires to support
replication just needs to pass down allows_streaming at initialization.
This updates the test to do so. Simplify things a bit while on it.
Per buildfarm member fairywren. Any Windows hosts running this test
would have failed, and I have reproduced the problem as well.
Backpatch-through: 10
M src/test/recovery/t/023_pitr_prepared_xact.pl
Fix timeline assignment in checkpoints with 2PC transactions
commit : f1d550f188e24d92b9dcc1d19ea0072a925894f5
author : Michael Paquier <[email protected]>
date : Mon, 22 Mar 2021 08:31:09 +0900
committer: Michael Paquier <[email protected]>
date : Mon, 22 Mar 2021 08:31:09 +0900
Any transactions found as still prepared by a checkpoint have their
state data read from the WAL records generated by PREPARE TRANSACTION
before being moved into their new location within pg_twophase/. While
reading such records, the WAL reader uses the callback
read_local_xlog_page() to read a page, that is shared across various
parts of the system. This callback, since 1148e22a, has introduced an
update of ThisTimeLineID when reading a record while in recovery, which
is potentially helpful in the context of cascading WAL senders.
This update of ThisTimeLineID interacts badly with the checkpointer if a
promotion happens while some 2PC data is read from its record, as, by
changing ThisTimeLineID, any follow-up WAL records would be written to
an timeline older than the promoted one. This results in consistency
issues. For instance, a subsequent server restart would cause a failure
in finding a valid checkpoint record, resulting in a PANIC, for
instance.
This commit changes the code reading the 2PC data to reset the timeline
once the 2PC record has been read, to prevent messing up with the static
state of the checkpointer. It would be tempting to do the same thing
directly in read_local_xlog_page(). However, based on the discussion
that has led to 1148e22a, users may rely on the updates of
ThisTimeLineID when a WAL record page is read in recovery, so changing
this callback could break some cases that are working currently.
A TAP test reproducing the issue is added, relying on a PITR to
precisely trigger a promotion with a prepared transaction still
tracked.
Per discussion with Heikki Linnakangas, Kyotaro Horiguchi, Fujii Masao
and myself.
Author: Soumyadeep Chakraborty, Jimmy Yih, Kevin Yeap
Discussion: https://postgr.es/m/CAE-ML+_EjH_fzfq1F3RJ1=XaaNG=-Jz-i3JqkNhXiLAsM3z-Ew@mail.gmail.com
Backpatch-through: 10
M src/backend/access/transam/twophase.c
A src/test/recovery/t/023_pitr_prepared_xact.pl
Fix memory leak when rejecting bogus DH parameters.
commit : 8c830148d2d411da25272503b5456a66833d8e47
author : Tom Lane <[email protected]>
date : Sat, 20 Mar 2021 12:47:21 -0400
committer: Tom Lane <[email protected]>
date : Sat, 20 Mar 2021 12:47:21 -0400
While back-patching e0e569e1d, I noted that there were some other
places where we ought to be applying DH_free(); namely, where we
load some DH parameters from a file and then reject them as not
being sufficiently secure. While it seems really unlikely that
anybody would hit these code paths in production, let alone do
so repeatedly, let's fix it for consistency.
Back-patch to v10 where this code was introduced.
Discussion: https://postgr.es/m/[email protected]
M src/backend/libpq/be-secure-openssl.c
Fix memory leak when initializing DH parameters in backend
commit : c49e287a8e4dbc3013a56f88793638f79a6ef099
author : Tom Lane <[email protected]>
date : Sat, 20 Mar 2021 12:38:22 -0400
committer: Tom Lane <[email protected]>
date : Sat, 20 Mar 2021 12:38:22 -0400
When loading DH parameters used for the generation of ephemeral DH keys
in the backend, the code has never bothered releasing the memory used
for the DH information loaded from a file or from libpq's default. This
commit makes sure that the information is properly free()'d.
Back-patch of e0e569e1d. We originally thought the leak was minor and
not worth back-patching, but Jelte Fennema pointed out that repeated
SIGHUP's can result in very serious bloat of the postmaster, which is
then multiplied by being duplicated into eadh forked child.
Back-patch to v10; the code looked different before c0a15e07c,
and didn't have a leak in the actually-live code paths.
Michael Paquier
Discussion: https://postgr.es/m/[email protected]
M src/backend/libpq/be-secure-openssl.c
Don't leak malloc'd error string in libpqrcv_check_conninfo().
commit : 20f11ca0dbc2bd99de9c4866eec6722b8202e422
author : Tom Lane <[email protected]>
date : Thu, 18 Mar 2021 22:21:58 -0400
committer: Tom Lane <[email protected]>
date : Thu, 18 Mar 2021 22:21:58 -0400
We leaked the error report from PQconninfoParse, when there was
one. It seems unlikely that real usage patterns would repeat
the failure often enough to create serious bloat, but let's
back-patch anyway to keep the code similar in all branches.
Found via valgrind testing.
Back-patch to v10 where this code was added.
Discussion: https://postgr.es/m/[email protected]
M src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
Don't leak malloc'd strings when a GUC setting is rejected.
commit : 26a3ae06d85c835c04642c08e304e11821587ad2
author : Tom Lane <[email protected]>
date : Thu, 18 Mar 2021 22:09:41 -0400
committer: Tom Lane <[email protected]>
date : Thu, 18 Mar 2021 22:09:41 -0400
Because guc.c prefers to keep all its string values in malloc'd
not palloc'd storage, it has to be more careful than usual to
avoid leaks. Error exits out of string GUC hook checks failed
to clear the proposed value string, and error exits out of
ProcessGUCArray() failed to clear the malloc'd results of
ParseLongOption().
Found via valgrind testing.
This problem is ancient, so back-patch to all supported branches.
Discussion: https://postgr.es/m/[email protected]
M src/backend/utils/misc/guc.c
Don't leak compiled regex(es) when an ispell cache entry is dropped.
commit : 099d2914f30b8c1c9d7aa09a8fa1e1ca3474866e
author : Tom Lane <[email protected]>
date : Thu, 18 Mar 2021 21:44:43 -0400
committer: Tom Lane <[email protected]>
date : Thu, 18 Mar 2021 21:44:43 -0400
The text search cache mechanisms assume that we can clean up
an invalidated dictionary cache entry simply by resetting the
associated long-lived memory context. However, that does not work
for ispell affixes that make use of regular expressions, because
the regex library deals in plain old malloc. Hence, we leaked
compiled regex(es) any time we dropped such a cache entry. That
could quickly add up, since even a fairly trivial regex can use up
tens of kB, and a large one can eat megabytes. Add a memory context
callback to ensure that a regex gets freed when its owning cache
entry is cleared.
Found via valgrind testing.
This problem is ancient, so back-patch to all supported branches.
Discussion: https://postgr.es/m/[email protected]
M src/backend/tsearch/spell.c
M src/include/tsearch/dicts/spell.h
Don't leak rd_statlist when a relcache entry is dropped.
commit : 967b693eaef10aab76038163c6abd5778db38c51
author : Tom Lane <[email protected]>
date : Thu, 18 Mar 2021 20:37:09 -0400
committer: Tom Lane <[email protected]>
date : Thu, 18 Mar 2021 20:37:09 -0400
Although these lists are usually NIL, and even when not empty
are unlikely to be large, constant relcache update traffic could
eventually result in visible bloat of CacheMemoryContext.
Found via valgrind testing.
Back-patch to v10 where this field was added.
Discussion: https://postgr.es/m/[email protected]
M src/backend/utils/cache/relcache.c
Fix function name in error hint
commit : 5d825d7bee4d05c4ed086e23306e7a74b8f817a8
author : Magnus Hagander <[email protected]>
date : Thu, 18 Mar 2021 11:24:42 +0100
committer: Magnus Hagander <[email protected]>
date : Thu, 18 Mar 2021 11:24:42 +0100
pg_read_file() is the function that's in core, pg_file_read() is in
adminpack. But when using pg_file_read() in adminpack it calls the *C*
level function pg_read_file() in core, which probably threw the original
author off. But the error hint should be about the SQL function.
Reported-By: Sergei Kornilov
Backpatch-through: 11
Discussion: https://postgr.es/m/[email protected]
M src/backend/utils/adt/genfile.c
Prevent buffer overrun in read_tablespace_map().
commit : 217815c66987704ef5139772a8fd05fd7c361e1a
author : Tom Lane <[email protected]>
date : Wed, 17 Mar 2021 16:10:38 -0400
committer: Tom Lane <[email protected]>
date : Wed, 17 Mar 2021 16:10:38 -0400
Robert Foggia of Trustwave reported that read_tablespace_map()
fails to prevent an overrun of its on-stack input buffer.
Since the tablespace map file is presumed trustworthy, this does
not seem like an interesting security vulnerability, but still
we should fix it just in the name of robustness.
While here, document that pg_basebackup's --tablespace-mapping option
doesn't work with tar-format output, because it doesn't. To make it
work, we'd have to modify the tablespace_map file within the tarball
sent by the server, which might be possible but I'm not volunteering.
(Less-painful solutions would require changing the basebackup protocol
so that the source server could adjust the map. That's not very
appetizing either.)
M doc/src/sgml/ref/pg_basebackup.sgml
M src/backend/access/transam/xlog.c
Revert "Fix race in Parallel Hash Join batch cleanup."
commit : 492f6e21038a821511600fc174a128d3af036d37
author : Thomas Munro <[email protected]>
date : Thu, 18 Mar 2021 01:09:35 +1300
committer: Thomas Munro <[email protected]>
date : Thu, 18 Mar 2021 01:09:35 +1300
This reverts commit 0129c56fbe5c26bfec91bfc2c8a3b8818f441d6e.
Discussion: https://postgr.es/m/CA%2BhUKGJmcqAE3MZeDCLLXa62cWM0AJbKmp2JrJYaJ86bz36LFA%40mail.gmail.com
M src/backend/executor/nodeHash.c
M src/backend/executor/nodeHashjoin.c
M src/include/executor/hashjoin.h
Fix race in Parallel Hash Join batch cleanup.
commit : 0129c56fbe5c26bfec91bfc2c8a3b8818f441d6e
author : Thomas Munro <[email protected]>
date : Wed, 17 Mar 2021 17:46:39 +1300
committer: Thomas Munro <[email protected]>
date : Wed, 17 Mar 2021 17:46:39 +1300
With very unlucky timing and parallel_leader_participation off, PHJ
could attempt to access per-batch state just as it was being freed.
There was code intended to prevent that by checking for a cleared
pointer, but it was buggy.
Fix, by introducing an extra barrier phase. The new phase
PHJ_BUILD_RUNNING means that it's safe to access the per-batch state to
find a batch to help with, and PHJ_BUILD_DONE means that it is too late.
The last to detach will free the array of per-batch state as before, but
now it will also atomically advance the phase at the same time, so that
late attachers can avoid the hazard, without the data race. This
mirrors the way per-batch hash tables are freed (see phases
PHJ_BATCH_PROBING and PHJ_BATCH_DONE).
Revealed by a one-off build farm failure, where BarrierAttach() failed a
sanity check assertion, because the memory had been clobbered by
dsa_free().
Back-patch to 11, where the code arrived.
Reported-by: Michael Paquier <[email protected]>
Discussion: https://postgr.es/m/20200929061142.GA29096%40paquier.xyz
M src/backend/executor/nodeHash.c
M src/backend/executor/nodeHashjoin.c
M src/include/executor/hashjoin.h
Avoid corner-case memory leak in SSL parameter processing.
commit : a2764d87df0475c786d021f4cd553aff2ae5f5bf
author : Tom Lane <[email protected]>
date : Tue, 16 Mar 2021 16:02:50 -0400
committer: Tom Lane <[email protected]>
date : Tue, 16 Mar 2021 16:02:50 -0400
After reading the root cert list from the ssl_ca_file, immediately
install it as client CA list of the new SSL context. That gives the
SSL context ownership of the list, so that SSL_CTX_free will free it.
This avoids a permanent memory leak if we fail further down in
be_tls_init(), which could happen if bogus CRL data is offered.
The leak could only amount to something if the CRL parameters get
broken after server start (else we'd just quit) and then the server
is SIGHUP'd many times without fixing the CRL data. That's rather
unlikely perhaps, but it seems worth fixing, if only because the
code is clearer this way.
While we're here, add some comments about the memory management
aspects of this logic.
Noted by Jelte Fennema and independently by Andres Freund.
Back-patch to v10; before commit de41869b6 it doesn't matter,
since we'd not re-execute this code during SIGHUP.
Discussion: https://postgr.es/m/[email protected]
M src/backend/libpq/be-secure-openssl.c
Fix race condition in psql \e's detection of file modification.
commit : 33aa7d13d610397837bd0a1cd9a41488c5166742
author : Tom Lane <[email protected]>
date : Fri, 12 Mar 2021 12:20:15 -0500
committer: Tom Lane <[email protected]>
date : Fri, 12 Mar 2021 12:20:15 -0500
psql's editing commands decide whether the user has edited the file
by checking for change of modification timestamp. This is probably
fine for a pre-existing file, but with a temporary file that is
created within the command, it's possible for a fast typist to
save-and-exit in less than the one-second granularity of stat(2)
timestamps. On Windows FAT filesystems the granularity is even
worse, 2 seconds, making the race a bit easier to hit.
To fix, try to set the temp file's mod time to be two seconds ago.
It's unlikely this would fail, but then again the race condition
itself is unlikely, so just ignore any error.
Also, we might as well check the file size as well as its mod time.
While this is a difficult bug to hit, it still seems worth
back-patching, to ensure that users' edits aren't lost.
Laurenz Albe, per gripe from Jacob Champion; based on fix suggestions
from Jacob and myself
Discussion: https://postgr.es/m/[email protected]
M src/bin/psql/command.c
Forbid marking an identity column as nullable.
commit : 6c34f186c4c62ac93b8f5f7229b03301b02741c9
author : Tom Lane <[email protected]>
date : Fri, 12 Mar 2021 11:08:42 -0500
committer: Tom Lane <[email protected]>
date : Fri, 12 Mar 2021 11:08:42 -0500
GENERATED ALWAYS AS IDENTITY implies NOT NULL, but the code failed
to complain if you overrode that with "GENERATED ALWAYS AS IDENTITY
NULL". One might think the old behavior was a feature, but it was
inconsistent because the outcome varied depending on the order of
the clauses, so it seems to have been just an oversight.
Per bug #16913 from Pavel Boev. Back-patch to v10 where identity
columns were introduced.
Vik Fearing (minor tweaks by me)
Discussion: https://postgr.es/m/[email protected]
M doc/src/sgml/ref/create_table.sgml
M src/backend/parser/parse_utilcmd.c
M src/test/regress/expected/identity.out
M src/test/regress/sql/identity.sql
Restore vacuum_cleanup_index_scale_factor coverage.
commit : ddd4cc09a6e5d775822e0244e73ca9bb894dce42
author : Peter Geoghegan <[email protected]>
date : Thu, 11 Mar 2021 12:52:35 -0800
committer: Peter Geoghegan <[email protected]>
date : Thu, 11 Mar 2021 12:52:35 -0800
Revert two recent commits that had btree_index.sql drop regression test
indexes rather than leave them behind for pg_dump testing.
This is intended to restore pg_upgrade coverage of indexes with the
vacuum_cleanup_index_scale_factor storage parameter set on buildfarm
member crake.
Backpatch: 11-12 only
M src/test/regress/expected/btree_index.out
M src/test/regress/sql/btree_index.sql
Re-simplify management of inStart in pqParseInput3's subroutines.
commit : d3a557894ce0dce0d5241563b2159c24816e6b35
author : Tom Lane <[email protected]>
date : Thu, 11 Mar 2021 14:43:45 -0500
committer: Tom Lane <[email protected]>
date : Thu, 11 Mar 2021 14:43:45 -0500
Commit 92785dac2 copied some logic related to advancement of inStart
from pqParseInput3 into getRowDescriptions and getAnotherTuple,
because it wanted to allow user-defined row processor callbacks to
potentially longjmp out of the library, and inStart would have to be
updated before that happened to avoid an infinite loop. We later
decided that that API was impossibly fragile and reverted it, but
we didn't undo all of the related code changes, and this bit of
messiness survived. Undo it now so that there's just one place in
pqParseInput3's processing where inStart is advanced; this will
simplify addition of better tracing support.
getParamDescriptions had grown similar processing somewhere along
the way (not in 92785dac2; I didn't track down just when), but it's
actually buggy because its handling of corrupt-message cases seems to
have been copied from the v2 logic where we lacked a known message
length. The cases where we "goto not_enough_data" should not simply
return EOF, because then we won't consume the message, potentially
creating an infinite loop. That situation now represents a
definitively corrupt message, and we should report it as such.
Although no field reports of getParamDescriptions getting stuck in
a loop have been seen, it seems appropriate to back-patch that fix.
I chose to back-patch all of this to keep the logic looking more alike
in supported branches.
Discussion: https://postgr.es/m/[email protected]
M src/interfaces/libpq/fe-protocol3.c
Drop other index behind pg_upgrade test issue.
commit : 28cf4d93d045b9862ef2d8b49a533bd2912228c1
author : Peter Geoghegan <[email protected]>
date : Wed, 10 Mar 2021 23:32:55 -0800
committer: Peter Geoghegan <[email protected]>
date : Wed, 10 Mar 2021 23:32:55 -0800
Fix the test failure by dropping the index in question. Missed by
commit 57ae7885.
Per buildfarm member crake.
Backpatch: 11-12 only
M src/test/regress/expected/btree_index.out
M src/test/regress/sql/btree_index.sql
Drop index behind pg_upgrade test issue.
commit : 006c52668ab3c93b4e18a5c53a51f28faa9603a2
author : Peter Geoghegan <[email protected]>
date : Wed, 10 Mar 2021 19:00:46 -0800
committer: Peter Geoghegan <[email protected]>
date : Wed, 10 Mar 2021 19:00:46 -0800
The vacuum_cleanup_index_scale_factor storage parameter was set in a
btree index that was previously left behind in the regression test
database. As a result, the index gets tested within pg_dump and
pg_restore tests, as well as pg_upgrade testing. This won't work when
upgrading to Postgres 14, though, because the storage parameter was
removed on that version by commit 9f3665fb.
Fix the test failure by dropping the index in question.
Per buildfarm member crake.
Discussion: https://postgr.es/m/CAH2-WzmeXYBWdhF7BMhNjhq9exsk=E1ohqBFAwzPdXJZ1XDMUA@mail.gmail.com
Backpatch: 11-12 only
M src/test/regress/expected/btree_index.out
M src/test/regress/sql/btree_index.sql
tutorial: land height is "elevation", not "altitude"
commit : b463490f9061232f77941e9b369b9343117d5748
author : Bruce Momjian <[email protected]>
date : Wed, 10 Mar 2021 20:25:18 -0500
committer: Bruce Momjian <[email protected]>
date : Wed, 10 Mar 2021 20:25:18 -0500
This is a follow-on patch to 92c12e46d5. In that patch, we renamed
"altitude" to "elevation" in the docs, based on these details:
https://mapscaping.com/blogs/geo-candy/what-is-the-difference-between-elevation-relief-and-altitude
This renames the tutorial SQL files to match the documentation.
Reported-by: [email protected]
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 9.6
M src/tutorial/advanced.source
Doc: improve introductory information about procedures.
commit : e0fcde7f74a573cd5ebb111f1ddc4ca890b2ec93
author : Tom Lane <[email protected]>
date : Wed, 10 Mar 2021 11:33:50 -0500
committer: Tom Lane <[email protected]>
date : Wed, 10 Mar 2021 11:33:50 -0500
Clarify the discussion in "User-Defined Procedures", by laying out
the key differences between functions and procedures in a bulleted
list. Notably, this avoids burying the lede about procedures being
able to do transaction control. Make the back-link in the CREATE
FUNCTION reference page more prominent, and add one in CREATE
PROCEDURE.
Per gripe from Guyren Howe. Thanks to David Johnston for discussion.
Discussion: https://postgr.es/m/BYAPR03MB4903C53A8BB7EFF5EA289674A6949@BYAPR03MB4903.namprd03.prod.outlook.com
M doc/src/sgml/ref/create_function.sgml
M doc/src/sgml/ref/create_procedure.sgml
M doc/src/sgml/xfunc.sgml
Validate the OID argument of pg_import_system_collations().
commit : ea42ccbced4baeff9df9be0cb8ec3e4d42070089
author : Tom Lane <[email protected]>
date : Mon, 8 Mar 2021 18:21:51 -0500
committer: Tom Lane <[email protected]>
date : Mon, 8 Mar 2021 18:21:51 -0500
"SELECT pg_import_system_collations(0)" caused an assertion failure.
With a random nonzero argument --- or indeed with zero, in non-assert
builds --- it would happily make pg_collation entries with garbage
values of collnamespace. These are harmless as far as I can tell
(unless maybe the OID happens to become used for a schema, later on?).
In any case this isn't a security issue, since the function is
superuser-only. But it seems like a gotcha for unwary DBAs, so let's
add a check that the given OID belongs to some schema.
Back-patch to v10 where this function was introduced.
M src/backend/commands/collationcmds.c
Clarify the usage of max_replication_slots on the subscriber side.
commit : 25b13721d41de3d74771f02b9827aac66bc97d33
author : Amit Kapila <[email protected]>
date : Wed, 3 Mar 2021 10:32:43 +0530
committer: Amit Kapila <[email protected]>
date : Wed, 3 Mar 2021 10:32:43 +0530
It was not clear in the docs that the max_replication_slots is also used
to track replication origins on the subscriber side.
Author: Paul Martinez
Reviewed-by: Amit Kapila
Backpatch-through: 10 where logical replication was introduced
Discussion: https://postgr.es/m/CACqFVBZgwCN_pHnW6dMNCrOS7tiHCw6Retf_=U2Vvj3aUSeATw@mail.gmail.com
M doc/src/sgml/config.sgml
M doc/src/sgml/logical-replication.sgml
Use native path separators to pg_ctl in initdb
commit : ae1c1d84ea2465a25bc2f20b9c22d0c5779c5b08
author : Alvaro Herrera <[email protected]>
date : Tue, 2 Mar 2021 15:39:34 -0300
committer: Alvaro Herrera <[email protected]>
date : Tue, 2 Mar 2021 15:39:34 -0300
On Windows, CMD.EXE allegedly does not run a command that uses forward slashes,
so let's convert the path to use backslashes instead.
Backpatch to 10.
Author: Nitin Jadhav <[email protected]>
Reviewed-by: Juan José Santamaría Flecha <[email protected]>
Discussion: https://postgr.es/m/CAMm1aWaNDuaPYFYMAqDeJrZmPtNvLcJRS++CcZWY8LT6KcoBZw@mail.gmail.com
M src/bin/initdb/initdb.c
Fix use-after-free bug with AfterTriggersTableData.storeslot
commit : d1c6edd31d6c3e6d173d47a64a3b28660705def7
author : Alvaro Herrera <[email protected]>
date : Sat, 27 Feb 2021 18:09:15 -0300
committer: Alvaro Herrera <[email protected]>
date : Sat, 27 Feb 2021 18:09:15 -0300
AfterTriggerSaveEvent() wrongly allocates the slot in execution-span
memory context, whereas the correct thing is to allocate it in
a transaction-span context, because that's where the enclosing
AfterTriggersTableData instance belongs into.
Backpatch to 12 (the test back to 11, where it works well with no code
changes, and it's good to have to confirm that the case was previously
well supported); this bug seems introduced by commit ff11e7f4b9ae.
Reported-by: Bertrand Drouvot <[email protected]>
Author: Amit Langote <[email protected]>
Discussion: https://postgr.es/m/[email protected]
M src/test/regress/expected/triggers.out
M src/test/regress/sql/triggers.sql
Doc: further clarify libpq's description of connection string URIs.
commit : de19e5e0ca2f8cbffef8bc8d40df509fc918f4f9
author : Tom Lane <[email protected]>
date : Fri, 26 Feb 2021 15:24:01 -0500
committer: Tom Lane <[email protected]>
date : Fri, 26 Feb 2021 15:24:01 -0500
Break the synopsis into named parts to make it less confusing.
Make more than zero effort at applying SGML markup. Do a bit
of copy-editing of nearby text.
The synopsis revision is by Alvaro Herrera and Paul Förster,
the rest is my fault. Back-patch to v10 where multi-host
connection strings appeared.
Discussion: https://postgr.es/m/[email protected]
M doc/src/sgml/libpq.sgml
Fix some typos, grammar and style in docs and comments
commit : 70dc2385f9a20c8d397a244b5237831790d8e2a6
author : Michael Paquier <[email protected]>
date : Wed, 24 Feb 2021 16:14:03 +0900
committer: Michael Paquier <[email protected]>
date : Wed, 24 Feb 2021 16:14:03 +0900
The portions fixing the documentation are backpatched where needed.
Author: Justin Pryzby
Discussion: https://postgr.es/m/[email protected]
backpatch-through: 9.6
M doc/src/sgml/charset.sgml
M doc/src/sgml/pageinspect.sgml
M doc/src/sgml/protocol.sgml
M doc/src/sgml/ref/create_type.sgml
M doc/src/sgml/ref/drop_index.sgml
M doc/src/sgml/rules.sgml
Reinstate HEAP_XMAX_LOCK_ONLY|HEAP_KEYS_UPDATED as allowed
commit : 2583917075ae9fc40d29c679867367db68be004b
author : Alvaro Herrera <[email protected]>
date : Tue, 23 Feb 2021 17:30:21 -0300
committer: Alvaro Herrera <[email protected]>
date : Tue, 23 Feb 2021 17:30:21 -0300
Commit 866e24d47db1 added an assert that HEAP_XMAX_LOCK_ONLY and
HEAP_KEYS_UPDATED cannot appear together, on the faulty assumption that
the latter necessarily referred to an update and not a tuple lock; but
that's wrong, because SELECT FOR UPDATE can use precisely that
combination, as evidenced by the amcheck test case added here.
Remove the Assert(), and also patch amcheck's verify_heapam.c to not
complain if the combination is found. Also, out of overabundance of
caution, update (across all branches) README.tuplock to be more explicit
about this.
Author: Julien Rouhaud <[email protected]>
Reviewed-by: Mahendra Singh Thalor <[email protected]>
Reviewed-by: Dilip Kumar <[email protected]>
Discussion: https://postgr.es/m/20210124061758.GA11756@nol
M src/backend/access/heap/README.tuplock
Fix another ancient bug in parsing of BRE-mode regular expressions.
commit : 6e6fecf495386e8aebfdc71ad6998eceb9da45e3
author : Tom Lane <[email protected]>
date : Thu, 18 Feb 2021 22:38:55 -0500
committer: Tom Lane <[email protected]>
date : Thu, 18 Feb 2021 22:38:55 -0500
While poking at the regex code, I happened to notice that the bug
squashed in commit afcc8772e had a sibling: next() failed to return
a specific value associated with the '}' token for a "\{m,n\}"
quantifier when parsing in basic RE mode. Again, this could result
in treating the quantifier as non-greedy, which it never should be in
basic mode. For that to happen, the last character before "\}" that
sets "nextvalue" would have to set it to zero, or it'd have to have
accidentally been zero from the start. The failure can be provoked
repeatably with, for example, a bound ending in digit "0".
Like the previous patch, back-patch all the way.
M src/backend/regex/regc_lex.c
Fix typo
commit : 5d319ce86f13d1b0e7fb911408fe012723259723
author : Magnus Hagander <[email protected]>
date : Wed, 17 Feb 2021 13:53:26 +0100
committer: Magnus Hagander <[email protected]>
date : Wed, 17 Feb 2021 13:53:26 +0100
Author: Daniel Gustafsson <[email protected]>
Discussion: https://postgr.es/m/[email protected]
M doc/src/sgml/ref/create_table.sgml
Make ExecGetInsertedCols() and friends more robust and improve comments.
commit : 6e437ce5a6b64c443cf7c907db0988bf571e6042
author : Heikki Linnakangas <[email protected]>
date : Mon, 15 Feb 2021 09:28:08 +0200
committer: Heikki Linnakangas <[email protected]>
date : Mon, 15 Feb 2021 09:28:08 +0200
If ExecGetInsertedCols(), ExecGetUpdatedCols() or ExecGetExtraUpdatedCols()
were called with a ResultRelInfo that's not in the range table and isn't a
partition routing target, the functions would dereference a NULL pointer,
relinfo->ri_RootResultRelInfo. Such ResultRelInfos are created when firing
RI triggers in tables that are not modified directly. None of the current
callers of these functions pass such relations, so this isn't a live bug,
but let's make them more robust.
Also update comment in ResultRelInfo; after commit 6214e2b228,
ri_RangeTableIndex is zero for ResultRelInfos created for partition tuple
routing.
Noted by Coverity. Backpatch down to v11, like commit 6214e2b228.
Reviewed-by: Tom Lane, Amit Langote
M src/backend/executor/execUtils.c
Default to wal_sync_method=fdatasync on FreeBSD.
commit : 1fefe8879a684666fee8353bef99e8c3e6f15901
author : Thomas Munro <[email protected]>
date : Mon, 15 Feb 2021 15:43:39 +1300
committer: Thomas Munro <[email protected]>
date : Mon, 15 Feb 2021 15:43:39 +1300
FreeBSD 13 gained O_DSYNC, which would normally cause wal_sync_method to
choose open_datasync as its default value. That may not be a good
choice for all systems, and performs worse than fdatasync in some
scenarios. Let's preserve the existing default behavior for now.
Like commit 576477e73c4, which did the same for Linux, back-patch to all
supported releases.
Discussion: https://postgr.es/m/CA%2BhUKGLsAMXBQrCxCXoW-JsUYmdOL8ALYvaX%3DCrHqWxm-nWbGA%40mail.gmail.com
M doc/src/sgml/config.sgml
M src/backend/utils/misc/postgresql.conf.sample
M src/include/port/freebsd.h
Hold interrupts while running dsm_detach() callbacks.
commit : acafdd9ed5f05742730ee666abf49b89e8a125ad
author : Thomas Munro <[email protected]>
date : Mon, 15 Feb 2021 13:32:58 +1300
committer: Thomas Munro <[email protected]>
date : Mon, 15 Feb 2021 13:32:58 +1300
While cleaning up after a parallel query or parallel index creation that
created temporary files, we could be interrupted by a statement timeout.
The error handling path would then fail to clean up the files when it
ran dsm_detach() again, because the callback was already popped off the
list. Prevent this hazard by holding interrupts while the cleanup code
runs.
Thanks to Heikki Linnakangas for this suggestion, and also to Kyotaro
Horiguchi, Masahiko Sawada, Justin Pryzby and Tom Lane for discussion of
this and earlier ideas on how to fix the problem.
Back-patch to all supported releases.
Reported-by: Justin Pryzby <[email protected]>
Discussion: https://postgr.es/m/[email protected]
M src/backend/storage/ipc/dsm.c
pg_attribute_no_sanitize_alignment() macro
commit : 22001684623bd95b4e1d5c21854f222a37b13267
author : Tom Lane <[email protected]>
date : Sat, 13 Feb 2021 17:49:08 -0500
committer: Tom Lane <[email protected]>
date : Sat, 13 Feb 2021 17:49:08 -0500
Modern gcc and clang compilers offer alignment sanitizers, which help to detect
pointer misalignment. However, our codebase already contains x86-specific
crc32 computation code, which uses unalignment access. Thankfully, those
compilers also support the attribute, which disables alignment sanitizers at
the function level. This commit adds pg_attribute_no_sanitize_alignment(),
which wraps this attribute, and applies it to pg_comp_crc32c_sse42() function.
Back-patch of commits 993bdb9f9 and ad2ad698a, to enable doing
alignment testing in all supported branches.
Discussion: https://postgr.es/m/CAPpHfdsne3%3DT%3DfMNU45PtxdhSL_J2PjLTeS8rwKnJzUR4YNd4w%40mail.gmail.com
Discussion: https://postgr.es/m/475514.1612745257%40sss.pgh.pa.us
Author: Alexander Korotkov, revised by Tom Lane
Reviewed-by: Tom Lane
M src/include/c.h
M src/port/pg_crc32c_sse42.c
Avoid divide-by-zero in regex_selectivity() with long fixed prefix.
commit : a28df6fa3041523f9a96cf0d3c3929f8bdc7c797
author : Tom Lane <[email protected]>
date : Fri, 12 Feb 2021 16:26:47 -0500
committer: Tom Lane <[email protected]>
date : Fri, 12 Feb 2021 16:26:47 -0500
Given a regex pattern with a very long fixed prefix (approaching 500
characters), the result of pow(FIXED_CHAR_SEL, fixed_prefix_len) can
underflow to zero. Typically the preceding selectivity calculation
would have underflowed as well, so that we compute 0/0 and get NaN.
In released branches this leads to an assertion failure later on.
That doesn't happen in HEAD, for reasons I've not explored yet,
but it's surely still a bug.
To fix, just skip the division when the pow() result is zero, so
that we'll (most likely) return a zero selectivity estimate. In
the edge cases where "sel" didn't yet underflow, perhaps this
isn't desirable, but I'm not sure that the case is worth spending
a lot of effort on. The results of regex_selectivity_sub() are
barely worth the electrons they're written on anyway :-(
Per report from Alexander Lakhin. Back-patch to all supported versions.
Discussion: https://postgr.es/m/[email protected]
M src/backend/utils/adt/selfuncs.c