PostgreSQL 15.0 (upcoming) commit log

commit   : bdf9b60085bca2dbb0af920d50f1a0917dda0cbb    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Tue, 4 Oct 2022 15:39:41 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Tue, 4 Oct 2022 15:39:41 +0900    

s/ERROR_HANDLING/ERROR_HANDLING_OPTIONS/.  
  
Author: Peter Smith  
Discussion: https://postgr.es/m/CAHut+PtDj3CV+f0pVisc0XYMi2LHGBpQxQWtF0FjiSVN_nV17Q@mail.gmail.com  

commit   : c42cd05c586235fa9e84fb4a3682286cf551df0e    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Tue, 4 Oct 2022 13:16:23 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Tue, 4 Oct 2022 13:16:23 +0900    

This cleans up a couple of areas:  
- Remove XLogSegNo calculation for the last WAL segment in backup in  
xlog.c (7d70809 has moved this logic entirely to xlogbackup.c when  
building the contents of the backup history file).  
- Remove check on log_min_duration in analyze.c, as it is already true  
where this code path is reached.  
- Simplify call to find_option() in guc.c.  
  
Author: Ranier Vilela  
Reviewed-by: Masahiko Sawada  
Discussion: https://postgr.es/m/CAEudQArCDQQiPiFR16=yu9k5s2tp4tgEe1U1ZbkW4ofx81AWWQ@mail.gmail.com  

commit   : 62be9e4cdc1d59dd6c9c268c7419d7d4f1016124    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Tue, 4 Oct 2022 10:11:08 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Tue, 4 Oct 2022 10:11:08 +0900    

This commit expands the TAP tests of pg_upgrade when running these with  
different major versions for the "old" cluster (to-be-upgraded) and the  
"new" cluster (upgraded-to), by backporting some of the buildfarm  
facilities directory into the script:  
- Remove comments from the dump files, avoiding version-dependent  
information.  
- Remove empty lines from the dump files.  
- Use --extra-float-digits=0 in the pg_dump command, when using an "old"  
cluster with version equal to or lower than v11.  
- Use --wal-segsize and --allow-group-access in initdb only when the  
"old" cluster is equal to or higher than v11.  
  
This allows the tests to pass down to v14 with the main regression test  
suite, while v9.5~13 still generate some diffs, but these are minimal  
compared to what happened before this commit.  Much more could be done,  
especially around dump differences with function and procedures (these  
can also be avoided with direct manipulation of the dumps loaded, for  
example, in a way similar to the buildfarm), but at least the basics are  
in place now.  
  
Reviewed-by: Justin Pryzby, Anton A. Melnikov  
Discussion: https://postgr.es/m/Yox1ME99GhAemMq1@paquier.xyz  

commit   : 908e17151b4834bd4bbfb703e206b68f5db341f9    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Mon, 3 Oct 2022 14:52:51 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Mon, 3 Oct 2022 14:52:51 -0700    

Otherwise we don't use LLVM's flags when building llvmjit_wrap.cpp and  
llvmjit_inline.cpp. That can cause compile time failures if the C++ compiler  
doesn't default to a new enough C++ standards version and link time failures  
due to ABI influencing flags like -fno-rtti.  

commit   : 4a79fd1a754edcc85f9b94f17a2fb4576becf0a3    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 3 Oct 2022 15:07:10 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 3 Oct 2022 15:07:10 -0400    

The pre-v15 behavior was to discard all but the last result,  
but with the new behavior of printing all results by default,  
we will send each such result to the \g file.  However,  
we're still opening and closing the \g file for each result,  
so you lose all but the last result anyway.  Move the output-file  
state up to ExecQueryAndProcessResults so that we open/close the  
\g file only once per command string.  
  
To support this without changing other behavior, we must  
adjust PrintQueryResult to have separate FILE * arguments  
for query and status output (since status output has never  
gone to the \g file).  That in turn makes it a good idea  
to push the responsibility for fflush'ing output down to  
PrintQueryTuples and PrintQueryStatus.  
  
Also fix an infinite loop if COPY IN/OUT is attempted in \watch.  
We used to reject that, but that error exit path got broken  
somewhere along the line in v15.  There seems no real reason  
to reject it anyway as the code now stands, so just remove  
the error exit and make sure that COPY OUT data goes to the  
right place.  
  
Also remove PrintQueryResult's unused is_watch parameter,  
and make some other cosmetic cleanups (adjust obsolete  
comments, break some overly-long lines).  
  
Daniel Vérité and Tom Lane  
  
Discussion: https://postgr.es/m/4333844c-2244-4d6e-a49a-1d483fbe304f@manitou-mail.org  

commit   : 0ae5db28d06939d1a2ac52813629be0dfc77010e    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Mon, 3 Oct 2022 10:13:12 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Mon, 3 Oct 2022 10:13:12 -0700    

I noticed during some manual testing that -Dldap=disabled (or  
--auto-features=disabled) doesn't disable ldap if available - that's obviously  
wrong.  

commit   : f4c7c410ee4a7baa06f51ebb8d5333c169691dd3    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 3 Oct 2022 10:56:16 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 3 Oct 2022 10:56:16 -0400    

This reverts commit db0d67db2401eb6238ccc04c6407a4fd4f985832 and  
several follow-on fixes.  The idea of making a cost-based choice  
of the order of the sorting columns is not fundamentally unsound,  
but it requires cost information and data statistics that we don't  
really have.  For example, relying on procost to distinguish the  
relative costs of different sort comparators is pretty pointless  
so long as most such comparator functions are labeled with cost 1.0.  
Moreover, estimating the number of comparisons done by Quicksort  
requires more than just an estimate of the number of distinct values  
in the input: you also need some idea of the sizes of the larger  
groups, if you want an estimate that's good to better than a factor of  
three or so.  That's data that's often unknown or not very reliable.  
Worse, to arrive at estimates of the number of calls made to the  
lower-order-column comparison functions, the code needs to make  
estimates of the numbers of distinct values of multiple columns,  
which are necessarily even less trustworthy than per-column stats.  
Even if all the inputs are perfectly reliable, the cost algorithm  
as-implemented cannot offer useful information about how to order  
sorting columns beyond the point at which the average group size  
is estimated to drop to 1.  
  
Close inspection of the code added by db0d67db2 shows that there  
are also multiple small bugs.  These could have been fixed, but  
there's not much point if we don't trust the estimates to be  
accurate in-principle.  
  
Finally, the changes in cost_sort's behavior made for very large  
changes (often a factor of 2 or so) in the cost estimates for all  
sorting operations, not only those for multi-column GROUP BY.  
That naturally changes plan choices in many situations, and there's  
precious little evidence to show that the changes are for the better.  
Given the above doubts about whether the new estimates are really  
trustworthy, it's hard to summon much confidence that these changes  
are better on the average.  
  
Since we're hard up against the release deadline for v15, let's  
revert these changes for now.  We can always try again later.  
  
Note: in v15, I left T_PathKeyInfo in place in nodes.h even though  
it's unreferenced.  Removing it would be an ABI break, and it seems  
a bit late in the release cycle for that.  
  
Discussion: https://postgr.es/m/TYAPR01MB586665EB5FB2C3807E893941F5579@TYAPR01MB5866.jpnprd01.prod.outlook.com  

commit   : f60eb3f2827db292edf71bb7296fbdf5958ace3d    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Mon, 3 Oct 2022 16:42:25 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Mon, 3 Oct 2022 16:42:25 +0900    

This commit introduces an authentication test for the peer method, as of  
a set of scenarios with and without a user name map.  The script is  
automatically skipped if peer is not supported in the environment where  
this test is run, checking this behavior by attempting a connection  
first on a cluster up and running.  
  
Author: Bertrand Drouvot  
Discussion: https://postgr.es/m/aa60994b-1c66-ca7a-dab9-9a200dbac3d2@amazon.com  

commit   : 89d16b63527d078ae611b0af1241258ffa1f460b    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Sat, 1 Oct 2022 17:04:13 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Sat, 1 Oct 2022 17:04:13 -0700    

Increase likelihood of discovering problems during CI rather the buildfarm by  
defining -DRELCACHE_FORCE_RELEASE -DCOPY_PARSE_PLAN_TREES  
-DWRITE_READ_PARSE_PLAN_TREES -DRAW_EXPRESSION_COVERAGE_TEST on FreeBSD, and  
-DRANDOMIZE_ALLOCATED_MEMORY on macOS.  
  
FreeBSD and macoS are currently not CI bottlenecks, so we can afford to  
increase their test times a bit.  
  
Author: Justin Pryzby <pryzbyj@telsasoft.com>  
Discussion: https://postgr.es/m/20220910200542.GX31833@telsasoft.com  

commit   : 2d2f08310490d63c4cc097243ba63a1601316c17    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Sat, 1 Oct 2022 16:55:16 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Sat, 1 Oct 2022 16:55:16 -0700    

Test performance regresses noticably when using all cores. This is more  
pronounced with meson than with autoconf, presumably because meson will  
schedule the "full number" of tests more consistently.  8 seems to work  
OK.  
  
Discussion: https://postgr.es/m/20220927040208.l3shfcidovpzqxfh@awork3.anarazel.de  
Backpatch: 15-, where CI was introduced  

commit   : 1360943d1ac03240fc719a459aed4ad4f9f9b5d4    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Sat, 1 Oct 2022 12:39:12 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Sat, 1 Oct 2022 12:39:12 -0700    

autoconf set PREFIX to /usr/local/pgsql, so using the same default for meson  
makes sense. The effect on windows is that installation defaults to installing  
to C:/usr/local/pgsql rather than meson's default of C:/, which doesn't seem  
perfect, but OK enough.  
  
Signed-off-by: Junwang Zhao <zhjwpku@gmail.com>  
Author: Junwang Zhao <zhjwpku@gmail.com>  
Discussion: https://postgr.es/CAEG8a3LGWE-gG6vuddmH91RORhi8gWs0mMB-hcTmP3_NVgM7dg@mail.gmail.com  

commit   : d0366bfb3b211b26a997a4220757392a0c153d8d    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Sat, 1 Oct 2022 12:39:12 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Sat, 1 Oct 2022 12:39:12 -0700    

Previously some paths (like c:\ or d:/) worked, but plenty others (like  
/path/to or //computer/share/path) didn't. As we'd like to change the default  
prefix to /usr/local/pgsql, that's a problem.  
  
Instead of trying to do this in meson.build, call out to the implementation  
meson install uses. This isn't pretty, but it's more reliable than what we had  
before.  
  
Discussion: https://postgr.es/CAEG8a3LGWE-gG6vuddmH91RORhi8gWs0mMB-hcTmP3_NVgM7dg@mail.gmail.com  

commit   : a9d58bfe8a3ae2254e1553ab76974feeaafa0133    
  
author   : Peter Eisentraut <peter@eisentraut.org>    
date     : Sat, 1 Oct 2022 12:48:24 +0200    
  
committer: Peter Eisentraut <peter@eisentraut.org>    
date     : Sat, 1 Oct 2022 12:48:24 +0200    

Both check_application_name() and check_cluster_name() use  
pg_clean_ascii() but didn't release the memory.  Depending on when the  
GUC is set, this might be cleaned up at some later time or it would  
leak postmaster memory once.  In any case, it seems better not to have  
to rely on such analysis and make the code locally robust.  Also, this  
makes Valgrind happier.  
  
Author: Masahiko Sawada <sawada.mshk@gmail.com>  
Reviewed-by: Jacob Champion <jchampion@timescale.com>  
Discussion: https://www.postgresql.org/message-id/CAD21AoBmFNy9MPfA0UUbMubQqH3AaK5U3mrv6pSeWrwCk3LJ8g@mail.gmail.com  

commit   : 83e42a0035718914efad2fe04080fd6c579e9ef2    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Sat, 1 Oct 2022 15:28:02 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Sat, 1 Oct 2022 15:28:02 +0900    

This fixes some areas related to logical replication and custom RMGRs.  
  
Author: Ekaterina Kiryanova  
Discussion: https://postgr.es/m/fa4773f1-1396-384a-bcd7-85b5e013f399@postgrespro.ru  
Backpatch-through: 15  

commit   : 24ef127b6d1f268ca09f4c501b4655e914329c5a    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Wed, 28 Sep 2022 10:19:00 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Wed, 28 Sep 2022 10:19:00 -0700    

I hadn't ported -Wl,--disable-auto-import over from the win32 template as I  
had focused on msvc for windows. The flag is desirable as it makes it easier  
to find problems one would have with msvc, particularly useful during cross  
compilation.  
  
This turned out to be a somewhat happy accident, as it allowed me to realize  
that readline actually works on windows these days, as long as auto imports to  
enable. Therefore enable auto-import again as part of linking to readline.  
  
We perhaps can come up with a better solution for the readline issue, but this  
seems good enough for now.  
  
Discussion: http://postgr.es/m/20220928022724.erzuk5v4ai4b53do@awork3.anarazel.de  

commit   : 2dc2e4e31adb71502074c8c2bf9e0766347aa6e5    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 30 Sep 2022 19:36:46 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 30 Sep 2022 19:36:46 -0400    

Commit 34f581c39 intended to ensure that RelationGetBufferForTuple  
would acquire a visibility-map page pin in case the otherBuffer's  
all-visible bit had become set since we last had lock on that page.  
But I missed a case: when we're extending the relation, VM concerns  
were dealt with only in the relatively-less-likely case that we  
fail to conditionally lock the otherBuffer.  I think I'd believed  
that we couldn't need to worry about it if the conditional lock  
succeeds, which is true for the target buffer; but the otherBuffer  
was unlocked for awhile so its bit might be set anyway.  So we need  
to do the GetVisibilityMapPins dance, and then also recheck the  
page's free space, in both cases.  
  
Per report from Jaime Casanova.  Back-patch to v12 as the previous  
patch was (although there's still no evidence that the bug is  
reachable pre-v14).  
  
Discussion: https://postgr.es/m/E1lWLjP-00006Y-Ml@gemulon.postgresql.org  

commit   : 0e497eadb1f4028b147b5c58dc08cea7e73675e1    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Wed, 28 Sep 2022 10:16:49 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Wed, 28 Sep 2022 10:16:49 -0700    

While mingw would otherwise fall back to  
__attribute__((visibility("default"))), that appears to only work as long as  
no symbols are declared with __declspec(dllexport). But we can end up with  
some, e.g. plpython's Py_Init.  
  
It's quite possible we should do the same for cygwin, but I don't have a test  
environment for that...  
  
Discussion: http://postgr.es/m/20220928022724.erzuk5v4ai4b53do@awork3.anarazel.de  
Discussion: http://postgr.es/m/20220928025242.ugf7t5ugxxgmkraa@awork3.anarazel.de  

commit   : 4e4f7b9fcc9ad0b023b6e698e978882d022b94c4    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 30 Sep 2022 10:26:47 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 30 Sep 2022 10:26:47 -0400    

Currently, PQsslAttributeNames() returns the same list of attribute  
names regardless of its conn parameter.  This patch changes it to  
have behavior parallel to what 80a05679d installed for PQsslAttribute:  
you get OpenSSL's attributes if conn is NULL or is an SSL-encrypted  
connection, or an empty list if conn is a non-encrypted connection.  
The point of this is to have sensible connection-dependent behavior  
in case we ever support multiple SSL libraries.  The behavior for  
NULL can be defined as "the attributes for the default SSL library",  
parallel to what PQsslAttribute(NULL, "library") does.  
  
Since this is mostly just future-proofing, no back-patch.  
  
Discussion: https://postgr.es/m/17625-fc47c78b7d71b534@postgresql.org  

commit   : 69298db8e1a5a7afcfeea32daf71e713a109ef93    
  
author   : Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Fri, 30 Sep 2022 12:53:31 +0200    
  
committer: Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Fri, 30 Sep 2022 12:53:31 +0200    

I (Álvaro) broke tab-completion for GRANT .. ALL TABLES IN SCHEMA while  
removing ALL from the publication syntax for schemas in the  
aforementioned commit.  I also missed to update a bunch of  
tab-completion rules for ALTER/CREATE PUBLICATION that match each  
individual piece of ALL TABLES IN SCHEMA.  Repair those bugs.  
  
While fixing up that commit, update a couple of outdated comments  
related to the same change.  
  
Backpatch to 15.  
  
Author: Shi yu <shiy.fnst@fujitsu.com>  
Reviewed-by: Peter Smith <smithpb2250@gmail.com>  
Discussion: https://postgr.es/m/OSZPR01MB6310FCE8609185A56344EED2FD559@OSZPR01MB6310.jpnprd01.prod.outlook.com  

commit   : 51fd7cdfd07d49223c82f8bbdf37866c81c62908    
  
author   : Daniel Gustafsson <dgustafsson@postgresql.org>    
date     : Fri, 30 Sep 2022 12:03:48 +0200    
  
committer: Daniel Gustafsson <dgustafsson@postgresql.org>    
date     : Fri, 30 Sep 2022 12:03:48 +0200    

The compression parameter to PQsslAttribute has never returned the  
compression method used, it has always returned "on" or "off since  
it was added in commit 91fa7b4719ac. Backpatch through v10.  
  
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>  
Discussion: https://postgr.es/m/B9EC60EC-F665-47E8-A221-398C76E382C9@yesql.se  
Backpatch-through: v10  

commit   : 65b158ae4e892c2da7a5e31e2d2645e5e79a0bfd    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Fri, 30 Sep 2022 15:57:47 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Fri, 30 Sep 2022 15:57:47 +0900    

The last caller of UnpinBuffer() that did not want to adjust  
CurrentResourceOwner was removed in 2d115e4, and nothing has been  
introduced in bufmgr.c to do the same thing since.  This simplifies 10  
code paths.  
  
Author: Aleksander Alekseev  
Reviewed-by: Nathan Bossart, Zhang Mingli, Bharath Rupireddy  
Discussion: https://postgr.es/m/CAJ7c6TOmmFpb6ohurLhTC7hKNJWGzdwf8s4EAtAZxD48g-e6Jw@mail.gmail.com  

commit   : ccf36ea2580f66abbc37f27d8c296861ffaad9bf    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Thu, 29 Sep 2022 16:09:09 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Thu, 29 Sep 2022 16:09:09 -0700    

It's easy enough to make changes that break on 32bit platforms and few people  
test that locally. Add a test for that to CI. LLVM is disabled on 32bit  
because installing it would bloat the image size further.  
  
The debian w/ meson task is fast enough that we can afford to test both.  
  
Use the occasion of a separate run of the tests to run them under LANG=C,  
we've recently discovered there's not a lot of testing in the buildfarm for  
the case.  
  
Discussion: https://postgr.es/m/4033181.1664395633@sss.pgh.pa.us  

commit   : 80a05679d5a400b8f995740c175f8bdb060bb05c    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 29 Sep 2022 17:28:09 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 29 Sep 2022 17:28:09 -0400    

Commit ebc8b7d44 intended to change the behavior of  
PQsslAttribute(NULL, "library"), but accidentally also changed  
what happens with a non-NULL conn pointer.  Undo that so that  
only the intended behavior change happens.  Clarify some  
associated documentation.  
  
Per bug #17625 from Heath Lord.  Back-patch to v15.  
  
Discussion: https://postgr.es/m/17625-fc47c78b7d71b534@postgresql.org  

commit   : 551aa6b7b9f3b78e7b6cbab1fea70947fa7f4966    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 29 Sep 2022 13:27:48 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 29 Sep 2022 13:27:48 -0400    

The one about "terminating process to release replication slot" told  
you nothing about why that was happening.  The one about "invalidating  
slot because its restart_lsn exceeds max_slot_wal_keep_size" told you  
what was happening, but violated our message style guideline about  
keeping the primary message short.  Add DETAIL/HINT lines to carry  
the appropriate detail and make the two cases more uniform.  
  
While here, fix bogus test logic in 019_replslot_limit.pl: if it timed  
out without seeing the expected log message, no test failure would be  
reported.  This is flat broken since commit 549ec201d removed the test  
counts; even before that it was horribly bad style, since you'd only  
get told that not all tests had been run.  
  
Kyotaro Horiguchi, reviewed by Bertrand Drouvot; test fixes by me  
  
Discussion: https://postgr.es/m/20211214.130456.2233153190058148084.horikyota.ntt@gmail.com  

commit   : d7e39d72ca1c6f188b400d7d58813ff5b5b79064    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 29 Sep 2022 12:14:39 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 29 Sep 2022 12:14:39 -0400    

Up to now, the ID values returned by pg_stat_get_backend_idset() and  
used by pg_stat_get_backend_activity() and allied functions were just  
indexes into a local array of sessions seen by the last stats refresh.  
This is problematic for a few reasons.  The "ID" of a session can vary  
over its existence, which is surprising.  Also, while these numbers  
often match the "backend ID" used for purposes like temp schema  
assignment, that isn't reliably true.  We can fairly cheaply switch  
things around to make these numbers actually be the sessions' backend  
IDs.  The added test case illustrates that with this definition, the  
temp schema used by a given session can be obtained given its PID.  
  
While here, delete some dead code that guarded against getting  
a NULL return from pgstat_fetch_stat_local_beentry().  That can't  
happen as long as the caller is careful to pass an in-range array  
index, as all the callers are.  (This code may not have been dead  
when written, but it surely is now.)  
  
Nathan Bossart  
  
Discussion: https://postgr.es/m/20220815205811.GA250990@nathanxps13  

commit   : d5e3fe682ac327ae2c0682a931f95e946ae13487    
  
author   : Etsuro Fujita <efujita@postgresql.org>    
date     : Thu, 29 Sep 2022 16:55:00 +0900    
  
committer: Etsuro Fujita <efujita@postgresql.org>    
date     : Thu, 29 Sep 2022 16:55:00 +0900    

Remove the stale text that is a leftover from an earlier version of the  
patch to add support for batch insertion, and adjust the wording in the  
remaining text.  
  
Back-patch to v14 where batch insertion came in.  
  
Review and wording adjustment by Tom Lane.  
  
Discussion: https://postgr.es/m/CAPmGK14goatHPHQv2Aeu_UTKqZ%2BBO%2BP%2Bzd3HKv5D%2BdyyfWKDSw%40mail.gmail.com  

commit   : 0823d061b0b7f1e20fbfd48bef3c2e093493dbd4    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Thu, 29 Sep 2022 15:05:40 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Thu, 29 Sep 2022 15:05:40 +0900    

SYSTEM_USER is a reserved keyword of the SQL specification that,  
roughly described, is aimed at reporting some information about the  
system user who has connected to the database server.  It may include  
implementation-specific information about the means by the user  
connected, like an authentication method.  
  
This commit implements SYSTEM_USER as of auth_method:identity, where  
"auth_method" is a keyword about the authentication method used to log  
into the server (like peer, md5, scram-sha-256, gss, etc.) and  
"identity" is the authentication identity as introduced by 9afffcb (peer  
sets authn to the OS user name, gss to the user principal, etc.).  This  
format has been suggested by Tom Lane.  
  
Note that thanks to d951052, SYSTEM_USER is available to parallel  
workers.  
  
Bump catalog version.  
  
Author: Bertrand Drouvot  
Reviewed-by: Jacob Champion, Joe Conway, Álvaro Herrera, Michael Paquier  
Discussion: https://postgr.es/m/7e692b8c-0b11-45db-1cad-3afc5b57409f@amazon.com  

commit   : 5ac9e869191148741539e626b84ba7e77dc71670    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Thu, 29 Sep 2022 14:28:13 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Thu, 29 Sep 2022 14:28:13 +0900    

This is a continuation of 78fdb1e, where this flag is set in the psql  
callback handler used for SIGINT.  This was previously a boolean but the  
C standard recommends the use of sig_atomic_t.  Note that this  
influences PromptInterruptContext in string.h, where the same flag is  
tracked.  
  
Author: Hayato Kuroda  
Discussion: https://postgr.es/m/TYAPR01MB58669A9EC96AA3078C2CD938F5549@TYAPR01MB5866.jpnprd01.prod.outlook.com  

commit   : b8d8a4593a3a2daa5e16e4a3634d9284fe14667f    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Wed, 28 Sep 2022 21:59:15 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Wed, 28 Sep 2022 21:59:15 -0700    

We'd like to use precompiled headers on windows to reduce compile times. Right  
now we rely on defining UMDF_USING_NTSTATUS before including postgres.h in a few  
select places - which doesn't work with precompiled headers.  Instead define  
it globally.  
  
When UMDF_USING_NTSTATUS is defined we need to explicitly include ntstatus.h,  
winternl.h to get a comparable set of symbols. Right now these includes would  
be required in a number of non-platform-specific .c files - to avoid that,  
include them in win32_port.h. Based on my measurements that doesn't increase  
compile times measurably.  
  
Reviewed-by: Thomas Munro <thomas.munro@gmail.com>  
Discussion: https://postgr.es/m/20220927011951.j3h4o7n6bhf7dwau@awork3.anarazel.de  

commit   : a1b3bca1c8e32c31ba1a8d1125b2eb97f750a7f0    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Wed, 28 Sep 2022 14:21:43 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Wed, 28 Sep 2022 14:21:43 -0700    

Not replacing getopt/getopt_long definitely causes issues on mingw. It's not  
as clear whether the solaris & openbsd aspect is still needed, but if not, we  
should remove it from both autoconf and meson.  
  
Discussion: http://postgr.es/m/20220928022724.erzuk5v4ai4b53do@awork3.anarazel.de  

commit   : caeeabd11066a360c8a9986581da320dd5aa09b9    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Wed, 28 Sep 2022 09:48:09 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Wed, 28 Sep 2022 09:48:09 -0700    

I didn't carry this forward from the win32 template. It's not needed anymore  
for the reason stated therein, but it turns out to be required to  
e.g. override getopt. Possibly a better solution exists, but that's for later.  
  
Discussion: http://postgr.es/m/20220928022724.erzuk5v4ai4b53do@awork3.anarazel.de  

commit   : dfefa0e46433a2c798281826f8501895f3fa2a71    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Tue, 27 Sep 2022 12:01:35 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Tue, 27 Sep 2022 12:01:35 -0700    

This doesn't end up with a triple that's exactly the same as config.guess -  
it'd be hard to achieve that and it doesn't seem required. We can't rely on  
config.guess as we don't necessarily have a /bin/sh on windows, e.g., when  
building on windows with msvc.  
  
This isn't perfect, e.g., clang works on windows as well.  But I suspect we'd  
need a bunch of other changes to make clang on windows work, and we haven't  
supported it historically.  
  
Discussion: http://postgr.es/m/20220928022724.erzuk5v4ai4b53do@awork3.anarazel.de  

commit   : e3a892539b2baabc1963c31605728bbbc8f8b89a    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Tue, 27 Sep 2022 11:55:00 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Tue, 27 Sep 2022 11:55:00 -0700    

This fixes a build issue on windows, when the prefix is set to a path with  
forward slashes. Windows python defaults to a path with a backslash, but mingw  
ucrt python defaults to a forward slash. This in turn lead to a wrong PATH set  
during tests, causing tests to fail.  
  
Reported-by: Melih Mutlu <m.melihmutlu@gmail.com>  
Discussion: http://postgr.es/m/20220928022724.erzuk5v4ai4b53do@awork3.anarazel.de  

commit   : 2beae72746e6b762cb335ec4fff87e5407b3096c    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Thu, 29 Sep 2022 10:14:47 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Thu, 29 Sep 2022 10:14:47 +0900    

This error can be reached when sending an incorrect file name to open()  
on Windows, resulting in a confusing errno reported.  This has been seen  
in the development of a different patch by the same author.  
  
Author: Bharath Rupireddy  
Discussion: https://postgr.es/m/CALj2ACWet-b8Juba0DiXwfGCyyOcohzwksahE5ebB9rcbLZKCQ@mail.gmail.com  

commit   : b6d8a60aba322678585ebe11dab072a37ac32905    
  
author   : Thomas Munro <tmunro@postgresql.org>    
date     : Thu, 29 Sep 2022 13:12:11 +1300    
  
committer: Thomas Munro <tmunro@postgresql.org>    
date     : Thu, 29 Sep 2022 13:12:11 +1300    

Commits cf112c12 and a0dc8271 were a little too hasty in getting rid of  
the pg_ prefixes where we use pread(), pwrite() and vectored variants.  
  
We dropped support for ancient Unixes where we needed to use lseek() to  
implement replacements for those, but it turns out that Windows also  
changes the current position even when you pass in an offset to  
ReadFile() and WriteFile() if the file handle is synchronous, despite  
its documentation saying otherwise.  
  
Switching to asynchronous file handles would fix that, but have other  
complications.  For now let's just put back the pg_ prefix and add some  
comments to highlight the non-standard side-effect, which we can now  
describe as Windows-only.  
  
Reported-by: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>  
Reviewed-by: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>  
Discussion: https://postgr.es/m/20220923202439.GA1156054%40nathanxps13  

commit   : 3a5817695a8360011864c1834f8a90ffdfc7f840    
  
author   : David Rowley <drowley@postgresql.org>    
date     : Thu, 29 Sep 2022 11:43:00 +1300    
  
committer: David Rowley <drowley@postgresql.org>    
date     : Thu, 29 Sep 2022 11:43:00 +1300    

91e9e89dc modified nodeSort.c so that it used datum sorts when the  
targetlist of the outer node contained only a single column.  That commit  
failed to recognise that the Datum returned by tuplesort_getdatum() must  
be pfree'd when the type is a byref type.  Ronan Dunklau did originally  
propose the patch with that restriction, but that, probably through my own  
fault, got lost during further development work.  
  
Due to the timing of this report (PG15 RC1 is almost out the door), let's  
just restrict the datum sort optimization to apply for byval types only.  
We might want to look harder into making this work for byref types in  
PG16.  
  
Reported-by: Önder Kalacı  
Diagnosis-by: Tom Lane  
Discussion: https://postgr.es/m/CACawEhVxe0ufR26UcqtU7GYGRuubq3p6ZWPGXL4cxy_uexpAAQ@mail.gmail.com  
Backpatch-through: 15, where 91e9e89dc was introduced.  

commit   : 2a66b9bfb74e522d64c066dabe4fddde0fe7425c    
  
author   : Bruce Momjian <bruce@momjian.us>    
date     : Wed, 28 Sep 2022 13:14:38 -0400    
  
committer: Bruce Momjian <bruce@momjian.us>    
date     : Wed, 28 Sep 2022 13:14:38 -0400    

Reported-by: Tom Lane  
  
Discussion: https://postgr.es/m/3976627.1662651004@sss.pgh.pa.us  
  
Backpatch-through: 10  

commit   : f77becbe5a99c9853b1ae7f22aa15babd01368b7    
  
author   : Bruce Momjian <bruce@momjian.us>    
date     : Wed, 28 Sep 2022 13:05:21 -0400    
  
committer: Bruce Momjian <bruce@momjian.us>    
date     : Wed, 28 Sep 2022 13:05:21 -0400    

doc revert of commit 1703726488.  Change was applied to irrelevant  
branches, and was not detailed enough to be helpful in relevant  
branches.  
  
Reported-by: Peter Eisentraut, Noah Misch  
  
Discussion: https://postgr.es/m/a2dc9de4-24fc-3222-87d3-0def8057d7d8@enterprisedb.com  
  
Backpatch-through: 10  

commit   : 0937f6d172921202e1b432e206e4c30775d564d8    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 28 Sep 2022 12:31:36 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 28 Sep 2022 12:31:36 -0400    

For some reason the "bpchar" type name was defined nowhere in  
our SGML docs, although several places refer to it in passing.  
Give it a proper mention under Character Types.  
  
While here, also provide an explanation of how the text and varchar  
types relate.  The previous wording seemed to be doing its best  
to sweep text under the rug, which doesn't seem very appropriate  
given its prominence in other parts of the docs.  
  
Minor rearrangements and word-smithing for clarity, too.  
  
Laurenz Albe and Tom Lane, per gripe from Yanliang Lei  
  
Discussion: https://postgr.es/m/120b3084.56b6.1833b5ffe4b.Coremail.msdnchina@163.com  

commit   : 4d2a844242dcfb34e05dd0d880b1a283a514b16b    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 28 Sep 2022 11:23:14 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 28 Sep 2022 11:23:14 -0400    

Fetch the next-item pointer before the call not after, so that  
we aren't dereferencing a dangling pointer if the callback  
deregistered itself during the call.  The risky coding pattern  
appears in CallXactCallbacks, CallSubXactCallbacks, and  
ResourceOwnerReleaseInternal.  (There are some other places that  
might be at hazard if they offered deregistration functionality,  
but they don't.)  
  
I (tgl) considered back-patching this, but desisted because it  
wouldn't be very safe for extensions to rely on this working in  
pre-v16 branches.  
  
Hao Wu  
  
Discussion: https://postgr.es/m/CAH+9SWXTiERkmhRke+QCcc+jRH8d5fFHTxh8ZK0-Yn4BSpyaAg@mail.gmail.com  

commit   : d84a7b290f866b3f16cbefb0fca31b69ebace98a    
  
author   : Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Wed, 28 Sep 2022 17:14:53 +0200    
  
committer: Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Wed, 28 Sep 2022 17:14:53 +0200    

This prevents marking the argument string for translation for gettext,  
and it also prevents the given string (which is already translated) from  
being translated at runtime.  
  
Also, mark the strings used as arguments to check_rolespec_name for  
translation.  
  
Backpatch all the way back as appropriate.  None of this is caught by  
any tests (necessarily so), so I verified it manually.  

commit   : 7188b9b0fdbb4dd99915626f171d820a56b98514    
  
author   : Robert Haas <rhaas@postgresql.org>    
date     : Wed, 28 Sep 2022 10:42:07 -0400    
  
committer: Robert Haas <rhaas@postgresql.org>    
date     : Wed, 28 Sep 2022 10:42:07 -0400    

Commit 6566133c5f52771198aca07ed18f84519fac1be7 broke the case where  
the role passed to DROP OWNED BY owns a database.  
  
Report by Rushabh Lathia, who also provided a patch, but this patch  
takes a slightly different approach to fixing the problem.  
  
Discussion: http://postgr.es/m/CAGPqQf2vO+nbo=3yAdZ8v26Rbug7bY4YjPaPLZx=L1NZ9-CC3w@mail.gmail.com  

commit   : a448e49bcbe40fb72e1ed85af910dd216d45bad8    
  
author   : Robert Haas <rhaas@postgresql.org>    
date     : Wed, 28 Sep 2022 09:45:27 -0400    
  
committer: Robert Haas <rhaas@postgresql.org>    
date     : Wed, 28 Sep 2022 09:45:27 -0400    

There are still some alignment-related failures in the buildfarm,  
which might or might not be able to be fixed quickly, but I've also  
just realized that it increased the size of many WAL records by 4 bytes  
because a block reference contains a RelFileLocator. The effect of that  
hasn't been studied or discussed, so revert for now.  

commit   : 6af082723277eeca74f2da65e7759666bf7c7f9c    
  
author   : Robert Haas <rhaas@postgresql.org>    
date     : Wed, 28 Sep 2022 08:02:30 -0400    
  
committer: Robert Haas <rhaas@postgresql.org>    
date     : Wed, 28 Sep 2022 08:02:30 -0400    

Since relfilenodes are now 56-bits, we use bigint as the SQL type  
to represent them, which means F_INT8EQ must be used here rather  
than F_OIDEQ. On 64-bit machines this doesn't matter, but 32-bit  
machines are unhappy.  
  
Dilip Kumar  
  
Discussion: http://postgr.es/m/CAFiTN-t71ciSckMzixAhrF9py7oRO6xszKi4mTRwjuucXr5tpw@mail.gmail.com  

commit   : 0222be137188ac3912d244d832a328be0944f3e9    
  
author   : Robert Haas <rhaas@postgresql.org>    
date     : Wed, 28 Sep 2022 07:51:48 -0400    
  
committer: Robert Haas <rhaas@postgresql.org>    
date     : Wed, 28 Sep 2022 07:51:48 -0400    

SharedInvalSmgrMsg can't require 8-byte alignment, because then  
SharedInvalidationMessage will require 8-byte alignment, which will  
then cause ParseCommitRecord to fail on machines that are picky  
about alignment, because it assumes that everything that gets  
packed into a commit record requires only 4-byte alignment.  
  
Another problem with 05d4cbf9b6ba708858984b01ca0fc56d59d4ec7c.  
  
Discussion: http://postgr.es/m/3825454.1664310917@sss.pgh.pa.us  

commit   : d0b1dbcb98454a353919d789c71c6d9a89e961eb    
  
author   : Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Wed, 28 Sep 2022 13:47:25 +0200    
  
committer: Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Wed, 28 Sep 2022 13:47:25 +0200    

Its API is quite strange, and since there's only one caller, there's no  
reason for it to be a separate function in the first place.  Inline it  
instead.  
  
Discussion: https://postgr.es/m/20220927124249.4zdzzlz6had7k3x2@alvherre.pgsql  

commit   : 2e560b974ec7f7e8fe47e765e7c276422015ff3b    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Wed, 28 Sep 2022 09:58:44 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Wed, 28 Sep 2022 09:58:44 +0900    

Both functions referred to an incorrect variable name, so make the whole  
more consistent.  
  
Oversight in 7d70809.  
  
Author: Kyotaro Horiguchi, Bharath Rupireddy  
Discussion: https://postgr.es/m/20220927.172427.467118514018439476.horikyota.ntt@gmail.com  

commit   : 0aaa7cf6989ef6709f2bade96c4c43c7195afe17    
  
author   : Robert Haas <rhaas@postgresql.org>    
date     : Tue, 27 Sep 2022 16:12:43 -0400    
  
committer: Robert Haas <rhaas@postgresql.org>    
date     : Tue, 27 Sep 2022 16:12:43 -0400    

Another defect in 05d4cbf9b6ba708858984b01ca0fc56d59d4ec7c.  
  
Per CI, via Justin Pryzby.  
  
Discussion: http://postgr.es/m/20220927200712.GH6256@telsasoft.com  

commit   : 99164b7ea6bb396f4df569eb7c07664b74b66f19    
  
author   : Robert Haas <rhaas@postgresql.org>    
date     : Tue, 27 Sep 2022 15:31:36 -0400    
  
committer: Robert Haas <rhaas@postgresql.org>    
date     : Tue, 27 Sep 2022 15:31:36 -0400    

Commit 05d4cbf9b6ba708858984b01ca0fc56d59d4ec7c needed to do this,  
but didn't.  
  
Per Justin Pryzby.  
  
Discussion: 20220927191710.GG6256@telsasoft.com  

commit   : 4667d97ca624b257f690e8d369b242b380f53a09    
  
author   : Robert Haas <rhaas@postgresql.org>    
date     : Tue, 27 Sep 2022 15:13:34 -0400    
  
committer: Robert Haas <rhaas@postgresql.org>    
date     : Tue, 27 Sep 2022 15:13:34 -0400    

Reported by Justin Pryzby.  
  
Discussion: http://postgr.es/m/20220927185121.GE6256@telsasoft.com  

commit   : c8b2ef05f481ef06326d7b9f3eb14b303f215c7e    
  
author   : Peter Eisentraut <peter@eisentraut.org>    
date     : Tue, 27 Sep 2022 20:47:07 +0200    
  
committer: Peter Eisentraut <peter@eisentraut.org>    
date     : Tue, 27 Sep 2022 20:47:07 +0200    

The previous macro implementations just cast the argument to a target  
type but did not check whether the input type was appropriate.  The  
function implementation can do better type checking of the input type.  
  
For the *GetDatumFast() macros, converting to an inline function  
doesn't work in the !USE_FLOAT8_BYVAL case, but we can use  
AssertVariableIsOfTypeMacro() to get a similar level of type checking.  
  
Reviewed-by: Aleksander Alekseev <aleksander@timescale.com>  
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>  
Discussion: https://www.postgresql.org/message-id/flat/8528fb7e-0aa2-6b54-85fb-0c0886dbd6ed%40enterprisedb.com  

commit   : 8caf96de0b7b4ad5beb02b36a158196520c035a7    
  
author   : Robert Haas <rhaas@postgresql.org>    
date     : Tue, 27 Sep 2022 13:34:23 -0400    
  
committer: Robert Haas <rhaas@postgresql.org>    
date     : Tue, 27 Sep 2022 13:34:23 -0400    

Buildfarm member crake ran headerscheck, which complained about  
a missing include here.  
  
Defect introduced by commit 2f47715cc8649f854b1df28dfc338af9801db217.  

commit   : 05d4cbf9b6ba708858984b01ca0fc56d59d4ec7c    
  
author   : Robert Haas <rhaas@postgresql.org>    
date     : Tue, 27 Sep 2022 13:25:21 -0400    
  
committer: Robert Haas <rhaas@postgresql.org>    
date     : Tue, 27 Sep 2022 13:25:21 -0400    

RelFileNumbers are now assigned using a separate counter, instead of  
being assigned from the OID counter. This counter never wraps around:  
if all 2^56 possible RelFileNumbers are used, an internal error  
occurs. As the cluster is limited to 2^64 total bytes of WAL, this  
limitation should not cause a problem in practice.  
  
If the counter were 64 bits wide rather than 56 bits wide, we would  
need to increase the width of the BufferTag, which might adversely  
impact buffer lookup performance. Also, this lets us use bigint for  
pg_class.relfilenode and other places where these values are exposed  
at the SQL level without worrying about overflow.  
  
This should remove the need to keep "tombstone" files around until  
the next checkpoint when relations are removed. We do that to keep  
RelFileNumbers from being recycled, but now that won't happen  
anyway. However, this patch doesn't actually change anything in  
this area; it just makes it possible for a future patch to do so.  
  
Dilip Kumar, based on an idea from Andres Freund, who also reviewed  
some earlier versions of the patch. Further review and some  
wordsmithing by me. Also reviewed at various points by Ashutosh  
Sharma, Vignesh C, Amul Sul, Álvaro Herrera, and Tom Lane.  
  
Discussion: http://postgr.es/m/CA+Tgmobp7+7kmi4gkq7Y+4AM9fTvL+O1oQ4-5gFTT+6Ng-dQ=g@mail.gmail.com  

commit   : 2f47715cc8649f854b1df28dfc338af9801db217    
  
author   : Robert Haas <rhaas@postgresql.org>    
date     : Tue, 27 Sep 2022 12:01:57 -0400    
  
committer: Robert Haas <rhaas@postgresql.org>    
date     : Tue, 27 Sep 2022 12:01:57 -0400    

Previously, these were declared in postgres_ext.h, but they are not  
needed nearly so widely as the OID declarations, so that doesn't  
necessarily make sense. Also, because postgres_ext.h is included  
before most of c.h has been processed, the previous location creates  
some problems for a pending patch.  
  
Patch by me, reviewed by Dilip Kumar.  
  
Discussion: http://postgr.es/m/CA+TgmoYc8oevMqRokZQ4y_6aRn-7XQny1JBr5DyWR_jiFtONHw@mail.gmail.com  

commit   : 7ac918ada0037fc1101456271b3e7d0982d6a375    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Tue, 27 Sep 2022 11:51:06 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Tue, 27 Sep 2022 11:51:06 -0400    

Push the units fields over to the left so that all the single-bit  
flags can be together.  I considered rearranging the single-bit  
flags to try to group flags with similar purposes, but eventually  
decided that that involved too many judgment calls.  
  
Discussion: https://postgr.es/m/17385-9ee529fb091f0ce5@postgresql.org  

commit   : 385366426511399a91da327c0f04765bbcfd5322    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Tue, 27 Sep 2022 11:47:12 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Tue, 27 Sep 2022 11:47:12 -0400    

Previously, the transaction-property GUCs such as transaction_isolation  
could be reset after starting a transaction, because we marked them  
as GUC_NO_RESET_ALL but still allowed a targeted RESET.  That leads to  
assertion failures or worse, because those properties aren't supposed  
to change after we've acquired a transaction snapshot.  
  
There are some NO_RESET_ALL variables for which RESET is okay, so  
we can't just redefine the semantics of that flag.  Instead introduce  
a separate GUC_NO_RESET flag.  Mark "seed", as well as the transaction  
property GUCs, as GUC_NO_RESET.  
  
We have to disallow GUC_ACTION_SAVE as well as straight RESET, because  
otherwise a function having a "SET transaction_isolation" clause can  
still break things: the end-of-function restore action is equivalent  
to a RESET.  
  
No back-patch, as it's conceivable that someone is doing something  
this patch will forbid (like resetting one of these GUCs at transaction  
start, or "CREATE FUNCTION ... SET transaction_read_only = 1") and not  
running into problems with it today.  Given how long we've had this  
issue and not noticed, the side effects in non-assert builds can't be  
too serious.  
  
Per bug #17385 from Andrew Bille.  
  
Masahiko Sawada  
  
Discussion: https://postgr.es/m/17385-9ee529fb091f0ce5@postgresql.org  

commit   : 4148c8b3daf95ca308f055e103f6ee82e25b8f99    
  
author   : Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Tue, 27 Sep 2022 14:11:31 +0200    
  
committer: Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Tue, 27 Sep 2022 14:11:31 +0200    

While at it, remove an unused queryString parameter from  
CheckPubRelationColumnList() and make other minor stylistic changes.  
  
Backpatch to 15.  
  
Reported by Kyotaro Horiguchi <horikyota.ntt@gmail.com>  
Co-authored-by: Hou zj <houzj.fnst@fujitsu.com>  
Discussion: https://postgr.es/m/20220926.160426.454497059203258582.horikyota.ntt@gmail.com  

commit   : 249b0409b181311bb1c375311e43eb767b5c3bdd    
  
author   : Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Tue, 27 Sep 2022 10:44:42 +0200    
  
committer: Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Tue, 27 Sep 2022 10:44:42 +0200    

We weren't jumbling the merge action list, so wildly different commands  
would be considered to use the same query ID.  Add that, mention it in  
the docs, and some test lines.  
  
Backpatch to 15.  
  
Author: Tatsu <bt22nakamorit@oss.nttdata.com>  
Reviewed-by: Julien Rouhaud <rjuju123@gmail.com>  
Discussion: https://postgr.es/m/d87e391694db75a038abc3b2597828e8@oss.nttdata.com  

commit   : bed0927aeb0c61bd8649b56e5b84a6d551d5f416    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Mon, 26 Sep 2022 20:02:26 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Mon, 26 Sep 2022 20:02:26 -0700    

I (Andres) chose to backpatch this to 15, as it seems better to keep the  
README the same.  
  
Author: James Coleman <jtc331@gmail.com>  
Discussion: https://postgr.es/m/CAAaqYe_7BXDjpk0Ks_eqf1r6LZpC_rfB7kjhb_T3+eC4t6yiGQ@mail.gmail.com  
Backpatch: 15-, where CI came in  

commit   : a1860071b3fc6b9475a09f0c306e432249bb8314    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Mon, 26 Sep 2022 19:44:05 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Mon, 26 Sep 2022 19:44:05 -0700    

While I (Andres) had planned to use relative rpaths, it looks like agreeing on  
the precise path might take a bit. So set up absolute rpaths for now.  
  
I'm pushing this fairly quickly after posting the patch as several hackers  
fought with this issue.  
  
Discussion: https://postgr.es/m/20220927011951.j3h4o7n6bhf7dwau@awork3.anarazel.de  

commit   : 1330dcdec0f22fb2b7a621f9a0e6e729e21d50a4    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Mon, 26 Sep 2022 19:36:24 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Mon, 26 Sep 2022 19:36:24 -0700    

Previously arguments passed in via CFLAGS/-Dc_args were neither displayed in  
meson's summary, nor in pg_config's output.  
  
Reported-by: "wangw.fnst@fujitsu.com" <wangw.fnst@fujitsu.com>  
Discussion: https://postgr.es/m/OS3PR01MB62751847BC9CD2DB7B29AC129E529@OS3PR01MB6275.jpnprd01.prod.outlook.com  

commit   : 78fdb1e50f7fd394505a400b507f70ecffa6d7bf    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Tue, 27 Sep 2022 09:29:56 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Tue, 27 Sep 2022 09:29:56 +0900    

ParallelMessagePending was previously marked as a boolean which should  
be fine on modern platforms, but the C standard recommends the use of  
sig_atomic_t for variables manipulated in signal handlers.  
  
Author: Hayato Kuroda  
Discussion: https://postgr.es/m/TYAPR01MB58667C15A95A234720F4F876F5529@TYAPR01MB5866.jpnprd01.prod.outlook.com  

commit   : e1e6f8f3dfe141839220875270a81ad3a719e0b6    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Tue, 27 Sep 2022 09:15:07 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Tue, 27 Sep 2022 09:15:07 +0900    

This was used as the returned result type of the generated contents for  
the backup_label and backup history files.  This is replaced by a simple  
string, reducing the cleanup burden of all the callers of  
build_backup_content().  
  
Reviewed-by: Bharath Rupireddy  
Discussion: https://postgr.es/m/YzERvNPaZivHEKZJ@paquier.xyz  

commit   : 31d2c4716e6b429353bb81cebaa0f2b1267823d6    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Mon, 26 Sep 2022 11:38:02 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Mon, 26 Sep 2022 11:38:02 -0700    

This may have served a purpose at some point, but these days it just  
contributes to a non-reproducible build.  
  
Reviewed-by: Peter Eisentraut <peter.eisentraut@enterprisedb.com>  
Discussion: https://postgr.es/m/c5736f70-bb6d-8d25-e35c-e3d886e4e905@enterprisedb.com  
Discussion: https://postgr.es/m/1cef5b48-32bd-5cbf-fb62-fb648860f5ef@enterprisedb.com  

commit   : fbd2bd15b0114bb900aa6986add2b359fec1b740    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 26 Sep 2022 14:19:21 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 26 Sep 2022 14:19:21 -0400    

I'd misunderstood how it worked in 5f1048881.  
  
Discussion: https://postgr.es/m/20220925215009.GC21938@telsasoft.com  

commit   : 787102b5637389b10c220b08992a6a064ac319c6    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 26 Sep 2022 16:32:16 +0200    
  
committer: Peter Eisentraut <peter@eisentraut.org>    
date     : Mon, 26 Sep 2022 16:32:16 +0200    

This was previously disabled because we lacked outfuncs/readfuncs  
support for most utility statement types.  
  
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>  
Discussion: https://www.postgresql.org/message-id/flat/4159834.1657405226@sss.pgh.pa.us  

commit   : 40ad8f9deed21f02b23eb034bfca87f7acc7562b    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 26 Sep 2022 16:32:16 +0200    
  
committer: Peter Eisentraut <peter@eisentraut.org>    
date     : Mon, 26 Sep 2022 16:32:16 +0200    

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>  
Discussion: https://www.postgresql.org/message-id/flat/4159834.1657405226@sss.pgh.pa.us  

commit   : acd624644bc4f957824abcd00f6af27861b03a29    
  
author   : Peter Eisentraut <peter@eisentraut.org>    
date     : Mon, 26 Sep 2022 16:02:09 +0200    
  
committer: Peter Eisentraut <peter@eisentraut.org>    
date     : Mon, 26 Sep 2022 16:02:09 +0200    

Historically we've been more worried about making the output of  
float fields look pretty than whether they'd be read back exactly.  
That won't work if we're to compare the read-back nodes for  
equality, so switch to using the Ryu code for float output.  
  
Author: Tom Lane <tgl@sss.pgh.pa.us>  
Discussion: https://www.postgresql.org/message-id/flat/4159834.1657405226@sss.pgh.pa.us  

commit   : c07785d458c1ca69ad7cd3ebb8f4a1d953c3779b    
  
author   : Peter Eisentraut <peter@eisentraut.org>    
date     : Mon, 26 Sep 2022 15:56:47 +0200    
  
committer: Peter Eisentraut <peter@eisentraut.org>    
date     : Mon, 26 Sep 2022 15:56:47 +0200    

for 8999f5ed3cd7d26be1121d912086d04d134d398b  

commit   : 8999f5ed3cd7d26be1121d912086d04d134d398b    
  
author   : Peter Eisentraut <peter@eisentraut.org>    
date     : Mon, 26 Sep 2022 15:25:59 +0200    
  
committer: Peter Eisentraut <peter@eisentraut.org>    
date     : Mon, 26 Sep 2022 15:25:59 +0200    

Historically, outToken has represented both NULL and empty-string  
strings as "<>", which readfuncs.c then read as NULL, thus failing  
to preserve empty-string fields accurately.  Remarkably, this has  
not caused any serious problems yet, but let's fix it.  
  
We'll keep the "<>" notation for NULL, and use """" for empty string,  
because that matches other notational choices already in use.  
An actual input string of """" is converted to "\""" (this was true  
already, apparently as a hangover from an ancient time when string  
quoting was handled directly by pg_strtok).  
  
CHAR fields also use "<>", but for '\0'.  
  
Author: Tom Lane <tgl@sss.pgh.pa.us>  
Discussion: https://www.postgresql.org/message-id/flat/4159834.1657405226@sss.pgh.pa.us  

commit   : af51b2f042a0808943125b82c0d6e785259069f2    
  
author   : Amit Kapila <akapila@postgresql.org>    
date     : Mon, 26 Sep 2022 08:47:00 +0530    
  
committer: Amit Kapila <akapila@postgresql.org>    
date     : Mon, 26 Sep 2022 08:47:00 +0530    

Commit 6c2003f8a1 removes the use of transaction id's for exporting  
snapshots. This commit removes one unused xid parameter left behind in  
SnapBuildGetOrBuildSnapshot.  
  
Author: Melih Mutlu  
Reviewed-By: Zhang Mingli  
Discussion: https://postgr.es/m/CAGPVpCTqZRoDKgCycw+eYi+Gq41rN9pU-gntgTd7wfsNDpPL3Q@mail.gmail.com  

commit   : 7d708093b7400327658a30d1aa1d5e284d37622c    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Mon, 26 Sep 2022 11:15:47 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Mon, 26 Sep 2022 11:15:47 +0900    

This change simplifies some of the logic related to the generation and  
creation of the backup_label and backup history files, which has become  
unnecessarily complicated since the removal of the exclusive backup mode  
in commit 39969e2.  The code was previously generating the contents of  
these files as a string (start phase for the backup_label and stop phase  
for the backup history file), one problem being that the contents of the  
backup_label string were scanned to grab some of its internal contents  
at the stop phase.  
  
This commit changes the logic so as we store the data required to build  
these files in an intermediate structure named BackupState.  The  
backup_label file and backup history file strings are generated when  
they are ready to be sent back to the client.  Both files are now  
generated with the same code path.  While on it, this commit renames  
some variables for clarity.  
  
Two new files named xlogbackup.{c,h} are introduced in this commit, to  
remove from xlog.c some of the logic around base backups.  Note that  
more could be moved to this new set of files.  
  
Author: Bharath Rupireddy, Michael Paquier  
Reviewed-by: Fujii Masao  
Discussion: https://postgr.es/m/CALj2ACXWwTDgJqCjdaPyfR7djwm6SrybGcrZyrvojzcsmt4FFw@mail.gmail.com  

commit   : 216f9c1ab3a4f333632ce576e1dc1e3643427eb8    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sun, 25 Sep 2022 17:10:58 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sun, 25 Sep 2022 17:10:58 -0400    

Commit 25936fd46 adjusted things so that the "storeslot" we use  
for remapping trigger tuples would have adequate lifespan, but it  
neglected to consider the lifespan of the tuple descriptor that  
the slot depends on.  It turns out that in at least some cases, the  
tupdesc we are passing is a refcounted tupdesc, and the refcount for  
the slot's reference can get assigned to a resource owner having  
different lifespan than the slot does.  That leads to an error like  
"tupdesc reference 0x7fdef236a1b8 is not owned by resource owner  
SubTransaction".  Worse, because of a second oversight in the same  
commit, we'd try to free the same tupdesc refcount again while  
cleaning up after that error, leading to recursive errors and an  
"ERRORDATA_STACK_SIZE exceeded" PANIC.  
  
To fix the initial problem, let's just make a non-refcounted copy  
of the tupdesc we're supposed to use.  That seems likely to guard  
against additional problems, since there's no strong reason for  
this code to assume that what it's given is a refcounted tupdesc;  
in which case there's an independent hazard of the tupdesc having  
shorter lifespan than the slot does.  (I didn't bother trying to  
free said copy, since it should go away anyway when the (sub)  
transaction context is cleaned up.)  
  
The other issue can be fixed by making the code added to  
AfterTriggerFreeQuery work like the rest of that function, ie be  
sure that it doesn't try to free the same slot twice in the event  
of recursive error cleanup.  
  
While here, also clean up minor stylistic issues in the test case  
added by 25936fd46: don't use "create or replace function", as any  
name collision within the tests is likely to have ill effects  
that that won't mask; and don't use function names as generic as  
trigger_function1, especially if you're not going to drop them  
at the end of the test stanza.  
  
Per bug #17607 from Thomas Mc Kay.  Back-patch to v12, as the  
previous fix was.  
  
Discussion: https://postgr.es/m/17607-bd8ccc81226f7f80@postgresql.org  

commit   : 1d2fec990c4dd6da8ffe5ca6b3c2aed2553197fb    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sun, 25 Sep 2022 13:10:10 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sun, 25 Sep 2022 13:10:10 -0400    

Commit 4fb5c794e intended to add coverage of some ambuildempty  
methods that were not getting reached, without removing any  
test coverage.  However, by changing a temp table to unlogged  
it managed to negate the intent of 4c51a2d1e, which means that  
we didn't have reliable test coverage of ginvacuum.c anymore.  
As things stand, much of that file might or might not get reached  
depending on timing, which seems pretty undesirable.  
  
Although this is only clearly broken for the GIN test, it seems  
best to revert 4fb5c794e altogether and instead add bespoke test  
cases covering unlogged indexes for these four AMs.  We don't  
need to do very much with them, so the extra tests are cheap.  
(Note that btree, hash, and bloom already have similar test cases,  
so they need no additional work.)  
  
We can also undo dec8ad367.  Since the testing deficiency that that  
hacked around was later fixed by 2f2e24d90, let's intentionally leave  
an unlogged table behind to improve test coverage in the modules that  
use the regression database for other test purposes.  (The case I used  
also leaves an unlogged sequence behind.)  
  
Per report from Alex Kozhemyakin.  Back-patch to v15 where the  
faulty test came in.  
  
Discussion: https://postgr.es/m/b00c8ee096ee46cd25c183125562a1a7@postgrespro.ru  

commit   : dda101315ad93e9b39c48eeb53b131d171d1fd0b    
  
author   : Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Sun, 25 Sep 2022 17:48:03 +0200    
  
committer: Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Sun, 25 Sep 2022 17:48:03 +0200    

commit   : 26f7802beb2a4aafa0903f5bedeb7f1fa6f4f358    
  
author   : Peter Eisentraut <peter@eisentraut.org>    
date     : Sat, 24 Sep 2022 18:38:35 -0400    
  
committer: Peter Eisentraut <peter@eisentraut.org>    
date     : Sat, 24 Sep 2022 18:38:35 -0400    

commit   : a6bc3301925e1a8ad1f58da629b9dd55bc4b8d9c    
  
author   : Peter Eisentraut <peter@eisentraut.org>    
date     : Sat, 24 Sep 2022 18:18:33 -0400    
  
committer: Peter Eisentraut <peter@eisentraut.org>    
date     : Sat, 24 Sep 2022 18:18:33 -0400    

The node types A_Const, Constraint, and A_Expr had custom output  
functions, but no read functions were implemented so far.  
  
The A_Expr output format had to be tweaked a bit to make it easier to  
parse.  
  
Be a bit more cautious about applying strncmp to unterminated strings.  
  
Also error out if an unrecognized enum value is found in each case,  
instead of just printing a placeholder value.  That was maybe ok for  
debugging but won't work if we want to have robust round-tripping.  
  
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>  
Discussion: https://www.postgresql.org/message-id/flat/4159834.1657405226@sss.pgh.pa.us  

commit   : 2cb1a5a8d4aeb63da2d6a2d22169f05c60bb5828    
  
author   : Peter Eisentraut <peter@eisentraut.org>    
date     : Sat, 24 Sep 2022 18:10:52 -0400    
  
committer: Peter Eisentraut <peter@eisentraut.org>    
date     : Sat, 24 Sep 2022 18:10:52 -0400    

The node tokenizer went out of its way to store BitString node values  
without the leading 'b'.  But everything else in the system stores the  
leading 'b'.  This would break if a BitString node is  
read-printed-read.  
  
Also, the node tokenizer didn't know that BitString node tokens could  
also start with 'x'.  
  
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>  
Discussion: https://www.postgresql.org/message-id/flat/4159834.1657405226@sss.pgh.pa.us  

commit   : 43f4b349152d972c711592b8e8a4645aea9625f4    
  
author   : Peter Eisentraut <peter@eisentraut.org>    
date     : Sat, 24 Sep 2022 18:10:11 -0400    
  
committer: Peter Eisentraut <peter@eisentraut.org>    
date     : Sat, 24 Sep 2022 18:10:11 -0400    

The main parser checks whether a literal fits into an int when  
deciding whether it should be put into an Integer or Float node.  The  
parser processes integer literals without signs.  So a most-negative  
integer literal will not fit into Integer and will end up as a Float  
node.  
  
The node tokenizer did this differently.  It included the sign when  
checking whether the literal fit into int.  So a most-negative integer  
would indeed fit that way and end up as an Integer node.  
  
In order to preserve the node structure correctly, we need the node  
tokenizer to also analyze integer literals without sign.  
  
There are a number of test cases in the regression tests that have a  
most-negative integer argument of some utility statement, so this  
issue is easily reproduced under WRITE_READ_PARSE_PLAN_TREES.  
  
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>  
Discussion: https://www.postgresql.org/message-id/flat/4159834.1657405226@sss.pgh.pa.us  

commit   : 03bf971d2dc701d473705fd00891028d140dd5ae    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Sat, 24 Sep 2022 12:01:06 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Sat, 24 Sep 2022 12:01:06 -0700    

The use in regexec.c could remain, since we only try to keep headers C++  
clean. But there really doesn't seem to be a good reason to use register in  
that spot.  
  
Discussion: https://postgr.es/m/20220308185902.ibdqmasoaunzjrfc@alap3.anarazel.de  

commit   : eef63941c127bcfbc278445b85cf3d9dd9e323b0    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Sat, 24 Sep 2022 12:04:56 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Sat, 24 Sep 2022 12:04:56 -0700    

There's really no need to build win32ver.rc as part of building  
pgmsgevent.rc. This will make it sligthly easier to add rc file generation to  
the meson build.  

commit   : a075c616d22921fd90eafa852f140df9cd832209    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Sat, 24 Sep 2022 11:29:29 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Sat, 24 Sep 2022 11:29:29 -0700    

commit   : 6d6e1368722c664eef547d59ab23a29e555778c8    
  
author   : Peter Eisentraut <peter@eisentraut.org>    
date     : Fri, 23 Sep 2022 21:16:08 -0400    
  
committer: Peter Eisentraut <peter@eisentraut.org>    
date     : Fri, 23 Sep 2022 21:16:08 -0400    

Use "prepared transaction" instead of "two-phrase transaction".  This  
is in line with 0e60a50e0bf158bead247731e00cee95bcf64daf.  

commit   : 5f1048881d5f16475b76e168bfe962682c741fb5    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 23 Sep 2022 18:20:11 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 23 Sep 2022 18:20:11 -0400    

Improve a couple of things I noticed while working on v15  
release notes.  

commit   : d811ce6ea343fa8a0b6b9cd7e9cddcbdaa27962b    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Fri, 23 Sep 2022 13:00:55 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Fri, 23 Sep 2022 13:00:55 -0700    

Because index creation does not go through heap_create_with_catalog() we  
didn't call pgstat_create_relation(), leading to index stats of a newly  
created realtion not getting dropped during rollback. To fix, move the  
pgstat_create_relation() to heap_create(), which indexes do use.  
  
Similarly, because dropping an index does not go through  
heap_drop_with_catalog(), we didn't drop index stats when the transaction  
dropping an index committed. Here there's no convenient common path for  
indexes and relations, so index_drop() now calls pgstat_drop_relation().  
  
Add tests for transactional index stats handling.  
  
Author: "Drouvot, Bertrand" <bdrouvot@amazon.com>  
Reviewed-by: Andres Freund <andres@anarazel.de>  
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>  
Discussion: https://postgr.es/m/51bbf286-2b4a-8998-bd12-eaae4b765d99@amazon.com  
Backpatch: 15-, like 8b1dccd37c71, which introduced the bug  

commit   : 0032a5456708811ca95bd80a538f4fb72ad0dd20    
  
author   : Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Fri, 23 Sep 2022 18:21:22 +0200    
  
committer: Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Fri, 23 Sep 2022 18:21:22 +0200    

The extended query protocol implementation I added in commit  
acb7e4eb6b1c has bugs when used in pipeline mode.  Rather than spend  
more time trying to fix it, remove that code and make the function rely  
on simple query protocol only, meaning it can no longer be used in  
pipeline mode.  
  
Users can easily change their applications to use PQsendQueryParams  
instead.  We leave PQsendQuery in place for Postgres 14, just in case  
somebody is using it and has not hit the mentioned bugs; but we should  
recommend that it not be used.  
  
Backpatch to 15.  
  
Per bug report from Gabriele Varrazzo.  
Discussion: https://postgr.es/m/CA+mi_8ZGSQNmW6-mk_iSR4JZB_LJ4ww3suOF+1vGNs3MrLsv4g@mail.gmail.com  

commit   : d11a41a4ce79660d1a1c5f81b051061717099a9f    
  
author   : Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Fri, 23 Sep 2022 18:11:48 +0200    
  
committer: Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Fri, 23 Sep 2022 18:11:48 +0200    

The "emulation" I wrote for PQsendQuery in pipeline mode to use extended  
query protocol, in commit acb7e4eb6b1c, is problematic.  Due to numerous  
bugs we'll soon remove it.  As a first step and for all branches back to  
14, stop using PQsendQuery in libpq_pipeline.  Also remove a few test  
lines that will no longer be relevant.  
  
Backpatch to 14.  
  
Discussion: https://postgr.es/m/CA+mi_8ZGSQNmW6-mk_iSR4JZB_LJ4ww3suOF+1vGNs3MrLsv4g@mail.gmail.com  

commit   : e3e6ee69641b8ea1e24f05ee64393a52e495bf86    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Thu, 22 Sep 2022 20:36:28 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Thu, 22 Sep 2022 20:36:28 -0700    

Ommitted in e6b6ea025cc, but necessary for libintl to be found. All other  
dependencies can be found via pkg-config (which searches in /usr/local/...)  
and thus worked even without adding the directories.  

commit   : 13a185f54ba594a5fb42bac3e1ecbdfd62b9041f    
  
author   : Amit Kapila <akapila@postgresql.org>    
date     : Fri, 23 Sep 2022 08:21:26 +0530    
  
committer: Amit Kapila <akapila@postgresql.org>    
date     : Fri, 23 Sep 2022 08:21:26 +0530    

We previously thought that allowing such cases can confuse users when they  
specify DROP TABLES IN SCHEMA but that doesn't seem to be the case based  
on discussion. This helps to uplift the restriction during  
ALTER TABLE ... SET SCHEMA which used to ensure that we couldn't end up  
with a publication having both a schema and the same schema's table.  
  
To allow this, we need to forbid having any schema on a publication if  
column lists on a table are specified (and vice versa). This is because  
otherwise we still need a restriction during ALTER TABLE ... SET SCHEMA to  
forbid cases where it could lead to a publication having both a schema and  
the same schema's table with column list.  
  
Based on suggestions by Peter Eisentraut.  
  
Author: Hou Zhijie and Vignesh C  
Reviewed-By: Peter Smith, Amit Kapila  
Backpatch-through: 15, where it was introduced  
Discussion: https://postgr.es/m/2729c9e2-9aac-8cda-f2f4-34f2bcc18f4e@enterprisedb.com  

commit   : d89755dac6153518a601ca0fa9e489f2bc209fdc    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 22 Sep 2022 22:05:09 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 22 Sep 2022 22:05:09 -0400    

The pg_dump and pg_dumpall man pages referred to app-psql-patterns  
as appearing "below", which I suspect was copied-and-pasted from  
equivalent text in psql-ref.sgml rather than being actually thought  
through.  At least to me, that phrasing means "later in this same  
web page/section", which this link target is not.  Drop the  
misleading and unnecessary-in-any-case adjective.  

commit   : 20e69daa1348f6899fffe3c260bf44293551ee87    
  
author   : Peter Geoghegan <pg@bowt.ie>    
date     : Thu, 22 Sep 2022 16:41:23 -0700    
  
committer: Peter Geoghegan <pg@bowt.ie>    
date     : Thu, 22 Sep 2022 16:41:23 -0700    

Make sure that function declarations use names that exactly match the  
corresponding names from function definitions in pg_dump/pg_dumpall  
related code.  
  
Affected code happens to be inconsistent in how it applies conventions  
around how Archive and Archive Handle variables are named.  Significant  
code churn is required to fully fix those inconsistencies, so take the  
least invasive approach possible: treat function definition names as  
authoritative, and mechanically adjust corresponding names from function  
definitions to match.  
  
Like other recent commits that cleaned up function parameter names, this  
commit was written with help from clang-tidy.  
  
Author: Peter Geoghegan <pg@bowt.ie>  
Reviewed-By: Tom Lane <tgl@sss.pgh.pa.us>  
Discussion: https://postgr.es/m/CAH2-Wzmma+vzcO6gr5NYDZ+sx0G14aU-UrzFutT2FoRaisVCUQ@mail.gmail.com  

commit   : 0faf7d933f625eb1668dcaa518b472f722b53a55    
  
author   : Peter Geoghegan <pg@bowt.ie>    
date     : Thu, 22 Sep 2022 13:59:20 -0700    
  
committer: Peter Geoghegan <pg@bowt.ie>    
date     : Thu, 22 Sep 2022 13:59:20 -0700    

Make sure that function declarations use names that exactly match the  
corresponding names from function definitions in contrib code.  
  
Like other recent commits that cleaned up function parameter names, this  
commit was written with help from clang-tidy.  
  
Author: Peter Geoghegan <pg@bowt.ie>  
Discussion: https://postgr.es/m/CAH2-WznJt9CMM9KJTMjJh_zbL5hD9oX44qdJ4aqZtjFi-zA3Tg@mail.gmail.com  

commit   : 8fb4e001e9c185250a95b2b13880a2a04d626b75    
  
author   : Peter Geoghegan <pg@bowt.ie>    
date     : Thu, 22 Sep 2022 13:27:16 -0700    
  
committer: Peter Geoghegan <pg@bowt.ie>    
date     : Thu, 22 Sep 2022 13:27:16 -0700    

Make sure that function declarations use names that exactly match the  
corresponding names from function definitions for several "lexer  
adjacent" backend functions.  These were missed by commit aab06442.  
  
Author: Peter Geoghegan <pg@bowt.ie>  
Discussion: https://postgr.es/m/CAH2-WznJt9CMM9KJTMjJh_zbL5hD9oX44qdJ4aqZtjFi-zA3Tg@mail.gmail.com  

commit   : 3535ebce5dc542b90f14d6e81cce80fe7226bda5    
  
author   : Peter Geoghegan <pg@bowt.ie>    
date     : Thu, 22 Sep 2022 12:53:20 -0700    
  
committer: Peter Geoghegan <pg@bowt.ie>    
date     : Thu, 22 Sep 2022 12:53:20 -0700    

Make ecpg function declarations consistently use named parameters.  Also  
make sure that the declarations use names that match corresponding names  
from function definitions.  
  
Like other recent commits that cleaned up function parameter names, this  
commit was written with help from clang-tidy.  
  
Author: Peter Geoghegan <pg@bowt.ie>  
Reviewed-By: David Rowley <dgrowleyml@gmail.com>  
Discussion: https://postgr.es/m/CAH2-WznJt9CMM9KJTMjJh_zbL5hD9oX44qdJ4aqZtjFi-zA3Tg@mail.gmail.com  

commit   : 163b0993a162ebae00fe5de8f593a5da28821a1b    
  
author   : Jeff Davis <jdavis@postgresql.org>    
date     : Thu, 22 Sep 2022 10:58:49 -0700    
  
committer: Jeff Davis <jdavis@postgresql.org>    
date     : Thu, 22 Sep 2022 10:58:49 -0700    

Similar to 5f12bc94dc, the code must re-check PageIsAllVisible() after  
buffer lock is re-acquired. Backpatching to the same version, 12.  
  
Discussion: https://postgr.es/m/CAEP4nAw9jYQDKd_5Y+-s2E4YiUJq1vqiikFjYGpLShtp-K3gag@mail.gmail.com  
Reported-by: Robins Tharakan  
Reviewed-by: Robins Tharakan  
Backpatch-through: 12  

commit   : 790bf615ddba8a0ba3b870915d03438ce9cb7860    
  
author   : Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Thu, 22 Sep 2022 19:02:25 +0200    
  
committer: Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Thu, 22 Sep 2022 19:02:25 +0200    

This may be a bit too subtle, but removing that word from there makes  
this clause no longer a perfect parallel of the GRANT variant "ALL  
TABLES IN SCHEMA": indeed, for publications what we record is the schema  
itself, not the tables therein, which means that any tables added to the  
schema in the future are also published.  This is completely different  
to what GRANT does, which is affect only the tables that exist when the  
command is executed.  
  
There isn't resounding support for this change, but there are a few  
positive votes and no opposition.  Because the time to 15 RC1 is very  
short, let's get this out now.  
  
Backpatch to 15.  
  
Discussion: https://postgr.es/m/2729c9e2-9aac-8cda-f2f4-34f2bcc18f4e  

commit   : ba50834551f936719450a287c0d7f1d0d769e9c9    
  
author   : Peter Eisentraut <peter@eisentraut.org>    
date     : Sat, 17 Sep 2022 11:34:20 +0200    
  
committer: Peter Eisentraut <peter@eisentraut.org>    
date     : Sat, 17 Sep 2022 11:34:20 +0200    

Commit 5ef1eefd76f404ddc59b885d50340e602b70f05f, which added  
archive_library, purged most mentions of archive_command from the  
documentation.  This is inappropriate, since archive_command is still  
a feature in use and users will want to see information about it.  
  
This restores all the removed mentions and rephrases things so that  
archive_command and archive_library are presented as alternatives of  
each other.  
  
Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>  
Discussion: https://www.postgresql.org/message-id/9366d634-a917-85a9-4991-b2a4859edaf9@enterprisedb.com  

commit   : 18ac08f0b42de3cf35f07199c9f482746c8b12c0    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Thu, 22 Sep 2022 20:02:40 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Thu, 22 Sep 2022 20:02:40 +0900    

The bounds hardcoded in compression.c since ffd5365 (minimum at 1 and  
maximum at 22) do not match the reality of what zstd is able to  
handle, these values being available via ZSTD_maxCLevel() and  
ZSTD_minCLevel() at run-time.  The maximum of 22 is actually correct  
in recent versions, but the minimum was not as the library can go down  
to -131720 by design.  This commit changes the code to use the run-time  
values in the code instead of some hardcoded ones.  
  
Zstd seems to assume that these bounds could change in the future, and  
Postgres will be able to adapt automatically to such changes thanks to  
what's being done in this commit.  
  
Reported-by: Justin Prysby  
Discussion: https://postgr.es/m/20220922033716.GL31833@telsasoft.com  
Backpatch-through: 15  

commit   : cbe6dd17ac453fece214b2a430b354d4f7d5a15d    
  
author   : Etsuro Fujita <efujita@postgresql.org>    
date     : Thu, 22 Sep 2022 15:55:00 +0900    
  
committer: Etsuro Fujita <efujita@postgresql.org>    
date     : Thu, 22 Sep 2022 15:55:00 +0900    

This comment has been wrong since its introduction in commit 0d5f05cde;  
backpatch to v12 where that came in.  
  
Discussion: https://postgr.es/m/CAPmGK14VGf-xQjGQN4o1QyAbXAaxugU5%3DqfcmTDh1iufUDnV_w%40mail.gmail.com  

commit   : e6b6ea025cc0b6e5cdb7a3bf6d9275afdd861e51    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Wed, 21 Sep 2022 21:53:18 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Wed, 21 Sep 2022 21:53:18 -0700    

The Windows task is changed to use meson as there currently is no way to run  
all tests in the old MSVC build system (only ninja is covered for now, we  
don't have enough CI resources to test msbuild as well).  
  
To maintain autoconf coverage, the Linux task is duplicated to test both meson  
and autoconf builds (linux is currently the fastest task). FreeBSD and macOS  
are also converted to meson, as it seems more important to have coverage for  
meson than autoconf.  
  
Author: Andres Freund <andres@anarazel.de>  
Author: Nazir Bilal Yavuz <byavuz81@gmail.com>  
Author: Justin Pryzby <pryzby@telsasoft.com>  

commit   : e6927270cd18d535b77cbe79c55c6584351524be    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Wed, 21 Sep 2022 21:53:12 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Wed, 21 Sep 2022 21:53:12 -0700    

Autoconf is showing its age, fewer and fewer contributors know how to wrangle  
it. Recursive make has a lot of hard to resolve dependency issues and slow  
incremental rebuilds. Our home-grown MSVC build system is hard to maintain for  
developers not using Windows and runs tests serially. While these and other  
issues could individually be addressed with incremental improvements, together  
they seem best addressed by moving to a more modern build system.  
  
After evaluating different build system choices, we chose to use meson, to a  
good degree based on the adoption by other open source projects.  
  
We decided that it's more realistic to commit a relatively early version of  
the new build system and mature it in tree.  
  
This commit adds an initial version of a meson based build system. It supports  
building postgres on at least AIX, FreeBSD, Linux, macOS, NetBSD, OpenBSD,  
Solaris and Windows (however only gcc is supported on aix, solaris). For  
Windows/MSVC postgres can now be built with ninja (faster, particularly for  
incremental builds) and msbuild (supporting the visual studio GUI, but  
building slower).  
  
Several aspects (e.g. Windows rc file generation, PGXS compatibility, LLVM  
bitcode generation, documentation adjustments) are done in subsequent commits  
requiring further review. Other aspects (e.g. not installing test-only  
extensions) are not yet addressed.  
  
When building on Windows with msbuild, builds are slower when using a visual  
studio version older than 2019, because those versions do not support  
MultiToolTask, required by meson for intra-target parallelism.  
  
The plan is to remove the MSVC specific build system in src/tools/msvc soon  
after reaching feature parity. However, we're not planning to remove the  
autoconf/make build system in the near future. Likely we're going to keep at  
least the parts required for PGXS to keep working around until all supported  
versions build with meson.  
  
Some initial help for postgres developers is at  
https://wiki.postgresql.org/wiki/Meson  
  
With contributions from Thomas Munro, John Naylor, Stone Tickle and others.  
  
Author: Andres Freund <andres@anarazel.de>  
Author: Nazir Bilal Yavuz <byavuz81@gmail.com>  
Author: Peter Eisentraut <peter@eisentraut.org>  
Reviewed-By: Peter Eisentraut <peter.eisentraut@enterprisedb.com>  
Discussion: https://postgr.es/m/20211012083721.hvixq4pnh2pixr3j@alap3.anarazel.de  

commit   : fbb5f54b67c2f35c885d07daa26bce7e2eb6b0be    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Thu, 22 Sep 2022 14:25:09 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Thu, 22 Sep 2022 14:25:09 +0900    

If the ps display is not cleared at this point, the process could  
continue displaying "recovering NNN" even if handling end-of-recovery  
steps.  df9274a has tackled that by providing some information with the  
end-of-recovery checkpoint but 7ff23c6 has nullified the effect of the  
first commit.  
  
Per a suggestion from Justin, just clear the ps display when we are done  
with recovery, so as no incorrect information is displayed.  This may  
get extended in the future, but for now restore the pre-7ff23c6  
behavior.  
  
Author: Justin Prysby  
Discussion: https://postgr.es/m/20220913223954.GU31833@telsasoft.com  
Backpatch-through: 15  

commit   : 2f636daac85b7bad608b24b475feceb7e3076ec6    
  
author   : Fujii Masao <fujii@postgresql.org>    
date     : Thu, 22 Sep 2022 12:54:26 +0900    
  
committer: Fujii Masao <fujii@postgresql.org>    
date     : Thu, 22 Sep 2022 12:54:26 +0900    

Commit 6c2003f8a1 changed the snapshot names mentioned in  
SET TRANSACTION docs, however, there was one place that  
the commit missed updating the name.  
  
Back-patch to all supported versions.  
  
Author: Japin Li  
Reviewed-by: Fujii Masao  
Discussion: https://postgr.es/m/MEYP282MB1669BD4280044501165F8B07B64F9@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM  

commit   : 14ff44f80c09718d43d853363941457f5468cc03    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Thu, 22 Sep 2022 09:47:28 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Thu, 22 Sep 2022 09:47:28 +0900    

This commit updates two code paths to use pg_lfind32() introduced by  
b6ef167 with TransactionId arrays:  
- At the end of TransactionIdIsInProgress(), when checking for the case  
of still running but overflowed subxids.  
- XidIsConcurrent(), when checking for a serializable conflict.  
  
These cases are less impactful than 37a6e5d, but a bit of  
micro-benchmarking of this API shows that linear search speeds up by  
~20% depending on the number of items involved (x86_64 and amd64 looked  
at here).  
  
Author: Nathan Bossart  
Reviewed-by: Richard Guo, Michael Paquier  
Discussion: https://postgr.es/m/20220901185153.GA783106@nathanxps13  

commit   : 9a6915257d1d804ddba05331030b74d7426a4005    
  
author   : Fujii Masao <fujii@postgresql.org>    
date     : Thu, 22 Sep 2022 09:25:29 +0900    
  
committer: Fujii Masao <fujii@postgresql.org>    
date     : Thu, 22 Sep 2022 09:25:29 +0900    

Commit 7103ebb7aa added the tab-completion for MERGE accidentally  
in the middle of that for LOCK TABLE. This commit fixes this issue.  
  
This also adds some tab-completion for MERGE.  
  
Back-patch to v15 where MERGE was introduced.  
  
Author: Kotaro Kawamoto, Fujii Masao  
Reviewed-by: Shinya Kato, Álvaro Herrera  
Discussion: https://postgr.es/m/9f1ad2a87a58cd5e7d64f3993130958d@oss.nttdata.com  

commit   : 661ee7bfc661a4ba52ed57cff46e414b2add75b1    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Wed, 21 Sep 2022 17:15:54 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Wed, 21 Sep 2022 17:15:54 -0700    

Cirrus defaults to SetErrorMode(SEM_NOGPFAULTERRORBOX | ...). That prevents  
crash reporting from working unless binaries do SetErrorMode()  
themselves. Furthermore, it appears that either python or, more likely, the C  
runtime has a bug where SEM_NOGPFAULTERRORBOX can very occasionally *trigger*  
a crash on process exit - which is hard to debug, given that it explicitly  
prevents crash dumps from working...  
  
Discussion: https://postgr.es/m/20220909235836.lz3igxtkcjb5w7zb%40awork3.anarazel.de  
Backpatch: 15-, where CI was added  

commit   : a3a3c1ea87804c9efddf53fc2e7793993630a034    
  
author   : Thomas Munro <tmunro@postgresql.org>    
date     : Thu, 22 Sep 2022 11:35:46 +1200    
  
committer: Thomas Munro <tmunro@postgresql.org>    
date     : Thu, 22 Sep 2022 11:35:46 +1200    

CI builds recently started failing with:  
  
"Memory size for 4.0 vCPU instance should be between 3840MiB and  
26624MiB, while 2048MiB is requested."  
  
Ok then, let's ask for 4G instead of 2G.  
  
This may be due to a change in the type of instance used to work around  
an outage, per:  
  
https://twitter.com/cirrus_labs/status/1572657320093712384  

commit   : aab06442d488364f8861219cb8864a16b6d0d4e4    
  
author   : Peter Geoghegan <pg@bowt.ie>    
date     : Wed, 21 Sep 2022 13:21:36 -0700    
  
committer: Peter Geoghegan <pg@bowt.ie>    
date     : Wed, 21 Sep 2022 13:21:36 -0700    

Make sure that function declarations use names that exactly match the  
corresponding names from function definitions for several "lexer  
adjacent" backend functions.  
  
These functions were missed by recent commits because they were obscured  
by clang-tidy warnings about functions whose signature is directly under  
the control of the lexer (flex seems to always generate function  
declarations with unnamed parameters).  We probably can't fix most of  
the warnings it generates for translation units that get built from .l  
and .y files, but we can at least do this much.  
  
Author: Peter Geoghegan <pg@bowt.ie>  
Discussion: https://postgr.es/m/CAH2-WznJt9CMM9KJTMjJh_zbL5hD9oX44qdJ4aqZtjFi-zA3Tg@mail.gmail.com  

commit   : e59a67fb8fe1ac1408dc1858038f525a860d772b    
  
author   : Peter Eisentraut <peter@eisentraut.org>    
date     : Wed, 21 Sep 2022 10:28:40 -0400    
  
committer: Peter Eisentraut <peter@eisentraut.org>    
date     : Wed, 21 Sep 2022 10:28:40 -0400    

We check that the ICU locale is only specified if the ICU locale  
provider is selected.  But we did that too early.  We need to wait  
until we load the settings of the template database, since that could  
also set what the locale provider is.  
  
Reported-by: Marina Polyakova <m.polyakova@postgrespro.ru>  
Discussion: https://www.postgresql.org/message-id/9ba4cd1ea6ed6b7b15c0ff15e6f540cd@postgrespro.ru  

commit   : 2da8c4cff39328897aa716a0ba57bdada5aeaf6e    
  
author   : Peter Eisentraut <peter@eisentraut.org>    
date     : Wed, 21 Sep 2022 09:34:22 -0400    
  
committer: Peter Eisentraut <peter@eisentraut.org>    
date     : Wed, 21 Sep 2022 09:34:22 -0400    

For publication schemas (OBJECT_PUBLICATION_NAMESPACE) and user  
mappings (OBJECT_USER_MAPPING), pg_get_object_address() checked the  
array length of the second argument, but not of the first argument.  
If the first argument was too long, it would just silently ignore  
everything but the first argument.  Fix that by checking the length of  
the first argument as well.  
  
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>  
Discussion: https://www.postgresql.org/message-id/flat/caaef70b-a874-1088-92ef-5ac38269c33b%40enterprisedb.com  

commit   : 3d4e841a076379663ae714d1d1c7eee11c638063    
  
author   : Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Wed, 21 Sep 2022 12:29:38 +0200    
  
committer: Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Wed, 21 Sep 2022 12:29:38 +0200    

It is not our usual style to use "we" in messages.  Also, remove some  
noise words.  Backpatch to 15.  
  
Noted by Kyotaro Horiguchi.  
  
Discussion: https://postgr.es/m/20220914.111507.13049297635620898.horikyota.ntt@gmail.com  

commit   : a932824dfe068f563e9abb9264f6e071f23e67ae    
  
author   : Amit Kapila <akapila@postgresql.org>    
date     : Wed, 21 Sep 2022 10:20:37 +0530    
  
committer: Amit Kapila <akapila@postgresql.org>    
date     : Wed, 21 Sep 2022 10:20:37 +0530    

Previously the following snprintf() wrappers:  
  
* ReplicationSlotNameForTablesync()  
* ReplicationOriginNameForTablesync()  
  
... used int as a second argument of snprintf() while the actual type of it  
is size_t. Although it doesn't fail at present better replace it with Size  
for consistency with the rest of the system.  
  
Author: Aleksander Alekseev  
Reviewed-By: Peter Smith  
Discussion: https://postgr.es/m/CAHut%2BPsa8hhfSE6ozUK-ih7GkQziAVAf4f3bqiXEj2nQiu-43g%40mail.gmail.com  

commit   : 6971a839ccdf1131ddf1fa2fa405cba43cd68608    
  
author   : Amit Kapila <akapila@postgresql.org>    
date     : Wed, 21 Sep 2022 09:43:59 +0530    
  
committer: Amit Kapila <akapila@postgresql.org>    
date     : Wed, 21 Sep 2022 09:43:59 +0530    

It is not our usual style to use "we" in the error messages.  
  
Author: Kyotaro Horiguchi  
Reviewed-By: Amit Kapila  
Discussion: https://postgr.es/m/20220914.111507.13049297635620898.horikyota.ntt@gmail.com  

commit   : 3f0c901e744c87f6e00744e63afe0242d5fe45e9    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Tue, 20 Sep 2022 18:11:10 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Tue, 20 Sep 2022 18:11:10 -0700    

Per off-list report from Thomas Munro.  

commit   : ec3c9cc202fb2749fce82483e6dc247cfe286cab    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Wed, 21 Sep 2022 10:11:23 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Wed, 21 Sep 2022 10:11:23 +0900    

Visual Studio 2015+ has support for a macro to control the alignement of  
structures as of __declspec(align(#)), and this commit adds a definition  
of pg_attribute_aligned() based on that.  It happens that this was  
already used in the implementation of atomics for MSVC.  Note that there  
is still no definition fo pg_attribute_packed(), so this does not impact  
itemptr.h.  
  
Author: James Coleman  
Discussion: https://postgr.es/m/CAAaqYe-HbtZvR3msoMtk+hYW2S0e0OapzMW8icSMYTMA+mN8Aw@mail.gmail.com  

commit   : 1c27d16e6e5c1f463bbe1e9ece88dda811235165    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Tue, 20 Sep 2022 18:03:22 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Tue, 20 Sep 2022 18:03:22 -0400    

expression_tree_walker and allied functions have traditionally  
declared their callback functions as, say, "bool (*walker) ()"  
to allow for variation in the declared types of the callback  
functions' context argument.  This is apparently going to be  
forbidden by the next version of the C standard, and the latest  
version of clang warns about that.  In any case it's always  
been pretty poor for error-detection purposes, so fixing it is  
a good thing to do.  
  
What we want to do is change the callback argument declarations to  
be like "bool (*walker) (Node *node, void *context)", which is  
correct so far as expression_tree_walker and friends are concerned,  
but not change the actual callback functions.  Strict compliance with  
the C standard would require changing them to declare their arguments  
as "void *context" and then cast to the appropriate context struct  
type internally.  That'd be very invasive and it would also introduce  
a bunch of opportunities for future bugs, since we'd no longer have  
any check that the correct sort of context object is passed by outside  
callers or internal recursion cases.  Therefore, we're just going  
to ignore the standard's position that "void *" isn't necessarily  
compatible with struct pointers.  No machine built in the last forty  
or so years actually behaves that way, so it's not worth introducing  
bug hazards for compatibility with long-dead hardware.  
  
Therefore, to silence these compiler warnings, introduce a layer of  
macro wrappers that cast the supplied function name to the official  
argument type.  Thanks to our use of -Wcast-function-type, this will  
still produce a warning if the supplied function is seriously  
incompatible with the required signature, without going as far as  
the official spec restriction does.  
  
This method fixes the problem without any need for source code changes  
outside nodeFuncs.h/.c.  However, it is an ABI break because the  
physically called functions now have names ending in "_impl".  Hence  
we can only fix it this way in HEAD.  In the back branches, we'll have  
to settle for disabling -Wdeprecated-non-prototype.  
  
Discussion: https://postgr.es/m/CA+hUKGKpHPDTv67Y+s6yiC8KH5OXeDg6a-twWo_xznKTcG0kSA@mail.gmail.com  

commit   : eccb607e19993483e25966abae895277599f77a2    
  
author   : Peter Geoghegan <pg@bowt.ie>    
date     : Tue, 20 Sep 2022 14:08:57 -0700    
  
committer: Peter Geoghegan <pg@bowt.ie>    
date     : Tue, 20 Sep 2022 14:08:57 -0700    

Fix selfuncs.h cpluspluscheck complaint, without reintroducing a  
parameter name inconsistency (restore the original declaration names,  
and then make corresponding function definitions consistent with that).  
  
Oversight in commit a601366a.  
  
Author: Peter Geoghegan <pg@bowt.ie>  
Reported-By: Andres Freund <andres@anarazel.de>  

commit   : a601366a460f68472bf70c4d94c57baa0a3ed1b2    
  
author   : Peter Geoghegan <pg@bowt.ie>    
date     : Tue, 20 Sep 2022 13:09:30 -0700    
  
committer: Peter Geoghegan <pg@bowt.ie>    
date     : Tue, 20 Sep 2022 13:09:30 -0700    

Make sure that function declarations use names that exactly match the  
corresponding names from function definitions in optimizer, parser,  
utility, libpq, and "commands" code, as well as in remaining library  
code.  Do the same for all code related to frontend programs (with the  
exception of pg_dump/pg_dumpall related code).  
  
Like other recent commits that cleaned up function parameter names, this  
commit was written with help from clang-tidy.  Later commits will handle  
ecpg and pg_dump/pg_dumpall.  
  
Author: Peter Geoghegan <pg@bowt.ie>  
Reviewed-By: David Rowley <dgrowleyml@gmail.com>  
Discussion: https://postgr.es/m/CAH2-WznJt9CMM9KJTMjJh_zbL5hD9oX44qdJ4aqZtjFi-zA3Tg@mail.gmail.com  

commit   : c3382a3c3ccda6df126c95bf37dcc762480c5202    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Tue, 20 Sep 2022 11:09:30 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Tue, 20 Sep 2022 11:09:30 -0700    

To avoid duplicating the PG_TEST_EXTRA logic in Makefiles into the upcoming  
meson based build definition, move the checks into the the tests  
themselves. That also has the advantage of making skipped tests visible.  
  
Reviewed-by: Peter Eisentraut <peter.eisentraut@enterprisedb.com>  
Author: Nazir Bilal Yavuz <byavuz81@gmail.com>  
Author: Andres Freund <andres@anarazel.de>  
Discussion: https://postgr.es/m/7dae5979-c6c0-cec5-7a36-76a85aa8053d@enterprisedb.com  

commit   : bb44a6ba48edfe1ac8bca87b1f2cfdcd9f86c930    
  
author   : Jeff Davis <jdavis@postgresql.org>    
date     : Tue, 20 Sep 2022 10:41:34 -0700    
  
committer: Jeff Davis <jdavis@postgresql.org>    
date     : Tue, 20 Sep 2022 10:41:34 -0700    

Clarify that the command counter may or may not have been incremented.  
  
We may want to change the behavior to be more consistent, but until  
that time, at least improve the comment.  
  
Discussion: https://postgr.es/m/CAHoZxqvN2eoic_CvjsAvpryyLyA2xG8JmsyMtKFFJz_1oFhfOg%40mail.gmail.com  
Reported-by: Mary Xu  

commit   : 3d53b9ef1a4cda7b6303a0496f8531eceeef0e77    
  
author   : Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Tue, 20 Sep 2022 18:50:16 +0200    
  
committer: Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Tue, 20 Sep 2022 18:50:16 +0200    

The original `trap` lines in these scripts are incomplete: in case of  
any signal, they delete the working directory but let the script run to  
completion, which is useless because it will only proceed to complain  
about the working directory being removed.  Add `exit` there, with the  
original exit value (not rm's).  
  
Since this is mostly just cosmetic, no backpatch.  
  
Discussion: https://postgr.es/m/20220913181002.hzsosy7qkemb7ky7@alvherre.pgsql  

commit   : 152c9f7b8f01437780d9f87bfe945bba47efdd0a    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Tue, 20 Sep 2022 12:04:37 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Tue, 20 Sep 2022 12:04:37 -0400    

clang 15+ will issue a set-but-not-used warning when the only  
use of a variable is in autoincrements (e.g., "foo++;").  
That's perfectly sensible, but it detects a few more cases that  
we'd not noticed before.  Silence the warnings with our usual  
methods, such as PG_USED_FOR_ASSERTS_ONLY, or in one case by  
actually removing a useless variable.  
  
One thing that we can't nicely get rid of is that with %pure-parser,  
Bison emits "yynerrs" as a local variable that falls foul of this  
warning.  To silence those, I inserted "(void) yynerrs;" in the  
top-level productions of affected grammars.  
  
Per recently-established project policy, this is a candidate  
for back-patching into out-of-support branches: it suppresses  
annoying compiler warnings but changes no behavior.  Hence,  
back-patch to 9.5, which is as far as these patches go without  
issues.  (A preliminary check shows that the prior branches  
need some other set-but-not-used cleanups too, so I'll leave  
them for another day.)  
  
Discussion: https://postgr.es/m/514615.1663615243@sss.pgh.pa.us  

commit   : c9a21fea44ca5722dbfcced0dfdc84db063aff71    
  
author   : Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Tue, 20 Sep 2022 12:38:48 +0200    
  
committer: Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Tue, 20 Sep 2022 12:38:48 +0200    

Otherwise, it can fail given sufficient bad luck.  
  
Backpatch to 15.  
  
Discussion: https://postgr.es/m/537759.1663625579@sss.pgh.pa.us  

commit   : 6f0dad88b2eff56e1ddada983f27427250b8a3c3    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Tue, 20 Sep 2022 19:28:37 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Tue, 20 Sep 2022 19:28:37 +0900    

The parameter controlling if two-phase transactions can be decoded was  
named "two_phase" in the documentation while its procedure defines  
"twophase".  
  
Author: Florin Irion  
Discussion: https://postgr.es/m/5eeabd10-1aff-ea61-f92d-9fa0d9a7e207@gmail.com  
Backpatch-through: 14  

commit   : e9123197c844a3a7fe20d723477fcdbef5b89f93    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Tue, 20 Sep 2022 18:13:00 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Tue, 20 Sep 2022 18:13:00 +0900    

These variables used XLogRecPtr instead of RepOriginId.  
  
Author: Masahiko Sawada  
Discussion: https://postgr.es/m/CAD21AoBm-vNyBSXGp4bmJGvhr=S-EGc5q1dtV70cFTcJvLhC=Q@mail.gmail.com  
Backpatch-through: 14  

commit   : bfcf1b34805f70df48eedeec237230d0cc1154a6    
  
author   : Peter Geoghegan <pg@bowt.ie>    
date     : Mon, 19 Sep 2022 19:18:36 -0700    
  
committer: Peter Geoghegan <pg@bowt.ie>    
date     : Mon, 19 Sep 2022 19:18:36 -0700    

Make sure that function declarations use names that exactly match the  
corresponding names from function definitions in storage, catalog,  
access method, executor, and logical replication code, as well as in  
miscellaneous utility/library code.  
  
Like other recent commits that cleaned up function parameter names, this  
commit was written with help from clang-tidy.  Later commits will do the  
same for other parts of the codebase.  
  
Author: Peter Geoghegan <pg@bowt.ie>  
Reviewed-By: David Rowley <dgrowleyml@gmail.com>  
Discussion: https://postgr.es/m/CAH2-WznJt9CMM9KJTMjJh_zbL5hD9oX44qdJ4aqZtjFi-zA3Tg@mail.gmail.com  

commit   : c47885bd8b6997ccb0cc1997f61f6f98a79ce32a    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Mon, 19 Sep 2022 18:03:17 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Mon, 19 Sep 2022 18:03:17 -0700    

The motivation for this is twofold. For one the meson patchset would like to  
have more control over the logfiles. For another, the log file location for  
tap tests (tmp_check/log) is not symmetric to the log location for  
pg_regress/isolation tests (log/).  
  
This commit does not change the default location for log files for tap tests,  
as that'd break the buildfarm log collection, it just provides the  
infrastructure for doing so.  
  
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>  
Reviewed-by: Peter Eisentraut <peter.eisentraut@enterprisedb.com>  
Reviewed-by: Justin Pryzby <pryzby@telsasoft.com>  
Discussion: https://postgr.es/m/1131990.1660661896@sss.pgh.pa.us  
Discussion: https://postgr.es/m/20220828170806.GN2342@telsasoft.com  

commit   : bb54bf22900f76dab6899594d47f55d62e912143    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Mon, 19 Sep 2022 18:00:50 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Mon, 19 Sep 2022 18:00:50 -0700    

This is motivated by the meson patchset, which wants to put the log / data for  
tests in a different place than the autoconf build. Right now log files for  
tap tests have to be inside $TESTDIR/tmp_check, whereas log files for  
pg_regress/isolationtester are outside of tmp_check. This change doesn't fix  
the latter, but is a prerequisite.  
  
The only test that needs adjustment is 010_tab_completion.pl, as it hardcoded  
the tmp_check/ directory. Instead create a dedicated directory for the test  
files.  It's also a bit cleaner independently, because it doesn't intermingle  
the test files with more important things like the log/ directory.  
  
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>  
Reviewed-by: Peter Eisentraut <peter.eisentraut@enterprisedb.com>  
Discussion: https://postgr.es/m/1131990.1660661896@sss.pgh.pa.us  
Discussion: https://postgr.es/m/d861493c-ed20-c251-7a89-7924f5197341@enterprisedb.com  

commit   : 4bac9600f09a9b9ba7daa3ba69495a877f51e6c3    
  
author   : Peter Geoghegan <pg@bowt.ie>    
date     : Mon, 19 Sep 2022 16:46:23 -0700    
  
committer: Peter Geoghegan <pg@bowt.ie>    
date     : Mon, 19 Sep 2022 16:46:23 -0700    

Make sure that function declarations use names that exactly match the  
corresponding names from function definitions.  Having parameter names  
that are reliably consistent in this way will make it easier to reason  
about groups of related C functions from the same translation unit as a  
module.  It will also make certain refactoring tasks easier.  
  
Like other recent commits that cleaned up function parameter names, this  
commit was written with help from clang-tidy.  Later commits will do the  
same for other parts of the codebase.  
  
Author: Peter Geoghegan <pg@bowt.ie>  
Reviewed-By: David Rowley <dgrowleyml@gmail.com>  
Discussion: https://postgr.es/m/CAH2-WznJt9CMM9KJTMjJh_zbL5hD9oX44qdJ4aqZtjFi-zA3Tg@mail.gmail.com  

commit   : cb8ff7ed5ac907a4a574413f3e46a3522d7b164c    
  
author   : Peter Geoghegan <pg@bowt.ie>    
date     : Mon, 19 Sep 2022 15:47:04 -0700    
  
committer: Peter Geoghegan <pg@bowt.ie>    
date     : Mon, 19 Sep 2022 15:47:04 -0700    

Adjust a handful of remaining function prototypes that were overlooked  
by recent commit bc2187ed.  This oversight wasn't caught by clang-tidy  
because the functions in question are only built in custom REG_DEBUG  
builds.  
  
Author: Peter Geoghegan <pg@bowt.ie>  
Reported-By: Tom Lane <tgl@sss.pgh.pa.us>  

commit   : 70df2df1cc89e69e31b31b6aa0d65fd72935af38    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Mon, 19 Sep 2022 15:34:50 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Mon, 19 Sep 2022 15:34:50 -0700    

The main issue with using gendef.pl as-is for meson is that with meson the  
filenames are a bit longer, exceeding the max commandline length when calling  
dumpbin with all objects. As it's easier to pass in a library anyway, do so.  
  
The .def file location, input and temporary file location need to be tunable  
as well.  
  
This also fixes a bug in gendef.pl: The logic when to regenerate was broken  
and never avoid regenerating.  
  
Author: Andres Freund <andres@anarazel.de>  
Reviewed-By: Peter Eisentraut <peter.eisentraut@enterprisedb.com>  
Discussion: https://postgr.es/m/20220809071055.rgikv3qn74ypnnbb@awork3.anarazel.de  
Discussion: https://postgr.es/m/7dae5979-c6c0-cec5-7a36-76a85aa8053d@enterprisedb.com  

commit   : 1091b48cd761abc7f697fa9c4e018c46763b46fb    
  
author   : Peter Eisentraut <peter@eisentraut.org>    
date     : Mon, 19 Sep 2022 18:30:05 -0400    
  
committer: Peter Eisentraut <peter@eisentraut.org>    
date     : Mon, 19 Sep 2022 18:30:05 -0400    

commit   : c4f8e89fef3d4cd8b0791637667fd984d6f38fb2    
  
author   : Peter Geoghegan <pg@bowt.ie>    
date     : Mon, 19 Sep 2022 15:13:42 -0700    
  
committer: Peter Geoghegan <pg@bowt.ie>    
date     : Mon, 19 Sep 2022 15:13:42 -0700    

Make our copy of the IANA timezone library use named parameters in  
function declarations.  Also make sure that parameter names from each  
function's declaration match corresponding definition parameter names.  
  
This makes the timezone code follow Postgres coding standards.  The  
value of having a consistent standard everywhere seems to outweigh the  
cost of keeping the function declarations in sync with future IANA  
releases.  
  
Author: Peter Geoghegan <pg@bowt.ie>  
Reviewed-By: David Rowley <dgrowleyml@gmail.com>  
Discussion: https://postgr.es/m/CAH2-WznJt9CMM9KJTMjJh_zbL5hD9oX44qdJ4aqZtjFi-zA3Tg@mail.gmail.com  

commit   : bc2187ed63c56bb9cd99f6613f3e2ba56afb22fe    
  
author   : Peter Geoghegan <pg@bowt.ie>    
date     : Mon, 19 Sep 2022 15:10:24 -0700    
  
committer: Peter Geoghegan <pg@bowt.ie>    
date     : Mon, 19 Sep 2022 15:10:24 -0700    

Make regex code consistently use named parameters in function  
declarations.  Also make sure that parameter names from each function's  
declaration match corresponding definition parameter names.  
  
This makes Henry Spencer's regex code follow Postgres coding standards.  
  
Author: Peter Geoghegan <pg@bowt.ie>  
Reviewed-By: David Rowley <dgrowleyml@gmail.com>  
Discussion: https://postgr.es/m/CAH2-WznJt9CMM9KJTMjJh_zbL5hD9oX44qdJ4aqZtjFi-zA3Tg@mail.gmail.com  

commit   : 55b4966365fa76bda275c409f3aefad43243f12c    
  
author   : David Rowley <drowley@postgresql.org>    
date     : Tue, 20 Sep 2022 10:03:26 +1200    
  
committer: David Rowley <drowley@postgresql.org>    
date     : Tue, 20 Sep 2022 10:03:26 +1200    

The header comment for get_cheapest_group_keys_order() claimed that the  
output arguments were set to a newly allocated list which may be freed by  
the calling function, however, this was not always true as the function  
would simply leave these arguments untouched in some cases.  
  
This tripped me up when working on 1349d2790 as I mistakenly assumed I  
could perform a list_concat with the output parameters.  That turned out  
bad due to list_concat modifying the original input lists.  
  
In passing, make it more clear that the number of distinct values is  
important to reduce tiebreaks during sorts.  Also, explain what the  
n_preordered parameter means.  
  
Backpatch-through: 15, where get_cheapest_group_keys_order was introduced.  

commit   : 78a9af1a27641ad983354bbaaaa4b7c00ea390f6    
  
author   : David Rowley <drowley@postgresql.org>    
date     : Tue, 20 Sep 2022 09:13:49 +1200    
  
committer: David Rowley <drowley@postgresql.org>    
date     : Tue, 20 Sep 2022 09:13:49 +1200    

The comment claimed we don't consider other orders of the GROUP BY clause,  
but this is no longer true as of db0d67db2.  
  
Discussion: https://postgr.es/m/CAApHDvq65=9Ro+hLX1i9ugWEiNDvHrBibAO7ARcTnf38_JE+UQ@mail.gmail.com  
Backpatch-through: 15, where db0d67db2 was introduced.  

commit   : 66fa8ff637982b51257d80626dd00dccf3ad9fa6    
  
author   : David Rowley <drowley@postgresql.org>    
date     : Tue, 20 Sep 2022 08:37:02 +1200    
  
committer: David Rowley <drowley@postgresql.org>    
date     : Tue, 20 Sep 2022 08:37:02 +1200    

Author: Justin Pryzby  
Discussion: https://postgr.es/m/20220919111000.GW31833@telsasoft.com  

commit   : cab3ce7a065b8ec04303d680a64bd9aa9bdd29db    
  
author   : Peter Eisentraut <peter@eisentraut.org>    
date     : Mon, 19 Sep 2022 15:22:43 -0400    
  
committer: Peter Eisentraut <peter@eisentraut.org>    
date     : Mon, 19 Sep 2022 15:22:43 -0400    

Similar to 1e08576691bf1a25c0e28745e5e800c44f2a1c76, but for the icu  
test suite.  
  
Reported-by: Christoph Berg <myon@debian.org>  
Discussion: https://www.postgresql.org/message-id/YyWeU61YMFwjVdxE@msg.df7cb.de  

commit   : 48a257d444a787941ba3da24d65e6cbe31461d0a    
  
author   : Robert Haas <rhaas@postgresql.org>    
date     : Mon, 19 Sep 2022 14:21:59 -0400    
  
committer: Robert Haas <rhaas@postgresql.org>    
date     : Mon, 19 Sep 2022 14:21:59 -0400    

If role A is a direct or indirect member of role B but does not inherit  
B's privileges (because at least one relevant grant was created WITH  
INHERIT FALSE) then A should not be permitted to bypass privilege  
checks that require the privileges of B. For example, A can't change  
the privileges of objects owned by B, nor can A drop those objects.  
  
However, up until now, it's been possible for A to change default  
privileges for role B. That doesn't seem to be correct, because a  
non-inherited role grant is only supposed to permit you to assume  
the identity of the granted role via SET ROLE, and should not  
otherwise permit you to exercise the privileges of that role. Most  
places followed that rule, but this case was an exception.  
  
This could be construed as a security vulnerability, but it does not  
seem entirely clear cut, since older branches were fuzzy about the  
distinction between is_member_of_role() and has_privs_of_role() in  
a number of other ways as well. Because of this, and because  
user-visible behavior changes in minor releases are to be avoided  
whenever possible, no back-patch.  
  
Discussion: http://postgr.es/m/CA+TgmobG_YUP06R_PM_2Z7wR0qv_52gQPHD8CYXbJva0cf0E+A@mail.gmail.com  

commit   : ebfb814f7ce0d5ab6f47f0b86db51a1b8f3342f4    
  
author   : Robert Haas <rhaas@postgresql.org>    
date     : Mon, 19 Sep 2022 12:53:46 -0400    
  
committer: Robert Haas <rhaas@postgresql.org>    
date     : Mon, 19 Sep 2022 12:53:46 -0400    

Normally when we use object-oriented programming techniques, we  
provide a pointer to an object and then some way of looking up the  
associated table of callbacks, but walmethods.c/h took the alternative  
approach of providing only a pointer to the table of callbacks and  
thus imposed the artificial restriction that there could only ever be  
one object of each type, so that the callbacks could find it via a  
global variable. That doesn't seem like the right idea, so revise the  
approach.  
  
Each callback which does not already have an argument of type  
Walfile * now takes a pointer to the relevant WalWriteMethod *  
so that these callbacks need not rely on there being only one  
object of each type.  
  
Freeing a WalWriteMethod is now performed via a callback provided  
for that purpose rather than requiring the caller to know which  
WAL method they want to free.  
  
Discussion: http://postgr.es/m/CA+TgmoZS0Kw98fOoAcGz8B9iDhdqB4Be4e=vDZaJZ5A-xMYBqA@mail.gmail.com  

commit   : c35ba141de1fa04373671ba24c73eb0fe4862415    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 19 Sep 2022 12:16:02 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 19 Sep 2022 12:16:02 -0400    

The API contract for planstate_tree_walker() callbacks is that they  
take a PlanState pointer and a context pointer.  Somebody figured  
they could save a couple lines of code by ignoring that, and passing  
ExecShutdownNode itself as the walker even though it has but one  
argument.  Somewhat remarkably, we've gotten away with that so far.  
However, it seems clear that the upcoming C2x standard means to  
forbid such cases, and compilers that actively break such code  
likely won't be far behind.  So spend the extra few lines of code  
to do it honestly with a separate walker function.  
  
In HEAD, we might as well go further and remove ExecShutdownNode's  
useless return value.  I left that as-is in back branches though,  
to forestall complaints about ABI breakage.  
  
Back-patch, with the thought that this might become of practical  
importance before our stable branches are all out of service.  
It doesn't seem to be fixing any live bug on any currently known  
platform, however.  
  
Discussion: https://postgr.es/m/208054.1663534665@sss.pgh.pa.us  

commit   : 4fd14794945e60c4aedad84b06ff1e2a7a6236f0    
  
author   : Robert Haas <rhaas@postgresql.org>    
date     : Mon, 19 Sep 2022 11:20:18 -0400    
  
committer: Robert Haas <rhaas@postgresql.org>    
date     : Mon, 19 Sep 2022 11:20:18 -0400    

This makes the curent file position and pathname visible in a generic  
way, so we no longer need current_walfile_name global variable or the  
get_current_pos() method. Since that purported to be able to fail but  
never actually did, this also lets us get rid of some unnecessary  
error-handling code.  
  
One risk of this change is that the get_current_pos() method  
previously cleared the error indicator, and that will no longer happen  
with the new approach. I looked for a way that this could cause problems  
and did not find one.  
  
The previous code was confused about whether "Walfile" was the  
implementation-dependent structure representing a WAL file or  
whether it was a pointer to that stucture. Some of the code used it  
one way, and some in the other. The compiler tolerated that because  
void * is interchangeable with void **, but now that Walfile is a  
struct, it's necessary to be consistent. Hence, some references to  
"Walfile" have been converted to "Walfile *".  
  
Discussion: http://postgr.es/m/CA+TgmoZS0Kw98fOoAcGz8B9iDhdqB4Be4e=vDZaJZ5A-xMYBqA@mail.gmail.com  

commit   : 1fe1d09652d796392785922bef54e0ffda6e1f05    
  
author   : Peter Eisentraut <peter@eisentraut.org>    
date     : Mon, 19 Sep 2022 06:35:01 -0400    
  
committer: Peter Eisentraut <peter@eisentraut.org>    
date     : Mon, 19 Sep 2022 06:35:01 -0400    

commit   : a23417790631e50f54bdcf5e40bf84e2dbd1c34b    
  
author   : Amit Kapila <akapila@postgresql.org>    
date     : Mon, 19 Sep 2022 14:21:39 +0530    
  
committer: Amit Kapila <akapila@postgresql.org>    
date     : Mon, 19 Sep 2022 14:21:39 +0530    

Author: Hou Zhijie and Zhang Mingli  
Discussion: https://postgr.es/m/OS0PR01MB57162559C01FE2848C12E8F7944D9@OS0PR01MB5716.jpnprd01.prod.outlook.com  

commit   : 08f8af983a8bd8ef78e48bab624071998a26cbb7    
  
author   : John Naylor <john.naylor@postgresql.org>    
date     : Mon, 19 Sep 2022 11:36:51 +0700    
  
committer: John Naylor <john.naylor@postgresql.org>    
date     : Mon, 19 Sep 2022 11:36:51 +0700    

Japin Li  
  
Reviewed by Kyotaro Horiguchi  
Discussion: https://www.postgresql.org/message-id/MEYP282MB1669459813B36FB5EAA38434B6499@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM  

commit   : f66d997fd024223a78ebf64bf42f98f639b0b942    
  
author   : Peter Geoghegan <pg@bowt.ie>    
date     : Sun, 18 Sep 2022 12:05:07 -0700    
  
committer: Peter Geoghegan <pg@bowt.ie>    
date     : Sun, 18 Sep 2022 12:05:07 -0700    

The function ReorderBufferCommitChild() was overlooked by initial work  
from commit 035ce1fe.  
  
Author: Peter Geoghegan <pg@bowt.ie>  
Discussion: https://postgr.es/m/CAH2-WzkhzFESnRo+VaGqyEZuzc33Dw09BdZBVmW896Sa22ci_A@mail.gmail.com  

commit   : 9f65aaa408f60081a057f559b717100b55511698    
  
author   : Michael Paquier <michael@paquier.xyz>    
date     : Sun, 18 Sep 2022 15:33:16 +0900    
  
committer: Michael Paquier <michael@paquier.xyz>    
date     : Sun, 18 Sep 2022 15:33:16 +0900    

Since c7aba7c, the transform method used during parse analysis of a  
subcripting construct has moved from transformAssignmentSubscripts() to  
the per-type transform method (arrays or arbitrary types) the step that  
checks for slicing support, but transformAssignmentSubscripts() has kept  
traces of it.  Removing it simplifies the code, so let's clean up all  
that.  
  
Author: Zhang Mingli  
Reviewed-by: Richard Guo  
Discussion: https://postgr.es/m/0d7041ac-c704-48ad-86fd-e05feddf08ed@Spark  

commit   : 035ce1feb2ed27680558ebc5cd1455041c8ec3cf    
  
author   : Peter Geoghegan <pg@bowt.ie>    
date     : Sat, 17 Sep 2022 17:20:17 -0700    
  
committer: Peter Geoghegan <pg@bowt.ie>    
date     : Sat, 17 Sep 2022 17:20:17 -0700    

Make reorderbuffer.h function declarations consistently use named  
parameters.  Also make sure that the declarations use names that match  
corresponding names from function definitions in reorderbuffer.c.  This  
makes the definitions easier to follow, especially in the case of  
functions that happen to have adjoining arguments of the same type.  
  
This patch was written with help from clang-tidy.  Specifically, its  
"readability-inconsistent-declaration-parameter-name" check and its  
"readability-named-parameter" check were used.  
  
Author: Peter Geoghegan <pg@bowt.ie>  
Discussion: https://postgr.es/m/3955318.1663377656@sss.pgh.pa.us  

commit   : 4274dc223ce75b2adf7b7cde5e00df7bbdd2a061    
  
author   : Peter Geoghegan <pg@bowt.ie>    
date     : Sat, 17 Sep 2022 16:54:17 -0700    
  
committer: Peter Geoghegan <pg@bowt.ie>    
date     : Sat, 17 Sep 2022 16:54:17 -0700    

The function has a bool argument named "case_insensitive", but that was  
spelled "case_sensitive" in the declaration.  Make them consistent now  
to avoid confusion in the future.  
  
Author: Peter Geoghegan <pg@bowt.ie>  
Reviewed-By: Michael Paquiër <michael@paquier.xyz>  
Discussion: https://postgr.es/m/CAH2-WznJt9CMM9KJTMjJh_zbL5hD9oX44qdJ4aqZtjFi-zA3Tg@mail.gmail.com  
Backpatch: 10-  

commit   : 43fcaa345d5af45101c5d96dd164f1ebed686b2c    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Sat, 17 Sep 2022 09:21:59 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Sat, 17 Sep 2022 09:21:59 -0700    

Frontend code shouldn't include postgres.h. Some files in src/port/ need to  
include postgres.h/postgres_fe.h, but these files don't.  
  
Discussion: https://postgr.es/m/20220915022626.5xx3ccgkzpkqw5mq@awork3.anarazel.de  
Backpatch: 12-, where 3fd2a7932ef introduced (some) of these files  

commit   : 8d513a6b71b7ad94331a485adaf00adce8ee74ec    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Sat, 17 Sep 2022 09:15:12 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Sat, 17 Sep 2022 09:15:12 -0700    

We got rid of the need for them in 4f5f485d10c and 846e91e0223.  
  
Discussion: https://postgr.es/m/20220915022626.5xx3ccgkzpkqw5mq@awork3.anarazel.de  

commit   : 9d3ebba729ebaf5882a92f0f5f662a3312037605    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Fri, 16 Sep 2022 14:08:40 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Fri, 16 Sep 2022 14:08:40 -0700