PostgreSQL 9.2.10 commit log

commit   : 9f20f2fc43f7dbe5a60958bc41f24130957560a3    
  
author   : Tom Lane <[email protected]>    
date     : Mon, 2 Feb 2015 15:44:39 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Mon, 2 Feb 2015 15:44:39 -0500    

commit   : b8f0a57d13fce3c61f99f07077e07ccba0848e71    
  
author   : Tom Lane <[email protected]>    
date     : Mon, 2 Feb 2015 11:24:08 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Mon, 2 Feb 2015 11:24:08 -0500    

Add entries for security issues.  
  
Security: CVE-2015-0241 through CVE-2015-0244  

commit   : 289592b23eef85b82034595b6261c7a6b0326139    
  
author   : Heikki Linnakangas <[email protected]>    
date     : Mon, 2 Feb 2015 17:09:12 +0200    
  
committer: Heikki Linnakangas <[email protected]>    
date     : Mon, 2 Feb 2015 17:09:12 +0200    

If any error occurred while we were in the middle of reading a protocol  
message from the client, we could lose sync, and incorrectly try to  
interpret a part of another message as a new protocol message. That will  
usually lead to an "invalid frontend message" error that terminates the  
connection. However, this is a security issue because an attacker might  
be able to deliberately cause an error, inject a Query message in what's  
supposed to be just user data, and have the server execute it.  
  
We were quite careful to not have CHECK_FOR_INTERRUPTS() calls or other  
operations that could ereport(ERROR) in the middle of processing a message,  
but a query cancel interrupt or statement timeout could nevertheless cause  
it to happen. Also, the V2 fastpath and COPY handling were not so careful.  
It's very difficult to recover in the V2 COPY protocol, so we will just  
terminate the connection on error. In practice, that's what happened  
previously anyway, as we lost protocol sync.  
  
To fix, add a new variable in pqcomm.c, PqCommReadingMsg, that is set  
whenever we're in the middle of reading a message. When it's set, we cannot  
safely ERROR out and continue running, because we might've read only part  
of a message. PqCommReadingMsg acts somewhat similarly to critical sections  
in that if an error occurs while it's set, the error handler will force the  
connection to be terminated, as if the error was FATAL. It's not  
implemented by promoting ERROR to FATAL in elog.c, like ERROR is promoted  
to PANIC in critical sections, because we want to be able to use  
PG_TRY/CATCH to recover and regain protocol sync. pq_getmessage() takes  
advantage of that to prevent an OOM error from terminating the connection.  
  
To prevent unnecessary connection terminations, add a holdoff mechanism  
similar to HOLD/RESUME_INTERRUPTS() that can be used hold off query cancel  
interrupts, but still allow die interrupts. The rules on which interrupts  
are processed when are now a bit more complicated, so refactor  
ProcessInterrupts() and the calls to it in signal handlers so that the  
signal handlers always call it if ImmediateInterruptOK is set, and  
ProcessInterrupts() can decide to not do anything if the other conditions  
are not met.  
  
Reported by Emil Lenngren. Patch reviewed by Noah Misch and Andres Freund.  
Backpatch to all supported versions.  
  
Security: CVE-2015-0244  

commit   : d1972da8ce5857cec09645c11d8c7ac81b87d887    
  
author   : Noah Misch <[email protected]>    
date     : Mon, 2 Feb 2015 10:00:45 -0500    
  
committer: Noah Misch <[email protected]>    
date     : Mon, 2 Feb 2015 10:00:45 -0500    

This covers alterations to buffer sizing and zeroing made between imath  
1.3 and imath 1.20.  Valgrind Memcheck identified the buffer overruns  
and reliance on uninitialized data; their exploit potential is unknown.  
Builds specifying --with-openssl are unaffected, because they use the  
OpenSSL BIGNUM facility instead of imath.  Back-patch to 9.0 (all  
supported versions).  
  
Security: CVE-2015-0243  

commit   : d95ebe0ac39b946c207ed0c37bba0365132ba3c6    
  
author   : Noah Misch <[email protected]>    
date     : Mon, 2 Feb 2015 10:00:45 -0500    
  
committer: Noah Misch <[email protected]>    
date     : Mon, 2 Feb 2015 10:00:45 -0500    

Most callers pass a stack buffer.  The ensuing stack smash can crash the  
server, and we have not ruled out the viability of attacks that lead to  
privilege escalation.  Back-patch to 9.0 (all supported versions).  
  
Marko Tiikkaja  
  
Security: CVE-2015-0243  

commit   : c6c6aa288c7d2835f587e89847c7355d43e548e3    
  
author   : Bruce Momjian <[email protected]>    
date     : Mon, 2 Feb 2015 10:00:45 -0500    
  
committer: Bruce Momjian <[email protected]>    
date     : Mon, 2 Feb 2015 10:00:45 -0500    

Prevent port/snprintf() from overflowing its local fixed-size  
buffer and pad to the desired number of digits with zeros, even  
if the precision is beyond the ability of the native sprintf().  
port/snprintf() is only used on systems that lack a native  
snprintf().  
  
Reported by Bruce Momjian. Patch by Tom Lane.	Backpatch to all  
supported versions.  
  
Security: CVE-2015-0242  

commit   : e09651e9d90011ff634ac1c10c8e67e3881687c8    
  
author   : Bruce Momjian <[email protected]>    
date     : Mon, 2 Feb 2015 10:00:45 -0500    
  
committer: Bruce Momjian <[email protected]>    
date     : Mon, 2 Feb 2015 10:00:45 -0500    

Previously very long localized month and weekday strings could  
overflow the allocated buffers, causing a server crash.  
  
Reported and patch reviewed by Noah Misch.  Backpatch to all  
supported versions.  
  
Security: CVE-2015-0241  

commit   : 5ae3bf1af34082f3b53955053ce11a6f20b1b751    
  
author   : Bruce Momjian <[email protected]>    
date     : Mon, 2 Feb 2015 10:00:44 -0500    
  
committer: Bruce Momjian <[email protected]>    
date     : Mon, 2 Feb 2015 10:00:44 -0500    

Previously very long field masks for floats could access memory  
beyond the existing buffer allocated to hold the result.  
  
Reported by Andres Freund and Peter Geoghegan.	Backpatch to all  
supported versions.  
  
Security: CVE-2015-0241  

commit   : 611037d5d46c10e1db5313acce74af328f105445    
  
author   : Tom Lane <[email protected]>    
date     : Mon, 2 Feb 2015 00:18:54 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Mon, 2 Feb 2015 00:18:54 -0500    

The variable name isn't optional --- looks like a copy-and-paste-o from  
the \set command, where it is.  
  
Dilip Kumar  

commit   : b77b40d8864aa6e1b28b66b83e52a135825fafe5    
  
author   : Peter Eisentraut <[email protected]>    
date     : Sun, 1 Feb 2015 23:07:30 -0500    
  
committer: Peter Eisentraut <[email protected]>    
date     : Sun, 1 Feb 2015 23:07:30 -0500    

Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git  
Source-Git-Hash: 47199c5813321fac9558fe6629fcb48989a28e44  

commit   : 040f5ef503b8bf7cbf08d8e3f70de7213372ceb2    
  
author   : Peter Eisentraut <[email protected]>    
date     : Sun, 1 Feb 2015 22:36:44 -0500    
  
committer: Peter Eisentraut <[email protected]>    
date     : Sun, 1 Feb 2015 22:36:44 -0500    

The previous wording claimed that the file was always in /etc, but of  
course this varies with the installation layout.  Write instead that it  
can be found via `pg_config --sysconfdir`.  Even though this is still  
somewhat incorrect because it doesn't account of moved installations, it  
at least conveys that the location depends on the installation.  

commit   : 9eadf637938798f84b7e5495fd13e74441a81bbd    
  
author   : Tom Lane <[email protected]>    
date     : Sun, 1 Feb 2015 16:53:22 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Sun, 1 Feb 2015 16:53:22 -0500    

commit   : ad48256ba387fba2401bb831f394f3aa2fc15afd    
  
author   : Tom Lane <[email protected]>    
date     : Sat, 31 Jan 2015 18:35:27 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Sat, 31 Jan 2015 18:35:27 -0500    

"ECHO all" is ignored for interactive input, and has been for a very long  
time, though possibly not for as long as the documentation has claimed the  
opposite.  Fix that, and also note that empty lines aren't echoed, which  
while dubious is another longstanding behavior (it's embedded in our  
regression test files for one thing).  Per bug #12721 from Hans Ginzel.  
  
In HEAD, also improve the code comments in this area, and suppress an  
unnecessary fflush(stdout) when we're not echoing.  That would likely  
be safe to back-patch, but I'll not risk it mere hours before a release  
wrap.  

commit   : c9048d353f1361642527d7fe31b6368237ca9079    
  
author   : Tom Lane <[email protected]>    
date     : Fri, 30 Jan 2015 22:45:44 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Fri, 30 Jan 2015 22:45:44 -0500    

DST law changes in Chile and Mexico (state of Quintana Roo).  
Historical changes for Iceland.  

commit   : a97dfdfd9043449e67aeefe8248891b43b37eed8    
  
author   : Tom Lane <[email protected]>    
date     : Fri, 30 Jan 2015 13:05:04 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Fri, 30 Jan 2015 13:05:04 -0500    

Coverity points out that mdc_finish returns a pointer to a local buffer  
(which of course is gone as soon as the function returns), leaving open  
a risk of misbehaviors possibly as bad as a stack overwrite.  
  
In reality, the only possible call site is in process_data_packets()  
which does not examine the returned pointer at all.  So there's no  
live bug, but nonetheless the code is confusing and risky.  Refactor  
to avoid the issue by letting process_data_packets() call mdc_finish()  
directly instead of going through the pullf_read() API.  
  
Although this is only cosmetic, it seems good to back-patch so that  
the logic in pgp-decrypt.c stays in sync across all branches.  
  
Marko Kreen  

commit   : 915290ee9033849e4fe25a066a135891f3a0982a    
  
author   : Stephen Frost <[email protected]>    
date     : Thu, 29 Jan 2015 21:59:57 -0500    
  
committer: Stephen Frost <[email protected]>    
date     : Thu, 29 Jan 2015 21:59:57 -0500    

In 804b6b6db4dcfc590a468e7be390738f9f7755fb we modified  
BuildIndexValueDescription to pay attention to which columns are visible  
to the user, but unfortunatley that commit neglected to consider indexes  
which are built on expressions.  
  
Handle error-reporting of violations of constraint indexes based on  
expressions by not returning any detail when the user does not have  
table-level SELECT rights.  
  
Backpatch to 9.0, as the prior commit was.  
  
Pointed out by Tom.  

commit   : 66cc746809057601fee992f3ddb85ea7eabd7f4a    
  
author   : Tom Lane <[email protected]>    
date     : Thu, 29 Jan 2015 20:18:42 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Thu, 29 Jan 2015 20:18:42 -0500    

connectby() didn't adequately check that the constructed SQL query returns  
what it's expected to; in fact, since commit 08c33c426bfebb32 it wasn't  
checking that at all.  This could result in a null-pointer-dereference  
crash if the constructed query returns only one column instead of the  
expected two.  Less excitingly, it could also result in surprising data  
conversion failures if the constructed query returned values that were  
not I/O-conversion-compatible with the types specified by the query  
calling connectby().  
  
In all branches, insist that the query return at least two columns;  
this seems like a minimal sanity check that can't break any reasonable  
use-cases.  
  
In HEAD, insist that the constructed query return the types specified by  
the outer query, including checking for typmod incompatibility, which the  
code never did even before it got broken.  This is to hide the fact that  
the implementation does a conversion to text and back; someday we might  
want to improve that.  
  
In back branches, leave that alone, since adding a type check in a minor  
release is more likely to break things than make people happy.  Type  
inconsistencies will continue to work so long as the actual type and  
declared type are I/O representation compatible, and otherwise will fail  
the same way they used to.  
  
Also, in all branches, be on guard for NULL results from the constructed  
query, which formerly would cause null-pointer dereference crashes.  
We now print the row with the NULL but don't recurse down from it.  
  
In passing, get rid of the rather pointless idea that  
build_tuplestore_recursively() should return the same tuplestore that's  
passed to it.  
  
Michael Paquier, adjusted somewhat by me  

commit   : 8251acf23b098e92c4ff6252ef489b09c3f3895d    
  
author   : Andres Freund <[email protected]>    
date     : Thu, 29 Jan 2015 17:49:03 +0100    
  
committer: Andres Freund <[email protected]>    
date     : Thu, 29 Jan 2015 17:49:03 +0100    

GetLockConflicts() has for a long time not properly terminated the  
returned array. During normal processing the returned array is zero  
initialized which, while not pretty, is sufficient to be recognized as  
a invalid virtual transaction id. But the HotStandby case is more than  
aesthetically broken: The allocated (and reused) array is neither  
zeroed upon allocation, nor reinitialized, nor terminated.  
  
Not having a terminating element means that the end of the array will  
not be recognized and that recovery conflict handling will thus read  
ahead into adjacent memory. Only terminating when hitting memory  
content that looks like a invalid virtual transaction id.  Luckily  
this seems so far not have caused significant problems, besides making  
recovery conflict more expensive.  
  
Discussion: [email protected]  
  
Backpatch into all supported branches.  

commit   : 61729e99d4653d55a2f093dd9bda2c06a1a93135    
  
author   : Heikki Linnakangas <[email protected]>    
date     : Thu, 29 Jan 2015 19:35:55 +0200    
  
committer: Heikki Linnakangas <[email protected]>    
date     : Thu, 29 Jan 2015 19:35:55 +0200    

When gin_fuzzy_search_limit was used, we could jump out of startScan()  
without calling startScanKey(). That was harmless in 9.3 and below, because  
startScanKey()() didn't do anything interesting, but in 9.4 it initializes  
information needed for skipping entries (aka GIN fast scans), and you  
readily get a segfault if it's not done. Nevertheless, it was clearly wrong  
all along, so backpatch all the way to 9.1 where the early return was  
introduced.  
  
(AFAICS startScanKey() did nothing useful in 9.3 and below, because the  
fields it initialized were already initialized in ginFillScanKey(), but I  
don't dare to change that in a minor release. ginFillScanKey() is always  
called in gingetbitmap() even though there's a check there to see if the  
scan keys have already been initialized, because they never are; ginrescan()  
free's them.)  
  
In the passing, remove unnecessary if-check from the second inner loop in  
startScan(). We already check in the first loop that the condition is true  
for all entries.  
  
Reported by Olaf Gawenda, bug #12694, Backpatch to 9.1 and above, although  
AFAICS it causes a live bug only in 9.4.  

commit   : 8e36028fcc98335ec34f5c6a742432e47db7ebfa    
  
author   : Stephen Frost <[email protected]>    
date     : Wed, 28 Jan 2015 17:43:12 -0500    
  
committer: Stephen Frost <[email protected]>    
date     : Wed, 28 Jan 2015 17:43:12 -0500    

Commit 804b6b6db4dcfc590a468e7be390738f9f7755fb added the build of a  
range table in copy.c to initialize the EState es_range_table since it  
can be needed in error paths.  Unfortunately, that commit didn't  
appreciate that some code paths might end up not initializing the rte  
which is used to build the range table.  
  
Fix that and clean up a couple others things along the way- build it  
only once and don't explicitly set it on the !is_from path as it  
doesn't make any sense there (cstate is palloc0'd, so this isn't an  
issue from an initializing standpoint either).  
  
The prior commit went back to 9.0, but this only goes back to 9.1 as  
prior to that the range table build happens immediately after building  
the RTE and therefore doesn't suffer from this issue.  
  
Pointed out by Robert.  

commit   : d49f84b084d82aac3ddc387f9f306c28240f62f7    
  
author   : Stephen Frost <[email protected]>    
date     : Mon, 12 Jan 2015 17:04:11 -0500    
  
committer: Stephen Frost <[email protected]>    
date     : Mon, 12 Jan 2015 17:04:11 -0500    

While building error messages to return to the user,  
BuildIndexValueDescription, ExecBuildSlotValueDescription and  
ri_ReportViolation would happily include the entire key or entire row in  
the result returned to the user, even if the user didn't have access to  
view all of the columns being included.  
  
Instead, include only those columns which the user is providing or which  
the user has select rights on.  If the user does not have any rights  
to view the table or any of the columns involved then no detail is  
provided and a NULL value is returned from BuildIndexValueDescription  
and ExecBuildSlotValueDescription.  Note that, for key cases, the user  
must have access to all of the columns for the key to be shown; a  
partial key will not be returned.  
  
Back-patch all the way, as column-level privileges are now in all  
supported versions.  
  
This has been assigned CVE-2014-8161, but since the issue and the patch  
have already been publicized on pgsql-hackers, there's no point in trying  
to hide this commit.  

commit   : 350f1e7a8c44a7b7dbad3baf31f5a92f4d2974b6    
  
author   : Tom Lane <[email protected]>    
date     : Tue, 27 Jan 2015 12:06:41 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Tue, 27 Jan 2015 12:06:41 -0500    

Commit 145343534c153d1e6c3cff1fa1855787684d9a38 arranged to store numeric  
NaN values as short-header numerics, but the field access macros did not  
get the memo: they thought only "SHORT" numerics have short headers.  
  
Most of the time this makes no difference because we don't access the  
weight or dscale of a NaN; but numeric_send does that.  As pointed out  
by Andrew Gierth, this led to fetching uninitialized bytes.  
  
AFAICS this could not have any worse consequences than that; in particular,  
an unaligned stored numeric would have been detoasted by PG_GETARG_NUMERIC,  
so that there's no risk of a fetch off the end of memory.  Still, the code  
is wrong on its own terms, and it's not hard to foresee future changes that  
might expose us to real risks.  So back-patch to all affected branches.  

commit   : 8abd0e2a9cf191f51caebe8e38c38027f6954ddc    
  
author   : Tom Lane <[email protected]>    
date     : Mon, 26 Jan 2015 15:17:41 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Mon, 26 Jan 2015 15:17:41 -0500    

Some fields of the sinfo struct are modified within PG_TRY and then  
referenced within PG_CATCH, so as with recent patch to async.c, "volatile"  
is necessary for strict POSIX compliance; and that propagates to a couple  
of subroutines as well as materializeQueryResult() itself.  I think the  
risk of actual issues here is probably higher than in async.c, because  
storeQueryResult() is likely to get inlined into materializeQueryResult(),  
leaving the compiler free to conclude that its stores into sinfo fields are  
dead code.  

commit   : 3dd084c7fe4a2596ddb695d52e2d65910ac9206e    
  
author   : Tom Lane <[email protected]>    
date     : Mon, 26 Jan 2015 12:18:25 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Mon, 26 Jan 2015 12:18:25 -0500    

The "callargs" variable is modified within PG_TRY and then referenced  
within PG_CATCH, which is exactly the coding pattern we've now found  
to be unsafe.  Marking "callargs" volatile would be problematic because  
it is passed by reference to some Tcl functions, so fix the problem  
by not modifying it within PG_TRY.  We can just postpone the free()  
till we exit the PG_TRY construct, as is already done elsewhere in this  
same file.  
  
Also, fix failure to free(callargs) when exiting on too-many-arguments  
error.  This is only a minor memory leak, but a leak nonetheless.  
  
In passing, remove some unnecessary "volatile" markings in the same  
function.  Those doubtless are there because gcc 2.95.3 whinged about  
them, but we now know that its algorithm for complaining is many bricks  
shy of a load.  
  
This is certainly a live bug with compilers that optimize similarly  
to current gcc, so back-patch to all active branches.  

commit   : 5c393a0ac52c46f342f4a11acf8b0d4647cb9da3    
  
author   : Tom Lane <[email protected]>    
date     : Mon, 26 Jan 2015 11:57:42 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Mon, 26 Jan 2015 11:57:42 -0500    

The "pos" variable is modified within PG_TRY and then referenced  
within PG_CATCH, so for strict POSIX conformance it must be marked  
volatile.  Superficially the code looked safe because pos's address  
was taken, which was sufficient to force it into memory ... but it's  
not sufficient to ensure that the compiler applies updates exactly  
where the program text says to.  The volatility marking has to extend  
into a couple of subroutines too, but I think that's probably a good  
thing because the risk of out-of-order updates is mostly in those  
subroutines not asyncQueueReadAllNotifications() itself.  In principle  
the compiler could have re-ordered operations such that an error could  
be thrown while "pos" had an incorrect value.  
  
It's unclear how real the risk is here, but for safety back-patch  
to all active branches.  

commit   : 502e5f9c3608c4620eb3044ad5321d61a1f9f646    
  
author   : Tom Lane <[email protected]>    
date     : Sat, 24 Jan 2015 13:05:53 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Sat, 24 Jan 2015 13:05:53 -0500    

strncpy() has a well-deserved reputation for being unsafe, so make an  
effort to get rid of nearly all occurrences in HEAD.  
  
A large fraction of the remaining uses were passing length less than or  
equal to the known strlen() of the source, in which case no null-padding  
can occur and the behavior is equivalent to memcpy(), though doubtless  
slower and certainly harder to reason about.  So just use memcpy() in  
these cases.  
  
In other cases, use either StrNCpy() or strlcpy() as appropriate (depending  
on whether padding to the full length of the destination buffer seems  
useful).  
  
I left a few strncpy() calls alone in the src/timezone/ code, to keep it  
in sync with upstream (the IANA tzcode distribution).  There are also a  
few such calls in ecpg that could possibly do with more analysis.  
  
AFAICT, none of these changes are more than cosmetic, except for the four  
occurrences in fe-secure-openssl.c, which are in fact buggy: an overlength  
source leads to a non-null-terminated destination buffer and ensuing  
misbehavior.  These don't seem like security issues, first because no stack  
clobber is possible and second because if your values of sslcert etc are  
coming from untrusted sources then you've got problems way worse than this.  
Still, it's undesirable to have unpredictable behavior for overlength  
inputs, so back-patch those four changes to all active branches.  

commit   : bdde191c1c79d86d43939435bec6a86c15d21041    
  
author   : Tom Lane <[email protected]>    
date     : Tue, 20 Jan 2015 21:21:41 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Tue, 20 Jan 2015 21:21:41 -0500    

Move random() and setseed() to a separate table, to have them grouped  
together. Also add a notice that random() is not cryptographically secure.  
  
Back-patch of commit 75fdcec14543b60cc0c67483d8cc47d5c7adf1a8 into  
all supported versions, per discussion of the need to document that  
random() is just a wrapper around random(3).  

commit   : 89b6a19e1cc9536e782a132b551a5e642db9972a    
  
author   : Tom Lane <[email protected]>    
date     : Mon, 19 Jan 2015 23:44:28 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Mon, 19 Jan 2015 23:44:28 -0500    

This results in a very substantial reduction in disk space usage during  
"make check-world", since that sequence involves creation of numerous  
temporary installations.  It should also help a bit in the buildfarm, even  
though the buildfarm script doesn't create as many temp installations,  
because the current script misses deleting some of them; and anyway it  
seems better to do this once in one place rather than expecting that  
script to get it right every time.  
  
In 9.4 and HEAD, also undo the unwise choice in commit b1aebbb6a86e96d7  
to report strerror(errno) after a rmtree() failure.  rmtree has already  
reported that, possibly for multiple failures with distinct errnos; and  
what's more, by the time it returns there is no good reason to assume  
that errno still reflects the last reportable error.  So reporting errno  
here is at best redundant and at worst badly misleading.  
  
Back-patch to all supported branches, so that future revisions of the  
buildfarm script can rely on this behavior.  

commit   : 33b723538dd7bb8cebb58dbf2919300f9c84c3cf    
  
author   : Tom Lane <[email protected]>    
date     : Mon, 19 Jan 2015 23:01:41 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Mon, 19 Jan 2015 23:01:41 -0500    

Per discussion, change the log level of this message to be LOG not WARNING.  
The main point of this change is to avoid causing buildfarm run failures  
when the stats collector is exceptionally slow to respond, which it not  
infrequently is on some of the smaller/slower buildfarm members.  
  
This change does lose notice to an interactive user when his stats query  
is looking at out-of-date stats, but the majority opinion (not necessarily  
that of yours truly) is that WARNING messages would probably not get  
noticed anyway on heavily loaded production systems.  A LOG message at  
least ensures that the problem is recorded somewhere where bulk auditing  
for the issue is possible.  
  
Also, instead of an untranslated "pgstat wait timeout" message, provide  
a translatable and hopefully more understandable message "using stale  
statistics instead of current ones because stats collector is not  
responding".  The original text was written hastily under the assumption  
that it would never really happen in practice, which we now know to be  
unduly optimistic.  
  
Back-patch to all active branches, since we've seen the buildfarm issue  
in all branches.  

commit   : 821386ab7ef6dc0c711475ce19c1a0addd07c3b4    
  
author   : Andres Freund <[email protected]>    
date     : Sun, 18 Jan 2015 15:57:55 +0100    
  
committer: Andres Freund <[email protected]>    
date     : Sun, 18 Jan 2015 15:57:55 +0100    

pg_dump.c:dumDatabase() called ArchiveEntry() with the results of a a  
query that was PQclear()ed a couple lines earlier.  
  
Backpatch to 9.2 where security labels for shared objects where  
introduced.  

commit   : c8ef5b1aceb0fec2b928778e83371b13ba7d70e1    
  
author   : Peter Eisentraut <[email protected]>    
date     : Tue, 6 Jan 2015 23:06:13 -0500    
  
committer: Peter Eisentraut <[email protected]>    
date     : Tue, 6 Jan 2015 23:06:13 -0500    

Previously, the xml value resulting from an xpath query would not have  
namespace declarations if the namespace declarations were attached to  
an ancestor element in the input xml value.  That means the output value  
was not correct XML.  Fix that by running the result value through  
xmlCopyNode(), which produces the correct namespace declarations.  
  
Author: Ali Akbar <[email protected]>  

commit   : 6bf343c6ef5d2a09cdfe8b5c9a51fd3519554d33    
  
author   : Heikki Linnakangas <[email protected]>    
date     : Fri, 16 Jan 2015 12:12:49 +0200    
  
committer: Heikki Linnakangas <[email protected]>    
date     : Fri, 16 Jan 2015 12:12:49 +0200    

Previous fix mapped "Norwegian (Bokmål)" locale, which contains a non-ASCII  
character, to the pure ASCII alias "norwegian-bokmal". However, it turns  
out that more recent versions of the CRT library, in particular MSVCR110  
(Visual Studio 2012), changed the behaviour of setlocale() so that if  
you pass "norwegian-bokmal" to setlocale, it returns "Norwegian_Norway".  
  
That meant trouble, when setlocale(..., NULL) first returned  
"Norwegian (Bokmål)_Norway", which we mapped to "norwegian-bokmal_Norway",  
but another call to setlocale(..., "norwegian-bokmal_Norway") returned  
"Norwegian_Norway". That caused PostgreSQL to think that they are different  
locales, and therefore not compatible. That caused initdb to fail at  
CREATE DATABASE.  
  
Older CRT versions seem to accept "Norwegian_Norway" too, so change the  
mapping to return "Norwegian_Norway" instead of "norwegian-bokmal".  
  
Backpatch to 9.2 like the previous attempt. We haven't made a release that  
includes the previous fix yet, so we don't need to worry about changing the  
locale of existing clusters from "norwegian-bokmal" to "Norwegian_Norway".  
(Doing any mapping like this at all requires changing the locale of  
existing databases; the release notes need to include instructions for  
that).  

commit   : 5596432ec02259d5a37c2ad7df93ee6958b2d5d8    
  
author   : Noah Misch <[email protected]>    
date     : Fri, 16 Jan 2015 01:27:31 -0500    
  
committer: Noah Misch <[email protected]>    
date     : Fri, 16 Jan 2015 01:27:31 -0500    

Commit 894459e59ffa5c7fee297b246c17e1f72564db1d revealed this option to  
be broken for NLS builds on Darwin, but "make -C contrib/unaccent check"  
and the buildfarm client rely on it.  Fix that configuration by  
redefining the option to imply LANG=C on Darwin.  In passing, use LANG=C  
instead of LANG=en on Windows; since only postmaster startup uses that  
value, testers are unlikely to notice the change.  Back-patch to 9.0,  
like the predecessor commit.  

commit   : 0acb32efb7327f9e1abb13495c9db2048122bf80    
  
author   : Tom Lane <[email protected]>    
date     : Thu, 15 Jan 2015 18:52:31 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Thu, 15 Jan 2015 18:52:31 -0500    

Up to now, the "child" executor state trees generated for EvalPlanQual  
rechecks have simply shared the ResultRelInfo arrays used for the original  
execution tree.  However, this leads to dangling-pointer problems, because  
ExecInitModifyTable() is all too willing to scribble on some fields of the  
ResultRelInfo(s) even when it's being run in one of those child trees.  
This trashes those fields from the perspective of the parent tree, because  
even if the generated subtree is logically identical to what was in use in  
the parent, it's in a memory context that will go away when we're done  
with the child state tree.  
  
We do however want to share information in the direction from the parent  
down to the children; in particular, fields such as es_instrument *must*  
be shared or we'll lose the stats arising from execution of the children.  
So the simplest fix is to make a copy of the parent's ResultRelInfo array,  
but not copy any fields back at end of child execution.  
  
Per report from Manuel Kniep.  The added isolation test is based on his  
example.  In an unpatched memory-clobber-enabled build it will reliably  
fail with "ctid is NULL" errors in all branches back to 9.1, as a  
consequence of junkfilter->jf_junkAttNo being overwritten with $7f7f.  
This test cannot be run as-is before that for lack of WITH syntax; but  
I have no doubt that some variant of this problem can arise in older  
branches, so apply the code change all the way back.  

commit   : d452bfd1b03a10498101d01a4337654c00bc26e6    
  
author   : Robert Haas <[email protected]>    
date     : Thu, 15 Jan 2015 09:26:03 -0500    
  
committer: Robert Haas <[email protected]>    
date     : Thu, 15 Jan 2015 09:26:03 -0500    

Previously, read() might have returned a length equal to the buffer  
length, and then the subsequent store to buf[len] would write a  
zero-byte one byte past the end.  This doesn't seem likely to be  
a security issue, but there's some chance it could result in  
pg_standby misbehaving.  
  
Spotted by Coverity; patch by Michael Paquier, reviewed by me.  

commit   : 7a70b0d31ff9771ce98f99af63eaa9ab0cc3cba0    
  
author   : Andres Freund <[email protected]>    
date     : Tue, 13 Jan 2015 21:02:47 +0100    
  
committer: Andres Freund <[email protected]>    
date     : Tue, 13 Jan 2015 21:02:47 +0100    

Commit b94ce6e80 reordered postmaster's startup sequence so that the  
tempfile directory is only cleaned up after all the necessary state  
for pg_ctl is collected.  Unfortunately the chosen location is after  
the syslogger has been started; which normally is fine, except for  
!WIN32 EXEC_BACKEND builds, which pass information to children via  
files in the temp directory.  
  
Move the call to RemovePgTempFiles() to just before the syslogger has  
started. That's the first child we fork.  
  
Luckily EXEC_BACKEND is pretty much only used by endusers on windows,  
which has a separate method to pass information to children. That  
means the real world impact of this bug is very small.  
  
Discussion: [email protected]  
  
Backpatch to 9.1, just as the previous commit was.  

commit   : 4bb45b99963a4c236d3076fe2c169e79fead5526    
  
author   : Tom Lane <[email protected]>    
date     : Mon, 12 Jan 2015 16:08:52 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Mon, 12 Jan 2015 16:08:52 -0500    

Per testing with a compiler that whines about this.  

commit   : e9f9ebfe65014ff701b3c0712d1036afea161d1f    
  
author   : Tom Lane <[email protected]>    
date     : Mon, 12 Jan 2015 15:13:37 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Mon, 12 Jan 2015 15:13:37 -0500    

I noticed the "vacuum" regression test taking really significantly longer  
than it used to on a slow machine.  Investigation pointed the finger at  
commit e415b469b33ba328765e39fd62edcd28f30d9c3c, which added creation of  
an index using an extremely expensive index function.  That function was  
evidently meant to be applied only twice ... but the test re-used an  
existing test table, which up till a couple lines before that had had over  
two thousand rows.  Depending on timing of the concurrent regression tests,  
the intervening VACUUMs might have been unable to remove those  
recently-dead rows, and then the index build would need to create index  
entries for them too, leading to the wrap_do_analyze() function being  
executed 2000+ times not twice.  Avoid this by using a different table  
that is guaranteed to have only the intended two rows in it.  
  
Back-patch to 9.0, like the commit that created the problem.  

commit   : 41479f34dda93dc462cd0794835798444ae6daa9    
  
author   : Stephen Frost <[email protected]>    
date     : Mon, 12 Jan 2015 10:13:18 -0500    
  
committer: Stephen Frost <[email protected]>    
date     : Mon, 12 Jan 2015 10:13:18 -0500    

Back in ed0b409, PGPROC was split and moved to static variables in  
procarray.c, with procs in ProcArrayStruct replaced by an array of  
integers representing process numbers (pgprocnos), with -1 indicating a  
dead process which has yet to be removed.  Access to procArray is  
generally done under ProcArrayLock and therefore most code does not have  
to concern itself with -1 entries.  
  
However, MinimumActiveBackends intentionally does not take  
ProcArrayLock, which means it has to be extra careful when accessing  
procArray.  Prior to ed0b409, this was handled by checking for a NULL  
in the pointer array, but that check was no longer valid after the  
split.  Coverity pointed out that the check could never happen and so  
it was removed in 5592eba.  That didn't make anything worse, but it  
didn't fix the issue either.  
  
The correct fix is to check for pgprocno == -1 and skip over that entry  
if it is encountered.  
  
Back-patch to 9.2, since there can be attempts to access the arrays  
prior to their start otherwise.  Note that the changes prior to 9.4 will  
look a bit different due to the change in 5592eba.  
  
Note that MinimumActiveBackends only returns a bool for heuristic  
purposes and any pre-array accesses are strictly read-only and so there  
is no security implication and the lack of fields complaints indicates  
it's very unlikely to run into issues due to this.  
  
Pointed out by Noah.  

commit   : 5ca4e444cb228faaaff8d6cf5719167410078537    
  
author   : Noah Misch <[email protected]>    
date     : Wed, 7 Jan 2015 22:35:44 -0500    
  
committer: Noah Misch <[email protected]>    
date     : Wed, 7 Jan 2015 22:35:44 -0500    

Darwin --enable-nls builds use a substitute setlocale() that may start a  
thread.  Buildfarm member orangutan experienced BackendList corruption  
on account of different postmaster threads executing signal handlers  
simultaneously.  Furthermore, a multithreaded postmaster risks undefined  
behavior from sigprocmask() and fork().  Emit LOG messages about the  
problem and its workaround.  Back-patch to 9.0 (all supported versions).  

commit   : 603eb79210da599b7b535afa7b2e53a2380a4cdf    
  
author   : Noah Misch <[email protected]>    
date     : Wed, 7 Jan 2015 22:34:57 -0500    
  
committer: Noah Misch <[email protected]>    
date     : Wed, 7 Jan 2015 22:34:57 -0500    

Typical server invocations already achieved that.  Invalid locale  
settings in the initial postmaster environment interfered, as could  
malloc() failure.  Setting "LC_MESSAGES=pt_BR.utf8 LC_ALL=invalid" in  
the postmaster environment will now choose C-locale messages, not  
Brazilian Portuguese messages.  Most localized programs, including all  
PostgreSQL frontend executables, do likewise.  Users are unlikely to  
observe changes involving locale categories other than LC_MESSAGES.  
CheckMyDatabase() ensures that we successfully set LC_COLLATE and  
LC_CTYPE; main() sets the remaining three categories to locale "C",  
which almost cannot fail.  Back-patch to 9.0 (all supported versions).  

commit   : e045052863a4517b11ffab0ae9a92160280d49ea    
  
author   : Noah Misch <[email protected]>    
date     : Wed, 7 Jan 2015 22:33:58 -0500    
  
committer: Noah Misch <[email protected]>    
date     : Wed, 7 Jan 2015 22:33:58 -0500    

vacuum()'s static variable handling makes it non-reentrant; an ensuing  
null pointer deference crashed the backend.  Back-patch to 9.0 (all  
supported versions).  

commit   : 6cbadda25a3f52c1fb76ad309f9af9e2aaa8a537    
  
author   : Andres Freund <[email protected]>    
date     : Wed, 7 Jan 2015 00:10:18 +0100    
  
committer: Andres Freund <[email protected]>    
date     : Wed, 7 Jan 2015 00:10:18 +0100    

The corner case where a relcache invalidation tried to rebuild the  
entry for a referenced relation but couldn't find it in the catalog  
wasn't correct.  
  
The code tried to RelationCacheDelete/RelationDestroyRelation the  
entry. That didn't work when assertions are enabled because the latter  
contains an assertion ensuring the refcount is zero. It's also more  
generally a bad idea, because by virtue of being referenced somebody  
might actually look at the entry, which is possible if the error is  
trapped and handled via a subtransaction abort.  
  
Instead just error out, without deleting the entry. As the entry is  
marked invalid, the worst that can happen is that the invalid (and at  
some point unused) entry lingers in the relcache.  
  
Discussion: [email protected]  
  
There should be no way to hit this case < 9.4 where logical decoding  
introduced a bug that can hit this. But since the code for handling  
the corner case is there it should do something halfway sane, so  
backpatch all the the way back.  The logical decoding bug will be  
handled in a separate commit.  

commit   : 753e62e17d520fa5181932cb11de70bc03d70746    
  
author   : Alvaro Herrera <[email protected]>    
date     : Tue, 6 Jan 2015 15:16:29 -0300    
  
committer: Alvaro Herrera <[email protected]>    
date     : Tue, 6 Jan 2015 15:16:29 -0300    

commit   : a5902566f245a17398517a8ce3d504bba8b38fdb    
  
author   : Bruce Momjian <[email protected]>    
date     : Tue, 6 Jan 2015 11:43:46 -0500    
  
committer: Bruce Momjian <[email protected]>    
date     : Tue, 6 Jan 2015 11:43:46 -0500    

Backpatch certain files through 9.0  

commit   : 6f9b84a4016b4da2275af10465119e7d50638bd2    
  
author   : Andres Freund <[email protected]>    
date     : Sun, 4 Jan 2015 15:44:49 +0100    
  
committer: Andres Freund <[email protected]>    
date     : Sun, 4 Jan 2015 15:44:49 +0100    

Previously the computation of the total test duration, measured in  
microseconds, accidentally overflowed due to accidentally using signed  
32bit arithmetic.  As the only consequence is that pg_test_timing  
invocations with such, overly large, durations never finished the  
practical consequences of this bug are minor.  
  
Pointed out by Coverity.  
  
Backpatch to 9.2 where pg_test_timing was added.  

commit   : 029e41afd2930bfabbbc6a1b7d3bf7b21455f150    
  
author   : Andres Freund <[email protected]>    
date     : Sun, 4 Jan 2015 15:35:47 +0100    
  
committer: Andres Freund <[email protected]>    
date     : Sun, 4 Jan 2015 15:35:47 +0100    

Pointed out by Coverity.  
  
Backpatch to all supported branches, the code has been that way for a  
long while.  

commit   : f4060db11852e65c97d956a5b1d860ebb180e767    
  
author   : Andres Freund <[email protected]>    
date     : Sun, 4 Jan 2015 14:36:22 +0100    
  
committer: Andres Freund <[email protected]>    
date     : Sun, 4 Jan 2015 14:36:22 +0100    

As every error in mark_file_as_archived() will lead to a failure of  
pg_basebackup the FD leak couldn't ever lead to a real problem.  It  
seems better to fix the leak anyway though, rather than silence  
Coverity, as the usage of the function might get extended or copied at  
some point in the future.  
  
Pointed out by Coverity.  
  
Backpatch to 9.2, like the relevant part of the previous patch.  

commit   : f961ad4790bddd540ebc5c3b44f752a3869fa866    
  
author   : Andres Freund <[email protected]>    
date     : Sat, 3 Jan 2015 20:51:52 +0100    
  
committer: Andres Freund <[email protected]>    
date     : Sat, 3 Jan 2015 20:51:52 +0100    

WAL (and timeline history) files created by pg_basebackup did not  
maintain the new base backup's archive status. That's currently not a  
problem if the new node is used as a standby - but if that node is  
promoted all still existing files can get archived again.  With a high  
wal_keep_segment settings that can happen a significant time later -  
which is quite confusing.  
  
Change both the backend (for the -x/-X fetch case) and pg_basebackup  
(for -X stream) itself to always mark WAL/timeline files included in  
the base backup as .done. That's in line with walreceiver.c doing so.  
  
The verbosity of the pg_basebackup changes show pretty clearly that it  
needs some refactoring, but that'd result in not be backpatchable  
changes.  
  
Backpatch to 9.1 where pg_basebackup was introduced.  
  
Discussion: [email protected]  

commit   : 4967e07a9131fa37b758c45fee3bd35ad7fb7035    
  
author   : Magnus Hagander <[email protected]>    
date     : Sat, 3 Jan 2015 13:18:54 +0100    
  
committer: Magnus Hagander <[email protected]>    
date     : Sat, 3 Jan 2015 13:18:54 +0100    

The system file is always in the absolute path /etc/, not relative.  
  
David Fetter  

commit   : daa63068f5fb763c46007ec1bd1bca2490f96e6f    
  
author   : Tom Lane <[email protected]>    
date     : Wed, 31 Dec 2014 16:42:51 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Wed, 31 Dec 2014 16:42:51 -0500    

Use the phraseology "ISO 8601 week-numbering year" in place of just  
"ISO year", and make related adjustments to other terminology.  
  
The point of this change is that it seems some people see "ISO year"  
and think "standard year", whereupon they're surprised when constructs  
like to_char(..., "IYYY-MM-DD") produce nonsensical results.  Perhaps  
hanging a few more adjectives on it will discourage them from jumping  
to false conclusions.  I put in an explicit warning against that  
specific usage, too, though the main point is to discourage people  
who haven't read this far down the page.  
  
In passing fix some nearby markup and terminology inconsistencies.  

commit   : 64c506535d6f8c719a126057b3b0796178c59915    
  
author   : Tom Lane <[email protected]>    
date     : Wed, 31 Dec 2014 12:17:04 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Wed, 31 Dec 2014 12:17:04 -0500    

For simple boolean variables such as ON_ERROR_STOP, psql has for a long  
time recognized variant spellings of "on" and "off" (such as "1"/"0"),  
and it also made a point of warning you if you'd misspelled the setting.  
But these conveniences did not exist for other keyword-valued variables.  
In particular, though ECHO_HIDDEN and ON_ERROR_ROLLBACK include "on" and  
"off" as possible values, none of the alternative spellings for those were  
recognized; and to make matters worse the code would just silently assume  
"on" was meant for any unrecognized spelling.  Several people have reported  
getting bitten by this, so let's fix it.  In detail, this patch:  
  
* Allows all spellings recognized by ParseVariableBool() for ECHO_HIDDEN  
and ON_ERROR_ROLLBACK.  
  
* Reports a warning for unrecognized values for COMP_KEYWORD_CASE, ECHO,  
ECHO_HIDDEN, HISTCONTROL, ON_ERROR_ROLLBACK, and VERBOSITY.  
  
* Recognizes all values for all these variables case-insensitively;  
previously there was a mishmash of case-sensitive and case-insensitive  
behaviors.  
  
Back-patch to all supported branches.  There is a small risk of breaking  
existing scripts that were accidentally failing to malfunction; but the  
consensus is that the chance of detecting real problems and preventing  
future mistakes outweighs this.  

commit   : 4db7eaae0f1aca8503f8a638a2775c1a3e0a17bb    
  
author   : Tatsuo Ishii <[email protected]>    
date     : Tue, 30 Dec 2014 19:59:26 +0900    
  
committer: Tatsuo Ishii <[email protected]>    
date     : Tue, 30 Dec 2014 19:59:26 +0900    

commit   : 67dc4b5c30a40cc68192c99d36844babb55ab422    
  
author   : Bruce Momjian <[email protected]>    
date     : Mon, 29 Dec 2014 21:25:23 -0500    
  
committer: Bruce Momjian <[email protected]>    
date     : Mon, 29 Dec 2014 21:25:23 -0500    

Backpatch a9c22d1480aa8e6d97a000292d05ef2b31bbde4e to make future  
backpatching easier.  
  
Backpatch through 9.0  

commit   : c61e471aea05eea7ce623f6a8ab694018c97ad77    
  
author   : Tom Lane <[email protected]>    
date     : Mon, 29 Dec 2014 14:21:03 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Mon, 29 Dec 2014 14:21:03 -0500    

Document the long forms of \H \i \ir \o \p \r \w ... apparently, we have  
a long and dishonorable history of leaving out the unabbreviated names of  
psql backslash commands.  
  
Avoid saying "Unix shell"; we can just say "shell" with equal clarity,  
and not leave Windows users wondering whether the feature works for them.  
  
Improve consistency of documentation of \g \o \w metacommands.  There's  
no reason to use slightly different wording or markup for each one.  

commit   : a986143c697b9053b5fc52b8eb4272c4b537bbd1    
  
author   : Noah Misch <[email protected]>    
date     : Fri, 26 Dec 2014 00:56:14 -0500    
  
committer: Noah Misch <[email protected]>    
date     : Fri, 26 Dec 2014 00:56:14 -0500    

Per buildfarm member hamerkop.  Oversight in 9.2 back-patch of commit  
f6dc6dd5ba54d52c0733aaafc50da2fbaeabb8b0; earlier versions lack the  
affected test suite, and later versions have the "-N" option.  

commit   : 7bb78b2acacb0acf0858430b267d41613f8a8dd3    
  
author   : Noah Misch <[email protected]>    
date     : Thu, 25 Dec 2014 13:52:03 -0500    
  
committer: Noah Misch <[email protected]>    
date     : Thu, 25 Dec 2014 13:52:03 -0500    

Windows versions later than Windows Server 2003 map "localhost" to ::1.  
Account for that in the generated pg_hba.conf, fixing another oversight  
in commit f6dc6dd5ba54d52c0733aaafc50da2fbaeabb8b0.  Back-patch to 9.0,  
like that commit.  
  
David Rowley and Noah Misch  

commit   : 5c8665892035a9b8d97501cbafbc45f5157279a4    
  
author   : Tom Lane <[email protected]>    
date     : Wed, 24 Dec 2014 16:35:23 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Wed, 24 Dec 2014 16:35:23 -0500    

For some reason this seems to have been missed when the lists in  
src/timezone/tznames/ were first constructed.  We can't put it in Default  
because of the conflict with US CST, but we should certainly list it among  
the alternative entries in Asia.txt.  (I checked for other oversights, but  
all the other abbreviations that are in current use according to the IANA  
files seem to be accounted for.)  Noted while responding to bug #12326.  

commit   : ee56e14bbb6f3593e79c1d7e22b02bbc6df4b500    
  
author   : Tom Lane <[email protected]>    
date     : Sun, 21 Dec 2014 15:30:39 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Sun, 21 Dec 2014 15:30:39 -0500    

Explain that you have to use "VARIADIC ARRAY[]" to pass an empty array  
to a variadic parameter position.  This was already implicit in the text  
but it seems better to spell it out.  
  
Per a suggestion from David Johnston, though I didn't use his proposed  
wording.  Back-patch to all supported branches.  

commit   : b71e37c88354387819b53cf6580db861c89e8943    
  
author   : Andres Freund <[email protected]>    
date     : Fri, 19 Dec 2014 14:29:52 +0100    
  
committer: Andres Freund <[email protected]>    
date     : Fri, 19 Dec 2014 14:29:52 +0100    

In LWLockRelease() (and in 9.4+ LWLockUpdateVar()) we release enqueued  
waiters using PGSemaphoreUnlock(). As there are other sources of such  
unlocks backends only wake up if MyProc->lwWaiting is set to false;  
which is only done in the aforementioned functions.  
  
Before this commit there were dangers because the store to lwWaitLink  
could become visible before the store to lwWaitLink. This could both  
happen due to compiler reordering (on most compilers) and on some  
platforms due to the CPU reordering stores.  
  
The possible consequence of this is that a backend stops waiting  
before lwWaitLink is set to NULL. If that backend then tries to  
acquire another lock and has to wait there the list could become  
corrupted once the lwWaitLink store is finally performed.  
  
Add a write memory barrier to prevent that issue.  
  
Unfortunately the barrier support has been only added in 9.2. Given  
that the issue has not knowingly been observed in praxis it seems  
sufficient to prohibit compiler reordering using volatile for 9.0 and  
9.1. Actual problems due to compiler reordering are more likely  
anyway.  
  
Discussion: [email protected]  

commit   : 3dd740b3e688b807fd95344561d5c89c72ad5945    
  
author   : Tom Lane <[email protected]>    
date     : Thu, 18 Dec 2014 16:39:01 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Thu, 18 Dec 2014 16:39:01 -0500    

The possibility that constant subexpressions of a CASE might be evaluated  
at planning time was touched on in 9.17.1 (CASE expressions), but it really  
ought to be explained in 4.2.14 (Expression Evaluation Rules) which is the  
primary discussion of such topics.  Add text and an example there, and  
revise the <note> under CASE to link there.  
  
Back-patch to all supported branches, since it's acted like this for a  
long time (though 9.2+ is probably worse because of its more aggressive  
use of constant-folding via replanning of nominally-prepared statements).  
Pre-9.4, also back-patch text added in commit 0ce627d4 about CASE versus  
aggregate functions.  
  
Tom Lane and David Johnston, per discussion of bug #12273.  

commit   : d710116c64ba8971fd48a09e54bf4ba9fcb4a6ca    
  
author   : Noah Misch <[email protected]>    
date     : Thu, 18 Dec 2014 03:55:17 -0500    
  
committer: Noah Misch <[email protected]>    
date     : Thu, 18 Dec 2014 03:55:17 -0500    

Back-patch to 9.0 (all supported versions).  This is mere  
future-proofing in the context of the master branch, but commit  
f6dc6dd5ba54d52c0733aaafc50da2fbaeabb8b0 requires it of older branches.  

commit   : a652b0c78c4f4bca8862a21aa8bba7ec35e305aa    
  
author   : Andres Freund <[email protected]>    
date     : Thu, 18 Dec 2014 08:35:27 +0100    
  
committer: Andres Freund <[email protected]>    
date     : Thu, 18 Dec 2014 08:35:27 +0100    

When starting up from a basebackup taken off a standby extra logic has  
to be applied to compute the point where the data directory is  
consistent. Normal base backups use a WAL record for that purpose, but  
that isn't possible on a standby.  
  
That logic had a error check ensuring that the cluster's control file  
indicates being in recovery. Unfortunately that check was too strict,  
disregarding the fact that the control file could also indicate that  
the cluster was shut down while in recovery.  
  
That's possible when the a cluster starting from a basebackup is shut  
down before the backup label has been removed. When everything goes  
well that's a short window, but when either restore_command or  
primary_conninfo isn't configured correctly the window can get much  
wider. That's because inbetween reading and unlinking the label we  
restore the last checkpoint from WAL which can need additional WAL.  
  
To fix simply also allow starting when the control file indicates  
"shutdown in recovery". There's nicer fixes imaginable, but they'd be  
more invasive.  
  
Backpatch to 9.2 where support for taking basebackups from standbys  
was added.  

commit   : 0046f651da3ef0b73c3e16672e1198607c2d2ce5    
  
author   : Noah Misch <[email protected]>    
date     : Wed, 17 Dec 2014 22:48:40 -0500    
  
committer: Noah Misch <[email protected]>    
date     : Wed, 17 Dec 2014 22:48:40 -0500    

Use SSPI authentication to allow connections exclusively from the OS  
user that launched the test suite.  This closes on Windows the  
vulnerability that commit be76a6d39e2832d4b88c0e1cc381aa44a7f86881  
closed on other platforms.  Users of "make installcheck" or custom test  
harnesses can run "pg_regress --config-auth=DATADIR" to activate the  
same authentication configuration that "make check" would use.  
Back-patch to 9.0 (all supported versions).  
  
Security: CVE-2014-0067  

commit   : d1131ae50350f971dbc28502d5f4e141d41d9c8e    
  
author   : Tom Lane <[email protected]>    
date     : Wed, 17 Dec 2014 13:22:07 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Wed, 17 Dec 2014 13:22:07 -0500    

Spotted by Álvaro Herrera.  

commit   : 556764957185d35336f060c3d38b7f81452e0d29    
  
author   : Magnus Hagander <[email protected]>    
date     : Wed, 17 Dec 2014 11:55:22 +0100    
  
committer: Magnus Hagander <[email protected]>    
date     : Wed, 17 Dec 2014 11:55:22 +0100    

Add Windows versions of generated scripts, and make sure we only  
ignore the scripts int he root directory.  
  
Michael Paquier  

commit   : e92c67ddc09727a8b7395041fe0e57cd2f595f79    
  
author   : Tom Lane <[email protected]>    
date     : Tue, 16 Dec 2014 15:35:43 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Tue, 16 Dec 2014 15:35:43 -0500    

MapArrayTypeName would copy up to NAMEDATALEN-1 bytes of the base type  
name, which of course is wrong: after prepending '_' there is only room for  
NAMEDATALEN-2 bytes.  Aside from being the wrong result, this case would  
lead to overrunning the statically allocated work buffer.  This would be a  
security bug if the function were ever used outside bootstrap mode, but it  
isn't, at least not in any currently supported branches.  
  
Aside from fixing the off-by-one loop logic, this patch gets rid of the  
static work buffer by having MapArrayTypeName pstrdup its result; the sole  
caller was already doing that, so this just requires moving the pstrdup  
call.  This saves a few bytes but mainly it makes the API a lot cleaner.  
  
Back-patch on the off chance that there is some third-party code using  
MapArrayTypeName with less-secure input.  Pushing pstrdup into the function  
should not cause any serious problems for such hypothetical code; at worst  
there might be a short term memory leak.  
  
Per Coverity scanning.  

commit   : 5b2c8f04a7cdf161f09ed45c235f0eebf3d88f0d    
  
author   : Tom Lane <[email protected]>    
date     : Tue, 16 Dec 2014 13:31:42 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Tue, 16 Dec 2014 13:31:42 -0500    

If the called command fails to return data, runShellCommand forgot to  
pclose() the pipe before returning.  This is fairly harmless in the current  
code, because pgbench would then abandon further processing of that client  
thread; so no more than nclients descriptors could be leaked this way.  But  
it's not hard to imagine future improvements whereby that wouldn't be true.  
In any case, it's sloppy coding, so patch all branches.  Found by Coverity.  

commit   : cd63c57e5cbfc16239aa6837f8b7043a721cdd28    
  
author   : Tom Lane <[email protected]>    
date     : Thu, 11 Dec 2014 21:02:34 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Thu, 11 Dec 2014 21:02:34 -0500    

Ordinarily we can omit checking of a WHERE condition that matches a partial  
index's condition, when we are using an indexscan on that partial index.  
However, in SELECT FOR UPDATE we must include the "redundant" filter  
condition in the plan so that it gets checked properly in an EvalPlanQual  
recheck.  The planner got this mostly right, but improperly omitted the  
filter condition if the index in question was on an inheritance child  
table.  In READ COMMITTED mode, this could result in incorrectly returning  
just-updated rows that no longer satisfy the filter condition.  
  
The cause of the error is using get_parse_rowmark() when get_plan_rowmark()  
is what should be used during planning.  In 9.3 and up, also fix the same  
mistake in contrib/postgres_fdw.  It's currently harmless there (for lack  
of inheritance support) but wrong is wrong, and the incorrect code might  
get copied to someplace where it's more significant.  
  
Report and fix by Kyotaro Horiguchi.  Back-patch to all supported branches.  

commit   : deadbf4f3324f7b2826cac60dd212dfa1b0084ec    
  
author   : Tom Lane <[email protected]>    
date     : Thu, 11 Dec 2014 19:37:10 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Thu, 11 Dec 2014 19:37:10 -0500    

In READ COMMITTED mode, if a SELECT FOR UPDATE discovers it has to redo  
WHERE-clause checking on rows that have been updated since the SELECT's  
snapshot, it invokes EvalPlanQual processing to do that.  If this first  
occurs within a non-first child table of an inheritance tree, the previous  
coding could accidentally re-return a matching row from an earlier,  
already-scanned child table.  (And, to add insult to injury, I think this  
could make it miss returning a row that should have been returned, if the  
updated row that this happens on should still have passed the WHERE qual.)  
Per report from Kyotaro Horiguchi; the added isolation test is based on his  
test case.  
  
This has been broken for quite awhile, so back-patch to all supported  
branches.  

commit   : 2b53d583de96e82d98b1f87c9fbc9f60aa292c9e    
  
author   : Heikki Linnakangas <[email protected]>    
date     : Fri, 5 Dec 2014 14:27:56 +0200    
  
committer: Heikki Linnakangas <[email protected]>    
date     : Fri, 5 Dec 2014 14:27:56 +0200    

Used to say just "could not read password from file "...": Success", which  
isn't very informative.  
  
Mats Erik Andersson. Backpatch to all supported versions.  

commit   : e640042e909d2881117f2b5298eba3a97693a2b2    
  
author   : Tom Lane <[email protected]>    
date     : Mon, 1 Dec 2014 15:25:12 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Mon, 1 Dec 2014 15:25:12 -0500    

We were not checking to see if the supplied dscale was valid for the given  
digit array when receiving binary-format numeric values.  While dscale can  
validly be more than the number of nonzero fractional digits, it shouldn't  
be less; that case causes fractional digits to be hidden on display even  
though they're there and participate in arithmetic.  
  
Bug #12053 from Tommaso Sala indicates that there's at least one broken  
client library out there that sometimes supplies an incorrect dscale value,  
leading to strange behavior.  This suggests that simply throwing an error  
might not be the best response; it would lead to failures in applications  
that might seem to be working fine today.  What seems the least risky fix  
is to truncate away any digits that would be hidden by dscale.  This  
preserves the existing behavior in terms of what will be printed for the  
transmitted value, while preventing subsequent arithmetic from producing  
results inconsistent with that.  
  
In passing, throw a specific error for the case of dscale being outside  
the range that will fit into a numeric's header.  Before you got "value  
overflows numeric format", which is a bit misleading.  
  
Back-patch to all supported branches.  

commit   : 7b46ef1dad84c6d2954dcf426df5755f6968aa6a    
  
author   : Tom Lane <[email protected]>    
date     : Sun, 30 Nov 2014 12:20:54 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Sun, 30 Nov 2014 12:20:54 -0500    

Coverity complained that the "else" added to fillPGconn() was unreachable,  
which it was.  Remove the dead code.  In passing, rearrange the tests so as  
not to bother trying to fetch values for options that can't be assigned.  
  
Pre-9.3 did not have that issue, but it did have a "return" that should be  
"goto oom_error" to ensure that a suitable error message gets filled in.  

commit   : a1cd04cd0dd6e025d832b1562fe8be3bbbbb2d96    
  
author   : Tom Lane <[email protected]>    
date     : Thu, 27 Nov 2014 11:12:55 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Thu, 27 Nov 2014 11:12:55 -0500    

Mark Simonetti reported that libxslt sometimes crashes for him, and that  
swapping xslt_process's object-freeing calls around to do them in reverse  
order of creation seemed to fix it.  I've not reproduced the crash, but  
valgrind clearly shows a reference to already-freed memory, which is  
consistent with the idea that shutdown of the xsltTransformContext is  
trying to reference the already-freed stylesheet or input document.  
With this patch, valgrind is no longer unhappy.  
  
I have an inquiry in to see if this is a libxslt bug or if we're just  
abusing the library; but even if it's a library bug, we'd want to adjust  
our code so it doesn't fail with unpatched libraries.  
  
Back-patch to all supported branches, because we've been doing this in  
the wrong(?) order for a long time.  

commit   : 9b468bcec15f1ea7433d4068102aa030d689346d    
  
author   : Heikki Linnakangas <[email protected]>    
date     : Tue, 25 Nov 2014 17:12:07 +0200    
  
committer: Heikki Linnakangas <[email protected]>    
date     : Tue, 25 Nov 2014 17:12:07 +0200    

If the "dbname" attribute in PQconnectDBParams contained a connection string  
or URI (and expand_dbname = TRUE), the database name from the connection  
string could not be overridden by a subsequent "dbname" keyword in the  
array. That was not intentional; all other options can be overridden.  
Furthermore, any subsequent "dbname" caused the connection string from the  
first dbname value to be processed again, overriding any values for the same  
options that were given between the connection string and the second dbname  
option.  
  
In the passing, clarify in the docs that only the first dbname option in the  
array is parsed as a connection string.  
  
Alex Shulgin. Backpatch to all supported versions.  

commit   : abcab2a64fb050e9ff8f4a3d9b51122c6d7baecd    
  
author   : Heikki Linnakangas <[email protected]>    
date     : Tue, 25 Nov 2014 12:55:00 +0200    
  
committer: Heikki Linnakangas <[email protected]>    
date     : Tue, 25 Nov 2014 12:55:00 +0200    

An out-of-memory in most of these would lead to strange behavior, like  
connecting to a different database than intended, but some would lead to  
an outright segfault.  
  
Alex Shulgin and me. Backpatch to all supported versions.  

commit   : 906599f65f4353cd616d56171930457b86ddf709    
  
author   : Tom Lane <[email protected]>    
date     : Sat, 22 Nov 2014 16:01:15 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Sat, 22 Nov 2014 16:01:15 -0500    

postgres_fdw would send query conditions involving system columns to the  
remote server, even though it makes no effort to ensure that system  
columns other than CTID match what the remote side thinks.  tableoid,  
in particular, probably won't match and might have some use in queries.  
Hence, prevent sending conditions that include non-CTID system columns.  
  
Also, create_foreignscan_plan neglected to check local restriction  
conditions while determining whether to set fsSystemCol for a foreign  
scan plan node.  This again would bollix the results for queries that  
test a foreign table's tableoid.  
  
Back-patch the first fix to 9.3 where postgres_fdw was introduced.  
Back-patch the second to 9.2.  The code is probably broken in 9.1 as  
well, but the patch doesn't apply cleanly there; given the weak state  
of support for FDWs in 9.1, it doesn't seem worth fixing.  
  
Etsuro Fujita, reviewed by Ashutosh Bapat, and somewhat modified by me  

commit   : d767aa51d58e0bcbbd95e3a4e1631c9d48497842    
  
author   : Tom Lane <[email protected]>    
date     : Wed, 19 Nov 2014 16:00:33 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Wed, 19 Nov 2014 16:00:33 -0500    

In bug #12000, Andreas Kunert complained that the documentation was  
misleading in saying "FROM T1 CROSS JOIN T2 is equivalent to FROM T1, T2".  
That's correct as far as it goes, but the equivalence doesn't hold when  
you consider three or more tables, since JOIN binds more tightly than  
comma.  I added a <note> to explain this, and ended up rearranging some  
of the existing text so that the note would make sense in context.  
  
In passing, rewrite the description of JOIN USING, which was unnecessarily  
vague, and hadn't been helped any by somebody's reliance on markup as a  
substitute for clear writing.  (Mostly this involved reintroducing a  
concrete example that was unaccountably removed by commit 032f3b7e166cfa28.)  
  
Back-patch to all supported branches.  

commit   : 57ce746617b6d253602e4c34682d0a75408b3186    
  
author   : Robert Haas <[email protected]>    
date     : Wed, 19 Nov 2014 11:57:54 -0500    
  
committer: Robert Haas <[email protected]>    
date     : Wed, 19 Nov 2014 11:57:54 -0500    

This can cause problems on Windows, where files that are still open  
can't be unlinked.  
  
Jeff Janes  

commit   : 26b27b274063a205611570a0f019216f3ee7dbb0    
  
author   : Tom Lane <[email protected]>    
date     : Tue, 18 Nov 2014 21:36:50 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Tue, 18 Nov 2014 21:36:50 -0500    

The regression test cases added in commits b2cbced9e et al depended in part  
on the Russian timezone offset changes of Oct 2014.  While this is of no  
particular concern for a default Postgres build, it was possible for a  
build using --with-system-tzdata to fail the tests if the system tzdata  
database wasn't au courant.  Bjorn Munch and Christoph Berg both complained  
about this while packaging 9.4rc1, so we probably shouldn't insist on the  
system tzdata being up-to-date.  Instead, make an equivalent test using a  
zone change that occurred in Venezuela in 2007.  With this patch, the  
regression tests should pass using any tzdata set from 2012 or later.  
(I can't muster much sympathy for somebody using --with-system-tzdata  
on a machine whose system tzdata is more than three years out-of-date.)  

commit   : b1e996035cd32c3349081ba0c7fca0710bb296fe    
  
author   : Tom Lane <[email protected]>    
date     : Mon, 17 Nov 2014 12:08:02 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Mon, 17 Nov 2014 12:08:02 -0500    

DST law changes in the Turks & Caicos Islands (America/Grand_Turk) and  
in Fiji.  New zone Pacific/Bougainville for portions of Papua New Guinea.  
Historical changes for Korea and Vietnam.  

commit   : ea8b3833ef064afacd8b8087e26744200f593b9b    
  
author   : Andres Freund <[email protected]>    
date     : Fri, 14 Nov 2014 18:21:30 +0100    
  
committer: Andres Freund <[email protected]>    
date     : Fri, 14 Nov 2014 18:21:30 +0100    

Unlogged relations are only reset when performing a unclean  
restart. That means they have to be synced to disk during clean  
shutdowns. During normal processing that's achieved by registering a  
buffer's file to be fsynced at the next checkpoint when flushed. But  
ResetUnloggedRelations() doesn't go through the buffer manager, so  
nothing will force reset relations to disk before the next shutdown  
checkpoint.  
  
So just make ResetUnloggedRelations() fsync the newly created main  
forks to disk.  
  
Discussion: [email protected]  
  
Backpatch to 9.1 where unlogged tables were introduced.  
  
Abhijit Menon-Sen and Andres Freund  

commit   : c5baa708fbae89c6d027d62be480f11660397289    
  
author   : Andres Freund <[email protected]>    
date     : Fri, 14 Nov 2014 18:20:59 +0100    
  
committer: Andres Freund <[email protected]>    
date     : Fri, 14 Nov 2014 18:20:59 +0100    

Unlogged relations are reset at the end of crash recovery as they're  
only synced to disk during a proper shutdown. Unfortunately that and  
later steps can fail, e.g. due to running out of space. This reset  
was, up to now performed after marking the database as having finished  
crash recovery successfully. As out of space errors trigger a crash  
restart that could lead to the situation that not all unlogged  
relations are reset.  
  
Once that happend usage of unlogged relations could yield errors like  
"could not open file "...": No such file or directory". Luckily  
clusters that show the problem can be fixed by performing a immediate  
shutdown, and starting the database again.  
  
To fix, just call ResetUnloggedRelations(UNLOGGED_RELATION_INIT)  
earlier, before marking the database as having successfully recovered.  
  
Discussion: [email protected]  
  
Backpatch to 9.1 where unlogged tables were introduced.  
  
Abhijit Menon-Sen and Andres Freund  

commit   : 86673a44a7570b931e928b971413a8e00a2bd114    
  
author   : Andres Freund <[email protected]>    
date     : Sat, 15 Nov 2014 01:09:05 +0100    
  
committer: Andres Freund <[email protected]>    
date     : Sat, 15 Nov 2014 01:09:05 +0100    

Backport commit cc52d5b33ff5df29de57dcae9322214cfe9c8464 back to 9.1  
to allow backpatching some unlogged table fixes that use fsync_fname.  

commit   : 3c5ce5102e5bfcf0a56a564215415862a726e979    
  
author   : Tom Lane <[email protected]>    
date     : Thu, 13 Nov 2014 18:19:35 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Thu, 13 Nov 2014 18:19:35 -0500    

Fix breakage induced by commits d8d3d2a4f37f6df5d0118b7f5211978cca22091a  
and 463f2625a5fb183b6a8925ccde98bb3889f921d9: pg_dumpall has crashed when  
attempting to dump from pre-8.1 servers since then, due to faulty  
construction of the query used for dumping roles from older servers.  
The query was erroneous as of the earlier commit, but it wasn't exposed  
unless you tried to use --binary-upgrade, which you presumably wouldn't  
with a pre-8.1 server.  However commit 463f2625a made it fail always.  
  
In HEAD, also fix additional breakage induced in the same query by  
commit 491c029dbc4206779cf659aa0ff986af7831d2ff, which evidently wasn't  
tested against pre-8.1 servers either.  
  
The bug is only latent in 9.1 because 463f2625a hadn't landed yet, but  
it seems best to back-patch all branches containing the faulty query.  
  
Gilles Darold  

commit   : 7eab804c22d40e1c0936c88334a8861d43d8e863    
  
author   : Heikki Linnakangas <[email protected]>    
date     : Thu, 13 Nov 2014 19:47:44 +0200    
  
committer: Heikki Linnakangas <[email protected]>    
date     : Thu, 13 Nov 2014 19:47:44 +0200    

There was a window in RestoreBackupBlock where a page would be zeroed out,  
but not yet locked. If a backend pinned and locked the page in that window,  
it saw the zeroed page instead of the old page or new page contents, which  
could lead to missing rows in a result set, or errors.  
  
To fix, replace RBM_ZERO with RBM_ZERO_AND_LOCK, which atomically pins,  
zeroes, and locks the page, if it's not in the buffer cache already.  
  
In stable branches, the old RBM_ZERO constant is renamed to RBM_DO_NOT_USE,  
to avoid breaking any 3rd party extensions that might use RBM_ZERO. More  
importantly, this avoids renumbering the other enum values, which would  
cause even bigger confusion in extensions that use ReadBufferExtended, but  
haven't been recompiled.  
  
Backpatch to all supported versions; this has been racy since hot standby  
was introduced.  

commit   : d47fff3d72cd703b80760d513cced81afae5dcc4    
  
author   : Tom Lane <[email protected]>    
date     : Wed, 12 Nov 2014 15:58:47 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Wed, 12 Nov 2014 15:58:47 -0500    

This only happens if a client issues a Parse message with an empty query  
string, which is a bit odd; but since it is explicitly called out as legal  
by our FE/BE protocol spec, we'd probably better continue to allow it.  
  
Fix by adding tests everywhere that the raw_parse_tree field is passed to  
functions that don't or shouldn't accept NULL.  Also make it clear in the  
relevant comments that NULL is an expected case.  
  
This reverts commits a73c9dbab0165b3395dfe8a44a7dfd16166963c4 and  
2e9650cbcff8c8fb0d9ef807c73a44f241822eee, which fixed specific crash  
symptoms by hacking things at what now seems to be the wrong end, ie the  
callee functions.  Making the callees allow NULL is superficially more  
robust, but it's not always true that there is a defensible thing for the  
callee to do in such cases.  The caller has more context and is better  
able to decide what the empty-query case ought to do.  
  
Per followup discussion of bug #11335.  Back-patch to 9.2.  The code  
before that is sufficiently different that it would require development  
of a separate patch, which doesn't seem worthwhile for what is believed  
to be an essentially cosmetic change.  

commit   : 4a9710e6edd1a23f6a053eb4b58b2b784245dc7e    
  
author   : Tom Lane <[email protected]>    
date     : Tue, 11 Nov 2014 17:22:15 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Tue, 11 Nov 2014 17:22:15 -0500    

This fixes a scenario in which pgp_sym_decrypt() failed with "Wrong key  
or corrupt data" on messages whose length is 6 less than a power of 2.  
  
Per bug #11905 from Connor Penhale.  Fix by Marko Tiikkaja, regression  
test case from Jeff Janes.  

commit   : 1c2f9a4f6e07d7870e2fed1cb314e673a6f4858d    
  
author   : Tom Lane <[email protected]>    
date     : Tue, 11 Nov 2014 17:00:25 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Tue, 11 Nov 2014 17:00:25 -0500    

When the recursive search in dependency.c visits a column and then later  
visits the whole table containing the column, it needs to propagate the  
drop-context flags for the table to the existing target-object entry for  
the column.  Otherwise we might refuse the DROP (if not CASCADE) on the  
incorrect grounds that there was no automatic drop pathway to the column.  
Remarkably, this has not been reported before, though it's possible at  
least when an extension creates both a datatype and a table using that  
datatype.  
  
Rather than just marking the column as allowed to be dropped, it might  
seem good to skip the DROP COLUMN step altogether, since the later DROP  
of the table will surely get the job done.  The problem with that is that  
the datatype would then be dropped before the table (since the whole  
situation occurred because we visited the datatype, and then recursed to  
the dependent column, before visiting the table).  That seems pretty risky,  
and the case is rare enough that it doesn't seem worth expending a lot of  
effort or risk to make the drops happen in a safe order.  So we just play  
dumb and delete the column separately according to the existing drop  
ordering rules.  
  
Per report from Petr Jelinek, though this is different from his proposed  
patch.  
  
Back-patch to 9.1, where extensions were introduced.  There's currently  
no evidence that such cases can arise before 9.1, and in any case we would  
also need to back-patch cb5c2ba2d82688d29b5902d86b993a54355cad4d to 9.0  
if we wanted to back-patch this.  

commit   : 19ccaf9d4685909257b9f0472916026b8c7eff0a    
  
author   : Tom Lane <[email protected]>    
date     : Mon, 10 Nov 2014 15:21:26 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Mon, 10 Nov 2014 15:21:26 -0500    

At one time it wasn't terribly important what column names were associated  
with the fields of a composite Datum, but since the introduction of  
operations like row_to_json(), it's important that looking up the rowtype  
ID embedded in the Datum returns the column names that users would expect.  
However, that doesn't work terribly well: you could get the column names  
of the underlying table, or column aliases from any level of the query,  
depending on minor details of the plan tree.  You could even get totally  
empty field names, which is disastrous for cases like row_to_json().  
  
It seems unwise to change this behavior too much in stable branches,  
however, since users might not have noticed that they weren't getting  
the least-unintuitive choice of field names.  Therefore, in the back  
branches, only change the results when the child plan has returned an  
actually-empty field name.  (We assume that can't happen with a named  
rowtype, so this also dodges the issue of possibly producing RECORD-typed  
output from a Var with a named composite result type.)  As in the sister  
patch for HEAD, we can get a better name to use from the Var's  
corresponding RTE.  There is no need to touch the RowExpr code since it  
was already using a copy of the RTE's alias list for RECORD cases.  
  
Back-patch as far as 9.2.  Before that we did not have row_to_json()  
so there were no core functions potentially affected by bogus field  
names.  While 9.1 and earlier do have contrib's hstore(record) which  
is also affected, those versions don't seem to produce empty field names  
(at least not in the known problem cases), so we'll leave them alone.  

commit   : 0bb3185954858264aac0e25bdf0c4f14df4dbfee    
  
author   : Tom Lane <[email protected]>    
date     : Thu, 6 Nov 2014 20:52:40 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Thu, 6 Nov 2014 20:52:40 -0500    

dict_thesaurus stored phrase IDs in uint16 fields, so it would get confused  
and even crash if there were more than 64K entries in the configuration  
file.  It turns out to be basically free to widen the phrase IDs to uint32,  
so let's just do so.  
  
This was complained of some time ago by David Boutin (in bug #7793);  
he later submitted an informal patch but it was never acted on.  
We now have another complaint (bug #11901 from Luc Ouellette) so it's  
time to make something happen.  
  
This is basically Boutin's patch, but for future-proofing I also added a  
defense against too many words per phrase.  Note that we don't need any  
explicit defense against overflow of the uint32 counters, since before that  
happens we'd hit array allocation sizes that repalloc rejects.  
  
Back-patch to all supported branches because of the crash risk.  

commit   : 38eb5d9e86af67953bad91dd5b9d993b076b37bf    
  
author   : Fujii Masao <[email protected]>    
date     : Thu, 6 Nov 2014 21:25:45 +0900    
  
committer: Fujii Masao <[email protected]>    
date     : Thu, 6 Nov 2014 21:25:45 +0900    

Previously .ready file was created for the timeline history file at the end  
of an archive recovery even when WAL archiving was not enabled.  
This creation is unnecessary and causes .ready file to remain infinitely.  
  
This commit changes an archive recovery so that it creates .ready file for  
the timeline history file only when WAL archiving is enabled.  
  
Backpatch to all supported versions.  

commit   : 0ef754cad73e0516bfdfc7f58cdd00dfdf305491    
  
author   : Tom Lane <[email protected]>    
date     : Wed, 5 Nov 2014 11:34:22 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Wed, 5 Nov 2014 11:34:22 -0500    

In general, datatype I/O functions are supposed to be immutable or at  
worst stable.  Some contrib I/O functions were, through oversight, not  
marked with any volatility property at all, which made them VOLATILE.  
Since (most of) these functions actually behave immutably, the erroneous  
marking isn't terribly harmful; but it can be user-visible in certain  
circumstances, as per a recent bug report from Joe Van Dyk in which a  
cast to text was disallowed in an expression index definition.  
  
To fix, just adjust the declarations in the extension SQL scripts.  If we  
were being very fussy about this, we'd bump the extension version numbers,  
but that seems like more trouble (for both developers and users) than the  
problem is worth.  
  
A fly in the ointment is that chkpass_in actually is volatile, because  
of its use of random() to generate a fresh salt when presented with a  
not-yet-encrypted password.  This is bad because of the general assumption  
that I/O functions aren't volatile: the consequence is that records or  
arrays containing chkpass elements may have input behavior a bit different  
from a bare chkpass column.  But there seems no way to fix this without  
breaking existing usage patterns for chkpass, and the consequences of the  
inconsistency don't seem bad enough to justify that.  So for the moment,  
just document it in a comment.  
  
Since we're not bumping version numbers, there seems no harm in  
back-patching these fixes; at least future installations will get the  
functions marked correctly.  

commit   : db72ad02ece05434bf011725f83d95b10f1505b9    
  
author   : Tom Lane <[email protected]>    
date     : Tue, 4 Nov 2014 13:24:17 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Tue, 4 Nov 2014 13:24:17 -0500    

The previous coding assumed that we could just let buffers for the  
database's old tablespace age out of the buffer arena naturally.  
The folly of that is exposed by bug #11867 from Marc Munro: the user could  
later move the database back to its original tablespace, after which any  
still-surviving buffers would match lookups again and appear to contain  
valid data.  But they'd be missing any changes applied while the database  
was in the new tablespace.  
  
This has been broken since ALTER SET TABLESPACE was introduced, so  
back-patch to all supported branches.  

commit   : 2c2c1e8ba083a81f8700fa9aac3dfede454e448a    
  
author   : Tom Lane <[email protected]>    
date     : Mon, 3 Nov 2014 11:11:34 -0500    
  
committer: Tom Lane <[email protected]>    
date     : Mon, 3 Nov 2014 11:11:34 -0500    

pgp_sym_encrypt's option is spelled "sess-key", not "enable-session-key".  
Spotted by Jeff Janes.  
  
In passing, improve a comment in pgp-pgsql.c to make it clearer that  
the debugging options are intentionally undocumented.  

commit   : c55dd5dc79b300d52ee452be7687e4c14d573c02    
  
author   : Noah Misch <[email protected]>    
date     : Sun, 2 Nov 2014 21:43:20 -0500    
  
committer: Noah Misch <[email protected]>    
date     : Sun, 2 Nov 2014 21:43:20 -0500    

Back-patch to 9.2, like commit db29620d4d16e08241f965ccd70d0f65883ff0de.  

commit   : 615f6790d8fac2920eb88a6458768796e45a1020    
  
author   : Peter Eisentraut <[email protected]>    
date     : Sat, 1 Nov 2014 11:31:35 -0400    
  
committer: Peter Eisentraut <[email protected]>    
date     : Sat, 1 Nov 2014 11:31:35 -0400    

Revert "6f6b46c9c0ca3d96acbebc5499c32ee6369e1eec", which was broken.  
  
Reported-by: Jonathan Rogers <[email protected]>  

commit   : 38cb8687a9dde85b1dad3d347ab420ecdf2259b7    
  
author   : Tom Lane <[email protected]>    
date     : Thu, 30 Oct 2014 13:03:31 -0400    
  
committer: Tom Lane <[email protected]>    
date     : Thu, 30 Oct 2014 13:03:31 -0400    

As noted by Noah Misch, my initial cut at fixing bug #11638 didn't cover  
all cases where ANALYZE might be invoked in an unsafe context.  We need to  
test the result of IsInTransactionChain not IsTransactionBlock; which is  
notationally a pain because IsInTransactionChain requires an isTopLevel  
flag, which would have to be passed down through several levels of callers.  
I chose to pass in_outer_xact (ie, the result of IsInTransactionChain)  
rather than isTopLevel per se, as that seemed marginally more apropos  
for the intermediate functions to know about.  

commit   : 40058fbcecf66b39ad5c608d3bda55d56df8b795    
  
author   : Tom Lane <[email protected]>    
date     : Wed, 29 Oct 2014 18:12:11 -0400    
  
committer: Tom Lane <[email protected]>    
date     : Wed, 29 Oct 2014 18:12:11 -0400    

VACUUM and ANALYZE update the target table's pg_class row in-place, that is  
nontransactionally.  This is OK, more or less, for the statistical columns,  
which are mostly nontransactional anyhow.  It's not so OK for the DDL hint  
flags (relhasindex etc), which might get changed in response to  
transactional changes that could still be rolled back.  This isn't a  
problem for VACUUM, since it can't be run inside a transaction block nor  
in parallel with DDL on the table.  However, we allow ANALYZE inside a  
transaction block, so if the transaction had earlier removed the last  
index, rule, or trigger from the table, and then we roll back the  
transaction after ANALYZE, the table would be left in a corrupted state  
with the hint flags not set though they should be.  
  
To fix, suppress the hint-flag updates if we are InTransactionBlock().  
This is safe enough because it's always OK to postpone hint maintenance  
some more; the worst-case consequence is a few extra searches of pg_index  
et al.  There was discussion of instead using a transactional update,  
but that would change the behavior in ways that are not all desirable:  
in most scenarios we're better off keeping ANALYZE's statistical values  
even if the ANALYZE itself rolls back.  In any case we probably don't want  
to change this behavior in back branches.  
  
Per bug #11638 from Casey Shobe.  This has been broken for a good long  
time, so back-patch to all supported branches.  
  
Tom Lane and Michael Paquier, initial diagnosis by Andres Freund  

commit   : 1a27fbd075e8671e0f8a98b3f12b35e86c41109b    
  
author   : Heikki Linnakangas <[email protected]>    
date     : Wed, 29 Oct 2014 14:32:01 +0200    
  
committer: Heikki Linnakangas <[email protected]>    
date     : Wed, 29 Oct 2014 14:32:01 +0200    

If you call PQreset() repeatedly, and the connection cannot be  
re-established, the error messages from the failed connection attempts  
kept accumulating in the error string.  
  
Fixes bug #11455 reported by Caleb Epstein. Backpatch to all supported  
versions.  

commit   : 604d94d4cacc787bfa41452785a2927c24829fc5    
  
author   : Heikki Linnakangas <[email protected]>    
date     : Mon, 27 Oct 2014 10:50:41 +0200    
  
committer: Heikki Linnakangas <[email protected]>    
date     : Mon, 27 Oct 2014 10:50:41 +0200    

1. The comparison for matching terms used only the CRC to decide if there's  
a match. Two different terms with the same CRC gave a match.  
  
2. It assumed that if the second operand has more terms than the first, it's  
never a match. That assumption is bogus, because there can be duplicate  
terms in either operand.  
  
Rewrite the implementation in a way that doesn't have those bugs.  
  
Backpatch to all supported versions.  

commit   : 4586572d789952f2be64faaa2c3e00e549162aec    
  
author   : Tom Lane <[email protected]>    
date     : Sun, 26 Oct 2014 16:12:32 -0400    
  
committer: Tom Lane <[email protected]>    
date     : Sun, 26 Oct 2014 16:12:32 -0400    

Since we taught btree to handle ScalarArrayOpExpr quals natively (commit  
9e8da0f75731aaa7605cf4656c21ea09e84d2eb1), the planner has always included  
ScalarArrayOpExpr quals in index conditions if possible.  However, if the  
qual is for a non-first index column, this could result in an inferior plan  
because we can no longer take advantage of index ordering (cf. commit  
807a40c551dd30c8dd5a0b3bd82f5bbb1e7fd285).  It can be better to omit the  
ScalarArrayOpExpr qual from the index condition and let it be done as a  
filter, so that the output doesn't need to get sorted.  Indeed, this is  
true for the query introduced as a test case by the latter commit.  
  
To fix, restructure get_index_paths and build_index_paths so that we  
consider paths both with and without ScalarArrayOpExpr quals in non-first  
index columns.  Redesign the API of build_index_paths so that it reports  
what it found, saving useless second or third calls.  
  
Report and patch by Andrew Gierth (though rather heavily modified by me).  
Back-patch to 9.2 where this code was introduced, since the issue can  
result in significant performance regressions compared to plans produced  
by 9.1 and earlier.  

commit   : d440c4b55f31dbf5bf38269d1b578fdda50973b1    
  
author   : Heikki Linnakangas <[email protected]>    
date     : Fri, 24 Oct 2014 19:56:03 +0300    
  
committer: Heikki Linnakangas <[email protected]>    
date     : Fri, 24 Oct 2014 19:56:03 +0300    

Windows has one a locale whose name contains a non-ASCII character:  
"Norwegian (Bokmål)" (that's an 'a' with a ring on top). That causes  
trouble; when passing it setlocale(), it's not clear what encoding the  
argument should be in. Another problem is that the locale name is stored in  
pg_database catalog table, and the encoding used there depends on what  
server encoding happens to be in use when the database is created. For  
example, if you issue the CREATE DATABASE when connected to a UTF-8  
database, the locale name is stored in pg_database in UTF-8. As long as all  
locale names are pure ASCII, that's not a problem.  
  
To work around that, map the troublesome locale name to a pure-ASCII alias  
of the same locale, "norwegian-bokmal".  
  
Now, this doesn't change the existing values that are already in  
pg_database and in postgresql.conf. Old clusters will need to be fixed  
manually. Instructions for that need to be put in the release notes.  
  
This fixes bug #11431 reported by Alon Siman-Tov. Backpatch to 9.2;  
backpatching further would require more work than seems worth it.  

commit   : 737ae3fc7bce54dfdd52c30a26ddb2d33626076f    
  
author   : Heikki Linnakangas <[email protected]>    
date     : Fri, 24 Oct 2014 19:26:44 +0300    
  
committer: Heikki Linnakangas <[email protected]>    
date     : Fri, 24 Oct 2014 19:26:44 +0300    

If the locale names are not equal, try to canonicalize both of them by  
passing them to setlocale(). Before, we only canonicalized the old cluster's  
locale if upgrading from a 8.4-9.2 server, but we also need to canonicalize  
when upgrading from a pre-8.4 server. That was an oversight in the code. But  
we should also canonicalize on newer server versions, so that we cope if the  
canonical form changes from one release to another. I'm about to do just  
that to fix bug #11431, by mapping a locale name that contains non-ASCII  
characters to a pure-ASCII alias of the same locale.  
  
This is partial backpatch of commit 33755e8edf149dabfc0ed9b697a84f70b0cca0de  
in master. Apply to 9.2, 9.3 and 9.4. The canonicalization code didn't exist  
before 9.2. In 9.2 and 9.3, this effectively also back-patches the changes  
from commit 58274728fb8e087049df67c0eee903d9743fdeda, to be more lax about  
the spelling of the encoding in the locale names.  

commit   : f09369da8c69c78b1a3ce9cd99162cce51bb816f    
  
author   : Tom Lane <[email protected]>    
date     : Thu, 23 Oct 2014 13:11:37 -0400    
  
committer: Tom Lane <[email protected]>    
date     : Thu, 23 Oct 2014 13:11:37 -0400    

Don't crash if an ispell dictionary definition contains flags but not  
any compound affixes.  (This isn't a security issue since only superusers  
can install affix files, but still it's a bad thing.)  
  
Also, be more careful about detecting whether an affix-file FLAG command  
is old-format (ispell) or new-format (myspell/hunspell).  And change the  
error message about mixed old-format and new-format commands into something  
intelligible.  
  
Per bug #11770 from Emre Hasegeli.  Back-patch to all supported branches.  

commit   : f904e9afde394cfb753530ecd93725364624b414    
  
author   : Fujii Masao <[email protected]>    
date     : Thu, 23 Oct 2014 16:21:27 +0900    
  
committer: Fujii Masao <[email protected]>    
date     : Thu, 23 Oct 2014 16:21:27 +0900    

Previously the archive recovery always created .ready file for  
the last WAL file of the old timeline at the end of recovery even when  
it's restored from the archive and has .done file. That is, there was  
the case where the WAL file had both .ready and .done files.  
This caused the already-archived WAL file to be archived again.  
  
This commit prevents the archive recovery from creating .ready file  
for the last WAL file if it has .done file, in order to prevent it from  
being archived again.  
  
This bug was added when cascading replication feature was introduced,  
i.e., the commit 5286105800c7d5902f98f32e11b209c471c0c69c.  
So, back-patch to 9.2, where cascading replication was added.  
  
Reviewed by Michael Paquier  

commit   : 6fa31d8d121df19d4625397bec607171a2afede5    
  
author   : Tom Lane <[email protected]>    
date     : Wed, 22 Oct 2014 18:41:54 -0400    
  
committer: Tom Lane <[email protected]>    
date     : Wed, 22 Oct 2014 18:41:54 -0400    

The EOF-detection logic in pqReadData was a bit confused about who should  
set up the error message in case the kernel gives us read-ready-but-no-data  
rather than ECONNRESET or some other explicit error condition.  Since the  
whole point of this situation is that the lower-level functions don't know  
there's anything wrong, pqReadData itself must set up the message.  But  
keep the assumption that if an errno was reported, a message was set up at  
lower levels.  
  
Per bug #11712 from Marko Tiikkaja.  It's been like this for a very long  
time, so back-patch to all supported branches.  

commit   : fd29810d16fb81fc4a64ba78c80330e6d95b1dc5    
  
author   : Andres Freund <[email protected]>    
date     : Mon, 20 Oct 2014 23:43:46 +0200    
  
committer: Andres Freund <[email protected]>    
date     : Mon, 20 Oct 2014 23:43:46 +0200    

CREATE DATABASE and ALTER DATABASE .. SET TABLESPACE copy the source  
database directory on the filesystem level. To ensure the on disk  
state is consistent they block out users of the affected database and  
force a checkpoint to flush out all data to disk. Unfortunately, up to  
now, that checkpoint didn't flush out dirty buffers from unlogged  
relations.  
  
That bug means there could be leftover dirty buffers in either the  
template database, or the database in its old location. Leading to  
problems when accessing relations in an inconsistent state; and to  
possible problems during shutdown in the SET TABLESPACE case because  
buffers belonging files that don't exist anymore are flushed.  
  
This was reported in bug #10675 by Maxim Boguk.  
  
Fix by Pavan Deolasee, modified somewhat by me. Reviewed by MauMau and  
Fujii Masao.  
  
Backpatch to 9.1 where unlogged tables were introduced.  

commit   : 3609c0d1f8a96b646060acda45b4459fe7905200    
  
author   : Tom Lane <[email protected]>    
date     : Fri, 17 Oct 2014 22:55:30 -0400    
  
committer: Tom Lane <[email protected]>    
date     : Fri, 17 Oct 2014 22:55:30 -0400    

Follow our usual style of providing an "extern" for a standard library  
function only when we're also providing the implementation.  This avoids  
issues when the system headers declare the function slightly differently  
than we do, as noted by Caleb Welton.  
  
We might have to go to the extent of probing to see if the system headers  
declare the function, but let's not do that until it's demonstrated to be  
necessary.  
  
Oversight in commit 9e6b1bf258170e62dac555fc82ff0536dfe01d29.  Back-patch  
to all supported branches, as that was.  

commit   : 6de1b53458a7d74276b087d12d34798bc5f3226b    
  
author   : Tom Lane <[email protected]>    
date     : Fri, 17 Oct 2014 22:33:10 -0400    
  
committer: Tom Lane <[email protected]>    
date     : Fri, 17 Oct 2014 22:33:10 -0400    

Nearly all Paths have parents, but a ResultPath representing an empty FROM  
clause does not.  Avoid a core dump in such cases.  I believe this is only  
a hazard for debugging usage, not for production, else we'd have heard  
about it before.  Nonetheless, back-patch to 9.1 where the troublesome code  
was introduced.  Noted while poking at bug #11703.  

commit   : 787e20bd4a33fd076cad1fd3ec58c644a14d8390    
  
author   : Tom Lane <[email protected]>    
date     : Fri, 17 Oct 2014 12:49:09 -0400    
  
committer: Tom Lane <[email protected]>    
date     : Fri, 17 Oct 2014 12:49:09 -0400    

This reverts nearly all of commit 28f6cab61ab8958b1a7dfb019724687d92722538  
in favor of just using the typrelid we already have in pg_dump's TypeInfo  
struct for the composite type.  As coded, it'd crash if the composite type  
had no attributes, since then the query would return no rows.  
  
Back-patch to all supported versions.  It seems to not really be a problem  
in 9.0 because that version rejects the syntax "create type t as ()", but  
we might as well keep the logic similar in all affected branches.  
  
Report and fix by Rushabh Lathia.  

commit   : 7c67b936590bc0f4440d77df3e9c84b23bbf4551    
  
author   : Tom Lane <[email protected]>    
date     : Thu, 16 Oct 2014 15:22:20 -0400    
  
committer: Tom Lane <[email protected]>    
date     : Thu, 16 Oct 2014 15:22:20 -0400    

Up to now, PG has assumed that any given timezone abbreviation (such as  
"EDT") represents a constant GMT offset in the usage of any particular  
region; we had a way to configure what that offset was, but not for it  
to be changeable over time.  But, as with most things horological, this  
view of the world is too simplistic: there are numerous regions that have  
at one time or another switched to a different GMT offset but kept using  
the same timezone abbreviation.  Almost the entire Russian Federation did  
that a few years ago, and later this month they're going to do it again.  
And there are similar examples all over the world.  
  
To cope with this, invent the notion of a "dynamic timezone abbreviation",  
which is one that is referenced to a particular underlying timezone  
(as defined in the IANA timezone database) and means whatever it currently  
means in that zone.  For zones that use or have used daylight-savings time,  
the standard and DST abbreviations continue to have the property that you  
can specify standard or DST time and get that time offset whether or not  
DST was theoretically in effect at the time.  However, the abbreviations  
mean what they meant at the time in question (or most recently before that  
time) rather than being absolutely fixed.  
  
The standard abbreviation-list files have been changed to use this behavior  
for abbreviations that have actually varied in meaning since 1970.  The  
old simple-numeric definitions are kept for abbreviations that have not  
changed, since they are a bit faster to resolve.  
  
While this is clearly a new feature, it seems necessary to back-patch it  
into all active branches, because otherwise use of Russian zone  
abbreviations is going to become even more problematic than it already was.  
This change supersedes the changes in commit 513d06ded et al to modify the  
fixed meanings of the Russian abbreviations; since we've not shipped that  
yet, this will avoid an undesirably incompatible (not to mention incorrect)  
change in behavior for timestamps between 2011 and 2014.  
  
This patch makes some cosmetic changes in ecpglib to keep its usage of  
datetime lookup tables as similar as possible to the backend code, but  
doesn't do anything about the increasingly obsolete set of timezone  
abbreviation definitions that are hard-wired into ecpglib.  Whatever we  
do about that will likely not be appropriate material for back-patching.  
Also, a potential free() of a garbage pointer after an out-of-memory  
failure in ecpglib has been fixed.  
  
This patch also fixes pre-existing bugs in DetermineTimeZoneOffset() that  
caused it to produce unexpected results near a timezone transition, if  
both the "before" and "after" states are marked as standard time.  We'd  
only ever thought about or tested transitions between standard and DST  
time, but that's not what's happening when a zone simply redefines their  
base GMT offset.  
  
In passing, update the SGML documentation to refer to the Olson/zoneinfo/  
zic timezone database as the "IANA" database, since it's now being  
maintained under the auspices of IANA.  

commit   : 905a8f47b8733bb048c89410be4029052437792f    
  
author   : Noah Misch <[email protected]>    
date     : Sun, 12 Oct 2014 23:27:06 -0400    
  
committer: Noah Misch <[email protected]>    
date     : Sun, 12 Oct 2014 23:27:06 -0400    

This file used __int64, which is specific to native Windows, rather than  
int64.  Suppress the long-unused union field of this type.  Noticed on  
Cygwin x86_64 with -lcrypt not installed.  Back-patch to 9.0 (all  
supported versions).  

commit   : 9770452bf80e993242a9c59085e117f564d687b2    
  
author   : Fujii Masao <[email protected]>    
date     : Fri, 10 Oct 2014 03:18:01 +0900    
  
committer: Fujii Masao <[email protected]>    
date     : Fri, 10 Oct 2014 03:18:01 +0900    

Back-patch to all supported branches.  
  
Marti Raudsepp, per a report from Marko Tiikkaja  

commit   : b513205bc3b13d5945743f41c9fd19b9b5a94ae8    
  
author   : Tom Lane <[email protected]>    
date     : Mon, 6 Oct 2014 21:23:20 -0400    
  
committer: Tom Lane <[email protected]>    
date     : Mon, 6 Oct 2014 21:23:20 -0400    

The code wrote a value into the caller's field[] array before checking  
to see if there was room, which of course is backwards.  Per report from  
Michael Paquier.  
  
I fixed the equivalent bug in the backend's version of this code way back  
in 630684d3a130bb93, but failed to think about ecpg's copy.  Fortunately  
this doesn't look like it would be exploitable for anything worse than a  
core dump: an external attacker would have no control over the single word  
that gets written.  

commit   : 0fb250dae751c6b8f6f3587cdb610b180fb7125a    
  
author   : Heikki Linnakangas <[email protected]>    
date     : Sun, 5 Oct 2014 09:21:45 +0300    
  
committer: Heikki Linnakangas <[email protected]>    
date     : Sun, 5 Oct 2014 09:21:45 +0300    

Before version 9.4, we didn't require sprintf to support the %z length  
modifier. Use %lu instead.  
  
Reported by Peter Eisentraut. Apply to 9.3 and earlier.  

commit   : 8f75d7a25ac59c8687abb45140ca6de02b32de4f    
  
author   : Tom Lane <[email protected]>    
date     : Sat, 4 Oct 2014 14:18:36 -0400    
  
committer: Tom Lane <[email protected]>    
date     : Sat, 4 Oct 2014 14:18:36 -0400    

Most zones in the Russian Federation are subtracting one or two hours  
as of 2014-10-26.  Update the meanings of the abbreviations IRKT, KRAT,  
MAGT, MSK, NOVT, OMST, SAKT, VLAT, YAKT, YEKT to match.  
  
The IANA timezone database has adopted abbreviations of the form AxST/AxDT  
for all Australian time zones, reflecting what they believe to be current  
majority practice Down Under.  These names do not conflict with usage  
elsewhere (other than ACST for Acre Summer Time, which has been in disuse  
since 1994).  Accordingly, adopt these names into our "Default" timezone  
abbreviation set.  The "Australia" abbreviation set now contains only  
CST,EAST,EST,SAST,SAT,WST, all of which are thought to be mostly historical  
usage.  Note that SAST has also been changed to be South Africa Standard  
Time in the "Default" abbreviation set.  
  
Add zone abbreviations SRET (Asia/Srednekolymsk) and XJT (Asia/Urumqi),  
and use WSST/WSDT for western Samoa.  
  
Also a DST law change in the Turks & Caicos Islands (America/Grand_Turk),  
and numerous corrections for historical time zone data.  

commit   : d7d546bbc5f71bf1d1cab3de0a90e082fe7995c0    
  
author   : Tom Lane <[email protected]>    
date     : Fri, 3 Oct 2014 17:44:38 -0400    
  
committer: Tom Lane <[email protected]>    
date     : Fri, 3 Oct 2014 17:44:38 -0400    

This updates known_abbrevs.txt to be what it should have been already,  
were my -P patch not broken; and updates some tznames/ entries that  
missed getting any love in previous timezone data updates because zic  
failed to flag the change of abbreviation.  
  
The non-cosmetic updates:  
  
* Remove references to "ADT" as "Arabia Daylight Time", an abbreviation  
that's been out of use since 2007; therefore, claiming there is a conflict  
with "Atlantic Daylight Time" doesn't seem especially helpful.  (We have  
left obsolete entries in the files when they didn't conflict with anything,  
but that seems like a different situation.)  
  
* Fix entirely incorrect GMT offsets for CKT (Cook Islands), FJT, FJST  
(Fiji); we didn't even have them on the proper side of the date line.  
(Seems to have been aboriginal errors in our tznames data; there's no  
evidence anything actually changed recently.)  
  
* FKST (Falkland Islands Summer Time) is now used all year round, so  
don't mark it as a DST abbreviation.  
  
* Update SAKT (Sakhalin) to mean GMT+11 not GMT+10.  
  
In cosmetic changes, I fixed a bunch of wrong (or at least obsolete)  
claims about abbreviations not being present in the zic files, and  
tried to be consistent about how obsolete abbreviations are labeled.  
  
Note the underlying timezone/data files are still at release 2014e;  
this is just trying to get us in sync with what those files actually  
say before we go to the next update.  

commit   : 769d6815e547010c9f19ebb8c7fff0299e58c1d4    
  
author   : Alvaro Herrera <[email protected]>    
date     : Fri, 3 Oct 2014 13:01:27 -0300    
  
committer: Alvaro Herrera <[email protected]>    
date     : Fri, 3 Oct 2014 13:01:27 -0300    

When there are cost-delay-related storage options set for a table,  
trying to make that table participate in the autovacuum cost-limit  
balancing algorithm produces undesirable results: instead of using the  
configured values, the global values are always used,  
as illustrated by Mark Kirkwood in  
http://www.postgresql.org/message-id/[email protected]  
  
Since the mechanism is already complicated, just disable it for those  
cases rather than trying to make it cope.  There are undesirable  
side-effects from this too, namely that the total I/O impact on the  
system will be higher whenever such tables are vacuumed.  However, this  
is seen as less harmful than slowing down vacuum, because that would  
cause bloat to accumulate.  Anyway, in the new system it is possible to  
tweak options to get the precise behavior one wants, whereas with the  
previous system one was simply hosed.  
  
This has been broken forever, so backpatch to all supported branches.  
This might affect systems where cost_limit and cost_delay have been set  
for individual tables.  

commit   : 8e137b075dc79997d621c7442c0eb299efed7ed7    
  
author   : Heikki Linnakangas <[email protected]>    
date     : Fri, 3 Oct 2014 12:07:10 +0300    
  
committer: Heikki Linnakangas <[email protected]>    
date     : Fri, 3 Oct 2014 12:07:10 +0300    

The page splitting code would go into infinite recursion if you try to  
insert an index tuple that doesn't fit even on an empty page.  
  
Per analysis and suggested fix by Andrew Gierth. Fixes bug #11555, reported  
by Bryan Seitz (analysis happened over IRC). Backpatch to all supported  
versions.  

commit   : a19423b22e899f73722abda984bd1f1867d01348    
  
author   : Heikki Linnakangas <[email protected]>    
date     : Thu, 2 Oct 2014 15:51:31 +0300    
  
committer: Heikki Linnakangas <[email protected]>    
date     : Thu, 2 Oct 2014 15:51:31 +0300    

commit   : 71b88cf52e3baccf6be77709fece5837ef04ea20    
  
author   : Tom Lane <[email protected]>    
date     : Wed, 1 Oct 2014 19:30:34 -0400    
  
committer: Tom Lane <[email protected]>    
date     : Wed, 1 Oct 2014 19:30:34 -0400    

As of commit a87c72915 (which later got backpatched as far as 9.1),  
we're explicitly supporting the notion that append relations can be  
nested; this can occur when UNION ALL constructs are nested, or when  
a UNION ALL contains a table with inheritance children.  
  
Bug #11457 from Nelson Page, as well as an earlier report from Elvis  
Pranskevichus, showed that there were still nasty bugs associated with such  
cases: in particular the EquivalenceClass mechanism could try to generate  
"join" clauses connecting an appendrel child to some grandparent appendrel,  
which would result in assertion failures or bogus plans.  
  
Upon investigation I concluded that all current callers of  
find_childrel_appendrelinfo() need to be fixed to explicitly consider  
multiple levels of parent appendrels.  The most complex fix was in  
processing of "broken" EquivalenceClasses, which are ECs for which we have  
been unable to generate all the derived equality clauses we would like to  
because of missing cross-type equality operators in the underlying btree  
operator family.  That code path is more or less entirely untested by  
the regression tests to date, because no standard opfamilies have such  
holes in them.  So I wrote a new regression test script to try to exercise  
it a bit, which turned out to be quite a worthwhile activity as it exposed  
existing bugs in all supported branches.  
  
The present patch is essentially the same as far back as 9.2, which is  
where parameterized paths were introduced.  In 9.0 and 9.1, we only need  
to back-patch a small fragment of commit 5b7b5518d, which fixes failure to  
propagate out the original WHERE clauses when a broken EC contains constant  
members.  (The regression test case results show that these older branches  
are noticeably stupider than 9.2+ in terms of the quality of the plans  
generated; but we don't really care about plan quality in such cases,  
only that the plan not be outright wrong.  A more invasive fix in the  
older branches would not be a good idea anyway from a plan-stability  
standpoint.)  

commit   : a97c8c393929a529d989de82a0be66b272c9c384    
  
author   : Robert Haas <[email protected]>    
date     : Fri, 26 Sep 2014 11:21:35 -0400    
  
committer: Robert Haas <[email protected]>    
date     : Fri, 26 Sep 2014 11:21:35 -0400    

Without this fix, parallel restore of a schema-only dump can deadlock,  
because when the dump is schema-only, the dependency will still be  
pointing at the TABLE item rather than the TABLE DATA item.  
  
Robert Haas and Tom Lane  

commit   : 66e620d0c0c40823cca1e3c1edc47fa3e289353c    
  
author   : Andres Freund <[email protected]>    
date     : Thu, 25 Sep 2014 15:22:26 +0200    
  
committer: Andres Freund <[email protected]>    
date     : Thu, 25 Sep 2014 15:22:26 +0200    

Some compilers don't automatically search the current directory for  
included files. 9cc2c182fc2 fixed that for builds from tarballs by  
adding an include to the source directory. But that doesn't work when  
the scanner is generated in the VPATH directory. Use the same search  
path as the other parsers in the tree.  
  
One compiler that definitely was affected is solaris' sun cc.  
  
Backpatch to 9.1 which introduced using an actual parser for  
replication commands.  

commit   : 3359a818c2dac930f68041c7230a8284e5584447    
  
author   : Tom Lane <[email protected]>    
date     : Tue, 23 Sep 2014 20:25:39 -0400    
  
committer: Tom Lane <[email protected]>    
date     : Tue, 23 Sep 2014 20:25:39 -0400    

When the number of allowed iterations is limited (either a "?" quantifier  
or a bound expression), the last sub-match has to reach to the end of the  
target string.  The previous coding here first tried the shortest possible  
match (one character, usually) and then gave up and back-tracked if that  
didn't work, typically leading to failure to match overall, as shown in  
bug #11478 from Christoph Berg.  The minimum change to fix that would be to  
not decrement k before "goto backtrack"; but that would be a pretty stupid  
solution, because we'd laboriously try each possible sub-match length  
before finally discovering that only ending at the end can work.  Instead,  
force the sub-match endpoint limit up to the end for even the first  
shortest() call if we cannot have any more sub-matches after this one.  
  
Bug introduced in my rewrite that added the iterdissect logic, commit  
173e29aa5deefd9e71c183583ba37805c8102a72.  The shortest-first search code  
was too closely modeled on the longest-first code, which hasn't got this  
issue since it tries a match reaching to the end to start with anyway.  
Back-patch to all affected branches.  

commit   : 5ff8c2d7d60d0084f577a920c9d614221bde283a    
  
author   : Tom Lane <[email protected]>    
date     : Fri, 19 Sep 2014 13:19:05 -0400    
  
committer: Tom Lane <[email protected]>    
date     : Fri, 19 Sep 2014 13:19:05 -0400    

This has been broken since commit af7914c6627bcf0b0ca614e9ce95d3f8056602bf,  
which added the EXPLAIN (TIMING) option.  Although that commit included  
updates to auto_explain, they evidently weren't tested very carefully,  
because the code failed to print node timings even when it should, due to  
failure to set es.timing in the ExplainState struct.  Reported off-list by  
Neelakanth Nadgir of Salesforce.  
  
In passing, clean up the documentation for auto_explain's options a  
little bit, including re-ordering them into what seems to me a more  
logical order.  

commit   : 8557a9f75fa0ac15892b21cb57fa19cce415142b    
  
author   : Andres Freund <[email protected]>    
date     : Fri, 19 Sep 2014 17:04:00 +0200    
  
committer: Andres Freund <[email protected]>    
date     : Fri, 19 Sep 2014 17:04:00 +0200    

x86's memory barrier assembly was marked as clobbering "memory" but  
not "cc" even though 'addl' sets various flags. As it turns out gcc on  
x86 implicitly assumes "cc" on every inline assembler statement, so  
it's not a bug. But as that's poorly documented and might get copied  
to architectures or compilers where that's not the case, it seems  
better to be precise.  
  
Discussion: [email protected]  
  
To keep the code common, backpatch to 9.2 where explicit memory  
barriers were introduced.  

commit   : c5d11ebd5ac9e5501d0597fb083ced4bb87a1af2    
  
author   : Peter Eisentraut <[email protected]>    
date     : Sun, 14 Sep 2014 10:50:04 -0400    
  
committer: Peter Eisentraut <[email protected]>    
date     : Sun, 14 Sep 2014 10:50:04 -0400    

The documentation used to suggest setting this parameter with ALTER ROLE  
SET, but that never worked, so replace it with a working suggestion.  
  
Reported-by: Kyotaro Horiguchi <[email protected]>  

commit   : 5d63f21596b04b2bb43597f7001a45a777dfed54    
  
author   : Stephen Frost <[email protected]>    
date     : Fri, 12 Sep 2014 11:24:09 -0400    
  
committer: Stephen Frost <[email protected]>    
date     : Fri, 12 Sep 2014 11:24:09 -0400    

In psql, expanded mode was not being displayed correctly when using  
the normal ascii or unicode linestyles and border set to '3'.  Now,  
per the documentation, border '3' is really only sensible for HTML  
and LaTeX formats, however, that's no excuse for ascii/unicode to  
break in that case, and provisions had been made for psql to cleanly  
handle this case (and it did, in non-expanded mode).  
  
This was broken when ascii/unicode was initially added a good five  
years ago because print_aligned_vertical_line wasn't passed in the  
border setting being used by print_aligned_vertical but instead was  
given the whole printTableContent.  There really isn't a good reason  
for vertical_line to have the entire printTableContent structure, so  
just pass in the printTextFormat and border setting (similar to how  
this is handled in horizontal_line).  
  
Pointed out by Pavel Stehule, fix by me.  
  
Back-patch to all currently-supported versions.  

commit   : 228ed43708a048680d2bf45e744e90032b1efec1    
  
author   : Tom Lane <[email protected]>    
date     : Thu, 11 Sep 2014 23:31:00 -0400    
  
committer: Tom Lane <[email protected]>    
date     : Thu, 11 Sep 2014 23:31:00 -0400    

The code for raising a NUMERIC value to an integer power wasn't very  
careful about large powers.  It got an outright wrong answer for an  
exponent of INT_MIN, due to failure to consider overflow of the Abs(exp)  
operation; which is fixable by using an unsigned rather than signed  
exponent value after that point.  Also, even though the number of  
iterations of the power-computation loop is pretty limited, it's easy for  
the repeated squarings to result in ridiculously enormous intermediate  
values, which can take unreasonable amounts of time/memory to process,  
or even overflow the internal "weight" field and so produce a wrong answer.  
We can forestall misbehaviors of that sort by bailing out as soon as the  
weight value exceeds what will fit in int16, since then the final answer  
must overflow (if exp > 0) or underflow (if exp < 0) the packed numeric  
format.  
  
Per off-list report from Pavel Stehule.  Back-patch to all supported  
branches.  

commit   : 7679eff0f6bdd840146265082e818bc7ad3e975b    
  
author   : Andres Freund <[email protected]>    
date     : Tue, 9 Sep 2014 13:57:38 +0200    
  
committer: Andres Freund <[email protected]>    
date     : Tue, 9 Sep 2014 13:57:38 +0200    

07968dbfaad03 missed part of the S_UNLOCK define when building for  
sparcv8+.  

commit   : d0b7ffc0f6d4e1d0e0d640ec4cc60ecd81e9ca2b    
  
author   : Andres Freund <[email protected]>    
date     : Tue, 9 Sep 2014 00:47:32 +0200    
  
committer: Andres Freund <[email protected]>    
date     : Tue, 9 Sep 2014 00:47:32 +0200    

Some Sparc CPUs can be run in various coherence models, ranging from  
RMO (relaxed) over PSO (partial) to TSO (total). Solaris has always  
run CPUs in TSO mode while in userland, but linux didn't use to and  
the various *BSDs still don't. Unfortunately the sparc TAS/S_UNLOCK  
were only correct under TSO. Fix that by adding the necessary memory  
barrier instructions. On sparcv8+, which should be all relevant CPUs,  
these are treated as NOPs if the current consistency model doesn't  
require the barriers.  
  
Discussion: [email protected]  
  
Will be backpatched to all released branches once a few buildfarm  
cycles haven't shown up problems. As I've no access to sparc, this is  
blindly written.  

commit   : 886b58b476fe4799702aecd47880aa7b7d336c17    
  
author   : Tom Lane <[email protected]>    
date     : Mon, 8 Sep 2014 16:09:56 -0400    
  
committer: Tom Lane <[email protected]>    
date     : Mon, 8 Sep 2014 16:09:56 -0400    

psql's \s (print command history) doesn't work at all with recent libedit  
versions when printing to the terminal, because libedit tries to do an  
fchmod() on the target file which will fail if the target is /dev/tty.  
(We'd already noted this in the context of the target being /dev/null.)  
Even before that, it didn't work pleasantly, because libedit likes to  
encode the command history file (to ensure successful reloading), which  
renders it nigh unreadable, not to mention significantly different-looking  
depending on exactly which libedit version you have.  So let's forget using  
write_history() for this purpose, and instead print the data ourselves,  
using logic similar to that used to iterate over the history for newline  
encoding/decoding purposes.  
  
While we're at it, insert the ability to use the pager when \s is printing  
to the terminal.  This has been an acknowledged shortcoming of \s for many  
years, so while you could argue it's not exactly a back-patchable bug fix  
it still seems like a good improvement.  Anyone who's seriously annoyed  
at this can use "\s /dev/tty" or local equivalent to get the old behavior.  
  
Experimentation with this showed that the history iteration logic was  
actually rather broken when used with libedit.  It turns out that with  
libedit you have to use previous_history() not next_history() to advance  
to more recent history entries.  The easiest and most robust fix for this  
seems to be to make a run-time test to verify which function to call.  
We had not noticed this because libedit doesn't really need the newline  
encoding logic: its own encoding ensures that command entries containing  
newlines are reloaded correctly (unlike libreadline).  So the effective  
behavior with recent libedits was that only the oldest history entry got  
newline-encoded or newline-decoded.  However, because of yet other bugs in  
history_set_pos(), some old versions of libedit allowed the existing loop  
logic to reach entries besides the oldest, which means there may be libedit  
~/.psql_history files out there containing encoded newlines in more than  
just the oldest entry.  To ensure we can reload such files, it seems  
appropriate to back-patch this fix, even though that will result in some  
incompatibility with older psql versions (ie, multiline history entries  
written by a psql with this fix will look corrupted to a psql without it,  
if its libedit is reasonably up to date).  
  
Stepan Rutz and Tom Lane  

commit   : 4cadb8a560f589ae8840f25a80b1ba47a6957705    
  
author   : Tom Lane <[email protected]>    
date     : Sun, 7 Sep 2014 22:40:41 -0400    
  
committer: Tom Lane <[email protected]>    
date     : Sun, 7 Sep 2014 22:40:41 -0400    

The old claim is from my commit d06ebdb8d3425185d7e641d15e45908658a0177d of  
2000-07-17, but it seems to have been a plain old thinko; sum(float4) has  
been distinct from sum(float8) since Berkeley days.  Noted by KaiGai Kohei.  
  
While at it, mention the existence of sum(money), which is also of  
embarrassingly ancient vintage.  

commit   : 78b1228efeb5d2615f7e844cb4fe8ad8ff335e29    
  
author   : Fujii Masao <[email protected]>    
date     : Fri, 5 Sep 2014 02:17:57 +0900    
  
committer: Fujii Masao <[email protected]>    
date     : Fri, 5 Sep 2014 02:17:57 +0900    

Back-patch to all supported branches.  
  
Per bug #11335 from Haruka Takatsuka  

commit   : 9c4b7ed13da24cdb2f977547546bb6be437d1974    
  
author   : Kevin Grittner <[email protected]>    
date     : Sat, 30 Aug 2014 11:04:12 -0500    
  
committer: Kevin Grittner <[email protected]>    
date     : Sat, 30 Aug 2014 11:04:12 -0500    

Errors detected using Topy (https://github.com/intgr/topy), all  
changes verified by hand and some manual tweaks added.  
  
Marti Raudsepp  
  
Individual changes backpatched, where applicable, as far as 9.0.  

commit   : f3998521fcca0faf237fcf7e66a7462ab2e30310    
  
author   : Tom Lane <[email protected]>    
date     : Thu, 28 Aug 2014 18:21:17 -0400    
  
committer: Tom Lane <[email protected]>    
date     : Thu, 28 Aug 2014 18:21:17 -0400    

In commit 45e02e3232ac7cc5ffe36f7986159b5e0b1f6fdc, we intentionally  
disallowed updates on individual elements of oidvector columns.  While that  
still seems like a sane idea in the abstract, we (I) forgot that citext's  
"upgrade from unpackaged" script did in fact perform exactly such updates,  
in order to fix the problem that citext indexes should have a collation  
but would not in databases dumped or upgraded from pre-9.1 installations.  
  
Even if we wanted to add casts to allow such updates, there's no practical  
way to do so in the back branches, so the only real alternative is to make  
citext's kluge even klugier.  In this patch, I cast the oidvector to text,  
fix its contents with regexp_replace, and cast back to oidvector.  (Ugh!)  
  
Since the aforementioned commit went into all active branches, we have to  
fix this in all branches that contain the now-broken update script.  
  
Per report from Eric Malm.  

commit   : 0719c2afa11289a57a8f1bcbb5a15f686c92ce4b    
  
author   : Andres Freund <[email protected]>    
date     : Mon, 25 Aug 2014 18:30:48 +0200    
  
committer: Andres Freund <[email protected]>    
date     : Mon, 25 Aug 2014 18:30:48 +0200    

Some of the many error messages introduced in 458857cc missed 'FROM  
unpackaged'. Also e016b724 and 45ffeb7e forgot to quote extension  
version numbers.  
  
Backpatch to 9.1, just like 458857cc which introduced the messages. Do  
so because the error messages thrown when the wrong command is copy &  
pasted aren't easy to understand.  

commit   : f13feb088aaf5a1f725289c01f636c5f78fa85e9    
  
author   : Fujii Masao <[email protected]>    
date     : Mon, 25 Aug 2014 18:30:48 +0200    
  
committer: Andres Freund <[email protected]>    
date     : Mon, 25 Aug 2014 18:30:48 +0200    

Backpatch as discussed in [email protected]  
ff. as the error messages are user facing and possibly confusing.  
  
Original commit: 6f9e39bc9993c18686f0950f9b9657c7c97c7450  

commit   : ebd4d9cddb894207911eb0a9e014867f3278b167    
  
author   : Noah Misch <[email protected]>    
date     : Mon, 18 Aug 2014 23:00:38 -0400    
  
committer: Noah Misch <[email protected]>    
date     : Mon, 18 Aug 2014 23:00:38 -0400    

Programs need execute permission on a DLL file to load it.  MSYS  
"install" ignores the mode argument, and our Cygwin build statically  
links libpq into programs.  That explains the lack of buildfarm trouble.  
Back-patch to 9.0 (all supported versions).  

commit   : ae941b8db49dc61a8d085a4fb6f1d5106ec40275    
  
author   : Tom Lane <[email protected]>    
date     : Mon, 18 Aug 2014 01:17:49 -0400    
  
committer: Tom Lane <[email protected]>    
date     : Mon, 18 Aug 2014 01:17:49 -0400    

The old text explained what happened if we didn't have working int64  
arithmetic.  Since that case has been explicitly rejected by configure  
since 8.4.3, documenting it in the 9.x branches can only produce confusion.  

commit   : 6ad25325dd6e52db36eb667db68d5601d8fa4acc    
  
author   : Tom Lane <[email protected]>    
date     : Sat, 16 Aug 2014 13:48:49 -0400    
  
committer: Tom Lane <[email protected]>    
date     : Sat, 16 Aug 2014 13:48:49 -0400    

PG_RETURN_BOOL() should only be used in functions following the V1 SQL  
function API.  This coding accidentally fails to fail since letting the  
compiler coerce the Datum representation of bool back to plain bool  
does give the right answer; but that doesn't make it a good idea.  
  
Back-patch to older branches just to avoid unnecessary code divergence.  

commit   : c5e2333aaf510dce45d8de7deb461d8569832839    
  
author   : Tom Lane <[email protected]>    
date     : Thu, 14 Aug 2014 16:05:55 -0400    
  
committer: Tom Lane <[email protected]>    
date     : Thu, 14 Aug 2014 16:05:55 -0400    

FreeBSD hasn't made any use of kern.ipc.semmap since 1.1, and newer  
releases reject attempts to set it altogether; so stop recommending  
that it be adjusted.  Per bug #11161.  
  
Back-patch to all supported branches.  Before 9.3, also incorporate  
commit 7a42dff47, which touches the same text and for some reason  
was not back-patched at the time.  

commit   : 054fc30965f3d3361e80fa57887f58e1a178cfe8    
  
author   : Fujii Masao <[email protected]>    
date     : Mon, 11 Aug 2014 23:19:23 +0900    
  
committer: Fujii Masao <[email protected]>    
date     : Mon, 11 Aug 2014 23:19:23 +0900    

Specifically this commit updates forkname_to_number() so that the HINT  
message includes "init" fork, and also adds the description of "init" fork  
into pg_relation_size() document.  
  
This is a part of the commit 2d00190495b22e0d0ba351b2cda9c95fb2e3d083  
which has fixed the same oversight in master and 9.4. Back-patch to  
9.1 where "init" fork was added.  

commit   : 84317b072021250c78cd1e127913f5d0a30e9028    
  
author   : Fujii Masao <[email protected]>    
date     : Mon, 11 Aug 2014 22:52:16 +0900    
  
committer: Fujii Masao <[email protected]>    
date     : Mon, 11 Aug 2014 22:52:16 +0900    

The initialization fork was added in 9.1, but has not been taken into  
consideration in documents of get_raw_page function in pageinspect and  
storage layout. This commit fixes those oversights.  
  
get_raw_page can read not only a table but also an index, etc. So it  
should be documented that the function can read any relation. This commit  
also fixes the document of pageinspect that way.  
  
Back-patch to 9.1 where those oversights existed.  
  
Vik Fearing, review by MauMau  

commit   : 6079e5d4bce4dc6c52e83d61aadb091a829a1a39    
  
author   : Tom Lane <[email protected]>    
date     : Sun, 10 Aug 2014 16:13:22 -0400    
  
committer: Tom Lane <[email protected]>    
date     : Sun, 10 Aug 2014 16:13:22 -0400    

The user documentation was vague and not entirely accurate about how  
we treat domain inputs for ambiguous operators/functions.  Clarify  
that, and add an example and some commentary.  Per a recent question  
from Adam Mackler.  
  
It's acted like this ever since we added domains, so back-patch  
to all supported branches.  

commit   : 15026ab97950d5efc7f085c33c6c57d6a5536da6    
  
author   : Tom Lane <[email protected]>    
date     : Sat, 9 Aug 2014 18:40:38 -0400    
  
committer: Tom Lane <[email protected]>    
date     : Sat, 9 Aug 2014 18:40:38 -0400    

In commit 0ca6bda8e7501947c05f30c127f6d12ff90b5a64, I rewrote the json.c  
code that decided how to convert SQL data types into JSON values, so that  
it no longer relied on typcategory which is a pretty untrustworthy guide  
to the output format of user-defined datatypes.  However, I overlooked the  
fact that CREATE DOMAIN inherits typcategory from the base type, so that  
the old coding did have the desirable property of treating domains like  
their base types --- but only in some cases, because not all its decisions  
turned on typcategory.  The version of the patch that went into 9.4 and  
up did a getBaseType() call to ensure that domains were always treated  
like their base types, but I omitted that from the older branches, because  
it would result in a behavioral change for domains over json or hstore;  
a change that's arguably a bug fix, but nonetheless a change that users  
had not asked for.  What I overlooked was that this meant that domains  
over numerics and boolean were no longer treated like their base types,  
and that we *did* get a complaint about, ie bug #11103 from David Grelaud.  
So let's do the getBaseType() call in the older branches as well, to  
restore their previous behavior in these cases.  That means 9.2 and 9.3  
will now make these decisions just like 9.4.  We could probably kluge  
things to still ignore the domain's base type if it's json etc, but that  
seems a bit silly.  

commit   : b4dacab12a47087036a3e9068c075bbcc73fb5b4    
  
author   : Tom Lane <[email protected]>    
date     : Sat, 9 Aug 2014 13:46:45 -0400    
  
committer: Tom Lane <[email protected]>    
date     : Sat, 9 Aug 2014 13:46:45 -0400    

Such cases are disallowed by the SQL spec, and even if we wanted to allow  
them, the semantics seem ambiguous: how should the FK columns be matched up  
with the columns of a unique index?  (The matching could be significant in  
the presence of opclasses with different notions of equality, so this issue  
isn't just academic.)  However, our code did not previously reject such  
cases, but instead would either fail to match to any unique index, or  
generate a bizarre opclass-lookup error because of sloppy thinking in the  
index-matching code.  
  
David Rowley  

commit   : dc4871c19fb0aae3f90d63220b8e0a5c61dfa91b    
  
author   : Heikki Linnakangas <[email protected]>    
date     : Fri, 1 Aug 2014 21:13:17 +0300    
  
committer: Heikki Linnakangas <[email protected]>    
date     : Fri, 1 Aug 2014 21:13:17 +0300    

commit   : c83aed34bea79a084b802e15fefebe127d2d31d5    
  
author   : Tom Lane <[email protected]>    
date     : Wed, 30 Jul 2014 14:41:35 -0400    
  
committer: Tom Lane <[email protected]>    
date     : Wed, 30 Jul 2014 14:41:35 -0400    

When autovacuum is nominally off, we will still launch autovac workers  
to vacuum tables that are at risk of XID wraparound.  But after we'd done  
that, an autovac worker would proceed to autovacuum every table in the  
targeted database, if they meet the usual thresholds for autovacuuming.  
This is at best pretty unexpected; at worst it delays response to the  
wraparound threat.  Fix it so that if autovacuum is nominally off, we  
*only* do forced vacuums and not any other work.  
  
Per gripe from Andrey Zhidenkov.  This has been like this all along,  
so back-patch to all supported branches.  

commit   : 1578d13dc76d8e40cb0ef04d525af406357bd57d    
  
author   : Heikki Linnakangas <[email protected]>    
date     : Tue, 29 Jul 2014 10:33:15 +0300    
  
committer: Heikki Linnakangas <[email protected]>    
date     : Tue, 29 Jul 2014 10:33:15 +0300    

There were several oversights in recovery code where COMMIT/ABORT PREPARED  
records were ignored:  
  
* pg_last_xact_replay_timestamp() (wasn't updated for 2PC commits)  
* recovery_min_apply_delay (2PC commits were applied immediately)  
* recovery_target_xid (recovery would not stop if the XID used 2PC)  
  
The first of those was reported by Sergiy Zuban in bug #11032, analyzed by  
Tom Lane and Andres Freund. The bug was always there, but was masked before  
commit d19bd29f07aef9e508ff047d128a4046cc8bc1e2, because COMMIT PREPARED  
always created an extra regular transaction that was WAL-logged.  
  
Backpatch to all supported versions (older versions didn't have all the  
features and therefore didn't have all of the above bugs).  

commit   : af9d51624e1147dd9773162a7680a532954ab2eb    
  
author   : Fujii Masao <[email protected]>    
date     : Mon, 28 Jul 2014 21:44:29 +0900    
  
committer: Fujii Masao <[email protected]>    
date     : Mon, 28 Jul 2014 21:44:29 +0900    

unix_socket_directories was introduced in 9.3, but the document  
in older versions wrongly have mentioned it. This commit replaces  
it with the correct older name unix_socket_directory.  
  
This is applied to only 9.2 and older supported versions.  
  
Guillaume Lelarge