commit : 2f4ffae5ada6ec272997ce1d6fe415eb9a025924 author : Tom Lane <[email protected]> date : Mon, 28 Aug 2017 17:30:10 -0400 committer: Tom Lane <[email protected]> date : Mon, 28 Aug 2017 17:30:10 -0400
commit : f4935327249923c7c88719ccdae5ca472d1d8767 author : Peter Eisentraut <[email protected]> date : Mon, 28 Aug 2017 10:07:56 -0400 committer: Peter Eisentraut <[email protected]> date : Mon, 28 Aug 2017 10:07:56 -0400
Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 93d2eb7f662bb15429730cecaaa4280298a4c50b
Release notes for 9.6.5, 9.5.9, 9.4.14, 9.3.19, 9.2.23.
commit : bf0dcdb2eb963adbd5b298eebf1091c26367d060 author : Tom Lane <[email protected]> date : Sun, 27 Aug 2017 17:35:04 -0400 committer: Tom Lane <[email protected]> date : Sun, 27 Aug 2017 17:35:04 -0400
Backpatch introduction of TupleDescAttr(tupdesc, i).
commit : 8cda1fadd25b8bd9448c7d161354643906c85650 author : Andres Freund <[email protected]> date : Tue, 22 Aug 2017 07:46:05 -0700 committer: Andres Freund <[email protected]> date : Tue, 22 Aug 2017 07:46:05 -0700
2cd70845240 / c6293249d change the way individual attributes in a TupleDesc are stored / accessed. To reduce the effort of making extensions compatible with postgresql 11, and to ease future backpatching, backpatch introduction of TupleDescAttr() to all releases. Do not backpatch change in storage, as that'd be a breaking change for existing and working extensions. Author: Andres Freund Discussion: https://postgr.es/m/[email protected] Backpatch: 9.2-
Further tweaks to compiler flags for PL/Perl on Windows.
commit : f7e4783ddbef9dfd269b97210f4f74d61b5d62c8 author : Tom Lane <[email protected]> date : Thu, 17 Aug 2017 13:15:46 -0400 committer: Tom Lane <[email protected]> date : Thu, 17 Aug 2017 13:15:46 -0400
It now emerges that we can only rely on Perl to tell us we must use -D_USE_32BIT_TIME_T if it's Perl 5.13.4 or later. For older versions, revert to our previous practice of assuming we need that symbol in all 32-bit Windows builds. This is not ideal, but inquiring into which compiler version Perl was built with seems far too fragile. In any case, we had not previously had complaints about these old Perl versions, so let's assume this is Good Enough. (It's still better than the situation ante commit 5a5c2feca, in that at least the effects are confined to PL/Perl rather than the whole PG build.) Back-patch to all supported versions, like 5a5c2feca and predecessors. Discussion: https://postgr.es/m/CANF[email protected]
Changed ecpg parser to allow RETURNING clauses without attached C variables.
commit : 60b135c8262bd7d1d115de1797165a437a890a7a author : Michael Meskes <[email protected]> date : Mon, 14 Aug 2017 11:29:34 +0200 committer: Michael Meskes <[email protected]> date : Mon, 14 Aug 2017 11:29:34 +0200
Include foreign tables in information_schema.table_privileges
commit : 98e6784aa5b1a316c19d58c7b53f106936aca5e7 author : Peter Eisentraut <[email protected]> date : Tue, 15 Aug 2017 19:27:22 -0400 committer: Peter Eisentraut <[email protected]> date : Tue, 15 Aug 2017 19:27:22 -0400
This appears to have been an omission in the original commit 0d692a0dc9f. All related information_schema views already include foreign tables. Reported-by: Nicolas Thauvin <[email protected]>
Handle elog(FATAL) during ROLLBACK more robustly.
commit : 8ae41ceae82bced88dbe8ac713248a1cd1de33c9 author : Tom Lane <[email protected]> date : Mon, 14 Aug 2017 15:43:20 -0400 committer: Tom Lane <[email protected]> date : Mon, 14 Aug 2017 15:43:20 -0400
Stress testing by Andreas Seltenreich disclosed longstanding problems that occur if a FATAL exit (e.g. due to receipt of SIGTERM) occurs while we are trying to execute a ROLLBACK of an already-failed transaction. In such a case, xact.c is in TBLOCK_ABORT state, so that AbortOutOfAnyTransaction would skip AbortTransaction and go straight to CleanupTransaction. This led to an assert failure in an assert-enabled build (due to the ROLLBACK's portal still having a cleanup hook) or without assertions, to a FATAL exit complaining about "cannot drop active portal". The latter's not disastrous, perhaps, but it's messy enough to want to improve it. We don't really want to run all of AbortTransaction in this code path. The minimum required to clean up the open portal safely is to do AtAbort_Memory and AtAbort_Portals. It seems like a good idea to do AtAbort_Memory unconditionally, to be entirely sure that we are starting with a safe CurrentMemoryContext. That means that if the main loop in AbortOutOfAnyTransaction does nothing, we need an extra step at the bottom to restore CurrentMemoryContext = TopMemoryContext, which I chose to do by invoking AtCleanup_Memory. This'll result in calling AtCleanup_Memory twice in many of the paths through this function, but that seems harmless and reasonably inexpensive. The original motivation for the assertion in AtCleanup_Portals was that we wanted to be sure that any user-defined code executed as a consequence of the cleanup hook runs during AbortTransaction not CleanupTransaction. That still seems like a valid concern, and now that we've seen one case of the assertion firing --- which means that exactly that would have happened in a production build --- let's replace the Assert with a runtime check. If we see the cleanup hook still set, we'll emit a WARNING and just drop the hook unexecuted. This has been like this a long time, so back-patch to all supported branches. Discussion: https://postgr.es/m/[email protected]
Absorb -D_USE_32BIT_TIME_T switch from Perl, if relevant.
commit : e3335ec0b6a6e037e30cb133f5ffc08c2e6a9a0c author : Tom Lane <[email protected]> date : Mon, 14 Aug 2017 11:48:59 -0400 committer: Tom Lane <[email protected]> date : Mon, 14 Aug 2017 11:48:59 -0400
Commit 3c163a7fc's original choice to ignore all #define symbols whose names begin with underscore turns out to be too simplistic. On Windows, some Perl installations are built with -D_USE_32BIT_TIME_T, and we must absorb that or we get the wrong result for sizeof(PerlInterpreter). This effectively re-reverts commit ef58b87df, which injected that symbol in a hacky way, making it apply to all of Postgres not just PL/Perl. More significantly, it did so on *all* 32-bit Windows builds, even when the Perl build to be used did not select this option; so that it fails to work properly with some newer Perl builds. By making this change, we would be introducing an ABI break in 32-bit Windows builds; but fortunately we have not used type time_t in any exported Postgres APIs in a long time. So it should be OK, both for PL/Perl itself and for third-party extensions, if an extension library is built with a different _USE_32BIT_TIME_T setting than the core code. Patch by me, based on research by Ashutosh Sharma and Robert Haas. Back-patch to all supported branches, as commit 3c163a7fc was. Discussion: https://postgr.es/m/CANF[email protected]
commit : 5069017fecd2d54b87019312e4281b9f6d65e45b author : Tom Lane <[email protected]> date : Sun, 13 Aug 2017 16:15:14 -0400 committer: Tom Lane <[email protected]> date : Sun, 13 Aug 2017 16:15:14 -0400
The sole useful effect of this function, to check that no catcache entries have positive refcounts at transaction end, has really been obsolete since we introduced ResourceOwners in PG 8.1. We reduced the checks to assertions years ago, so that the function was a complete no-op in production builds. There have been previous discussions about removing it entirely, but consensus up to now was that it had some small value as a cross-check for bugs in the ResourceOwner logic. However, it now emerges that it's possible to trigger these assertions if you hit an assert-enabled backend with SIGTERM during a call to SearchCatCacheList, because that function temporarily increases the refcounts of entries it's intending to add to a catcache list construct. In a normal ERROR scenario, the extra refcounts are cleaned up by SearchCatCacheList's PG_CATCH block; but in a FATAL exit we do a transaction abort and exit without ever executing PG_CATCH handlers. There's a case to be made that this is a generic hazard and we should consider restructuring elog(FATAL) handling so that pending PG_CATCH handlers do get run. That's pretty scary though: it could easily create more problems than it solves. Preliminary stress testing by Andreas Seltenreich suggests that there are not many live problems of this ilk, so we rejected that idea. There are more-localized ways to fix the problem; the most principled one would be to use PG_ENSURE_ERROR_CLEANUP instead of plain PG_TRY. But adding cycles to SearchCatCacheList isn't very appealing. We could also weaken the assertions in AtEOXact_CatCache in some more or less ad-hoc way, but that just makes its raison d'etre even less compelling. In the end, the most reasonable solution seems to be to just remove AtEOXact_CatCache altogether, on the grounds that it's not worth trying to fix it. It hasn't found any bugs for us in many years. Per report from Jeevan Chalke. Back-patch to all supported branches. Discussion: https://postgr.es/m/CAM2[email protected]
Fix handling of container types in find_composite_type_dependencies.
commit : 4e704aac18d1ee80dc79114ef18ec6cd5265f8a3 author : Tom Lane <[email protected]> date : Wed, 9 Aug 2017 17:03:10 -0400 committer: Tom Lane <[email protected]> date : Wed, 9 Aug 2017 17:03:10 -0400
find_composite_type_dependencies correctly found columns that are of the specified type, and columns that are of arrays of that type, but not columns that are domains or ranges over the given type, its array type, etc. The most general way to handle this seems to be to assume that any type that is directly dependent on the specified type can be treated as a container type, and processed recursively (allowing us to handle nested cases such as ranges over domains over arrays ...). Since a type's array type already has such a dependency, we can drop the existing special case for the array type. The very similar logic in get_rels_with_domain was likewise a few bricks shy of a load, as it supposed that a directly dependent type could *only* be a sub-domain. This is already wrong for ranges over domains, and it'll someday be wrong for arrays over domains. Add test cases illustrating the problems, and back-patch to all supported branches. Discussion: https://postgr.es/m/[email protected]