commit : 6f5e8094c2c0b829e3d00fc1e1656248457e16e6 author : Tom Lane <firstname.lastname@example.org> date : Mon, 6 Feb 2017 16:50:42 -0500 committer: Tom Lane <email@example.com> date : Mon, 6 Feb 2017 16:50:42 -0500
Release notes for 9.6.2, 9.5.6, 9.4.11, 9.3.16, 9.2.20.
commit : a587f69f658210b76a29b404ab2c0ad8205a0671 author : Tom Lane <firstname.lastname@example.org> date : Mon, 6 Feb 2017 15:30:17 -0500 committer: Tom Lane <email@example.com> date : Mon, 6 Feb 2017 15:30:17 -0500
Avoid returning stale attribute bitmaps in RelationGetIndexAttrBitmap().
commit : 32c893c8d125af85c5852b040c04517fbb58d2b2 author : Tom Lane <firstname.lastname@example.org> date : Mon, 6 Feb 2017 13:19:51 -0500 committer: Tom Lane <email@example.com> date : Mon, 6 Feb 2017 13:19:51 -0500
The problem with the original coding here is that we might receive (and clear) a relcache invalidation signal for the target relation down inside one of the index_open calls we're doing. Since the target is open, we would not drop the relcache entry, just reset its rd_indexvalid and rd_indexlist fields. But RelationGetIndexAttrBitmap() kept going, and would eventually cache and return potentially-obsolete attribute bitmaps. The case where this matters is where the inval signal was from a CREATE INDEX CONCURRENTLY telling us about a new index on a formerly-unindexed column. (In all other cases, the lock we hold on the target rel should prevent any concurrent change in index state.) Even just returning the stale attribute bitmap is not such a problem, because it shouldn't matter during the transaction in which we receive the signal. What hurts is caching the stale data, because it can survive into later transactions, breaking CREATE INDEX CONCURRENTLY's expectation that later transactions will not create new broken HOT chains. The upshot is that there's a window for building corrupted indexes during CREATE INDEX CONCURRENTLY. This patch fixes the problem by rechecking that the set of index OIDs is still the same at the end of RelationGetIndexAttrBitmap() as it was at the start. If not, we loop back and try again. That's a little more than is strictly necessary to fix the bug --- in principle, we could return the stale data but not cache it --- but it seems like a bad idea on general principles for relcache to return data it knows is stale. There might be more hazards of the same ilk, or there might be a better way to fix this one, but this patch definitely improves matters and seems unlikely to make anything worse. So let's push it into today's releases even as we continue to study the problem. Pavan Deolasee and myself Discussion: https://postgr.es/m/CABOikdM2MUq9cyZJi1KyLmmkCereyGp5JQ4fuwKoyKEde_mzkQ@mail.gmail.com
commit : fc7c21f6bf9eec5699e1138e95bf552e26d092f5 author : Peter Eisentraut <firstname.lastname@example.org> date : Mon, 6 Feb 2017 12:35:49 -0500 committer: Peter Eisentraut <email@example.com> date : Mon, 6 Feb 2017 12:35:49 -0500
Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 057c41b7234bc3fb44ea722f297167dbe4ea472c
Add missing newline to error messages
commit : 4387c9cfe41f6334a8960fc853dc86f9dc5e8a2e author : Peter Eisentraut <firstname.lastname@example.org> date : Mon, 6 Feb 2017 09:47:39 -0500 committer: Peter Eisentraut <email@example.com> date : Mon, 6 Feb 2017 09:47:39 -0500
Also improve the message style a bit while we're here.
Fix typo also in expected output.
commit : 822115db8f8dfa6cbd3b8b5090b9f7f990cbd402 author : Heikki Linnakangas <firstname.lastname@example.org> date : Mon, 6 Feb 2017 12:04:04 +0200 committer: Heikki Linnakangas <email@example.com> date : Mon, 6 Feb 2017 12:04:04 +0200
Commit 181bdb90ba fixed the typo in the .sql file, but forgot to update the expected output.
Fix typos in comments.
commit : e8f9fe4ae7ab2784ca42b264f4656249311ddfe4 author : Heikki Linnakangas <firstname.lastname@example.org> date : Mon, 6 Feb 2017 11:33:58 +0200 committer: Heikki Linnakangas <email@example.com> date : Mon, 6 Feb 2017 11:33:58 +0200
Backpatch to all supported versions, where applicable, to make backpatching of future fixes go more smoothly. Josh Soref Discussion: https://www.postgresql.org/message-id/CACZqfqCf+5qRztLPgmmosr-B0Ye4srWzzw_mo4c_8_B_mtjmJQ@mail.gmail.com
Add KOI8-U map files to Makefile.
commit : b87e1680b98465b002198ae49a4f4f2bce4d129e author : Heikki Linnakangas <firstname.lastname@example.org> date : Thu, 2 Feb 2017 14:12:35 +0200 committer: Heikki Linnakangas <email@example.com> date : Thu, 2 Feb 2017 14:12:35 +0200
These were left out by mistake back when support for KOI8-U encoding was added. Extracted from Kyotaro Horiguchi's larger patch.
Update time zone data files to tzdata release 2016j.
commit : 2b133be04bf68870263a3a649439b3ebcfe78256 author : Tom Lane <firstname.lastname@example.org> date : Mon, 30 Jan 2017 11:40:22 -0500 committer: Tom Lane <email@example.com> date : Mon, 30 Jan 2017 11:40:22 -0500
DST law changes in northern Cyprus (new zone Asia/Famagusta), Russia (new zone Europe/Saratov), Tonga, Antarctica/Casey. Historical corrections for Asia/Aqtau, Asia/Atyrau, Asia/Gaza, Asia/Hebron, Italy, Malta. Replace invented zone abbreviation "TOT" for Tonga with numeric UTC offset; but as in the past, we'll keep accepting "TOT" for input.
Orthography fixes for new castNode() macro.
commit : ae145306ca2e005a9433c966dddbd6f54b541813 author : Tom Lane <firstname.lastname@example.org> date : Fri, 27 Jan 2017 08:33:58 -0500 committer: Tom Lane <email@example.com> date : Fri, 27 Jan 2017 08:33:58 -0500
Clean up hastily-composed comment. Normalize whitespace. Erik Rijkers and myself
Check interrupts during hot standby waits
commit : 332068a212c0357aa7bbbb0c187134ba3af32fbd author : Simon Riggs <simon@2ndQuadrant.com> date : Fri, 27 Jan 2017 12:18:07 +0000 committer: Simon Riggs <simon@2ndQuadrant.com> date : Fri, 27 Jan 2017 12:18:07 +0000
Add castNode(type, ptr) for safe casting between NodeTag based types.
commit : 1ad163ef0130db4c371444a7e7fc2ecdd63b76bc author : Andres Freund <firstname.lastname@example.org> date : Thu, 26 Jan 2017 16:47:04 -0800 committer: Andres Freund <email@example.com> date : Thu, 26 Jan 2017 16:47:04 -0800
The new function allows to cast from one NodeTag based type to another, while asserting that the conversion is valid. This replaces the common pattern of doing a cast and a Assert(IsA(ptr, type)) close-by. As this seems likely to be used pervasively, we decided to backpatch this change the addition of this macro. Otherwise backpatched fixes are more likely not to work on back-branches. On branches before 9.6, where we do not yet rely on inline functions being available, the type assertion is only performed if PG_USE_INLINE support is detected. The cast obviously is performed regardless. For the benefit of verifying the macro compiles in the back-branches, this commit contains a single use of the new macro. On master, a somewhat larger conversion will be committed separately. Author: Peter Eisentraut and Andres Freund Reviewed-By: Tom Lane Discussion: https://firstname.lastname@example.org Backpatch: 9.2-
Reset hot standby xmin after restart
commit : 048d44175a019cca7e08dac45bf95db680b4ed87 author : Simon Riggs <simon@2ndQuadrant.com> date : Thu, 26 Jan 2017 20:15:23 +0000 committer: Simon Riggs <simon@2ndQuadrant.com> date : Thu, 26 Jan 2017 20:15:23 +0000
Hot_standby_feedback could be reset by reload and worked correctly, but if the server was restarted rather than reloaded the xmin was not reset. Force reset always if hot_standby_feedback is enabled at startup. Ants Aasma, Craig Ringer Reported-by: Ants Aasma
Ensure that a tsquery like '!foo' matches empty tsvectors.
commit : 2e024f83bd428fe32a2284452f31288c163a1190 author : Tom Lane <email@example.com> date : Thu, 26 Jan 2017 12:17:47 -0500 committer: Tom Lane <firstname.lastname@example.org> date : Thu, 26 Jan 2017 12:17:47 -0500
!foo means "the tsvector does not contain foo", and therefore it should match an empty tsvector. ts_match_vq() overenthusiastically supposed that an empty tsvector could never match any query, so it forcibly returned FALSE, the wrong answer. Remove the premature optimization. Our behavior on this point was inconsistent, because while seqscans and GIST index searches both failed to match empty tsvectors, GIN index searches would find them, since GIN scans don't rely on ts_match_vq(). That makes this certainly a bug, not a debatable definition disagreement, so back-patch to all supported branches. Report and diagnosis by Tom Dunstan (bug #14515); added test cases by me. Discussion: https://email@example.com
Revert "Fix comments in StrategyNotifyBgWriter()."
commit : 451132415dc4f255b440b1645362cc125025ae5c author : Tatsuo Ishii <firstname.lastname@example.org> date : Tue, 24 Jan 2017 10:46:34 +0900 committer: Tatsuo Ishii <email@example.com> date : Tue, 24 Jan 2017 10:46:34 +0900
This reverts commit df9e034f958a5cd092f7f461d7a50156f6d076af, which tried to fix the comments to reflect the change of API of the function but actually the change had been made only for 9.5 or later.
Fix comments in StrategyNotifyBgWriter().
commit : df9e034f958a5cd092f7f461d7a50156f6d076af author : Tatsuo Ishii <firstname.lastname@example.org> date : Tue, 24 Jan 2017 09:39:11 +0900 committer: Tatsuo Ishii <email@example.com> date : Tue, 24 Jan 2017 09:39:11 +0900
The interface for the function was changed in d72731a70450b5e7084991b9caa15cb58a2820df but the comments of the function was not updated. Patch by Yugo Nagata.
doc: Update URL for Microsoft download site
commit : c3364a0267cca6dabae72a973bdfbe1d54083385 author : Peter Eisentraut <firstname.lastname@example.org> date : Tue, 17 Jan 2017 12:00:00 -0500 committer: Peter Eisentraut <email@example.com> date : Tue, 17 Jan 2017 12:00:00 -0500
Avoid useless respawining the autovacuum launcher at high speed.
commit : 5c5788e901e2bc3ec242d0a22de8b7d8a5ddb69b author : Robert Haas <firstname.lastname@example.org> date : Fri, 20 Jan 2017 15:55:45 -0500 committer: Robert Haas <email@example.com> date : Fri, 20 Jan 2017 15:55:45 -0500
When (1) autovacuum = off and (2) there's at least one database with an XID age greater than autovacuum_freeze_max_age and (3) all tables in that database that need vacuuming are already being processed by a worker and (4) the autovacuum launcher is started, a kind of infinite loop occurs. The launcher starts a worker and immediately exits. The worker, finding no worker to do, immediately starts the launcher, supposedly so that the next database can be processed. But because datfrozenxid for that database hasn't been advanced yet, the new worker gets put right back into the same database as the old one, where it once again starts the launcher and exits. High-speed ping pong ensues. There are several possible ways to break the cycle; this seems like the safest one. Amit Khandekar (code) and Robert Haas (comments), reviewed by Álvaro Herrera. Discussion: http://postgr.es/m/CAJ3gD9eWejf72HKquKSzax0r+epS=nAbQKNnykkMA0E8c+rMDg@mail.gmail.com
Reset the proper GUC in create_index test.
commit : 22b4b55b99f60ae8a586f30eb95f5e7efb083467 author : Tom Lane <firstname.lastname@example.org> date : Wed, 18 Jan 2017 16:33:18 -0500 committer: Tom Lane <email@example.com> date : Wed, 18 Jan 2017 16:33:18 -0500
Thinko in commit a4523c5aa. It doesn't really affect anything at present, but it would be a problem if any tests added later in this file ought to get index-only-scan plans. Back-patch, like the previous commit, just to avoid surprises in case we add such a test and then back-patch it. Nikita Glukhov Discussion: https://firstname.lastname@example.org
Change some test macros to return true booleans
commit : e0f4a80ee515fab2922bf2a3f68dc6d1efdbf05e author : Alvaro Herrera <email@example.com> date : Wed, 18 Jan 2017 18:06:13 -0300 committer: Alvaro Herrera <firstname.lastname@example.org> date : Wed, 18 Jan 2017 18:06:13 -0300
These macros work fine when they are used directly in an "if" test or similar, but as soon as the return values are assigned to boolean variables (or passed as boolean arguments to some function), they become bugs, hopefully caught by compiler warnings. To avoid future problems, fix the definitions so that they return actual booleans. To further minimize the risk that somebody uses them in back-patched fixes that only work correctly in branches starting from the current master and not in old ones, back-patch the change to supported branches as appropriate. See also commit af4472bcb88ab36b9abbe7fd5858e570a65a2d1a, and the long discussion (and larger patch) in the thread mentioned in its commit message. Discussion: https://email@example.com
Fix an assertion failure related to an exclusive backup.
commit : f64b11fa063de85d6d394398d8e9bbe07d588f50 author : Fujii Masao <firstname.lastname@example.org> date : Tue, 17 Jan 2017 17:32:20 +0900 committer: Fujii Masao <email@example.com> date : Tue, 17 Jan 2017 17:32:20 +0900
Previously multiple sessions could execute pg_start_backup() and pg_stop_backup() to start and stop an exclusive backup at the same time. This could trigger the assertion failure of "FailedAssertion("!(XLogCtl->Insert.exclusiveBackup)". This happend because, even while pg_start_backup() was starting an exclusive backup, other session could run pg_stop_backup() concurrently and mark the backup as not-in-progress unconditionally. This patch introduces ExclusiveBackupState indicating the state of an exclusive backup. This state is used to ensure that there is only one session running pg_start_backup() or pg_stop_backup() at the same time, to avoid the assertion failure. Back-patch to all supported versions. Author: Michael Paquier Reviewed-By: Kyotaro Horiguchi and me Reported-By: Andreas Seltenreich Discussion: <firstname.lastname@example.org>
Throw suitable error for COPY TO STDOUT/FROM STDIN in a SQL function.
commit : 47d32a464a8a5e70c95fe52d6b3e3a3fb25fd845 author : Tom Lane <email@example.com> date : Sat, 14 Jan 2017 13:27:47 -0500 committer: Tom Lane <firstname.lastname@example.org> date : Sat, 14 Jan 2017 13:27:47 -0500
A client copy can't work inside a function because the FE/BE wire protocol doesn't support nesting of a COPY operation within query results. (Maybe it could, but the protocol spec doesn't suggest that clients should support this, and libpq for one certainly doesn't.) In most PLs, this prohibition is enforced by spi.c, but SQL functions don't use SPI. A comparison of _SPI_execute_plan() and init_execution_state() shows that rejecting client COPY is the only discrepancy in what they allow, so there's no other similar bugs. This is an astonishingly ancient oversight, so back-patch to all supported branches. Report: https://postgr.es/m/BY2PR05MB2309EABA3DEFA0143F50F0D593780@BY2PR05MB2309.namprd05.prod.outlook.com
pg_restore: Don't allow non-positive number of jobs
commit : 4779d6ca20f7ce89c61b7729a6c714a258586d75 author : Stephen Frost <email@example.com> date : Wed, 11 Jan 2017 15:46:09 -0500 committer: Stephen Frost <firstname.lastname@example.org> date : Wed, 11 Jan 2017 15:46:09 -0500
pg_restore will currently accept invalid values for the number of parallel jobs to run (eg: -1), unlike pg_dump which does check that the value provided is reasonable. Worse, '-1' is actually a valid, independent, parameter (as an alias for --single-transaction), leading to potentially completely unexpected results from a command line such as: -> pg_restore -j -1 Where a user would get neither parallel jobs nor a single-transaction. Add in validity checking of the parallel jobs option, as we already have in pg_dump, before we try to open up the archive. Also move the check that we haven't been asked to run more parallel jobs than possible on Windows to the same place, so we do all the option validity checking before opening the archive. Back-patch all the way, though for 9.2 we're adding the Windows-specific check against MAXIMUM_WAIT_OBJECTS as that check wasn't back-patched originally. Discussion: https://www.postgresql.org/message-id/20170110044815.GC18360%40tamriel.snowman.net
Fix invalid-parallel-jobs error message
commit : 7cda702363e8bfb61409bb8cbae13689b19f1648 author : Stephen Frost <email@example.com> date : Mon, 9 Jan 2017 23:09:39 -0500 committer: Stephen Frost <firstname.lastname@example.org> date : Mon, 9 Jan 2017 23:09:39 -0500
Including the program name twice is not helpful: -> pg_dump -j -1 pg_dump: pg_dump: invalid number of parallel jobs Correct by removing the progname from the exit_horribly() call used when validating the number of parallel jobs. Noticed while testing various pg_dump error cases. Back-patch to 9.3 where parallel pg_dump was added.
Invalidate cached plans on FDW option changes.
commit : a8191800a6e63e8f4a61e6c3eccdfb428eb085d8 author : Tom Lane <email@example.com> date : Fri, 6 Jan 2017 14:12:52 -0500 committer: Tom Lane <firstname.lastname@example.org> date : Fri, 6 Jan 2017 14:12:52 -0500
This fixes problems where a plan must change but fails to do so, as seen in a bug report from Rajkumar Raghuwanshi. For ALTER FOREIGN TABLE OPTIONS, do this through the standard method of forcing a relcache flush on the table. For ALTER FOREIGN DATA WRAPPER and ALTER SERVER, just flush the whole plan cache on any change in pg_foreign_data_wrapper or pg_foreign_server. That matches the way we handle some other low-probability cases such as opclass changes, and it's unclear that the case arises often enough to be worth working harder. Besides, that gives a patch that is simple enough to back-patch with confidence. Back-patch to 9.3. In principle we could apply the code change to 9.2 as well, but (a) we lack postgres_fdw to test it with, (b) it's doubtful that anyone is doing anything exciting enough with FDWs that far back to need this desperately, and (c) the patch doesn't apply cleanly. Patch originally by Amit Langote, reviewed by Etsuro Fujita and Ashutosh Bapat, who each contributed substantial changes as well. Discussion: https://postgr.es/m/CAKcux6m5cA6rRPTKkqVdJ-R=KKDfe35Q_ZuUqxDSV_4hwgaemail@example.com
Fix handling of empty arrays in array_fill().
commit : ee9cb284a6d6c79080033b825391b8b78b5eccfb author : Tom Lane <firstname.lastname@example.org> date : Thu, 5 Jan 2017 11:33:51 -0500 committer: Tom Lane <email@example.com> date : Thu, 5 Jan 2017 11:33:51 -0500
array_fill(..., array) produced an empty array, which is probably what users expect, but it was a one-dimensional zero-length array which is not our standard representation of empty arrays. Also, for no very good reason, it rejected empty input arrays; that case should be allowed and produce an empty output array. In passing, remove the restriction that the input array(s) have lower bound 1. That seems rather pointless, and it would have needed extra complexity to make the check deal with empty input arrays. Per bug #14487 from Andrew Gierth. It's been broken all along, so back-patch to all supported branches. Discussion: https://firstname.lastname@example.org
Handle OID column inheritance correctly in ALTER TABLE ... INHERIT.
commit : 5f89a9885e118ab22689f9641237f7941d9ba8fd author : Tom Lane <email@example.com> date : Wed, 4 Jan 2017 18:00:12 -0500 committer: Tom Lane <firstname.lastname@example.org> date : Wed, 4 Jan 2017 18:00:12 -0500
Inheritance operations must treat the OID column, if any, much like regular user columns. But MergeAttributesIntoExisting() neglected to do that, leading to weird results after a table with OIDs is associated to a parent with OIDs via ALTER TABLE ... INHERIT. Report and patch by Amit Langote, reviewed by Ashutosh Bapat, some adjustments by me. It's been broken all along, so back-patch to all supported branches. Discussion: https://email@example.com
Update copyright for 2017
commit : e7c586e7b222b80c42de473468ce5e7e14bbca60 author : Bruce Momjian <firstname.lastname@example.org> date : Tue, 3 Jan 2017 12:37:53 -0500 committer: Bruce Momjian <email@example.com> date : Tue, 3 Jan 2017 12:37:53 -0500
Backpatch-through: certain files through 9.2
Remove bogus notice that older clients might not work with MD5 passwords.
commit : 470af1f41c8bae498004cfd8563f6adcc3924b79 author : Heikki Linnakangas <firstname.lastname@example.org> date : Tue, 3 Jan 2017 14:09:01 +0200 committer: Heikki Linnakangas <email@example.com> date : Tue, 3 Jan 2017 14:09:01 +0200
That was written when we still had "crypt" authentication, and it was referring to the fact that an older client might support "crypt" authentication but not "md5". But we haven't supported "crypt" for years. (As soon as we add a new authentication mechanism that doesn't work with MD5 hashes, we'll need a similar notice again. But this text as it's worded now is just wrong.) Backpatch to all supported versions. Discussion: https://firstname.lastname@example.org
Silence compiler warnings
commit : 6b4a1764aa5dfece5020b78beb56ffde66bd1b21 author : Joe Conway <email@example.com> date : Mon, 2 Jan 2017 14:12:28 -0800 committer: Joe Conway <firstname.lastname@example.org> date : Mon, 2 Jan 2017 14:12:28 -0800
In GetCachedPlan(), initialize 'plan' to silence a compiler warning, but also add an Assert() to make sure we don't ever actually fall through with 'plan' still being set to NULL, since we are about to dereference it. Back-patch back to 9.2. Author: Stephen Frost Discussion: https://postgr.es/m/20161129152102.GR13284%40tamriel.snowman.net
Silence Bison deprecation warnings
commit : 3f9479603caca249fb3643871c24c6fa55a339b4 author : Joe Conway <email@example.com> date : Mon, 2 Jan 2017 13:51:32 -0800 committer: Joe Conway <firstname.lastname@example.org> date : Mon, 2 Jan 2017 13:51:32 -0800
Bison >=3.0 issues warnings about %name-prefix="base_yy" instead of the now preferred %name-prefix "base_yy" but the latter doesn't work with Bison 2.3 or less. So for now we silence the deprecation warnings. Back-patch to 9.2 and 9.3 -- the newer branches already have this fix. Author: Peter Eisentraut Discussion: https://postgr.es/m/677.1483384145%40sss.pgh.pa.us
Fix incorrect example of to_timestamp() usage.
commit : 49832227b2fad0e1137d535c3a1906813c8ebb31 author : Tom Lane <email@example.com> date : Thu, 29 Dec 2016 18:05:34 -0500 committer: Tom Lane <firstname.lastname@example.org> date : Thu, 29 Dec 2016 18:05:34 -0500
Must use HH24 not HH to read a hour value exceeding 12. This was already fixed in HEAD in commit d3cd36a13, but I didn't think of backpatching it. Report: https://email@example.com
Fix interval_transform so it doesn't throw away non-no-op casts.
commit : 58359983909ae2c4038da21c907d606fd6da9bdf author : Tom Lane <firstname.lastname@example.org> date : Tue, 27 Dec 2016 15:43:54 -0500 committer: Tom Lane <email@example.com> date : Tue, 27 Dec 2016 15:43:54 -0500
interval_transform() contained two separate bugs that caused it to sometimes mistakenly decide that a cast from interval to restricted interval is a no-op and throw it away. First, it was wrong to rely on dt.h's field type macros to have an ordering consistent with the field's significance; in one case they do not. This led to mistakenly treating YEAR as less significant than MONTH, so that a cast from INTERVAL MONTH to INTERVAL YEAR was incorrectly discarded. Second, fls(1<<k) produces k+1 not k, so comparing its output directly to SECOND was wrong. This led to supposing that a cast to INTERVAL MINUTE was really a cast to INTERVAL SECOND and so could be discarded. To fix, get rid of the use of fls(), and make a function based on intervaltypmodout to produce a field ID code adapted to the need here. Per bug #14479 from Piotr Stefaniak. Back-patch to 9.2 where transform functions were introduced, because this code was born broken. Discussion: https://firstname.lastname@example.org
Explain unaccounted for space in pgstattuple.
commit : f60daa3bdc2d268077cf618b170ebe4443ed6377 author : Andrew Dunstan <email@example.com> date : Tue, 27 Dec 2016 11:23:46 -0500 committer: Andrew Dunstan <firstname.lastname@example.org> date : Tue, 27 Dec 2016 11:23:46 -0500
In addition to space accounted for by tuple_len, dead_tuple_len and free_space, the table_len includes page overhead, the item pointers table and padding bytes. Backpatch to live branches.
Remove triggerable Assert in hashname().
commit : a6d5e47e68d1a0748ee830f03ca05f4236206d00 author : Tom Lane <email@example.com> date : Mon, 26 Dec 2016 14:58:02 -0500 committer: Tom Lane <firstname.lastname@example.org> date : Mon, 26 Dec 2016 14:58:02 -0500
hashname() asserted that the key string it is given is shorter than NAMEDATALEN. That should surely always be true if the input is in fact a regular value of type "name". However, for reasons of coding convenience, we allow plain old C strings to be treated as "name" values in many places. Some SQL functions accept arbitrary "text" inputs, convert them to C strings, and pass them otherwise-untransformed to syscache lookups for name columns, allowing an overlength input value to trigger hashname's Assert. This would be a DOS problem, except that it only happens in assert-enabled builds which aren't recommended for production. In a production build, you'll just get a name lookup error, since regardless of the hash value computed by hashname, the later equality comparison checks can't match. Likewise, if the catalog lookup is done by seqscan or indexscan searches, there will just be a lookup error, since the name comparison functions don't contain any similar length checks, and will see an overlength input as unequal to any stored entry. After discussion we concluded that we should simply remove this Assert. It's inessential to hashname's own functionality, and having such an assertion in only some paths for name lookup is more of a foot-gun than a useful check. There may or may not be a case for the affected callers to do something other than let the name lookup fail, but we'll consider that separately; in any case we probably don't want to change such behavior in the back branches. Per report from Tushar Ahuja. Back-patch to all supported branches. Report: https://email@example.com Discussion: https://firstname.lastname@example.org
pg_dumpall: Include --verbose option in --help output
commit : 376d05f1db0601c018d96ba789b13184df6ec4dd author : Stephen Frost <email@example.com> date : Sat, 24 Dec 2016 01:42:14 -0500 committer: Stephen Frost <firstname.lastname@example.org> date : Sat, 24 Dec 2016 01:42:14 -0500
The -v/--verbose option was not included in the output from --help for pg_dumpall even though it's in the pg_dumpall documentation and has apparently been around since pg_dumpall was reimplemented in C in 2002. Fix that by adding it. Pointed out by Daniel Westermann. Back-patch to all supported branches. Discussion: https://www.postgresql.org/message-id/2020970042.4589542.1482482101585.JavaMail.zimbra%40dbi-services.com
Fix tab completion in psql for ALTER DEFAULT PRIVILEGES
commit : 2022d594da3233dca4a4570b1e4e5d8a83ff6163 author : Stephen Frost <email@example.com> date : Fri, 23 Dec 2016 21:01:48 -0500 committer: Stephen Frost <firstname.lastname@example.org> date : Fri, 23 Dec 2016 21:01:48 -0500
When providing tab completion for ALTER DEFAULT PRIVILEGES, we are including the list of roles as possible options for completion after the GRANT or REVOKE. Further, we accept FOR ROLE/IN SCHEMA at the same time and in either order, but the tab completion was only working for one or the other. Lastly, we weren't using the actual list of allowed kinds of objects for default privileges for completion after the 'GRANT X ON' but instead were completeing to what 'GRANT X ON' supports, which isn't the ssame at all. Address these issues by improving the forward tab-completion for ALTER DEFAULT PRIVILEGES and then constrain and correct how the tail completion is done when it is for ALTER DEFAULT PRIVILEGES. Back-patch the forward/tail tab-completion to 9.6, where we made it easy to handle such cases. For 9.5 and earlier, correct the initial tab-completion to at least be correct as far as it goes and then add a check for GRANT/REVOKE to only tab-complete when the GRANT/REVOKE is the start of the command, so we don't try to do tab-completion after we get to the GRANT/REVOKE part of the ALTER DEFAULT PRIVILEGES command, which is better than providing incorrect completions. Initial patch for master and 9.6 by Gilles Darold, though I cleaned it up and added a few comments. All bugs in the 9.5 and earlier patch are mine. Discussion: https://email@example.com
Use TSConfigRelationId in AlterTSConfiguration()
commit : 0e3aadb682f0c76f6b21ac0058e3717eb7cc2b19 author : Stephen Frost <firstname.lastname@example.org> date : Thu, 22 Dec 2016 17:09:00 -0500 committer: Stephen Frost <email@example.com> date : Thu, 22 Dec 2016 17:09:00 -0500
When we are altering a text search configuration, we are getting the tuple from pg_ts_config and using its OID, so use TSConfigRelationId when invoking any post-alter hooks and setting the object address. Further, in the functions called from AlterTSConfiguration(), we're saving information about the command via EventTriggerCollectAlterTSConfig(), so we should be setting commandCollected to true. Also add a regression test to test_ddl_deparse for ALTER TEXT SEARCH CONFIGURATION. Author: Artur Zakirov, a few additional comments by me Discussion: https://www.postgresql.org/message-id/57a71eba-f2c7-e7fd-6fc0-2126ec0b39bd%40postgrespro.ru Back-patch the fix for the InvokeObjectPostAlterHook() call to 9.3 where it was introduced, and the fix for the ObjectAddressSet() call and setting commandCollected to true to 9.5 where those changes to ProcessUtilitySlow() were introduced.
Fix broken error check in _hash_doinsert.
commit : 603ad8ad298315cab79fa4e1c78095e4a3eca003 author : Robert Haas <firstname.lastname@example.org> date : Thu, 22 Dec 2016 13:54:40 -0500 committer: Robert Haas <email@example.com> date : Thu, 22 Dec 2016 13:54:40 -0500
You can't just cast a HashMetaPage to a Page, because the meta page data is stored after the page header, not at offset 0. Fortunately, this didn't break anything because it happens to find hashm_bsize at the offset at which it expects to find pd_pagesize_version, and the values are close enough to the same that this works out. Still, it's a bug, so back-patch to all supported versions. Mithun Cy, revised a bit by me.
Make dblink try harder to form useful error messages
commit : 9b8507bfae9119427a5c3acf037c466a7e3d7046 author : Joe Conway <firstname.lastname@example.org> date : Thu, 22 Dec 2016 09:47:25 -0800 committer: Joe Conway <email@example.com> date : Thu, 22 Dec 2016 09:47:25 -0800
When libpq encounters a connection-level error, e.g. runs out of memory while forming a result, there will be no error associated with PGresult, but a message will be placed into PGconn's error buffer. postgres_fdw takes care to use the PGconn error message when PGresult does not have one, but dblink has been negligent in that regard. Modify dblink to mirror what postgres_fdw has been doing. Back-patch to all supported branches. Author: Joe Conway Reviewed-By: Tom Lane Discussion: https://postgr.es/m/02fa2d90-2efd-00bc-fefc-c23c00eb671e%40joeconway.com
Protect dblink from invalid options when using postgres_fdw server
commit : bd46cce21476792c71952e23543bd943b160d0f1 author : Joe Conway <firstname.lastname@example.org> date : Thu, 22 Dec 2016 09:18:50 -0800 committer: Joe Conway <email@example.com> date : Thu, 22 Dec 2016 09:18:50 -0800
When dblink uses a postgres_fdw server name for its connection, it is possible for the connection to have options that are invalid with dblink (e.g. "updatable"). The recommended way to avoid this problem is to use dblink_fdw servers instead. However there are use cases for using postgres_fdw, and possibly other FDWs, for dblink connection options, therefore protect against trying to use any options that do not apply by using is_valid_dblink_option() when building the connection string from the options. Back-patch to 9.3. Although 9.2 supports FDWs for connection info, is_valid_dblink_option() did not yet exist, and neither did postgres_fdw, at least in the postgres source tree. Given the lack of previous complaints, fixing that seems too invasive/not worth it. Author: Corey Huinker Reviewed-By: Joe Conway Discussion: https://postgr.es/m/CADkLM%3DfWyXVEyYcqbcRnxcHutkP45UHU9WD7XpdZaMfe7S%3DRwA%40mail.gmail.com
Fix buffer overflow on particularly named files and clarify documentation about output file naming.
commit : 1df8b3fe820d4d589f6a38ea0d0c9e5714651509 author : Michael Meskes <firstname.lastname@example.org> date : Thu, 22 Dec 2016 08:28:13 +0100 committer: Michael Meskes <email@example.com> date : Thu, 22 Dec 2016 08:28:13 +0100
Patch by Tsunakawa, Takayuki <firstname.lastname@example.org>
Improve dblink error message when remote does not provide it
commit : 3272be3468956eedb9e18a5e1dc9eef352663152 author : Joe Conway <email@example.com> date : Wed, 21 Dec 2016 15:48:40 -0800 committer: Joe Conway <firstname.lastname@example.org> date : Wed, 21 Dec 2016 15:48:40 -0800
When dblink or postgres_fdw detects an error on the remote side of the connection, it will try to construct a local error message as best it can using libpq's PQresultErrorField(). When no primary message is available, it was bailing out with an unhelpful "unknown error". Make that message better and more style guide compliant. Per discussion on hackers. Backpatch to 9.2 except postgres_fdw which didn't exist before 9.3. Discussion: https://postgr.es/m/19872.1482338965%40sss.pgh.pa.us
Fix detection of unfinished Unicode surrogate pair at end of string.
commit : a57695d9a815ce355e17c5cdec181f87bc9de3f9 author : Tom Lane <email@example.com> date : Wed, 21 Dec 2016 17:39:33 -0500 committer: Tom Lane <firstname.lastname@example.org> date : Wed, 21 Dec 2016 17:39:33 -0500
The U&'...' and U&"..." syntaxes silently discarded a surrogate pair start (that is, a code between U+D800 and U+DBFF) if it occurred at the very end of the string. This seems like an obvious oversight, since we throw an error for every other invalid combination of surrogate characters, including the very same situation in E'...' syntax. This has been wrong since the pair processing was added (in 9.0), so back-patch to all supported branches. Discussion: https://email@example.com
Fix dumping of casts and transforms using built-in functions
commit : 1f2cfd26f50d3a7d885961aa68361d40d7753949 author : Stephen Frost <firstname.lastname@example.org> date : Wed, 21 Dec 2016 13:47:28 -0500 committer: Stephen Frost <email@example.com> date : Wed, 21 Dec 2016 13:47:28 -0500
In pg_dump.c dumpCast() and dumpTransform(), we would happily ignore the cast or transform if it happened to use a built-in function because we weren't including the information about built-in functions when querying pg_proc from getFuncs(). Modify the query in getFuncs() to also gather information about functions which are used by user-defined casts and transforms (where "user-defined" means "has an OID >= FirstNormalObjectId"). This also adds to the TAP regression tests for 9.6 and master to cover these types of objects. Back-patch all the way for casts, back to 9.5 for transforms. Discussion: https://www.postgresql.org/message-id/flat/20160504183952.GE10850%40tamriel.snowman.net
For 8.0 servers, get last built-in oid from pg_database
commit : fc03f7dd195fba5ff3abd222d7e7d4a8e3a63341 author : Stephen Frost <firstname.lastname@example.org> date : Wed, 21 Dec 2016 13:47:28 -0500 committer: Stephen Frost <email@example.com> date : Wed, 21 Dec 2016 13:47:28 -0500
We didn't start ensuring that all built-in objects had OIDs less than 16384 until 8.1, so for 8.0 servers we still need to query the value out of pg_database. We need this, in particular, to distinguish which casts were built-in and which were user-defined. For HEAD, we only worry about going back to 8.0, for the back-branches, we also ensure that 7.0-7.4 work. Discussion: https://www.postgresql.org/message-id/flat/20160504183952.GE10850%40tamriel.snowman.net
Fix off-by-one in memory allocation for quote_literal_cstr().
commit : e71fe84708174b3ae56add6d2ad98e9c91f84589 author : Heikki Linnakangas <firstname.lastname@example.org> date : Fri, 16 Dec 2016 12:50:20 +0200 committer: Heikki Linnakangas <email@example.com> date : Fri, 16 Dec 2016 12:50:20 +0200
The calculation didn't take into account the NULL terminator. That lead to overwriting the palloc'd buffer by one byte, if the input consists entirely of backslashes. For example "format('%L', E'\\')". Fixes bug #14468. Backpatch to all supported versions. Report: https://www.postgresql.org/message-id/20161216105001.13334.42819%40wrigleys.postgresql.org
Sync our copy of the timezone library with IANA release tzcode2016j.
commit : ccf24539b6bf23345c57b76749b84c9af31ca8a5 author : Tom Lane <firstname.lastname@example.org> date : Thu, 15 Dec 2016 14:32:42 -0500 committer: Tom Lane <email@example.com> date : Thu, 15 Dec 2016 14:32:42 -0500
This is a trivial update (consisting in fact only in the addition of a comment). The point is just to get back to being synced with an official release of tzcode, rather than some ad-hoc point in their commit history, which is where commit 1f87181e1 left it.
Back-patch fcff8a575198478023ada8a48e13b50f70054766 as a bug fix.
commit : 5d80171adace192c6d4308ae4b22074d6b0809f3 author : Kevin Grittner <firstname.lastname@example.org> date : Tue, 13 Dec 2016 19:05:35 -0600 committer: Kevin Grittner <email@example.com> date : Tue, 13 Dec 2016 19:05:35 -0600
When there is both a serialization failure and a unique violation, throw the former rather than the latter. When initially pushed, this was viewed as a feature to assist application framework developers, so that they could more accurately determine when to retry a failed transaction, but a test case presented by Ian Jackson has shown that this patch can prevent serialization anomalies in some cases where a unique violation is caught within a subtransaction, the work of that subtransaction is discarded, and no error is thrown. That makes this a bug fix, so it is being back-patched to all supported branches where it is not already present (i.e., 9.2 to 9.5). Discussion: https://firstname.lastname@example.org Discussion: https://email@example.com
Use "%option prefix" to set API names in ecpg's lexer.
commit : 2bdee07abefee3e59db9f89da635d7ecf9716a7b author : Tom Lane <firstname.lastname@example.org> date : Sun, 11 Dec 2016 18:04:28 -0500 committer: Tom Lane <email@example.com> date : Sun, 11 Dec 2016 18:04:28 -0500
Back-patch commit 92fb64983 into the pre-9.6 branches. Without this, ecpg fails to build with the latest version of flex. It's not unreasonable that people would want to compile our old branches with recent tools. Per report from Дилян Палаузов. Discussion: https://firstname.lastname@example.org
Build backend/parser/scan.l and interfaces/ecpg/preproc/pgc.l standalone.
commit : 73ae395d84198ff14792522c79471975936ee76a author : Tom Lane <email@example.com> date : Sun, 11 Dec 2016 17:44:16 -0500 committer: Tom Lane <firstname.lastname@example.org> date : Sun, 11 Dec 2016 17:44:16 -0500
Back-patch commit 72b1e3a21 into the pre-9.6 branches. As noted in the original commit, this has some extra benefits: we can narrow the scope of the -Wno-error flag that's forced on scan.c. Also, since these grammar and lexer files are so large, splitting them into separate build targets should have some advantages in build speed, particularly in parallel or ccache'd builds. However, the real reason for doing this now is that it avoids symbol- redefinition warnings (or worse) with the latest version of flex. It's not unreasonable that people would want to compile our old branches with recent tools. Per report from Дилян Палаузов. Discussion: https://email@example.com
Prevent crash when ts_rewrite() replaces a non-top-level subtree with null.
commit : 79e1a9efa808d2e15ea41d06d7696a6daab05467 author : Tom Lane <firstname.lastname@example.org> date : Sun, 11 Dec 2016 13:09:57 -0500 committer: Tom Lane <email@example.com> date : Sun, 11 Dec 2016 13:09:57 -0500
When ts_rewrite()'s replacement argument is an empty tsquery, it's supposed to simplify any operator nodes whose operand(s) become NULL; but it failed to do that reliably, because dropvoidsubtree() only examined the top level of the result tree. Rather than make a second recursive pass, let's just give the responsibility to dofindsubquery() to simplify while it's doing the main replacement pass. Per report from Andreas Seltenreich. Artur Zakirov, with some cosmetic changes by me. Back-patch to all supported branches. Discussion: https://firstname.lastname@example.org
Be more careful about Python refcounts while creating exception objects.
commit : cea6de20b35624d5cc7985867b15c7af2b87ea0b author : Tom Lane <email@example.com> date : Fri, 9 Dec 2016 15:27:23 -0500 committer: Tom Lane <firstname.lastname@example.org> date : Fri, 9 Dec 2016 15:27:23 -0500
PLy_generate_spi_exceptions neglected to do Py_INCREF on the new exception objects, evidently supposing that PyModule_AddObject would do that --- but it doesn't. This left us in a situation where a Python garbage collection cycle could result in deletion of exception object(s), causing server crashes or wrong answers if the exception objects are used later in the session. In addition, PLy_generate_spi_exceptions didn't bother to test for a null result from PyErr_NewException, which at best is inconsistent with the code in PLy_add_exceptions. And PLy_add_exceptions, while it did do Py_INCREF on the exceptions it makes, waited to do that till after some PyModule_AddObject calls, creating a similar risk for failure if garbage collection happened within those calls. To fix, refactor to have just one piece of code that creates an exception object and adds it to the spiexceptions module, bumping the refcount first. Also, let's add an additional refcount to represent the pointer we're going to store in a C global variable or hash table. This should only matter if the user does something weird like delete the spiexceptions Python module, but lack of paranoia has caused us enough problems in PL/Python already. The fact that PyModule_AddObject doesn't do a Py_INCREF of its own explains the need for the Py_INCREF added in commit 4c966d920, so we can improve the comment about that; also, this means we really want to do that before not after the PyModule_AddObject call. The missing Py_INCREF in PLy_generate_spi_exceptions was reported and diagnosed by Rafa de la Torre; the other fixes by me. Back-patch to all supported branches. Discussion: https://postgr.es/m/CA+Fz15kR1OXZv43mDrJb3XY+1MuQYWhx5kx3ea6BRKQp6ezGkg@mail.gmail.com
Fix reporting of column typmods for multi-row VALUES constructs.
commit : 2afe282a37322bd21890344206b3abe7eea42bb7 author : Tom Lane <email@example.com> date : Fri, 9 Dec 2016 12:01:14 -0500 committer: Tom Lane <firstname.lastname@example.org> date : Fri, 9 Dec 2016 12:01:14 -0500
expandRTE() and get_rte_attribute_type() reported the exprType() and exprTypmod() values of the expressions in the first row of the VALUES as being the column type/typmod returned by the VALUES RTE. That's fine for the data type, since we coerce all expressions in a column to have the same common type. But we don't coerce them to have a common typmod, so it was possible for rows after the first one to return values that violate the claimed column typmod. This leads to the incorrect result seen in bug #14448 from Hassan Mahmood, as well as some other corner-case misbehaviors. The desired behavior is the same as we use in other type-unification cases: report the common typmod if there is one, but otherwise return -1 indicating no particular constraint. We fixed this in HEAD by deriving the typmods during transformValuesClause and storing them in the RTE, but that's not a feasible solution in the back branches. Instead, just use a brute-force approach of determining the correct common typmod during expandRTE() and get_rte_attribute_type(). Simple testing says that that doesn't really cost much, at least not in common cases where expandRTE() is only used once per query. It turns out that get_rte_attribute_type() is typically never used at all on VALUES RTEs, so the inefficiency there is of no great concern. Report: https://email@example.com Discussion: https://firstname.lastname@example.org
Log the creation of an init fork unconditionally.
commit : 8e403f2151995595a8f24c6c90adc331a8353289 author : Robert Haas <email@example.com> date : Thu, 8 Dec 2016 14:09:09 -0500 committer: Robert Haas <firstname.lastname@example.org> date : Thu, 8 Dec 2016 14:09:09 -0500
Previously, it was thought that this only needed to be done for the benefit of possible standbys, so wal_level = minimal skipped it. But that's not safe, because during crash recovery we might replay XLOG_DBASE_CREATE or XLOG_TBLSPC_CREATE record which recursively removes the directory that contains the new init fork. So log it always. The user-visible effect of this bug is that if you create a database or tablespace, then create an unlogged table, then crash without checkpointing, then restart, accessing the table will fail, because the it won't have been properly reset. This commit fixes that. Michael Paquier, per a report from Konstantin Knizhnik. Wording of the comments per a suggestion from me.
Restore psql's SIGPIPE setting if popen() fails.
commit : 433e65c2bd907723a5d93b3f2ff0bdbc77a0b625 author : Tom Lane <email@example.com> date : Wed, 7 Dec 2016 12:39:24 -0500 committer: Tom Lane <firstname.lastname@example.org> date : Wed, 7 Dec 2016 12:39:24 -0500
Ancient oversight in PageOutput(): if popen() fails, we'd better reset the SIGPIPE handler before returning stdout, because ClosePager() won't. Noticed while fixing the empty-PAGER issue.
Handle empty or all-blank PAGER setting more sanely in psql.
commit : 82eb5c5144732df7774fe1f83c0b079e068c5be9 author : Tom Lane <email@example.com> date : Wed, 7 Dec 2016 12:19:56 -0500 committer: Tom Lane <firstname.lastname@example.org> date : Wed, 7 Dec 2016 12:19:56 -0500
If the PAGER environment variable is set but contains an empty string, psql would pass it to "sh" which would silently exit, causing whatever query output we were printing to vanish entirely. This is quite mystifying; it took a long time for us to figure out that this was the cause of Joseph Brenner's trouble report. Rather than allowing that to happen, we should treat this as another way to specify "no pager". (We could alternatively treat it as selecting the default pager, but it seems more likely that the former is what the user meant to achieve by setting PAGER this way.) Nonempty, but all-white-space, PAGER values have the same behavior, and it's pretty easy to test for that, so let's handle that case the same way. Most other cases of faulty PAGER values will result in the shell printing some kind of complaint to stderr, which should be enough to diagnose the problem, so we don't need to work harder than this. (Note that there's been an intentional decision not to be very chatty about apparent failure returns from the pager process, since that may happen if, eg, the user quits the pager with control-C or some such. I'd just as soon not start splitting hairs about which exit codes might merit making our own report.) libpq's old PQprint() function was already on board with ignoring empty PAGER values, but for consistency, make it ignore all-white-space values as well. It's been like this a long time, so back-patch to all supported branches. Discussion: https://postgr.es/m/CAFfgvXWLOE2novHzYjmQK8-J6TmHz42G8f3X0SORM44+stUGmw@mail.gmail.com
Make pgwin32_putenv() visit debug CRTs.
commit : 6c5d5918b5f7fe5e24680832a5c381dd3ae934f0 author : Noah Misch <email@example.com> date : Sat, 3 Dec 2016 15:46:36 -0500 committer: Noah Misch <firstname.lastname@example.org> date : Sat, 3 Dec 2016 15:46:36 -0500
This has no effect in the most conventional case, where no relevant DLL uses a debug build. For an example where it does matter, given a debug build of MIT Kerberos, the krb_server_keyfile parameter usually had no effect. Since nobody wants a Heisenbug, back-patch to 9.2 (all supported versions). Christian Ullrich, reviewed by Michael Paquier.
Remove wrong CloseHandle() call.
commit : 4c3505eb46779a2d4ea55b731736b994a0f3eb49 author : Noah Misch <email@example.com> date : Sat, 3 Dec 2016 15:46:35 -0500 committer: Noah Misch <firstname.lastname@example.org> date : Sat, 3 Dec 2016 15:46:35 -0500
In accordance with its own documentation, invoke CloseHandle() only when directed in the documentation for the function that furnished the handle. GetModuleHandle() does not so direct. We have been issuing this call only in the rare event that a CRT DLL contains no "_putenv" symbol, so lack of bug reports is uninformative. Back-patch to 9.2 (all supported versions). Christian Ullrich, reviewed by Michael Paquier.
Refine win32env.c cosmetics.
commit : 2d60d921ed4b54074ebf1991ddd2d80f8bf2175a author : Noah Misch <email@example.com> date : Sat, 3 Dec 2016 15:46:35 -0500 committer: Noah Misch <firstname.lastname@example.org> date : Sat, 3 Dec 2016 15:46:35 -0500
Replace use of plain 0 as a null pointer constant. In comments, update terminology and lessen redundancy. Back-patch to 9.2 (all supported versions) for the convenience of back-patching the next two commits. Christian Ullrich and Noah Misch, reviewed (in earlier versions) by Michael Paquier.
Doc: improve description of trim() and related functions.
commit : 35532e3b0a96345d230893cb18cb9590cdef142c author : Tom Lane <email@example.com> date : Wed, 30 Nov 2016 13:34:14 -0500 committer: Tom Lane <firstname.lastname@example.org> date : Wed, 30 Nov 2016 13:34:14 -0500
Per bug #14441 from Mark Pether, the documentation could be misread, mainly because some of the examples failed to show what happens with a multicharacter "characters to trim" string. Also, while the text description in most of these entries was fairly clear that the "characters" argument is a set of characters not a substring to match, some of them used variant wording that was a bit less clear. trim() itself suffered from both deficiencies and was thus pretty misinterpretable. Also fix failure to explain which of LEADING/TRAILING/BOTH is the default. Discussion: https://email@example.com
Clarify pg_dump -b documentation
commit : eacdd5d7b06576c025f449b5a9eca0c11c85a5a2 author : Stephen Frost <firstname.lastname@example.org> date : Tue, 29 Nov 2016 10:35:14 -0500 committer: Stephen Frost <email@example.com> date : Tue, 29 Nov 2016 10:35:14 -0500
The documentation around the -b/--blobs option to pg_dump seemed to imply that it might be possible to add blobs to a "schema-only" dump or similar. Clarify that blobs are data and therefore will only be included in dumps where data is being included, even when -b is used to request blobs be included. The -b option has been around since before 9.2, so back-patch to all supported branches. Discussion: https://postgr.es/m/20161119173316.GA13284@tamriel.snowman.net
Fix test about ignoring extension dependencies during extension scripts.
commit : 2cbb62db1303766a98fe87f35d0f74710573e692 author : Tom Lane <firstname.lastname@example.org> date : Sat, 26 Nov 2016 13:31:35 -0500 committer: Tom Lane <email@example.com> date : Sat, 26 Nov 2016 13:31:35 -0500
Commit 08dd23cec introduced an exception to the rule that extension member objects can only be dropped as part of dropping the whole extension, intending to allow such drops while running the extension's own creation or update scripts. However, the exception was only applied at the outermost recursion level, because it was modeled on a pre-existing check to ignore dependencies on objects listed in pendingObjects. Bug #14434 from Philippe Beaudoin shows that this is inadequate: in some cases we can reach an extension member object by recursion from another one. (The bug concerns the serial-sequence case; I'm not sure if there are other cases, but there might well be.) To fix, revert 08dd23cec's changes to findDependentObjects() and instead apply the creating_extension exception regardless of stack level. Having seen this example, I'm a bit suspicious that the pendingObjects logic is also wrong and such cases should likewise be allowed at any recursion level. However, changing that would interact in subtle ways with the recursion logic (at least it would need to be moved to after the recursing-from check). Given that the code's been like that a long time, I'll refrain from touching it without a clear example showing it's wrong. Back-patch to all active branches. In HEAD and 9.6, where suitable test infrastructure exists, add a regression test case based on the bug report. Report: <firstname.lastname@example.org> Discussion: <email@example.com>
Check for pending trigger events on far end when dropping an FK constraint.
commit : 05bef7b0884d85c25a3c8a5060c6389e6da52531 author : Tom Lane <firstname.lastname@example.org> date : Fri, 25 Nov 2016 13:44:48 -0500 committer: Tom Lane <email@example.com> date : Fri, 25 Nov 2016 13:44:48 -0500
When dropping a foreign key constraint with ALTER TABLE DROP CONSTRAINT, we refuse the drop if there are any pending trigger events on the named table; this ensures that we won't remove the pg_trigger row that will be consulted by those events. But we should make the same check for the referenced relation, else we might remove a due-to-be-referenced pg_trigger row for that relation too, resulting in "could not find trigger NNN" or "relation NNN has no triggers" errors at commit. Per bug #14431 from Benjie Gillam. Back-patch to all supported branches. Report: <firstname.lastname@example.org>
Make sure ALTER TABLE preserves index tablespaces.
commit : 8f67a6c226a3f73b7115491650630dd8a91937df author : Tom Lane <email@example.com> date : Wed, 23 Nov 2016 13:45:56 -0500 committer: Tom Lane <firstname.lastname@example.org> date : Wed, 23 Nov 2016 13:45:56 -0500
When rebuilding an existing index, ALTER TABLE correctly kept the physical file in the same tablespace, but it messed up the pg_class entry if the index had been in the database's default tablespace and "default_tablespace" was set to some non-default tablespace. This led to an inaccessible index. Fix by fixing pg_get_indexdef_string() to always include a tablespace clause, whether or not the index is in the default tablespace. The previous behavior was installed in commit 537e92e41, and I think it just wasn't thought through very clearly; certainly the possible effect of default_tablespace wasn't considered. There's some risk in changing the behavior of this function, but there are no other call sites in the core code. Even if it's being used by some third party extension, it's fairly hard to envision a usage that is okay with a tablespace clause being appended some of the time but can't handle it being appended all the time. Back-patch to all supported versions. Code fix by me, investigation and test cases by Michael Paquier. Discussion: <email@example.com>
Doc: improve documentation about composite-value usage.
commit : 624839a9739edee79ecb98b09b9f588e8d418358 author : Tom Lane <firstname.lastname@example.org> date : Tue, 22 Nov 2016 17:56:16 -0500 committer: Tom Lane <email@example.com> date : Tue, 22 Nov 2016 17:56:16 -0500
Create a section specifically for the syntactic rules around whole-row variable usage, such as expansion of "foo.*". This was previously documented only haphazardly, with some critical info buried in unexpected places like xfunc-sql-composite-functions. Per repeated questions in different mailing lists. Discussion: <firstname.lastname@example.org>
Doc: add a section in Part II concerning RETURNING.
commit : 1477f39cafa98bccbec897af832ede250e180036 author : Tom Lane <email@example.com> date : Tue, 22 Nov 2016 14:02:52 -0500 committer: Tom Lane <firstname.lastname@example.org> date : Tue, 22 Nov 2016 14:02:52 -0500
There are assorted references to RETURNING in Part II, but nothing that would qualify as an explanation of the feature, which seems like an oversight considering how useful it is. Add something. Noted while looking for a place to point a cross-reference to ...
Fix PGLC_localeconv() to handle errors better.
commit : cd5dfea32d4a85bdbe071cb099c1b6822c746d3d author : Tom Lane <email@example.com> date : Mon, 21 Nov 2016 18:21:56 -0500 committer: Tom Lane <firstname.lastname@example.org> date : Mon, 21 Nov 2016 18:21:56 -0500
The code was intentionally not very careful about leaking strdup'd strings in case of an error. That was forgivable probably, but it also failed to notice strdup() failures, which could lead to subsequent null-pointer-dereference crashes, since many callers unsurprisingly didn't check for null pointers in the struct lconv fields. An even worse problem is that it could throw error while we were setlocale'd to a non-C locale, causing unwanted behavior in subsequent libc calls. Rewrite to ensure that we cannot throw elog(ERROR) until after we've restored the previous locale settings, or at least attempted to. (I'm sorely tempted to make restore failure be a FATAL error, but will refrain for the moment.) Having done that, it's not much more work to ensure that we clean up strdup'd storage on the way out, too. This code is substantially the same in all supported branches, so back-patch all the way. Michael Paquier and Tom Lane Discussion: <CAB7nPqRMbGqa_mesopcn4MPyTs34eqtVEK7ELYxvvV=oqS00YA@mail.gmail.com>
Prevent multicolumn expansion of "foo.*" in an UPDATE source expression.
commit : 71db302ecf4876f898ef49a57f9cb92b828ad736 author : Tom Lane <email@example.com> date : Sun, 20 Nov 2016 14:26:19 -0500 committer: Tom Lane <firstname.lastname@example.org> date : Sun, 20 Nov 2016 14:26:19 -0500
Because we use transformTargetList() for UPDATE as well as SELECT tlists, the code accidentally tried to expand a "*" reference into several columns. This is nonsensical, because the UPDATE syntax provides exactly one target column to put the value into. The immediate result was that transformUpdateTargetList() got confused and reported "UPDATE target count mismatch --- internal error". It seems better to treat such a reference as a plain whole-row variable, as it would be in other contexts. (This could produce useful results when the target column is of composite type.) Fix by tweaking transformTargetList() to perform *-expansion only conditionally, depending on its exprKind parameter. Back-patch to 9.3. The problem exists further back, but a fix would be much more invasive before that, because transformTargetList() wasn't told what kind of list it was working on. Doesn't seem worth the trouble given the lack of field reports. (I only noticed it because I was checking the code while trying to improve the documentation about how we handle "foo.*".) Discussion: <email@example.com>
Allow DOS-style line endings in ~/.pgpass files.
commit : 46b6f3fff0f11b22538d63f3711b206250bc6962 author : Tom Lane <firstname.lastname@example.org> date : Tue, 15 Nov 2016 16:17:19 -0500 committer: Tom Lane <email@example.com> date : Tue, 15 Nov 2016 16:17:19 -0500
On Windows, libc will mask \r\n line endings for us, since we read the password file in text mode. But that doesn't happen on Unix. People who share password files across both systems might have \r\n line endings in a file they use on Unix, so as a convenience, ignore trailing \r. Per gripe from Josh Berkus. In passing, put the existing check for empty line somewhere where it's actually useful, ie after stripping the newline not before. Vik Fearing, adjusted a bit by me Discussion: <firstname.lastname@example.org>
commit : 2cd311d4992cf57de832728cb9f84dc2efd802b7 author : Magnus Hagander <email@example.com> date : Tue, 8 Nov 2016 18:34:59 +0100 committer: Magnus Hagander <firstname.lastname@example.org> date : Tue, 8 Nov 2016 18:34:59 +0100
Rationalize and document pltcl's handling of magic ".tupno" array element.
commit : 9c0b04f18b2f9cf0a56f6dc97f506b21a6a041c3 author : Tom Lane <email@example.com> date : Sun, 6 Nov 2016 14:43:14 -0500 committer: Tom Lane <firstname.lastname@example.org> date : Sun, 6 Nov 2016 14:43:14 -0500
For a very long time, pltcl's spi_exec and spi_execp commands have had a behavior of storing the current row number as an element of output arrays, but this was never documented. Fix that. For an equally long time, pltcl_trigger_handler had a behavior of silently ignoring ".tupno" as an output column name, evidently so that the result of spi_exec could be used directly as a trigger result tuple. Not sure how useful that really is, but in any case it's bad that it would break attempts to use ".tupno" as an actual column name. We can fix it by not checking for ".tupno" until after we check for a column name match. This comports with the effective behavior of spi_exec[p] that ".tupno" is only magic when you don't have an actual column named that. In passing, wordsmith the description of returning modified tuples from a pltcl trigger. Noted while working on Jim Nasby's patch to support composite results from pltcl. The inability to return trigger tuples using ".tupno" as a column name is a bug, so back-patch to all supported branches.
More zic cleanup.
commit : 3a8f24abdf9e4889ba83bf0ee1c3fe34a31a7f0e author : Tom Lane <email@example.com> date : Sun, 6 Nov 2016 10:45:58 -0500 committer: Tom Lane <firstname.lastname@example.org> date : Sun, 6 Nov 2016 10:45:58 -0500
The workaround the IANA guys chose to get rid of the clang warning we'd silenced in commit 23ed2ba81 turns out not to satisfy Coverity. Go back to the previous solution, ie, remove the useless comparison to SIZE_MAX. (In principle, there could be machines out there where it's not useless because ptrdiff_t is wider than size_t. But the whole thing is pretty academic anyway, as we could never approach this limit for any sane estimate of the amount of data that zic will ever be asked to work with.) Also, s/lineno/lineno_t/g, because if we accept their decision to start using "lineno" as a typedef, it is going to have very unpleasant consequences in our next pgindent run. Noted that while fooling with pltcl yesterday.
Sync our copy of the timezone library with IANA tzcode master.
commit : 22b1207a33d177f8c2d86d16133d2946d5e29597 author : Tom Lane <email@example.com> date : Fri, 4 Nov 2016 10:44:16 -0400 committer: Tom Lane <firstname.lastname@example.org> date : Fri, 4 Nov 2016 10:44:16 -0400
This patch absorbs some unreleased fixes for symlink manipulation bugs introduced in tzcode 2016g. Ordinarily I'd wait around for a released version, but in this case it seems like we could do with extra testing, in particular checking whether it works in EDB's VMware build environment. This corresponds to commit aec59156abbf8472ba201b6c7ca2592f9c10e077 in https://github.com/eggert/tz. Per a report from Sandeep Thakkar, building in an environment where hard links are not supported in the timezone data installation directory failed, because upstream code refactoring had broken the case of symlinking from an existing symlink. Further experimentation also showed that the symlinks were sometimes made incorrectly, with too many or too few "../"'s in the symlink contents. Back-patch of commit 1f87181e12beb067d21b79493393edcff14c190b. Report: <CANFyU94_p6mqRQc2i26PFp5QAOQGB++AjGX=FO8LDpXw0GSTjw@mail.gmail.com> Discussion: http://mm.icann.org/pipermail/tz/2016-November/024431.html
Fix nasty performance problem in tsquery_rewrite().
commit : 407d513dfcf47185110ee606de2f2eeafdf469d3 author : Tom Lane <email@example.com> date : Sun, 30 Oct 2016 17:35:43 -0400 committer: Tom Lane <firstname.lastname@example.org> date : Sun, 30 Oct 2016 17:35:43 -0400
tsquery_rewrite() tries to find matches to subsets of AND/OR conditions; for example, in the query 'a | b | c' the substitution subquery 'a | c' should match and lead to replacement of the first and third items. That's fine, but the matching algorithm apparently takes about O(2^N) for an N-clause query (I say "apparently" because the code is also both unintelligible and uncommented). We could probably do better than that even without any extra assumptions --- but actually, we know that the subclauses are sorted, indeed are depending on that elsewhere in this very same function. So we can just scan the two lists a single time to detect matches, as though we were doing a merge join. Also do a re-flattening call (QTNTernary()) in tsquery_rewrite_query, just to make sure that the tree fits the expectations of the next search cycle. I didn't try to devise a test case for this, but I'm pretty sure that the oversight could have led to failure to match in some cases where a match would be expected. Improve comments, and also stick a CHECK_FOR_INTERRUPTS into dofindsubquery, just in case it's still too slow for somebody. Per report from Andreas Seltenreich. Back-patch to all supported branches. Discussion: <email@example.com>
Fix bogus tree-flattening logic in QTNTernary().
commit : 77a22f898e6633c9f15e0c3edfa6f6296ba6f17b author : Tom Lane <firstname.lastname@example.org> date : Sun, 30 Oct 2016 15:24:40 -0400 committer: Tom Lane <email@example.com> date : Sun, 30 Oct 2016 15:24:40 -0400
QTNTernary() contains logic to flatten, eg, '(a & b) & c' into 'a & b & c', which is all well and good, but it tries to do that to NOT nodes as well, so that '!!a' gets changed to '!a'. Explicitly restrict the conversion to be done only on AND and OR nodes, and add a test case illustrating the bug. In passing, provide some comments for the sadly naked functions in tsquery_util.c, and simplify some baroque logic in QTNFree(), which I think may have been leaking some items it intended to free. Noted while investigating a complaint from Andreas Seltenreich. Back-patch to all supported versions.
If the stats collector dies during Hot Standby, restart it.
commit : e927f55ffffb43b29e7a8c459825950b2b280219 author : Robert Haas <firstname.lastname@example.org> date : Thu, 27 Oct 2016 14:27:40 -0400 committer: Robert Haas <email@example.com> date : Thu, 27 Oct 2016 14:27:40 -0400
This bug exists as far back as 9.0, when Hot Standby was introduced, so back-patch to all supported branches. Report and patch by Takayuki Tsunakawa, reviewed by Michael Paquier and Kuntal Ghosh.
Fix possible pg_basebackup failure on standby with "include WAL".
commit : 92929a3e370dcc89ff806c2a8fb2fc257c42f01a author : Robert Haas <firstname.lastname@example.org> date : Thu, 27 Oct 2016 11:19:51 -0400 committer: Robert Haas <email@example.com> date : Thu, 27 Oct 2016 11:19:51 -0400
If a restartpoint flushed no dirty buffers, it could fail to update the minimum recovery point, leading to a minimum recovery point prior to the starting REDO location. perform_base_backup() would interpret that as meaning that no WAL files at all needed to be included in the backup, failing an internal sanity check. To fix, have restartpoints always update the minimum recovery point to just after the checkpoint record itself, so that the file (or files) containing the checkpoint record will always be included in the backup. Code by Amit Kapila, per a design suggestion by me, with some additional work on the code comment by me. Test case by Michael Paquier. Report by Kyotaro Horiguchi.
Fix not-HAVE_SYMLINK code in zic.c.
commit : 44c56d3b1c30f6cf2febe43271f324bb90c931f2 author : Tom Lane <firstname.lastname@example.org> date : Wed, 26 Oct 2016 13:40:41 -0400 committer: Tom Lane <email@example.com> date : Wed, 26 Oct 2016 13:40:41 -0400
I broke this in commit f3094920a. Apparently it's dead code anyway, at least as far as our buildfarm is concerned (and the upstream IANA code doesn't worry at all about symlink() not being present). But as long as the rest of our code is willing to guard against not having symlink(), this should too. Noted while investigating a tangentially-related complaint from Sandeep Thakkar. Back-patch to keep branches in sync.