PostgreSQL 9.3.18 commit log

Stamp 9.3.18.

  
commit   : a5915db2fab1fbe555b6410440df5177a247a2f2    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 7 Aug 2017 17:17:46 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 7 Aug 2017 17:17:46 -0400    

Click here for diff

  
  

Translation updates

  
commit   : 61f52850f5809ff62b8d2605ded0503f6a822ec9    
  
author   : Peter Eisentraut <peter_e@gmx.net>    
date     : Mon, 7 Aug 2017 13:51:07 -0400    
  
committer: Peter Eisentraut <peter_e@gmx.net>    
date     : Mon, 7 Aug 2017 13:51:07 -0400    

Click here for diff

  
Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git  
Source-Git-Hash: 0858deb5ec238f269d1311ff1299f003fc168cab  
  

Last-minute updates for release notes.

  
commit   : d64440f5fb7483faeb5fc1c9822e1ad2e0b555e2    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 7 Aug 2017 11:46:20 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 7 Aug 2017 11:46:20 -0400    

Click here for diff

  
Security: CVE-2017-7546, CVE-2017-7547, CVE-2017-7548  
  

Again match pg_user_mappings to information_schema.user_mapping_options.

  
commit   : 5e8e009146e3cae5c596d6e857a9c98fe22657b8    
  
author   : Noah Misch <noah@leadboat.com>    
date     : Mon, 7 Aug 2017 07:09:28 -0700    
  
committer: Noah Misch <noah@leadboat.com>    
date     : Mon, 7 Aug 2017 07:09:28 -0700    

Click here for diff

  
Commit 3eefc51053f250837c3115c12f8119d16881a2d7 claimed to make  
pg_user_mappings enforce the qualifications user_mapping_options had  
been enforcing, but its removal of a longstanding restriction left them  
distinct when the current user is the subject of a mapping yet has no  
server privileges.  user_mapping_options emits no rows for such a  
mapping, but pg_user_mappings includes full umoptions.  Change  
pg_user_mappings to show null for umoptions.  Back-patch to 9.2, like  
the above commit.  
  
Reviewed by Tom Lane.  Reported by Jeff Janes.  
  
Security: CVE-2017-7547  
  

Don’t allow logging in with empty password.

  
commit   : b2f833ea71bf9d2d56ec0c0ae4d839b001e6e7b1    
  
author   : Heikki Linnakangas <heikki.linnakangas@iki.fi>    
date     : Mon, 7 Aug 2017 17:03:42 +0300    
  
committer: Heikki Linnakangas <heikki.linnakangas@iki.fi>    
date     : Mon, 7 Aug 2017 17:03:42 +0300    

Click here for diff

  
Some authentication methods allowed it, others did not. In the client-side,  
libpq does not even try to authenticate with an empty password, which makes  
using empty passwords hazardous: an administrator might think that an  
account with an empty password cannot be used to log in, because psql  
doesn't allow it, and not realize that a different client would in fact  
allow it. To clear that confusion and to be be consistent, disallow empty  
passwords in all authentication methods.  
  
All the authentication methods that used plaintext authentication over the  
wire, except for BSD authentication, already checked that the password  
received from the user was not empty. To avoid forgetting it in the future  
again, move the check to the recv_password_packet function. That only  
forbids using an empty password with plaintext authentication, however.  
MD5 and SCRAM need a different fix:  
  
* In stable branches, check that the MD5 hash stored for the user does not  
not correspond to an empty string. This adds some overhead to MD5  
authentication, because the server needs to compute an extra MD5 hash, but  
it is not noticeable in practice.  
  
* In HEAD, modify CREATE and ALTER ROLE to clear the password if an empty  
string, or a password hash that corresponds to an empty string, is  
specified. The user-visible behavior is the same as in the stable branches,  
the user cannot log in, but it seems better to stop the empty password from  
entering the system in the first place. Secondly, it is fairly expensive to  
check that a SCRAM hash doesn't correspond to an empty string, because  
computing a SCRAM hash is much more expensive than an MD5 hash by design,  
so better avoid doing that on every authentication.  
  
We could clear the password on CREATE/ALTER ROLE also in stable branches,  
but we would still need to check at authentication time, because even if we  
prevent empty passwords from being stored in pg_authid, there might be  
existing ones there already.  
  
Reported by Jeroen van der Ham, Ben de Graaff and Jelte Fennema.  
  
Security: CVE-2017-7546  
  

Release notes for 9.6.4, 9.5.8, 9.4.13, 9.3.18, 9.2.22.

  
commit   : 73c2b36ab56f3ee114e814ecce5e40a59d73fc23    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sun, 6 Aug 2017 17:56:49 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sun, 6 Aug 2017 17:56:49 -0400    

Click here for diff

  
  

Disallow SSL session tickets.

  
commit   : dda04b9dd1bdfcda2edc180b0eb346988f3497da    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 4 Aug 2017 11:07:10 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 4 Aug 2017 11:07:10 -0400    

Click here for diff

  
We don't actually support session tickets, since we do not create an SSL  
session identifier.  But it seems that OpenSSL will issue a session ticket  
on-demand anyway, which will then fail when used.  This results in  
reconnection failures when using ticket-aware client-side SSL libraries  
(such as the Npgsql .NET driver), as reported by Shay Rojansky.  
  
To fix, just tell OpenSSL not to issue tickets.  At some point in the  
far future, we might consider enabling tickets instead.  But the security  
implications of that aren't entirely clear; and besides it would have  
little benefit except for very short-lived database connections, which is  
Something We're Bad At anyhow.  It would take a lot of other work to get  
to a point where that would really be an exciting thing to do.  
  
While at it, also tell OpenSSL not to use a session cache.  This doesn't  
really do anything, since a backend would never populate the cache anyway,  
but it might gain some micro-efficiencies and/or reduce security  
exposures.  
  
Patch by me, per discussion with Heikki Linnakangas and Shay Rojansky.  
Back-patch to all supported versions.  
  
Discussion: https://postgr.es/m/CADT4RqBU8N-csyZuzaook-c795dt22Zcwg1aHWB6tfVdAkodZA@mail.gmail.com  
  

Add missing ALTER USER variants

  
commit   : b7d1bc820e191d8b56a35c8a8af409062c3a71be    
  
author   : Peter Eisentraut <peter_e@gmx.net>    
date     : Thu, 3 Aug 2017 20:49:07 -0400    
  
committer: Peter Eisentraut <peter_e@gmx.net>    
date     : Thu, 3 Aug 2017 20:49:07 -0400    

Click here for diff

  
ALTER USER ... SET did not support all the syntax variants of ALTER ROLE  
...  SET.  
  
Reported-by: Pavel Golub <pavel@microolap.com>  
  

Fix pg_dump/pg_restore to emit REFRESH MATERIALIZED VIEW commands last.

  
commit   : 035bb82222bc0518a740d02483395fafd333d426    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 3 Aug 2017 17:36:23 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 3 Aug 2017 17:36:23 -0400    

Click here for diff

  
Because we push all ACL (i.e. GRANT/REVOKE) restore steps to the end,  
materialized view refreshes were occurring while the permissions on  
referenced objects were still at defaults.  This led to failures if,  
say, an MV owned by user A reads from a table owned by user B, even  
if B had granted the necessary privileges to A.  We've had multiple  
complaints about that type of restore failure, most recently from  
Jordan Gigov.  
  
The ideal fix for this would be to start treating ACLs as dependency-  
sortable objects, rather than hard-wiring anything about their dump order  
(the existing approach is a messy kluge dating to commit dc0e76ca3).  
But that's going to be a rather major change, and it certainly wouldn't  
lead to a back-patchable fix.  As a short-term solution, convert the  
existing two-pass hack (ie, normal objects then ACLs) to a three-pass hack,  
ie, normal objects then ACLs then matview refreshes.  Because this happens  
in RestoreArchive(), it will also fix the problem when restoring from an  
existing archive-format dump.  
  
(Note this means that if a matview refresh would have failed under the  
permissions prevailing at dump time, it'll fail during restore as well.  
We'll define that as user error rather than something we should try  
to work around.)  
  
To avoid performance loss in parallel restore, we need the matview  
refreshes to still be parallelizable.  Hence, clean things up enough  
so that both ACLs and matviews are handled by the parallel restore  
infrastructure, instead of reverting back to serial restore for ACLs.  
There is still a final serial step, but it shouldn't normally have to  
do anything; it's only there to try to recover if we get stuck due to  
some problem like unresolved circular dependencies.  
  
Patch by me, but it owes something to an earlier attempt by Kevin Grittner.  
Back-patch to 9.3 where materialized views were introduced.  
  
Discussion: https://postgr.es/m/28572.1500912583@sss.pgh.pa.us  
  

Add pgtcl back to the list of externally-maintained client interfaces.

  
commit   : fb31e3a272e7b18e6f86b6b58f0833c5726322b6    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 2 Aug 2017 16:55:03 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 2 Aug 2017 16:55:03 -0400    

Click here for diff

  
FlightAware is still maintaining this, and indeed is seemingly being  
more active with it than the pgtclng fork is.  List both, for the  
time being anyway.  
  
In the back branches, also back-port commit e20f679f6 and other  
recent updates to the client-interfaces list.  I think these are  
probably of current interest to users of back branches.  I did  
not touch the list of externally maintained PLs in the back  
branches, though.  Those are much more likely to be server version  
sensitive, and I don't know which of these PLs work all the way back.  
  
Discussion: https://postgr.es/m/20170730162612.1449.58796@wrigleys.postgresql.org  
  

Silence warning from modern perl about unescaped braces

  
commit   : 3d9ae20e75e0fd08420454a316192d0d1038edc4    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 2 Aug 2017 15:07:20 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 2 Aug 2017 15:07:20 -0400    

Click here for diff

  
Back-patch commit 76a1c97bf21c301f61bb41345e0cdd0d365b2086 into  
the older branches (9.5 and before).  This is needed because perl  
5.26 and later treats the case as an error not just a warning.  
  
Original patch by Andrew Dunstan, need for back-patch noted by  
Ashutosh Sharma  
  
Discussion: https://postgr.es/m/CAE9k0PkfNcmj9pA7Yx4qQ=K=3aY4TuiRhp7KYpayDWm9MYsnjg@mail.gmail.com  
  

Fix comment.

  
commit   : bf19a6fe32840bbb56c10a370df38a56666994cb    
  
author   : Tatsuo Ishii <ishii@postgresql.org>    
date     : Tue, 1 Aug 2017 08:00:11 +0900    
  
committer: Tatsuo Ishii <ishii@postgresql.org>    
date     : Tue, 1 Aug 2017 08:00:11 +0900    

Click here for diff

  
XLByteToSeg and XLByteToPrevSeg calculate only a segment number.  The  
definition of these macros were modified by commit  
dfda6ebaec6763090fb78b458a979b558c50b39b but the comment remain  
unchanged.  
  
Patch by Yugo Nagata. Back patched to 9.3 and beyond.  
  

Doc: specify that the minimum supported version of Perl is 5.8.3.

  
commit   : 3bf894feebcb8339b5e7348facf20f7ccf596af4    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 31 Jul 2017 13:42:48 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 31 Jul 2017 13:42:48 -0400    

Click here for diff

  
Previously the docs just said "5.8 or later".  Experimentation shows  
that while you can build on Unix from a git checkout with 5.8.0,  
compiling recent PL/Perl requires at least 5.8.1, and you won't be  
able to run the TAP tests with less than 5.8.3 because that's when  
they added "prove".  (I do not have any information on just what the  
MSVC build scripts require.)  
  
Since all these versions are quite ancient, let's not split hairs  
in the docs, but just say that 5.8.3 is the minimum requirement.  
  
Discussion: https://postgr.es/m/16894.1501392088@sss.pgh.pa.us  
  

PL/Perl portability fix: absorb relevant -D switches from Perl.

  
commit   : 0d8f015e7726f5c9635b0b435a4cdf4d6dcdfdbe    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 31 Jul 2017 12:38:35 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 31 Jul 2017 12:38:35 -0400    

Click here for diff

  
Back-patch of commit 3c163a7fc76debbbdad1bdd3c43721cffe72f4db,  
which see for more info.  
  
Also throw in commit b4cc35fbb709bd6fcae8998f041fd731c9acbf42,  
so Coverity doesn't whine about the back branches.  
  
Ashutosh Sharma, some adjustments by me  
  
Discussion: https://postgr.es/m/CANFyU97OVQ3+Mzfmt3MhuUm5NwPU=-FtbNH5Eb7nZL9ua8=rcA@mail.gmail.com  
  

PL/Perl portability fix: avoid including XSUB.h in plperl.c.

  
commit   : b92f17277eb92da18366ccddeffcea997692f9e5    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 31 Jul 2017 12:10:36 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 31 Jul 2017 12:10:36 -0400    

Click here for diff

  
Back-patch of commit bebe174bb4462ef079a1d7eeafb82ff969f160a4,  
which see for more info.  
  
Patch by me, with some help from Ashutosh Sharma  
  
Discussion: https://postgr.es/m/CANFyU97OVQ3+Mzfmt3MhuUm5NwPU=-FtbNH5Eb7nZL9ua8=rcA@mail.gmail.com  
  

Add missing comment in postgresql.conf.

  
commit   : c89d4a28fb00f0e3142726ceb2e0d1a671d70da0    
  
author   : Tatsuo Ishii <ishii@postgresql.org>    
date     : Mon, 31 Jul 2017 11:24:51 +0900    
  
committer: Tatsuo Ishii <ishii@postgresql.org>    
date     : Mon, 31 Jul 2017 11:24:51 +0900    

Click here for diff

  
current_source requires to restart server to reflect the new  
value. Per Yugo Nagata and Masahiko Sawada.  
  
Back patched to 9.2 and beyond.  
  

Fix psql tab completion for CREATE USER MAPPING.

  
commit   : 689646b05e86a1fb93bd1dcd71dc8b695e586030    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 27 Jul 2017 14:13:15 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 27 Jul 2017 14:13:15 -0400    

Click here for diff

  
After typing CREATE USER M..., it would not fill in MAPPING FOR,  
even though that was clearly intended behavior.  
  
Jeff Janes  
  
Discussion: https://postgr.es/m/CAMkU=1wo2iQ6jWnN=egqOb5NxEPn0PpANEtKHr3uPooQ+nYPtw@mail.gmail.com  
  

Clean up SQL emitted by psql/describe.c.

  
commit   : 00cf718b84af63bc7bfb4c937979c42d0973db79    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 26 Jul 2017 19:35:35 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 26 Jul 2017 19:35:35 -0400    

Click here for diff

  
Fix assorted places that had not bothered with the convention of  
prefixing catalog and function names with "pg_catalog.".  That  
could possibly result in query failure when running with a nondefault  
search_path.  Also fix two places that weren't quoting OID literals.  
I think the latter hasn't mattered much since about 7.3, but it's still  
a bad idea to be doing it in 99 places and not in 2 others.  
  
Also remove a useless EXISTS sub-select that someone had stuck into  
describeOneTableDetails' queries for child tables.  We just got the OID  
out of pg_class, so I hardly see how checking that it exists in pg_class  
was doing anything helpful.  
  
In passing, try to improve the emitted formatting of a couple of  
these queries, though I didn't work really hard on that.  And merge  
unnecessarily duplicative coding in some other places.  
  
Much of this was new in HEAD, but some was quite old; back-patch  
as appropriate.  
  

Fix concurrent locking of tuple update chain

  
commit   : 2efbfb94b8872362841d13f420ebcae7832e113d    
  
author   : Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Wed, 26 Jul 2017 17:24:16 -0400    
  
committer: Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Wed, 26 Jul 2017 17:24:16 -0400    

Click here for diff

  
If several sessions are concurrently locking a tuple update chain with  
nonconflicting lock modes using an old snapshot, and they all succeed,  
it may happen that some of them fail because of restarting the loop (due  
to a concurrent Xmax change) and getting an error in the subsequent pass  
while trying to obtain a tuple lock that they already have in some tuple  
version.  
  
This can only happen with very high concurrency (where a row is being  
both updated and FK-checked by multiple transactions concurrently), but  
it's been observed in the field and can have unpleasant consequences  
such as an FK check failing to see a tuple that definitely exists:  
    ERROR:  insert or update on table "child_table" violates foreign key constraint "fk_constraint_name"  
    DETAIL:  Key (keyid)=(123456) is not present in table "parent_table".  
(where the key is observably present in the table).  
  
Discussion: https://postgr.es/m/20170714210011.r25mrff4nxjhmf3g@alvherre.pgsql  
  

Fix race condition in predicate-lock init code in EXEC_BACKEND builds.

  
commit   : 4ecee1192a02bb467ddf4e361523a751258f0991    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 24 Jul 2017 16:45:47 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 24 Jul 2017 16:45:47 -0400    

Click here for diff

  
Trading a little too heavily on letting the code path be the same whether  
we were creating shared data structures or only attaching to them,  
InitPredicateLocks() inserted the "scratch" PredicateLockTargetHash entry  
unconditionally.  This is just wrong if we're in a postmaster child,  
which would only reach this code in EXEC_BACKEND builds.  Most of the  
time, the hash_search(HASH_ENTER) call would simply report that the  
entry already existed, causing no visible effect since the code did not  
bother to check for that possibility.  However, if this happened while  
some other backend had transiently removed the "scratch" entry, then  
that other backend's eventual RestoreScratchTarget would suffer an  
assert failure; this appears to be the explanation for a recent failure  
on buildfarm member culicidae.  In non-assert builds, there would be  
no visible consequences there either.  But nonetheless this is a pretty  
bad bug for EXEC_BACKEND builds, for two reasons:  
  
1. Each new backend would perform the hash_search(HASH_ENTER) call  
without holding any lock that would prevent concurrent access to the  
PredicateLockTargetHash hash table.  This creates a low but certainly  
nonzero risk of corruption of that hash table.  
  
2. In the event that the race condition occurred, by reinserting the  
scratch entry too soon, we were defeating the entire purpose of the  
scratch entry, namely to guarantee that transaction commit could move  
hash table entries around with no risk of out-of-memory failure.  
The odds of an actual OOM failure are quite low, but not zero, and if  
it did happen it would again result in corruption of the hash table.  
  
The user-visible symptoms of such corruption are a little hard to predict,  
but would presumably amount to misbehavior of SERIALIZABLE transactions  
that'd require a crash or postmaster restart to fix.  
  
To fix, just skip the hash insertion if IsUnderPostmaster.  I also  
inserted a bunch of assertions that the expected things happen  
depending on whether IsUnderPostmaster is true.  That might be overkill,  
since most comparable code in other functions isn't quite that paranoid,  
but once burnt twice shy.  
  
In passing, also move a couple of lines to places where they seemed  
to make more sense.  
  
Diagnosis of problem by Thomas Munro, patch by me.  Back-patch to  
all supported branches.  
  
Discussion: https://postgr.es/m/10593.1500670709@sss.pgh.pa.us  
  

Ensure that pg_get_ruledef()’s output matches pg_get_viewdef()’s.

  
commit   : b6d64004765710eab097c40e76bb689b464643ef    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 24 Jul 2017 15:16:31 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 24 Jul 2017 15:16:31 -0400    

Click here for diff

  
Various cases involving renaming of view columns are handled by having  
make_viewdef pass down the view's current relation tupledesc to  
get_query_def, which then takes care to use the column names from the  
tupledesc for the output column names of the SELECT.  For some reason  
though, we'd missed teaching make_ruledef to do similarly when it is  
printing an ON SELECT rule, even though this is exactly the same case.  
The results from pg_get_ruledef would then be different and arguably wrong.  
In particular, this breaks pre-v10 versions of pg_dump, which in some  
situations would define views by means of emitting a CREATE RULE ... ON  
SELECT command.  Third-party tools might not be happy either.  
  
In passing, clean up some crufty code in make_viewdef; we'd apparently  
modernized the equivalent code in make_ruledef somewhere along the way,  
and missed this copy.  
  
Per report from Gilles Darold.  Back-patch to all supported versions.  
  
Discussion: https://postgr.es/m/ec05659a-40ff-4510-fc45-ca9d965d0838@dalibo.com  
  

MSVC: Accept tcl86.lib in addition to tcl86t.lib.

  
commit   : 9842c1b559a9041371fb7d30a83cb94d2de79896    
  
author   : Noah Misch <noah@leadboat.com>    
date     : Sun, 23 Jul 2017 23:53:27 -0700    
  
committer: Noah Misch <noah@leadboat.com>    
date     : Sun, 23 Jul 2017 23:53:27 -0700    

Click here for diff

  
ActiveTcl8.6.4.1.299124-win32-x86_64-threaded.exe ships just tcl86.lib.  
Back-patch to 9.2, like the commit recognizing tcl86t.lib.  
  

Fix pg_dump’s handling of event triggers.

  
commit   : 68a22bc69df85cadd21ef6614de3a53d1df26384    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sat, 22 Jul 2017 20:20:10 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sat, 22 Jul 2017 20:20:10 -0400    

Click here for diff

  
pg_dump with the --clean option failed to emit DROP EVENT TRIGGER  
commands for event triggers.  In a closely related oversight,  
it also did not emit ALTER OWNER commands for event triggers.  
Since only superusers can create event triggers, the latter oversight  
is of little practical consequence ... but if we're going to record  
an owner for event triggers, then surely pg_dump should preserve it.  
  
Per complaint from Greg Atkins.  Back-patch to 9.3 where event triggers  
were introduced.  
  
Discussion: https://postgr.es/m/20170722191142.yi4e7tzcg3iacclg@gmail.com  
  

Stabilize postgres_fdw regression tests.

  
commit   : 6d9de660dcec7a92d4dfce6dd680420fe817bb85    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 21 Jul 2017 14:20:43 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 21 Jul 2017 14:20:43 -0400    

Click here for diff

  
The new test cases added in commit 8bf58c0d9 turn out to have output  
that can vary depending on the lc_messages setting prevailing on the  
test server.  Hide the remote end's error messages to ensure stable  
output.  This isn't a terribly desirable solution; we'd rather know  
that the connection failed for the expected reason and not some other  
one.  But there seems little choice for the moment.  
  
Per buildfarm.  
  
Discussion: https://postgr.es/m/18419.1500658570@sss.pgh.pa.us  
  

Re-establish postgres_fdw connections after server or user mapping changes.

  
commit   : 69711415e6fd8d61c0760c2208f121a5b89d4126    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 21 Jul 2017 12:51:38 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 21 Jul 2017 12:51:38 -0400    

Click here for diff

  
Previously, postgres_fdw would keep on using an existing connection even  
if the user did ALTER SERVER or ALTER USER MAPPING commands that should  
affect connection parameters.  Teach it to watch for catcache invals  
on these catalogs and re-establish connections when the relevant catalog  
entries change.  Per bug #14738 from Michal Lis.  
  
In passing, clean up some rather crufty decisions in commit ae9bfc5d6  
about where fields of ConnCacheEntry should be reset.  We now reset  
all the fields whenever we open a new connection.  
  
Kyotaro Horiguchi, reviewed by Ashutosh Bapat and myself.  
Back-patch to 9.3 where postgres_fdw appeared.  
  
Discussion: https://postgr.es/m/20170710113917.7727.10247@wrigleys.postgresql.org  
  

Doc: clarify description of degenerate NATURAL joins.

  
commit   : a6088e1f5a58e47ee6f207ec13c67773852df970    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 20 Jul 2017 12:41:26 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 20 Jul 2017 12:41:26 -0400    

Click here for diff

  
Claiming that NATURAL JOIN is equivalent to CROSS JOIN when there are  
no common column names is only strictly correct if it's an inner join;  
you can't say e.g. CROSS LEFT JOIN.  Better to explain it as meaning  
JOIN ON TRUE, instead.  Per a suggestion from David Johnston.  
  
Discussion: https://postgr.es/m/CAKFQuwb+mYszQhDS9f_dqRrk1=Pe-S6D=XMkAXcDf4ykKPmgKQ@mail.gmail.com  
  

Fix dumping of outer joins with empty qual lists.

  
commit   : e947838ae432579d86fa35f0b4d6a384c20d4824    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 20 Jul 2017 11:29:36 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 20 Jul 2017 11:29:36 -0400    

Click here for diff

  
Normally, a JoinExpr would have empty "quals" only if it came from CROSS  
JOIN syntax.  However, it's possible to get to this state by specifying  
NATURAL JOIN between two tables with no common column names, and there  
might be other ways too.  The code previously printed no ON clause if  
"quals" was empty; that's right for CROSS JOIN but syntactically invalid  
if it's some type of outer join.  Fix by printing ON TRUE in that case.  
  
This got broken by commit 2ffa740be, which stopped using NATURAL JOIN  
syntax in ruleutils output due to its brittleness in the face of  
column renamings.  Back-patch to 9.3 where that commit appeared.  
  
Per report from Tushar Ahuja.  
  
Discussion: https://postgr.es/m/98b283cd-6dda-5d3f-f8ac-87db8c76a3da@enterprisedb.com  
  

Doc: add missing note about permissions needed to change log_lock_waits.

  
commit   : cd969b23bc03d0251310f6f6a204bd3ffc6d0186    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 19 Jul 2017 12:58:36 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 19 Jul 2017 12:58:36 -0400    

Click here for diff

  
log_lock_waits is PGC_SUSET, but config.sgml lacked the standard  
boilerplate sentence noting that.  
  
Report: https://postgr.es/m/20170719100838.19352.16320@wrigleys.postgresql.org  
  

Doc: explain dollar quoting in the intro part of the pl/pgsql chapter.

  
commit   : a64726e7a53482fca80860cd0ea5038f465f7fa1    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 17 Jul 2017 16:43:03 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 17 Jul 2017 16:43:03 -0400    

Click here for diff

  
We're throwing people into the guts of the syntax with not much context;  
let's back up one step and point out that this goes inside a literal in  
a CREATE FUNCTION command.  Per suggestion from Kurt Kartaltepe.  
  
Discussion: https://postgr.es/m/CACawnnyWAmH+au8nfZhLiFfWKjXy4d0kY+eZWfcxPRnjVfaa_Q@mail.gmail.com  
  

Merge large_object.sql test into largeobject.source.

  
commit   : 1a3ec19b1a93edf4c088a8d4cc6d6d9dc4b0e2c0    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 17 Jul 2017 15:28:17 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 17 Jul 2017 15:28:17 -0400    

Click here for diff

  
It seems pretty confusing to have tests named both largeobject and  
large_object.  The latter is of very recent vintage (commit ff992c074),  
so get rid of it in favor of merging into the former.  
  
Also, enable the LO comment test that was added by commit 70ad7ed4e,  
since the later commit added the then-missing pg_upgrade functionality.  
The large_object.sql test case is almost completely redundant with that,  
but not quite: it seems like creating a user-defined LO with an OID in  
the system range might be an interesting case for pg_upgrade, so let's  
keep it.  
  
Like the earlier patch, back-patch to all supported branches.  
  
Discussion: https://postgr.es/m/18665.1500306372@sss.pgh.pa.us  
  

Fix pg_basebackup output to stdout on Windows.

  
commit   : f3633689f25be3b1ee58745e5b069fc276024d47    
  
author   : Heikki Linnakangas <heikki.linnakangas@iki.fi>    
date     : Fri, 14 Jul 2017 16:02:53 +0300    
  
committer: Heikki Linnakangas <heikki.linnakangas@iki.fi>    
date     : Fri, 14 Jul 2017 16:02:53 +0300    

Click here for diff

  
When writing a backup to stdout with pg_basebackup on Windows, put stdout  
to binary mode. Any CR bytes in the output will otherwise be output  
incorrectly as CR+LF.  
  
In the passing, standardize on using "_setmode" instead of "setmode", for  
the sake of consistency. They both do the same thing, but according to  
MSDN documentation, setmode is deprecated.  
  
Fixes bug #14634, reported by Henry Boehlert. Patch by Haribabu Kommi.  
Backpatch to all supported versions.  
  
Discussion: https://www.postgresql.org/message-id/20170428082818.24366.13134@wrigleys.postgresql.org  
  

Fix dumping of FUNCTION RTEs that contain non-function-call expressions.

  
commit   : 0ecc407d94514f2dfcf0d6261be84b20d6adee6e    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 13 Jul 2017 19:24:44 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 13 Jul 2017 19:24:44 -0400    

Click here for diff

  
The grammar will only accept something syntactically similar to a function  
call in a function-in-FROM expression.  However, there are various ways  
to input something that ruleutils.c won't deparse that way, potentially  
leading to a view or rule that fails dump/reload.  Fix by inserting a  
dummy CAST around anything that isn't going to deparse as a function  
(which is one of the ways to get something like that in there in the  
first place).  
  
In HEAD, also make use of the infrastructure added by this to avoid  
emitting unnecessary parentheses in CREATE INDEX deparsing.  I did  
not change that in back branches, thinking that people might find it  
to be unexpected/unnecessary behavioral change.  
  
In HEAD, also fix incorrect logic for when to add extra parens to  
partition key expressions.  Somebody apparently thought they could  
get away with simpler logic than pg_get_indexdef_worker has, but  
they were wrong --- a counterexample is PARTITION BY LIST ((a[1])).  
Ignoring the prettyprint flag for partition expressions isn't exactly  
a nice solution anyway.  
  
This has been broken all along, so back-patch to all supported branches.  
  
Discussion: https://postgr.es/m/10477.1499970459@sss.pgh.pa.us  
  

Fix race between GetNewTransactionId and GetOldestActiveTransactionId.

  
commit   : 5c5af32d1870ef198c04955e71a843f0ccab6df6    
  
author   : Heikki Linnakangas <heikki.linnakangas@iki.fi>    
date     : Thu, 13 Jul 2017 15:47:02 +0300    
  
committer: Heikki Linnakangas <heikki.linnakangas@iki.fi>    
date     : Thu, 13 Jul 2017 15:47:02 +0300    

Click here for diff

  
The race condition goes like this:  
  
1. GetNewTransactionId advances nextXid e.g. from 100 to 101  
2. GetOldestActiveTransactionId reads the new nextXid, 101  
3. GetOldestActiveTransactionId loops through the proc array. There are no  
   active XIDs there, so it returns 101 as the oldest active XID.  
4. GetNewTransactionid stores XID 100 to MyPgXact->xid  
  
So, GetOldestActiveTransactionId returned XID 101, even though 100 only  
just started and is surely still running.  
  
This would be hard to hit in practice, and even harder to spot any ill  
effect if it happens. GetOldestActiveTransactionId is only used when  
creating a checkpoint in a master server, and the race condition can only  
happen on an online checkpoint, as there are no backends running during a  
shutdown checkpoint. The oldestActiveXid value of an online checkpoint is  
only used when starting up a hot standby server, to determine the starting  
point where pg_subtrans is initialized from. For the race condition to  
happen, there must be no other XIDs in the proc array that would hold back  
the oldest-active XID value, which means that the missed XID must be a top  
transaction's XID. However, pg_subtrans is not used for top XIDs, so I  
believe an off-by-one error is in fact inconsequential. Nevertheless, let's  
fix it, as it's clearly wrong and the fix is simple.  
  
This has been wrong ever since hot standby was introduced, so backport to  
all supported versions.  
  
Discussion: https://www.postgresql.org/message-id/e7258662-82b6-7a45-56d4-99b337a32bf7@iki.fi  
  

Fix ruleutils.c for domain-over-array cases, too.

  
commit   : aea1a3f0ebfcbe17f3ce89cf4cf9bd20828c199e    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 12 Jul 2017 18:00:04 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 12 Jul 2017 18:00:04 -0400    

Click here for diff

  
Further investigation shows that ruleutils isn't quite up to speed either  
for cases where we have a domain-over-array: it needs to be prepared to  
look past a CoerceToDomain at the top level of field and element  
assignments, else it decompiles them incorrectly.  Potentially this would  
result in failure to dump/reload a rule, if it looked like the one in the  
new test case.  (I also added a test for EXPLAIN; that output isn't broken,  
but clearly we need more test coverage here.)  
  
Like commit b1cb32fb6, this bug is reachable in cases we already support,  
so back-patch all the way.  
  

Reduce memory usage of tsvector type analyze function.

  
commit   : 11854dee01e582e83d87fc2b3a5316f2d44852b3    
  
author   : Heikki Linnakangas <heikki.linnakangas@iki.fi>    
date     : Wed, 12 Jul 2017 22:03:38 +0300    
  
committer: Heikki Linnakangas <heikki.linnakangas@iki.fi>    
date     : Wed, 12 Jul 2017 22:03:38 +0300    

Click here for diff

  
compute_tsvector_stats() detoasted and kept in memory every tsvector value  
in the sample, but that can be a lot of memory. The original bug report  
described a case using over 10 gigabytes, with statistics target of 10000  
(the maximum).  
  
To fix, allocate a separate copy of just the lexemes that we keep around,  
and free the detoasted tsvector values as we go. This adds some palloc/pfree  
overhead, when you have a lot of distinct lexemes in the sample, but it's  
better than running out of memory.  
  
Fixes bug #14654 reported by James C. Reviewed by Tom Lane. Backport to  
all supported versions.  
  
Discussion: https://www.postgresql.org/message-id/20170514200602.1451.46797@wrigleys.postgresql.org  
  

Fix variable and type name in comment.

  
commit   : cf3e27685312653bd67a79e600d7f709a4fdcd7e    
  
author   : Heikki Linnakangas <heikki.linnakangas@iki.fi>    
date     : Wed, 12 Jul 2017 17:07:35 +0300    
  
committer: Heikki Linnakangas <heikki.linnakangas@iki.fi>    
date     : Wed, 12 Jul 2017 17:07:35 +0300    

Click here for diff

  
Kyotaro Horiguchi  
  
Discussion: https://www.postgresql.org/message-id/20170711.163441.241981736.horiguchi.kyotaro@lab.ntt.co.jp  
  

Remove unnecessary braces, to match the surrounding style.

  
commit   : 66a3ea0711db8d0eb04da98b0f1354929b9daf30    
  
author   : Heikki Linnakangas <heikki.linnakangas@iki.fi>    
date     : Wed, 12 Jul 2017 12:30:50 +0300    
  
committer: Heikki Linnakangas <heikki.linnakangas@iki.fi>    
date     : Wed, 12 Jul 2017 12:30:50 +0300    

Click here for diff

  
Mostly in the new subscription-related commands. Backport the few that  
were also present in older versions.  
  
Thomas Munro  
  
Discussion: https://www.postgresql.org/message-id/CAEepm=3CyW1QmXcXJXmqiJXtXzFDc8SvSfnxkEGD3Bkv2SrkeQ@mail.gmail.com  
  

Fix multiple assignments to a column of a domain type.

  
commit   : 521fede166d6d8ce0c7745c169ad7c0ea49233c9    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Tue, 11 Jul 2017 16:48:59 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Tue, 11 Jul 2017 16:48:59 -0400    

Click here for diff

  
We allow INSERT and UPDATE commands to assign to the same column more than  
once, as long as the assignments are to subfields or elements rather than  
the whole column.  However, this failed when the target column was a domain  
over array rather than plain array.  Fix by teaching process_matched_tle()  
to look through CoerceToDomain nodes, and add relevant test cases.  
  
Also add a group of test cases exercising domains over array of composite.  
It's doubtless accidental that CREATE DOMAIN allows this case while not  
allowing straight domain over composite; but it does, so we'd better make  
sure we don't break it.  (I could not find any documentation mentioning  
either side of that, so no doc changes.)  
  
It's been like this for a long time, so back-patch to all supported  
branches.  
  
Discussion: https://postgr.es/m/4206.1499798337@sss.pgh.pa.us  
  

On Windows, retry process creation if we fail to reserve shared memory.

  
commit   : 59892b1209b9202338dbfc65c9a59cbed182befb    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 10 Jul 2017 11:00:09 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 10 Jul 2017 11:00:09 -0400    

Click here for diff

  
We've heard occasional reports of backend launch failing because  
pgwin32_ReserveSharedMemoryRegion() fails, indicating that something  
has already used that address space in the child process.  It's not  
very clear what, given that we disable ASLR in Windows builds, but  
suspicion falls on antivirus products.  It'd be better if we didn't  
have to disable ASLR, anyway.  So let's try to ameliorate the problem  
by retrying the process launch after such a failure, up to 100 times.  
  
Patch by me, based on previous work by Amit Kapila and others.  
This is a longstanding issue, so back-patch to all supported branches.  
  
Discussion: https://postgr.es/m/CAA4eK1+R6hSx6t_yvwtx+NRzneVp+MRqXAdGJZChcau8Uij-8g@mail.gmail.com  
  

Doc: clarify wording about tool requirements in sourcerepo.sgml.

  
commit   : 1b2e875e5fae174913dc3955556ab4ee845fc9a6    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 10 Jul 2017 00:08:19 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 10 Jul 2017 00:08:19 -0400    

Click here for diff

  
Original wording had confusingly vague antecedent for "they", so replace  
that with a more repetitive but clearer formulation.  In passing, make the  
link to the installation requirements section more specific.  Per gripe  
from Martin Mai, though this is not the fix he initially proposed.  
  
Discussion: https://postgr.es/m/CAN_NWRu-cWuNaiXUjV3m4H-riWURuPW=j21bSaLADs6rjjzXgQ@mail.gmail.com  
  

Fix potential data corruption during freeze

  
commit   : f371cc9e9fffc79ab68185e07013d50147ed2bc9    
  
author   : Teodor Sigaev <teodor@sigaev.ru>    
date     : Thu, 6 Jul 2017 17:20:56 +0300    
  
committer: Teodor Sigaev <teodor@sigaev.ru>    
date     : Thu, 6 Jul 2017 17:20:56 +0300    

Click here for diff

  
Fix oversight in 3b97e6823b94 bug fix. Bitwise AND is used instead of OR and  
it cleans all bits in t_infomask heap tuple field.  
  
Backpatch to 9.3  
  

Treat clean shutdown of an SSL connection same as the non-SSL case.

  
commit   : 543e00bc1f06247850d85b7382dc3e3db72ae833    
  
author   : Heikki Linnakangas <heikki.linnakangas@iki.fi>    
date     : Mon, 3 Jul 2017 14:51:51 +0300    
  
committer: Heikki Linnakangas <heikki.linnakangas@iki.fi>    
date     : Mon, 3 Jul 2017 14:51:51 +0300    

Click here for diff

  
If the client closes an SSL connection, treat it the same as EOF on a  
non-SSL connection. In particular, don't write a message in the log about  
that.  
  
Michael Paquier.  
  
Discussion: https://www.postgresql.org/message-id/CAB7nPqSfyVV42Q2acFo%3DvrvF2gxoZAMJLAPq3S3KkjhZAYi7aw@mail.gmail.com  
  

Second try at fixing tcp_keepalives_idle option on Solaris.

  
commit   : cc154d9a0022102147ed85dc50766d95ee229bb1    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 28 Jun 2017 12:30:16 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 28 Jun 2017 12:30:16 -0400    

Click here for diff

  
Buildfarm evidence shows that TCP_KEEPALIVE_THRESHOLD doesn't exist  
after all on Solaris < 11.  This means we need to take positive action to  
prevent the TCP_KEEPALIVE code path from being taken on that platform.  
I've chosen to limit it with "&& defined(__darwin__)", since it's unclear  
that anyone else would follow Apple's precedent of spelling the symbol  
that way.  
  
Also, follow a suggestion from Michael Paquier of eliminating code  
duplication by defining a couple of intermediate symbols for the  
socket option.  
  
In passing, make some effort to reduce the number of translatable messages  
by replacing "setsockopt(foo) failed" with "setsockopt(%s) failed", etc,  
throughout the affected files.  And update relevant documentation so  
that it doesn't claim to provide an exhaustive list of the possible  
socket option names.  
  
Like the previous commit (f0256c774), back-patch to all supported branches.  
  
Discussion: https://postgr.es/m/20170627163757.25161.528@wrigleys.postgresql.org  
  

Support tcp_keepalives_idle option on Solaris.

  
commit   : 9ce7f39195dcd953adbf746deb09a490f7bca2b6    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Tue, 27 Jun 2017 18:47:57 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Tue, 27 Jun 2017 18:47:57 -0400    

Click here for diff

  
Turns out that the socket option for this is named TCP_KEEPALIVE_THRESHOLD,  
at least according to the tcp(7P) man page for Solaris 11.  (But since that  
text refers to "SunOS", it's likely pretty ancient.)  It appears that the  
symbol TCP_KEEPALIVE does get defined on that platform, but it doesn't  
seem to represent a valid protocol-level socket option.  This leads to  
bleats in the postmaster log, and no tcp_keepalives_idle functionality.  
  
Per bug #14720 from Andrey Lizenko, as well as an earlier report from  
Dhiraj Chawla that nobody had followed up on.  The issue's been there  
since we added the TCP_KEEPALIVE code path in commit 5acd417c8, so  
back-patch to all supported branches.  
  
Discussion: https://postgr.es/m/20170627163757.25161.528@wrigleys.postgresql.org  
  

Re-allow SRFs and window functions within sub-selects within aggregates.

  
commit   : 66dee28b40fb2c6f5875c29f2c9f9b3f8f7832ee    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Tue, 27 Jun 2017 17:51:11 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Tue, 27 Jun 2017 17:51:11 -0400    

Click here for diff

  
check_agg_arguments_walker threw an error upon seeing a SRF or window  
function, but that is too aggressive: if the function is within a  
sub-select then it's perfectly fine.  I broke the SRF case in commit  
0436f6bde by copying the logic for window functions ... but that was  
broken too, and had been since commit eaccfded9.  
  
Repair both cases in HEAD, and the window function case back to 9.3.  
9.2 gets this right.  
  

Don’t lose walreceiver start requests due to race condition in postmaster.

  
commit   : cb59949f6ec654802b8cbc9898e43c234e423bb6    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 26 Jun 2017 17:31:56 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 26 Jun 2017 17:31:56 -0400    

Click here for diff

  
When a walreceiver dies, the startup process will notice that and send  
a PMSIGNAL_START_WALRECEIVER signal to the postmaster, asking for a new  
walreceiver to be launched.  There's a race condition, which at least  
in HEAD is very easy to hit, whereby the postmaster might see that  
signal before it processes the SIGCHLD from the walreceiver process.  
In that situation, sigusr1_handler() just dropped the start request  
on the floor, reasoning that it must be redundant.  Eventually, after  
10 seconds (WALRCV_STARTUP_TIMEOUT), the startup process would make a  
fresh request --- but that's a long time if the connection could have  
been re-established almost immediately.  
  
Fix it by setting a state flag inside the postmaster that we won't  
clear until we do launch a walreceiver.  In cases where that results  
in an extra walreceiver launch, it's up to the walreceiver to realize  
it's unwanted and go away --- but we have, and need, that logic anyway  
for the opposite race case.  
  
I came across this through investigating unexpected delays in the  
src/test/recovery TAP tests: it manifests there in test cases where  
a master server is stopped and restarted while leaving streaming  
slaves active.  
  
This logic has been broken all along, so back-patch to all supported  
branches.  
  
Discussion: https://postgr.es/m/21344.1498494720@sss.pgh.pa.us  
  

Ignore old stats file timestamps when starting the stats collector.

  
commit   : 456bf261d57f828e586c07c955938ef543356ec1    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 26 Jun 2017 16:17:06 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 26 Jun 2017 16:17:06 -0400    

Click here for diff

  
The stats collector disregards inquiry messages that bear a cutoff_time  
before when it last wrote the relevant stats file.  That's fine, but at  
startup when it reads the "permanent" stats files, it absorbed their  
timestamps as if they were the times at which the corresponding temporary  
stats files had been written.  In reality, of course, there's no data  
out there at all.  This led to disregarding inquiry messages soon after  
startup if the postmaster had been shut down and restarted within less  
than PGSTAT_STAT_INTERVAL; which is a pretty common scenario, both for  
testing and in the field.  Requesting backends would hang for 10 seconds  
and then report failure to read statistics, unless they got bailed out  
by some other backend coming along and making a newer request within  
that interval.  
  
I came across this through investigating unexpected delays in the  
src/test/recovery TAP tests: it manifests there because the autovacuum  
launcher hangs for 10 seconds when it can't get statistics at startup,  
thus preventing a second shutdown from occurring promptly.  We might  
want to do some things in the autovac code to make it less prone to  
getting stuck that way, but this change is a good bug fix regardless.  
  
In passing, also fix pgstat_read_statsfiles() to ensure that it  
re-zeroes its global stats variables if they are corrupted by a  
short read from the stats file.  (Other reads in that function  
go into temp variables, so that the issue doesn't arise.)  
  
This has been broken since we created the separation between permanent  
and temporary stats files in 8.4, so back-patch to all supported branches.  
  
Discussion: https://postgr.es/m/16860.1498442626@sss.pgh.pa.us  
  

Fix typo in comment

  
commit   : 2563f079ec0217f672680d13d9d442a1ea6efc6a    
  
author   : Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Thu, 22 Jun 2017 16:42:38 -0400    
  
committer: Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Thu, 22 Jun 2017 16:42:38 -0400    

Click here for diff

  
Once upon a time, WAL pointers could be NULL, but no longer.  We talk about  
"valid" now.  
  
Reported-by: Amit Langote  
Discussion: https://postgr.es/m/33e9617d-27f1-eee8-3311-e27af98eaf2b@lab.ntt.co.jp  
  

Fix possibility of creating a “phantom” segment after promotion.

  
commit   : 511d803ca41ae571574de9a8f1084370dcbcb88c    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Wed, 21 Jun 2017 14:14:12 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Wed, 21 Jun 2017 14:14:12 -0700    

Click here for diff

  
When promoting a standby just after a XLOG_SWITCH record was replayed,  
and next segment(s) are already are locally available (via walsender,  
restore_command + trigger/recovery target), that segment could  
accidentally be recycled onto the past of the new timeline.  Later  
checkpointer would create a .ready file for it, assuming there was an  
error during creation, and it would get archived.  That causes trouble  
if another standby is later brought up from a basebackup from before  
the timeline creation, because it would try to read the  
segment, because XLogFileReadAnyTLI just tries all possible timelines,  
which doesn't have valid contents.  Thus replay would fail.  
  
The problem, if already occurred, can be fixed by removing the segment  
and/or having restore_command filter it out.  
  
The reason for the creation of such "phantom" segments was, that after  
an XLOG_SWITCH record the EndOfLog variable points to the beginning of  
the next segment, and RemoveXlogFile() used XLByteToPrevSeg().  
Normally RemoveXlogFile() doing so is harmless, because the last  
segment will still exist preventing InstallXLogFileSegment() from  
causing harm, but just after promotion there's no previous segment on  
the new timeline.  
  
Fix that by using XLByteToSeg() instead of XLByteToPrevSeg().  
  
Author: Andres Freund  
Reported-By: Greg Burek  
Discussion: https://postgr.es/m/20170619073026.zcwpe6mydsaz5ygd@alap3.anarazel.de  
Backpatch: 9.2-, bug older than all supported versions  
  

pg_upgrade: start/stop new server after pg_resetwal

  
commit   : 5c890645d9c4f57d49110e7943914c11012d3e85    
  
author   : Bruce Momjian <bruce@momjian.us>    
date     : Tue, 20 Jun 2017 13:20:02 -0400    
  
committer: Bruce Momjian <bruce@momjian.us>    
date     : Tue, 20 Jun 2017 13:20:02 -0400    

Click here for diff

  
When commit 0f33a719fdbb5d8c43839ea0d2c90cd03e2af2d2 removed the  
instructions to start/stop the new cluster before running rsync, it was  
now possible for pg_resetwal/pg_resetxlog to leave the final WAL record  
at wal_level=minimum, preventing upgraded standby servers from  
reconnecting.  
  
This patch fixes that by having pg_upgrade unconditionally start/stop  
the new cluster after pg_resetwal/pg_resetxlog has run.  
  
Backpatch through 9.2 since, though the instructions were added in PG  
9.5, they worked all the way back to 9.2.  
  
Discussion: https://postgr.es/m/20170620171844.GC24975@momjian.us  
  
Backpatch-through: 9.2  
  

Fix materialized-view documentation oversights.

  
commit   : f1e1f990887b87174b6c291f5a60d2b2f4393dce    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 19 Jun 2017 18:32:23 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 19 Jun 2017 18:32:23 -0400    

Click here for diff

  
When materialized views were added, psql's \d commands were made to  
treat them as a separate object category ... but not everyplace in the  
documentation or comments got the memo.  
  
Noted by David Johnston.  Back-patch to 9.3 where matviews came in.  
  
Discussion: https://postgr.es/m/CAKFQuwb27M3VXRhHErjCpkWwN9eKThbqWb1=trtoXi9_ejqPXQ@mail.gmail.com  
  

On Windows, make pg_dump use binary mode for compressed plain text output.

  
commit   : 2943c04f7711d4f2cf7de17434c5ed44e4b16e68    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 19 Jun 2017 11:02:45 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 19 Jun 2017 11:02:45 -0400    

Click here for diff

  
The combination of -Z -Fp and output to stdout resulted in corrupted  
output data, because we left stdout in text mode, resulting in newline  
conversion being done on the compressed stream.  Switch stdout to binary  
mode for this case, at the same place where we do it for non-text output  
formats.  
  
Report and patch by Kuntal Ghosh, tested by Ashutosh Sharma and Neha  
Sharma.  Back-patch to all supported branches.  
  
Discussion: https://postgr.es/m/CAGz5QCJPvbBjXAmJuGx1B_41yVCetAJhp7rtaDf7XQGWuB1GSw@mail.gmail.com  
  

Fix dependency, when changing a function’s argument/return type.

  
commit   : b47e2f7a94631c9dc8374339de2f668d898cd1c6    
  
author   : Heikki Linnakangas <heikki.linnakangas@iki.fi>    
date     : Thu, 15 Jun 2017 10:42:10 +0300    
  
committer: Heikki Linnakangas <heikki.linnakangas@iki.fi>    
date     : Thu, 15 Jun 2017 10:42:10 +0300    

Click here for diff

  
When a new base type is created using the old-style procedure of first  
creating the input/output functions with "opaque" in place of the base  
type, the "opaque" argument/return type is changed to the final base type,  
on CREATE TYPE. However, we did not create a pg_depend record when doing  
that, so the functions were left not depending on the type.  
  
Fixes bug #14706, reported by Karen Huddleston.  
  
Discussion: https://www.postgresql.org/message-id/20170614232259.1424.82774@wrigleys.postgresql.org  
  

Fix low-probability leaks of PGresult objects in the backend.

  
commit   : 99090e977d51107b25ba1670801975d6d1495d74    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 15 Jun 2017 15:03:39 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 15 Jun 2017 15:03:39 -0400    

Click here for diff

  
We had three occurrences of essentially the same coding pattern  
wherein we tried to retrieve a query result from a libpq connection  
without blocking.  In the case where PQconsumeInput failed (typically  
indicating a lost connection), all three loops simply gave up and  
returned, forgetting to clear any previously-collected PGresult  
object.  Since those are malloc'd not palloc'd, the oversight results  
in a process-lifespan memory leak.  
  
One instance, in libpqwalreceiver, is of little significance because  
the walreceiver process would just quit anyway if its connection fails.  
But we might as well fix it.  
  
The other two instances, in postgres_fdw, are somewhat more worrisome  
because at least in principle the scenario could be repeated, allowing  
the amount of memory leaked to build up to something worth worrying  
about.  Moreover, in these cases the loops contain CHECK_FOR_INTERRUPTS  
calls, as well as other calls that could potentially elog(ERROR),  
providing another way to exit without having cleared the PGresult.  
Here we need to add PG_TRY logic similar to what exists in quite a  
few other places in postgres_fdw.  
  
Coverity noted the libpqwalreceiver bug; I found the other two cases  
by checking all calls of PQconsumeInput.  
  
Back-patch to all supported versions as appropriate (9.2 lacks  
postgres_fdw, so this is really quite unexciting for that branch).  
  
Discussion: https://postgr.es/m/22620.1497486981@sss.pgh.pa.us  
  

doc: remove mention of Windows junction points by pg_upgrade

  
commit   : ae58c15bd3f6447cbc67256bfb0b40d342b88fec    
  
author   : Bruce Momjian <bruce@momjian.us>    
date     : Thu, 15 Jun 2017 13:25:44 -0400    
  
committer: Bruce Momjian <bruce@momjian.us>    
date     : Thu, 15 Jun 2017 13:25:44 -0400    

Click here for diff

  
pg_upgrade never used Windows junction points but instead always used  
Windows hard links.  
  
Reported-by: Adrian Klaver  
  
Discussion: https://postgr.es/m/6a638c60-90bb-4921-8ee4-5fdad68f8b09@aklaver.com  
  
Backpatch-through: 9.3, where the mention first appeared  
  

Fix document bug regarding read only transactions.

  
commit   : 5eaee9b4c4af3c3cc7f52f921e03512699dcd887    
  
author   : Tatsuo Ishii <ishii@postgresql.org>    
date     : Thu, 15 Jun 2017 10:01:39 +0900    
  
committer: Tatsuo Ishii <ishii@postgresql.org>    
date     : Thu, 15 Jun 2017 10:01:39 +0900    

Click here for diff

  
It was explained that read only transactions (not in standby) allow to  
update sequences. This had been wrong since the commit:  
05d8a561ff85db1545f5768fe8d8dc9d99ad2ef7  
  
Discussion: https://www.postgresql.org/message-id/20170614.110826.425627939780392324.t-ishii%40sraoss.co.jp  
  

postgres_fdw: Allow cancellation of transaction control commands.

  
commit   : fc267a0c3c652996cb7f49967d5bd11522a32166    
  
author   : Robert Haas <rhaas@postgresql.org>    
date     : Wed, 7 Jun 2017 15:14:55 -0400    
  
committer: Robert Haas <rhaas@postgresql.org>    
date     : Wed, 7 Jun 2017 15:14:55 -0400    

Click here for diff

  
Commit f039eaac7131ef2a4cf63a10cf98486f8bcd09d2, later back-patched  
with commit 1b812afb0eafe125b820cc3b95e7ca03821aa675, allowed many of  
the queries issued by postgres_fdw to fetch remote data to respond to  
cancel interrupts in a timely fashion.  However, it didn't do anything  
about the transaction control commands, which remained  
noninterruptible.  
  
Improve the situation by changing do_sql_command() to retrieve query  
results using pgfdw_get_result(), which uses the asynchronous  
interface to libpq so that it can check for interrupts every time  
libpq returns control.  Since this might result in a situation  
where we can no longer be sure that the remote transaction state  
matches the local transaction state, add a facility to force all  
levels of the local transaction to abort if we've lost track of  
the remote state; without this, an apparently-successful commit of  
the local transaction might fail to commit changes made on the  
remote side.  Also, add a 60-second timeout for queries issue during  
transaction abort; if that expires, give up and mark the state of  
the connection as unknown.  Drop all such connections when we exit  
the local transaction.  Together, these changes mean that if we're  
aborting the local toplevel transaction anyway, we can just drop the  
remote connection in lieu of waiting (possibly for a very long time)  
for it to complete an abort.  
  
This still leaves quite a bit of room for improvement.  PQcancel()  
has no asynchronous interface, so if we get stuck sending the cancel  
request we'll still hang.  Also, PQsetnonblocking() is not used, which  
means we could block uninterruptibly when sending a query.  There  
might be some other optimizations possible as well.  Nonetheless,  
this allows us to escape a wait for an unresponsive remote server  
quickly in many more cases than previously.  
  
Report by Suraj Kharage.  Patch by me and Rafia Sabih.  Review  
and testing by Amit Kapila and Tushar Ahuja.  
  
Discussion: http://postgr.es/m/CAF1DzPU8Kx+fMXEbFoP289xtm3bz3t+ZfxhmKavr98Bh-C0TqQ@mail.gmail.com  
  

Fix docs to not claim ECPG’s SET CONNECTION is not thread-aware.

  
commit   : 9d1758d1e694fbb399be054d081ec9a7520919bc    
  
author   : Michael Meskes <meskes@postgresql.org>    
date     : Tue, 6 Jun 2017 12:19:28 +0200    
  
committer: Michael Meskes <meskes@postgresql.org>    
date     : Tue, 6 Jun 2017 12:19:28 +0200    

Click here for diff

  
Changed by: Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>  
  

Clear auth context correctly when re-connecting after failed auth attempt.

  
commit   : f2fa0c6514b6c5b7bccfe5050f6791dea1113c2e    
  
author   : Heikki Linnakangas <heikki.linnakangas@iki.fi>    
date     : Wed, 7 Jun 2017 14:01:46 +0300    
  
committer: Heikki Linnakangas <heikki.linnakangas@iki.fi>    
date     : Wed, 7 Jun 2017 14:01:46 +0300    

Click here for diff

  
If authentication over an SSL connection fails, with sslmode=prefer,  
libpq will reconnect without SSL and retry. However, we did not clear  
the variables related to GSS, SSPI, and SASL authentication state, when  
reconnecting. Because of that, the second authentication attempt would  
always fail with a "duplicate GSS/SASL authentication request" error.  
pg_SSPI_startup did not check for duplicate authentication requests like  
the corresponding GSS and SASL functions, so with SSPI, you would leak  
some memory instead.  
  
Another way this could manifest itself, on version 10, is if you list  
multiple hostnames in the "host" parameter. If the first server requests  
Kerberos or SCRAM authentication, but it fails, the attempts to connect to  
the other servers will also fail with "duplicate authentication request"  
errors.  
  
To fix, move the clearing of authentication state from closePGconn to  
pgDropConnection, so that it is cleared also when re-connecting.  
  
Patch by Michael Paquier, with some kibitzing by me.  
  
Backpatch down to 9.3. 9.2 has the same bug, but the code around closing  
the connection is somewhat different, so that this patch doesn't apply.  
To fix this in 9.2, I think we would need to back-port commit 210eb9b743  
first, and then apply this patch. However, given that we only bumped into  
this in our own testing, we haven't heard any reports from users about  
this, and that 9.2 will be end-of-lifed in a couple of months anyway, it  
doesn't seem worth the risk and trouble.  
  
Discussion: https://www.postgresql.org/message-id/CAB7nPqRuOUm0MyJaUy9L3eXYJU3AKCZ-0-03=-aDTZJGV4GyWw@mail.gmail.com  
  

Remove leftover variable from previous commit.

  
commit   : 9d09842830ee6d1a28c86161520fe980fb7e75ab    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Mon, 5 Jun 2017 20:27:21 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Mon, 5 Jun 2017 20:27:21 -0700    

Click here for diff

  
Apparently I somehow mis-resolved a conflict slightly.  
  

Unify SIGHUP handling between normal and walsender backends.

  
commit   : 45d067d50d8ed89ef014b2a9e625e9b1f6734587    
  
author   : Andres Freund <andres@anarazel.de>    
date     : Mon, 5 Jun 2017 18:53:42 -0700    
  
committer: Andres Freund <andres@anarazel.de>    
date     : Mon, 5 Jun 2017 18:53:42 -0700    

Click here for diff

  
Because walsender and normal backends share the same main loop it's  
problematic to have two different flag variables, set in signal  
handlers, indicating a pending configuration reload.  Only certain  
walsender commands reach code paths checking for the  
variable (START_[LOGICAL_]REPLICATION, CREATE_REPLICATION_SLOT  
... LOGICAL, notably not base backups).  
  
This is a bug present since the introduction of walsender, but has  
gotten worse in releases since then which allow walsender to do more.  
  
A later patch, not slated for v10, will similarly unify SIGHUP  
handling in other types of processes as well.  
  
Author: Petr Jelinek, Andres Freund  
Reviewed-By: Michael Paquier  
Discussion: https://postgr.es/m/20170423235941.qosiuoyqprq4nu7v@alap3.anarazel.de  
Backpatch: 9.2-, bug is present since 9.0  
  

Fix thinko in previous openssl change

  
commit   : da30fa603aeb3b406931543b1ff4427bdf051ec5    
  
author   : Andrew Dunstan <andrew@dunslane.net>    
date     : Mon, 5 Jun 2017 20:38:46 -0400    
  
committer: Andrew Dunstan <andrew@dunslane.net>    
date     : Mon, 5 Jun 2017 20:38:46 -0400    

Click here for diff

  
  

Find openssl lib files in right directory for MSVC

  
commit   : fe39a086d457c044dc22706b7f505430c0768363    
  
author   : Andrew Dunstan <andrew@dunslane.net>    
date     : Mon, 5 Jun 2017 14:24:42 -0400    
  
committer: Andrew Dunstan <andrew@dunslane.net>    
date     : Mon, 5 Jun 2017 14:24:42 -0400    

Click here for diff

  
Some openssl builds put their lib files in a VC subdirectory, others do  
not. Cater for both cases.  
  
Backpatch to all live branches.  
  
From an offline discussion with Leonardo Cecchi.  
  

Always use -fPIC, not -fpic, when building shared libraries with gcc.

  
commit   : cee7238de58fca9c0a3c7f5012eb4f905f80fde6    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 1 Jun 2017 13:32:56 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Thu, 1 Jun 2017 13:32:56 -0400    

Click here for diff

  
On some platforms, -fpic fails for sufficiently large shared libraries.  
We've mostly not hit that boundary yet, but there are some extensions  
such as Citus and pglogical where it's becoming a problem.  A bit of  
research suggests that the penalty for -fPIC is small, in the  
single-digit-percentage range --- and there's none at all on popular  
platforms such as x86_64.  So let's just default to -fPIC everywhere  
and provide one less thing for extension developers to worry about.  
  
Per complaint from Christoph Berg.  Back-patch to all supported branches.  
(I did not bother to touch the recently-removed Makefiles for sco and  
unixware in the back branches, though.  We'd have no way to test that  
it doesn't break anything on those platforms.)  
  
Discussion: https://postgr.es/m/20170529155850.qojdfrwkkqnjb3ap@msg.df7cb.de  
  

Try to ensure that stats collector’s receive buffer size is at least 100KB.

  
commit   : 4a3bb96ce9e938479ccaf03402b39ea6259d5069    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 29 May 2017 20:27:45 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 29 May 2017 20:27:45 -0400    

Click here for diff

  
Back-patch of commit 8b0b6303e991079726e83d17401405e94da11564.  
  
Discussion: https://postgr.es/m/22173.1494788088@sss.pgh.pa.us  
  

Prevent running pg_resetwal/pg_resetxlog against wrong-version data dirs.

  
commit   : 78e4fb8e41df1c425fc097cb6c94d0fd75931632    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 29 May 2017 17:08:16 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 29 May 2017 17:08:16 -0400    

Click here for diff

  
pg_resetwal (formerly pg_resetxlog) doesn't insist on finding a matching  
version number in pg_control, and that seems like an important thing to  
preserve since recovering from corrupt pg_control is a prime reason to  
need to run it.  However, that means you can try to run it against a  
data directory of a different major version, which is at best useless  
and at worst disastrous.  So as to provide some protection against that  
type of pilot error, inspect PG_VERSION at startup and refuse to do  
anything if it doesn't match.  PG_VERSION is read-only after initdb,  
so it's unlikely to get corrupted, and even if it were corrupted it would  
be easy to fix by hand.  
  
This hazard has been there all along, so back-patch to all supported  
branches.  
  
Michael Paquier, with some kibitzing by me  
  
Discussion: https://postgr.es/m/f4b8eb91-b934-8a0d-b3cc-68f06e2279d1@enterprisedb.com  
  

Allow NumericOnly to be “+ FCONST”.

  
commit   : 7d9309fca51b0a50734ae9d83a668e422e46a997    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 29 May 2017 15:19:07 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Mon, 29 May 2017 15:19:07 -0400    

Click here for diff

  
The NumericOnly grammar production accepted ICONST, + ICONST, - ICONST,  
FCONST, and - FCONST, but for some reason not + FCONST.  This led to  
strange inconsistencies like  
  
regression=# set random_page_cost = +4;  
SET  
regression=# set random_page_cost = 4000000000;  
SET  
regression=# set random_page_cost = +4000000000;  
ERROR:  syntax error at or near "4000000000"  
  
(because 4000000000 is too large to be an ICONST).  While there's  
no actual functional reason to need to write a "+", if we allow  
it for integers it seems like we should allow it for numerics too.  
  
It's been like that forever, so back-patch to all supported branches.  
  
Discussion: https://postgr.es/m/30908.1496006184@sss.pgh.pa.us  
  

Move autogenerated array types out of the way during ALTER … RENAME.

  
commit   : 525780c6221b8635f9b1fcb1e9e2b455af93ac21    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 26 May 2017 15:16:59 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 26 May 2017 15:16:59 -0400    

Click here for diff

  
Commit 9aa3c782c added code to allow CREATE TABLE/CREATE TYPE to not fail  
when the desired type name conflicts with an autogenerated array type, by  
dint of renaming the array type out of the way.  But I (tgl) overlooked  
that the same case arises in ALTER TABLE/TYPE RENAME.  Fix that too.  
Back-patch to all supported branches.  
  
Report and patch by Vik Fearing, modified a bit by me  
  
Discussion: https://postgr.es/m/0f4ade49-4f0b-a9a3-c120-7589f01d1eb8@2ndquadrant.com  
  

Fix pg_dump to not emit invalid SQL for an empty operator class.

  
commit   : a561254e4c620ca9d62044520bd05cfe687f786c    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 26 May 2017 12:51:05 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Fri, 26 May 2017 12:51:05 -0400    

Click here for diff

  
If an operator class has no operators or functions, and doesn't need  
a STORAGE clause, we emitted "CREATE OPERATOR CLASS ... AS ;" which  
is syntactically invalid.  Fix by forcing a STORAGE clause to be  
emitted anyway in this case.  
  
(At some point we might consider changing the grammar to allow CREATE  
OPERATOR CLASS without an opclass_item_list.  But probably we'd want to  
omit the AS in that case, so that wouldn't fix this pg_dump issue anyway.)  
  
It's been like this all along, so back-patch to all supported branches.  
  
Daniel Gustafsson, tweaked by me to avoid a dangling-pointer bug  
  
Discussion: https://postgr.es/m/D9E5FC64-7A37-4F3D-B946-7E4FB468F88A@yesql.se  
  

Remove docs mention of PGREALM variable

  
commit   : 1218abc47e859c3f98030558e93942636e12af0d    
  
author   : Magnus Hagander <magnus@hagander.net>    
date     : Fri, 26 May 2017 10:58:15 -0400    
  
committer: Magnus Hagander <magnus@hagander.net>    
date     : Fri, 26 May 2017 10:58:15 -0400    

Click here for diff

  
This variable was only used with Kerberos v4. That support was removed  
in 2005, but we forgot to remove the documentation.  
  
Noted by Shinichi Matsuda  
  

Tighten checks for whitespace in functions that parse identifiers etc.

  
commit   : 971a158e67fd12af13595bc6baeda9ad2a189144    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 24 May 2017 15:28:35 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 24 May 2017 15:28:35 -0400    

Click here for diff

  
This patch replaces isspace() calls with scanner_isspace() in functions  
that are likely to be presented with non-ASCII input.  isspace() has  
the small advantage that it will correctly recognize no-break space  
in single-byte encodings (such as LATIN1); but it cannot work successfully  
for any multibyte character, and depending on platform it might return  
false positive results for some fragments of multibyte characters.  That's  
disastrous for functions that are trying to discard whitespace between  
valid strings, as noted in bug #14662 from Justin Muise.  Even treating  
no-break space as whitespace is pretty questionable for the usages touched  
here, because the core scanner would think it is an identifier character.  
  
Affected functions are parse_ident(), parseNameAndArgTypes (underlying  
regprocedurein() and siblings), SplitIdentifierString (used for parsing  
GUCs and options that are qualified names or lists of names), and  
SplitDirectoriesString (used for parsing GUCs that are lists of  
directories).  
  
All the functions adjusted here are parsing SQL identifiers and similar  
constructs, so it's reasonable to insist that their definition of  
whitespace match the core scanner.  So we can hope that this won't cause  
many backwards-compatibility problems.  I've left alone isspace() calls  
in places that aren't really expecting any non-ASCII input characters,  
such as float8in().  
  
Back-patch to all supported branches.  
  
Discussion: https://postgr.es/m/10129.1495302480@sss.pgh.pa.us  
  

Update URLs in pgindent source and README

  
commit   : beaa3b1252bfd983eeefc339ebf88829ad87b73c    
  
author   : Magnus Hagander <magnus@hagander.net>    
date     : Tue, 23 May 2017 14:02:24 -0400    
  
committer: Magnus Hagander <magnus@hagander.net>    
date     : Tue, 23 May 2017 14:02:24 -0400    

Click here for diff

  
Website and buildfarm is https, not http, and the ftp protocol will be  
shut down shortly.  
  

Fix precision and rounding issues in money multiplication and division.

  
commit   : b3c536bce953e7e890b0148d3cb6e90a1fd15846    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sun, 21 May 2017 13:05:17 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sun, 21 May 2017 13:05:17 -0400    

Click here for diff

  
The cash_div_intX functions applied rint() to the result of the division.  
That's not merely useless (because the result is already an integer) but  
it causes precision loss for values larger than 2^52 or so, because of  
the forced conversion to float8.  
  
On the other hand, the cash_mul_fltX functions neglected to apply rint() to  
their multiplication results, thus possibly causing off-by-one outputs.  
  
Per C standard, arithmetic between any integral value and a float value is  
performed in float format.  Thus, cash_mul_flt4 and cash_div_flt4 produced  
answers good to only about six digits, even when the float value is exact.  
We can improve matters noticeably by widening the float inputs to double.  
(It's tempting to consider using "long double" arithmetic if available,  
but that's probably too much of a stretch for a back-patched fix.)  
  
Also, document that cash_div_intX operators truncate rather than round.  
  
Per bug #14663 from Richard Pistole.  Back-patch to all supported branches.  
  
Discussion: https://postgr.es/m/22403.1495223615@sss.pgh.pa.us  
  

Change documentation references to PG website to use https: not http:

  
commit   : 038420a58b711562f8250a185706374223ab6f5d    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sat, 20 May 2017 21:50:47 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Sat, 20 May 2017 21:50:47 -0400    

Click here for diff

  
This is more secure, and saves a redirect since we no longer accept  
plain HTTP connections on the website.  
  
References in code comments should probably be updated too, but  
that doesn't seem to need back-patching, whereas this does.  
  
Also, in the 9.2 branch, remove suggestion that you can get the  
source code via FTP, since that service will be shut down soon.  
  
Daniel Gustafsson, with a few additional changes by me  
  
Discussion: https://postgr.es/m/9A2C89A7-0BB8-41A8-B288-8B7BD09D7D44@yesql.se  
  

Fix typo in comment.

  
commit   : edd8c79e697850d94af1576f14a4f2352cd1634c    
  
author   : Heikki Linnakangas <heikki.linnakangas@iki.fi>    
date     : Thu, 18 May 2017 10:33:16 +0300    
  
committer: Heikki Linnakangas <heikki.linnakangas@iki.fi>    
date     : Thu, 18 May 2017 10:33:16 +0300    

Click here for diff

  
Daniel Gustafsson  
  

Make psql handle EOF during COPY FROM STDIN properly on all platforms.

  
commit   : 6bc710f6dcceabc0c670882fc90fafdacfdf5b67    
  
author   : Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 17 May 2017 12:24:19 -0400    
  
committer: Tom Lane <tgl@sss.pgh.pa.us>    
date     : Wed, 17 May 2017 12:24:19 -0400    

Click here for diff

  
When stdin is a terminal, it's possible to end a COPY FROM STDIN with  
a keyboard EOF signal (typically control-D), and then keep on issuing  
SQL commands.  One would expect another COPY FROM STDIN to work as well,  
but on some platforms it did not.  This turns out to be because we were  
not resetting the stream's feof() flag, and BSD-ish versions of fread()  
and fgets() won't attempt to read more data if that's set.  
  
The misbehavior is observed on BSDen (including macOS), but not Linux,  
Windows, or SysV-ish Unixen, which makes this a portability bug not  
just a missing feature.  
  
Add a clearerr() call to fix the behavior, and improve the prompt that's  
issued when copying from a TTY to mention that EOF signals work.  
  
It's been like this forever, so back-patch to all supported branches.  
  
Thomas Munro  
  
Discussion: https://postgr.es/m/CAEepm=0MCGfYf=JAMiYhO6JPtv9-3ZfBo8fcGeCZ8oMzaw+Z+Q@mail.gmail.com  
  

Fix new warnings from GCC 7

  
commit   : 80a06b5acda386edcb48a98188d9bfdd7a338a4e    
  
author   : Peter Eisentraut <peter_e@gmx.net>    
date     : Tue, 11 Apr 2017 14:13:31 -0400    
  
committer: Peter Eisentraut <peter_e@gmx.net>    
date     : Tue, 11 Apr 2017 14:13:31 -0400    

Click here for diff

  
This addresses the new warning types -Wformat-truncation  
-Wformat-overflow that are part of -Wall, via -Wformat, in GCC 7.  
  

doc: update markup for release note “release date” block

  
commit   : 2c80c3710fd9bc98e06d65006bc89a8024430745    
  
author   : Bruce Momjian <bruce@momjian.us>    
date     : Fri, 12 May 2017 18:31:54 -0400    
  
committer: Bruce Momjian <bruce@momjian.us>    
date     : Fri, 12 May 2017 18:31:54 -0400    

Click here for diff

  
This has to be backpatched to all supported releases so release markup  
added to HEAD and copied to back branches matches the existing markup.  
  
Reported-by: Peter Eisentraut  
  
Discussion: 2b8a2552-fffa-f7c8-97c5-14db47a87731@2ndquadrant.com  
  
Author: initial patch and sample markup by Peter Eisentraut  
  
Backpatch-through: 9.2  
  

Add libxml2 include path for MSVC builds

  
commit   : 2c7d2114bb883b07816c2171830edd654696c856    
  
author   : Andrew Dunstan <andrew@dunslane.net>    
date     : Fri, 12 May 2017 10:17:54 -0400    
  
committer: Andrew Dunstan <andrew@dunslane.net>    
date     : Fri, 12 May 2017 10:17:54 -0400    

Click here for diff

  
On Unix this path is detected via the use of xml2-config, but that's not  
available on Windows. This means that users building with libxml2 will  
no longer need to move things around from the standard libxml2  
installation for MSVC builds.  
  
Backpatch to all live branches.  
  

psql: Add missing translation markers

  
commit   : 29442701ff719556e9a5d7a332858c82368b4c3e    
  
author   : Peter Eisentraut <peter_e@gmx.net>    
date     : Wed, 10 May 2017 10:14:49 -0400    
  
committer: Peter Eisentraut <peter_e@gmx.net>    
date     : Wed, 10 May 2017 10:14:49 -0400    

Click here for diff

  
  

Ignore PQcancel errors properly

  
commit   : 345bf97b80a0d45b1fc1a0d921d059a782f06db8    
  
author   : Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Tue, 9 May 2017 14:58:51 -0300    
  
committer: Alvaro Herrera <alvherre@alvh.no-ip.org>    
date     : Tue, 9 May 2017 14:58:51 -0300    

Click here for diff

  
Add a (void) cast to all PQcancel() calls that purposefully don't check  
the return value, to keep compilers and static checkers happy.  
  
Per Coverity.