Stamp 9.5.15.
commit : 0b09804544cb51e0d90c874f62a1d600ca9321d6
author : Tom Lane <[email protected]>
date : Mon, 5 Nov 2018 16:49:29 -0500
committer: Tom Lane <[email protected]>
date : Mon, 5 Nov 2018 16:49:29 -0500
M configure
M configure.in
M doc/bug.template
M src/include/pg_config.h.win32
M src/interfaces/libpq/libpq.rc.in
M src/port/win32ver.rc
Fix copy-paste error in errhint() introduced in 691d79a07933.
commit : a0e450e91ee9b6a79c55b5a5265147e789996549
author : Andres Freund <[email protected]>
date : Mon, 5 Nov 2018 12:02:25 -0800
committer: Andres Freund <[email protected]>
date : Mon, 5 Nov 2018 12:02:25 -0800
Reported-By: Petr Jelinek
Discussion: https://postgr.es/m/[email protected]
Backpatch: 9.4-, like the previous commit
M src/backend/replication/slot.c
Translation updates
commit : 9096bf3e7ec7355f26ccd6c579406c7fd68a0ca2
author : Peter Eisentraut <[email protected]>
date : Mon, 5 Nov 2018 15:10:54 +0100
committer: Peter Eisentraut <[email protected]>
date : Mon, 5 Nov 2018 15:10:54 +0100
Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git
Source-Git-Hash: fa2a38c6d1759866a6840952dd2fbd71b9a69955
M src/backend/po/de.po
M src/backend/po/fr.po
M src/backend/po/it.po
M src/backend/po/ru.po
M src/bin/initdb/po/fr.po
M src/bin/initdb/po/ru.po
M src/bin/pg_basebackup/po/fr.po
M src/bin/pg_basebackup/po/it.po
M src/bin/pg_basebackup/po/ru.po
M src/bin/pg_controldata/po/ru.po
M src/bin/pg_ctl/po/it.po
M src/bin/pg_dump/po/fr.po
M src/bin/pg_dump/po/it.po
M src/bin/pg_dump/po/ru.po
M src/bin/pg_resetxlog/po/ru.po
M src/bin/pg_rewind/po/fr.po
M src/bin/pg_rewind/po/it.po
M src/bin/pg_rewind/po/ru.po
M src/bin/psql/po/it.po
M src/bin/psql/po/ru.po
M src/bin/scripts/po/fr.po
M src/bin/scripts/po/it.po
M src/interfaces/ecpg/preproc/po/it.po
M src/interfaces/ecpg/preproc/po/ru.po
M src/interfaces/libpq/po/ru.po
Release notes for 11.1, 10.6, 9.6.11, 9.5.15, 9.4.20, 9.3.25.
commit : 1d00f275f1601ab6974123b8750a2487e630a185
author : Tom Lane <[email protected]>
date : Sun, 4 Nov 2018 16:57:14 -0500
committer: Tom Lane <[email protected]>
date : Sun, 4 Nov 2018 16:57:14 -0500
M doc/src/sgml/release-9.3.sgml
M doc/src/sgml/release-9.4.sgml
M doc/src/sgml/release-9.5.sgml
Make ts_locale.c's character-type functions cope with UTF-16.
commit : 6e6092989fbb27fecdbfbcd66f39e10f18aa0a69
author : Tom Lane <[email protected]>
date : Sat, 3 Nov 2018 13:56:10 -0400
committer: Tom Lane <[email protected]>
date : Sat, 3 Nov 2018 13:56:10 -0400
On Windows, in UTF8 database encoding, what char2wchar() produces is
UTF16 not UTF32, ie, characters above U+FFFF will be represented by
surrogate pairs. t_isdigit() and siblings did not account for this
and failed to provide a large enough result buffer. That in turn
led to bogus "invalid multibyte character for locale" errors, because
contrary to what you might think from char2wchar()'s documentation,
its Windows code path doesn't cope sanely with buffer overflow.
The solution for t_isdigit() and siblings is pretty clear: provide
a 3-wchar_t result buffer not 2.
char2wchar() also needs some work to provide more consistent, and more
accurately documented, buffer overrun behavior. But that's a bigger job
and it doesn't actually have any immediate payoff, so leave it for later.
Per bug #15476 from Kenji Uno, who deserves credit for identifying the
cause of the problem. Back-patch to all active branches.
Discussion: https://postgr.es/m/[email protected]
M src/backend/tsearch/ts_locale.c
Yet further rethinking of build changes for macOS Mojave.
commit : 94ea1cf731834baff3a17b266c202d482fb1d9a1
author : Tom Lane <[email protected]>
date : Fri, 2 Nov 2018 18:54:00 -0400
committer: Tom Lane <[email protected]>
date : Fri, 2 Nov 2018 18:54:00 -0400
The solution arrived at in commit e74dd00f5 presumes that the compiler
has a suitable default -isysroot setting ... but further experience
shows that in many combinations of macOS version, XCode version, Xcode
command line tools version, and phase of the moon, Apple's compiler
will *not* supply a default -isysroot value.
We could potentially go back to the approach used in commit 68fc227dd,
but I don't have a lot of faith in the reliability or life expectancy of
that either. Let's just revert to the approach already shipped in 11.0,
namely specifying an -isysroot switch globally. As a partial response to
the concerns raised by Jakob Egger, adjust the contents of Makefile.global
to look like
CPPFLAGS = -isysroot $(PG_SYSROOT) ...
PG_SYSROOT = /path/to/sysroot
This allows overriding the sysroot path at build time in a relatively
painless way.
Add documentation to installation.sgml about how to use the PG_SYSROOT
option. I also took the opportunity to document how to work around
macOS's "System Integrity Protection" feature.
As before, back-patch to all supported versions.
Discussion: https://postgr.es/m/[email protected]
M configure
M configure.in
M doc/src/sgml/installation.sgml
M src/Makefile.global.in
M src/template/darwin
docs: adjust simpler language for NULL return from ANY/ALL
commit : d403ed2acd35c326df7e20f91ce679f2c2e7ad1a
author : Bruce Momjian <[email protected]>
date : Fri, 2 Nov 2018 13:05:30 -0400
committer: Bruce Momjian <[email protected]>
date : Fri, 2 Nov 2018 13:05:30 -0400
Adjustment to commit 8610c973ddf1cbf0befc1369d2cf0d56c0efcd0a.
Reported-by: Tom Lane
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 9.3
M doc/src/sgml/func.sgml
GUC: adjust effective_cache_size docs and SQL description
commit : 75f1abfa1516e0320e56de211b778f46f3874ff5
author : Bruce Momjian <[email protected]>
date : Fri, 2 Nov 2018 09:10:59 -0400
committer: Bruce Momjian <[email protected]>
date : Fri, 2 Nov 2018 09:10:59 -0400
Clarify that effective_cache_size is both kernel buffers and shared
buffers.
Reported-by: [email protected]
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 9.3
M doc/src/sgml/config.sgml
M src/backend/utils/misc/guc.c
Fix some spelling errors in the documentation
commit : 51afe7602bfa703f93b22fb81f13e8201f0f2b56
author : Magnus Hagander <[email protected]>
date : Fri, 2 Nov 2018 13:55:57 +0100
committer: Magnus Hagander <[email protected]>
date : Fri, 2 Nov 2018 13:55:57 +0100
Author: Daniel Gustafsson <[email protected]>
M doc/src/sgml/libpq.sgml
M doc/src/sgml/lobj.sgml
doc: use simpler language for NULL return from ANY/ALL
commit : eff71cd910ad8cd1931bd78103f8d5b9fd8e634b
author : Bruce Momjian <[email protected]>
date : Fri, 2 Nov 2018 08:54:33 -0400
committer: Bruce Momjian <[email protected]>
date : Fri, 2 Nov 2018 08:54:33 -0400
Previously the combination of "does not return" and "any row" caused
ambiguity.
Reported-by: KES <[email protected]>
Discussion: https://postgr.es/m/[email protected]
Reviewed-by: David G. Johnston
Backpatch-through: 9.3
M doc/src/sgml/func.sgml
Fix error message typo introduced 691d79a07933.
commit : d554e333e548c6f8eb033c2ae9c451eb232413c2
author : Andres Freund <[email protected]>
date : Thu, 1 Nov 2018 10:43:54 -0700
committer: Andres Freund <[email protected]>
date : Thu, 1 Nov 2018 10:43:54 -0700
Reported-By: Michael Paquier
Discussion: https://postgr.es/m/[email protected]
Backpatch: 9.4-, like the previous commit
M src/backend/replication/slot.c
Disallow starting server with insufficient wal_level for existing slot.
commit : 679cb44e4b563a1af6049a482db56aa02809d80c
author : Andres Freund <[email protected]>
date : Wed, 31 Oct 2018 14:47:41 -0700
committer: Andres Freund <[email protected]>
date : Wed, 31 Oct 2018 14:47:41 -0700
Previously it was possible to create a slot, change wal_level, and
restart, even if the new wal_level was insufficient for the
slot. That's a problem for both logical and physical slots, because
the necessary WAL records are not generated.
This removes a few tests in newer versions that, somewhat
inexplicably, whether restarting with a too low wal_level worked (a
buggy behaviour!).
Reported-By: Joshua D. Drake
Author: Andres Freund
Discussion: https://postgr.es/m/[email protected]
Backpatch: 9.4-, where replication slots where introduced
M src/backend/replication/logical/logical.c
M src/backend/replication/slot.c
Fix memory leak in repeated SPGIST index scans.
commit : 156a737a6b7387805633194d8549c0fa6cc900ed
author : Tom Lane <[email protected]>
date : Wed, 31 Oct 2018 17:04:43 -0400
committer: Tom Lane <[email protected]>
date : Wed, 31 Oct 2018 17:04:43 -0400
spgendscan neglected to pfree all the memory allocated by spgbeginscan.
It's possible to get away with that in most normal queries, since the
memory is allocated in the executor's per-query context which is about
to get deleted anyway; but it causes severe memory leakage during
creation or filling of large exclusion-constraint indexes.
Also, document that amendscan is supposed to free what ambeginscan
allocates. The docs' lack of clarity on that point probably caused this
bug to begin with. (There is discussion of changing that API spec going
forward, but I don't think it'd be appropriate for the back branches.)
Per report from Bruno Wolff. It's been like this since the beginning,
so back-patch to all active branches.
In HEAD, also fix an independent leak caused by commit 2a6368343
(allocating memory during spgrescan instead of spgbeginscan, which
might be all right if it got cleaned up, but it didn't). And do a bit
of code beautification on that commit, too.
Discussion: https://postgr.es/m/[email protected]
M doc/src/sgml/indexam.sgml
M src/backend/access/spgist/spgscan.c
Sync our copy of the timezone library with IANA release tzcode2018g.
commit : 5cdb330cb2acb0dbf72236b0ff8898f4f117729b
author : Tom Lane <[email protected]>
date : Wed, 31 Oct 2018 09:47:53 -0400
committer: Tom Lane <[email protected]>
date : Wed, 31 Oct 2018 09:47:53 -0400
This patch absorbs an upstream fix to "zic" for a recently-introduced
bug that made it output data that some 32-bit clients couldn't read.
Given the current source data, the bug only manifests in zones with
leap seconds, which we don't generate, so that there's no actual
change in our installed timezone data files from this. Still, in
case somebody uses our copy of "zic" to do something else, it seems
best to apply the fix promptly.
Also, update the README's notes about converting upstream code to
our conventions.
M src/timezone/README
M src/timezone/zic.c
Update time zone data files to tzdata release 2018g.
commit : 811d8cb87a5cdfe90fc72e8c297042c4e01edd10
author : Tom Lane <[email protected]>
date : Wed, 31 Oct 2018 08:35:50 -0400
committer: Tom Lane <[email protected]>
date : Wed, 31 Oct 2018 08:35:50 -0400
DST law changes in Morocco (with, effectively, zero notice).
Historical corrections for Hawaii.
M src/timezone/data/tzdata.zi
Fix missing whitespace in pg_dump ref page
commit : ba5644d996f5a53306049e0004ecb07a9f74fb79
author : Magnus Hagander <[email protected]>
date : Mon, 29 Oct 2018 12:34:49 +0100
committer: Magnus Hagander <[email protected]>
date : Mon, 29 Oct 2018 12:34:49 +0100
Author: Daniel Gustafsson <[email protected]>
M doc/src/sgml/ref/pg_dump.sgml
Fix perl searchpath for modern perl for MSVC tools
commit : ba103dc8779f004b01e249261c799773e29a4f38
author : Andrew Dunstan <[email protected]>
date : Sun, 28 Oct 2018 12:22:32 -0400
committer: Andrew Dunstan <[email protected]>
date : Sun, 28 Oct 2018 12:22:32 -0400
Modern versions of perl no longer include the current directory in the
perl searchpath, as it's insecure. Instead of adding the current
directory, we get around the problem by adding the directory where the
script lives.
Problem noted by Victor Wagner.
Solution adapted from buildfarm client code.
Backpatch to all live versions.
M src/tools/msvc/install.pl
M src/tools/msvc/mkvcbuild.pl
M src/tools/msvc/vcregress.pl
Lower privilege level of programs calling regression_main
commit : cc02db82c0f3b17ddcc595eb5863f11fe18ad2ad
author : Andrew Dunstan <[email protected]>
date : Sat, 20 Oct 2018 09:02:36 -0400
committer: Andrew Dunstan <[email protected]>
date : Sat, 20 Oct 2018 09:02:36 -0400
On Windows this mean that the regression tests can now safely and
successfully run as Administrator, which is useful in situations like
Appveyor. Elsewhere it's a no-op.
Backpatch to 9.5 - this is harder in earlier branches and not worth the
trouble.
Discussion: https://postgr.es/m/[email protected]
M src/test/regress/pg_regress.c
Client-side fixes for delayed NOTIFY receipt.
commit : ac3be116a79855b8a61c0efccd1c26470e8dbeef
author : Tom Lane <[email protected]>
date : Fri, 19 Oct 2018 22:22:57 -0400
committer: Tom Lane <[email protected]>
date : Fri, 19 Oct 2018 22:22:57 -0400
PQnotifies() is defined to just process already-read data, not try to read
any more from the socket. (This is a debatable decision, perhaps, but I'm
hesitant to change longstanding library behavior.) The documentation has
long recommended calling PQconsumeInput() before PQnotifies() to ensure
that any already-arrived message would get absorbed and processed.
However, psql did not get that memo, which explains why it's not very
reliable about reporting notifications promptly.
Also, most (not quite all) callers called PQconsumeInput() just once before
a PQnotifies() loop. Taking this recommendation seriously implies that we
should do PQconsumeInput() before each call. This is more important now
that we have "payload" strings in notification messages than it was before;
that increases the probability of having more than one packet's worth
of notify messages. Hence, adjust code as well as documentation examples
to do it like that.
Back-patch to 9.5 to match related server fixes. In principle we could
probably go back further with these changes, but given lack of field
complaints I doubt it's worthwhile.
Discussion: https://postgr.es/m/CAOYf6ec-TmRYjKBXLLaGaB-jrd=mjG1Hzn1a1wufUAR39PQYhw@mail.gmail.com
M doc/src/sgml/libpq.sgml
M src/bin/psql/common.c
M src/interfaces/ecpg/ecpglib/execute.c
M src/interfaces/libpq/fe-exec.c
M src/test/examples/testlibpq2.c
Server-side fix for delayed NOTIFY and SIGTERM processing.
commit : f4941666afc6ed8cf29fa8e89b089b8a3443485f
author : Tom Lane <[email protected]>
date : Fri, 19 Oct 2018 21:39:22 -0400
committer: Tom Lane <[email protected]>
date : Fri, 19 Oct 2018 21:39:22 -0400
Commit 4f85fde8e introduced some code that was meant to ensure that we'd
process cancel, die, sinval catchup, and notify interrupts while waiting
for client input. But there was a flaw: it supposed that the process
latch would be set upon arrival at secure_read() if any such interrupt
was pending. In reality, we might well have cleared the process latch
at some earlier point while those flags remained set -- particularly
notifyInterruptPending, which can't be handled as long as we're within
a transaction.
To fix the NOTIFY case, also attempt to process signals (except
ProcDiePending) before trying to read.
Also, if we see that ProcDiePending is set before we read, forcibly set the
process latch to ensure that we will handle that signal promptly if no data
is available. I also made it set the process latch on the way out, in case
there is similar logic elsewhere. (It remains true that we won't service
ProcDiePending here unless we need to wait for input.)
The code for handling ProcDiePending during a write needs those changes,
too.
Also be a little more careful about when to reset whereToSendOutput,
and improve related comments.
Back-patch to 9.5 where this code was added. I'm not entirely convinced
that older branches don't have similar issues, but the complaint at hand
is just about the >= 9.5 code.
Jeff Janes and Tom Lane
Discussion: https://postgr.es/m/CAOYf6ec-TmRYjKBXLLaGaB-jrd=mjG1Hzn1a1wufUAR39PQYhw@mail.gmail.com
M src/backend/libpq/be-secure.c
M src/backend/tcop/postgres.c
Sync our copy of the timezone library with IANA release tzcode2018f.
commit : eda69c66272622fb6479fa5edf584e54b77b83aa
author : Tom Lane <[email protected]>
date : Fri, 19 Oct 2018 19:36:34 -0400
committer: Tom Lane <[email protected]>
date : Fri, 19 Oct 2018 19:36:34 -0400
About half of this is purely cosmetic changes to reduce the diff between
our code and theirs, like inserting "const" markers where they have them.
The other half is tracking actual code changes in zic.c and localtime.c.
I don't think any of these represent near-term compatibility hazards, but
it seems best to stay up to date.
I also fixed longstanding bugs in our code for producing the
known_abbrevs.txt list, which by chance hadn't been exposed before,
but which resulted in some garbage output after applying the upstream
changes in zic.c. Notably, because upstream removed their old phony
transitions at the Big Bang, it's now necessary to cope with TZif files
containing no DST transition times at all.
M src/timezone/README
M src/timezone/localtime.c
M src/timezone/pgtz.h
M src/timezone/private.h
M src/timezone/strftime.c
M src/timezone/tzfile.h
M src/timezone/zic.c
Update time zone data files to tzdata release 2018f.
commit : 56170609b7f5b1ff94ec7e5c2cf64933d1ba24d3
author : Tom Lane <[email protected]>
date : Fri, 19 Oct 2018 17:01:34 -0400
committer: Tom Lane <[email protected]>
date : Fri, 19 Oct 2018 17:01:34 -0400
DST law changes in Chile, Fiji, and Russia (Volgograd).
Historical corrections for China, Japan, Macau, and North Korea.
Note: like the previous tzdata update, this involves a depressingly
large amount of semantically-meaningless churn in tzdata.zi. That
is a consequence of upstream's data compression method assigning
unstable abbreviations to DST rulesets. I complained about that
to them last time, and this version now uses an assignment method
that pays some heed to not changing abbreviations unnecessarily.
So hopefully, that'll be better going forward.
M src/timezone/data/tzdata.zi
M src/timezone/known_abbrevs.txt
M src/timezone/tznames/America.txt
M src/timezone/tznames/Asia.txt
M src/timezone/tznames/Default
M src/timezone/tznames/Pacific.txt
Still further rethinking of build changes for macOS Mojave.
commit : 021b355cd1668c667f34b76c56fe6b3f8dbaefe3
author : Tom Lane <[email protected]>
date : Thu, 18 Oct 2018 14:55:23 -0400
committer: Tom Lane <[email protected]>
date : Thu, 18 Oct 2018 14:55:23 -0400
To avoid the sorts of problems complained of by Jakob Egger, it'd be
best if configure didn't emit any references to the sysroot path at all.
In the case of PL/Tcl, we can do that just by keeping our hands off the
TCL_INCLUDE_SPEC string altogether. In the case of PL/Perl, we need to
substitute -iwithsysroot for -I in the compile commands, which is easily
handled if we change to using a configure output variable that includes
the switch not only the directory name. Since PL/Tcl and PL/Python
already do it like that, this seems like good consistency cleanup anyway.
Hence, this replaces the advice given to Perl-related extensions in commit
5e2217131; instead of writing "-I$(perl_archlibexp)/CORE", they should
just write "$(perl_includespec)". (The old way continues to work, but not
on recent macOS.)
It's still the case that configure needs to be aware of the sysroot
path internally, but that's cleaner than what we had before.
As before, back-patch to all supported versions.
Discussion: https://postgr.es/m/[email protected]
M configure
M configure.in
M contrib/hstore_plperl/Makefile
M src/Makefile.global.in
M src/pl/plperl/GNUmakefile
M src/template/darwin
Fix minor bug in isolationtester.
commit : 7a1e7b291d0691461cff5d2ae7eff114f035f6de
author : Tom Lane <[email protected]>
date : Wed, 17 Oct 2018 15:06:38 -0400
committer: Tom Lane <[email protected]>
date : Wed, 17 Oct 2018 15:06:38 -0400
If the lock wait query failed, isolationtester would report the
PQerrorMessage from some other connection, meaning there would be
no message or an unrelated one. This seems like a pretty unlikely
occurrence, but if it did happen, this bug could make it really
difficult/confusing to figure out what happened. That seems to
justify patching all the way back.
In passing, clean up another place where the "wrong" conn was used
for an error report. That one's not actually buggy because it's
a different alias for the same connection, but it's still confusing
to the reader.
M src/test/isolation/isolationtester.c
Improve tzparse's handling of TZDEFRULES ("posixrules") zone data.
commit : fb38d9a2e1ed8c42a81c18743c4e61a57b226497
author : Tom Lane <[email protected]>
date : Wed, 17 Oct 2018 12:26:48 -0400
committer: Tom Lane <[email protected]>
date : Wed, 17 Oct 2018 12:26:48 -0400
In the IANA timezone code, tzparse() always tries to load the zone
file named by TZDEFRULES ("posixrules"). Previously, we'd hacked
that logic to skip the load in the "lastditch" code path, which we use
only to initialize the default "GMT" zone during GUC initialization.
That's critical for a couple of reasons: since we do not support leap
seconds, we *must not* allow "GMT" to have leap seconds, and since this
case runs before the GUC subsystem is fully alive, we'd really rather
not take the risk of pg_open_tzfile throwing any errors.
However, that still left the code reading TZDEFRULES on every other
call, something we'd noticed to the extent of having added code to cache
the result so it was only done once per process not a lot of times.
Andres Freund complained about the static data space used up for the
cache; but as long as the logic was like this, there was no point in
trying to get rid of that space.
We can improve matters by looking a bit more closely at what the IANA
code actually needs the TZDEFRULES data for. One thing it does is
that if "posixrules" is a leap-second-aware zone, the leap-second
behavior will be absorbed into every POSIX-style zone specification.
However, that's a behavior we'd really prefer to do without, since
for our purposes the end effect is to render every POSIX-style zone
name unsupported. Otherwise, the TZDEFRULES data is used only if
the POSIX zone name specifies DST but doesn't include a transition
date rule (e.g., "EST5EDT" rather than "EST5EDT,M3.2.0,M11.1.0").
That is a minority case for our purposes --- in particular, it
never happens when tzload() invokes tzparse() to interpret a
transition date rule string found in a tzdata zone file.
Hence, if we legislate that we're going to ignore leap-second data
from "posixrules", we can postpone the TZDEFRULES load into the path
where we actually need to substitute for a missing date rule string.
That means it will never happen at all in common scenarios, making it
reasonable to dynamically allocate the cache space when it does happen.
Even when the data is already loaded, this saves some cycles in the
common code path since we avoid a memcpy of 23KB or so. And, IMO at
least, this is a less ugly hack on the IANA logic than what we had
before, since it's not messing with the lastditch-vs-regular code paths.
Back-patch to all supported branches, not so much because this is a
critical change as that I want to keep all our copies of the IANA
timezone code in sync.
Discussion: https://postgr.es/m/[email protected]
M src/timezone/README
M src/timezone/localtime.c
Back off using -isysroot on Darwin.
commit : d0ab588cc83608d08a9f79c850100fd433dc23d8
author : Tom Lane <[email protected]>
date : Tue, 16 Oct 2018 16:27:15 -0400
committer: Tom Lane <[email protected]>
date : Tue, 16 Oct 2018 16:27:15 -0400
Rethink the solution applied in commit 5e2217131 to get PL/Tcl to
build on macOS Mojave. I feared that adding -isysroot globally might
have undesirable consequences, and sure enough Jakob Egger reported
one: it complicates building extensions with a different Xcode version
than was used for the core server. (I find that a risky proposition
in general, but apparently it works most of the time, so we shouldn't
break it if we don't have to.)
We'd already adopted the solution for PL/Perl of inserting the sysroot
path directly into the -I switches used to find Perl's headers, and we
can do the same thing for PL/Tcl by changing the -iwithsysroot switch
that Apple's tclConfig.sh reports. This restricts the risks to PL/Perl
and PL/Tcl themselves and directly-dependent extensions, which is a lot
more pleasing in general than a global -isysroot switch.
Along the way, tighten the test to see if we need to inject the sysroot
path into $perl_includedir, as I'd speculated about upthread but not
gotten round to doing.
As before, back-patch to all supported versions.
Discussion: https://postgr.es/m/[email protected]
M configure
M configure.in
M src/template/darwin
Avoid rare race condition in privileges.sql regression test.
commit : 7249d1d64127b0856d81d3774c7641712ab3a6ef
author : Tom Lane <[email protected]>
date : Tue, 16 Oct 2018 13:56:58 -0400
committer: Tom Lane <[email protected]>
date : Tue, 16 Oct 2018 13:56:58 -0400
We created a temp table, then switched to a new session, leaving
the old session to clean up its temp objects in background. If that
took long enough, the eventual attempt to drop the user that owns
the temp table could fail, as exhibited today by sidewinder.
Fix by dropping the temp table explicitly when we're done with it.
It's been like this for quite some time, so back-patch to all
supported branches.
Report: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=sidewinder&dt=2018-10-16%2014%3A45%3A00
M src/test/regress/expected/privileges.out
M src/test/regress/sql/privileges.sql
Make PostgresNode.pm's poll_query_until() more chatty about failures.
commit : 94ccffb2b5b22408f0f5395b820bcfa5c1b172d3
author : Tom Lane <[email protected]>
date : Tue, 16 Oct 2018 12:32:28 -0400
committer: Tom Lane <[email protected]>
date : Tue, 16 Oct 2018 12:32:28 -0400
Reporting only the stderr is unhelpful when the problem is that the
server output we're getting doesn't match what was expected. So we
should report the query output too; and just for good measure, let's
print the query we used and the output we expected.
Back-patch to 9.5 where poll_query_until was introduced.
Discussion: https://postgr.es/m/[email protected]
M src/bin/pg_rewind/RewindTest.pm
Improve stability of recently-added regression test case.
commit : 4f6a77e46af26eeeecfd75d50eabd090eb99f3c8
author : Tom Lane <[email protected]>
date : Tue, 16 Oct 2018 12:01:19 -0400
committer: Tom Lane <[email protected]>
date : Tue, 16 Oct 2018 12:01:19 -0400
Commit b5febc1d1 added a contrib/btree_gist test case that has been
observed to fail in the buildfarm as a result of background auto-analyze
updating stats and changing the selected plan. Forestall that by
forcibly analyzing in foreground, instead. The new plan choice is
just as good for our purposes, since we really only care that an
index-only plan does not get selected.
Back-patch to 9.5, like the previous patch.
Discussion: https://postgr.es/m/[email protected]
M contrib/btree_gist/expected/inet.out
M contrib/btree_gist/sql/inet.sql
Avoid statically allocating gmtsub()'s timezone workspace.
commit : 18c725413fad42e6edbead22751382ee45c01166
author : Tom Lane <[email protected]>
date : Tue, 16 Oct 2018 11:50:19 -0400
committer: Tom Lane <[email protected]>
date : Tue, 16 Oct 2018 11:50:19 -0400
localtime.c's "struct state" is a rather large object, ~23KB. We were
statically allocating one for gmtsub() to use to represent the GMT
timezone, even though that function is not at all heavily used and is
never reached in most backends. Let's malloc it on-demand, instead.
This does pose the question of how to handle a malloc failure, but
there's already a well-defined error report convention here, ie
set errno and return NULL.
We have but one caller of pg_gmtime in HEAD, and two in back branches,
neither of which were troubling to check for error. Make them do so.
The possible errors are sufficiently unlikely (out-of-range timestamp,
and now malloc failure) that I think elog() is adequate.
Back-patch to all supported branches to keep our copies of the IANA
timezone code in sync. This particular change is in a stanza that
already differs from upstream, so it's a wash for maintenance purposes
--- but only as long as we keep the branches the same.
Discussion: https://postgr.es/m/[email protected]
M src/backend/utils/adt/nabstime.c
M src/backend/utils/adt/timestamp.c
M src/timezone/localtime.c
Check for stack overrun in standard_ProcessUtility().
commit : 10412cef11efde3f865c8640d96d80fa262b3358
author : Tom Lane <[email protected]>
date : Mon, 15 Oct 2018 14:01:38 -0400
committer: Tom Lane <[email protected]>
date : Mon, 15 Oct 2018 14:01:38 -0400
ProcessUtility can recurse, and indeed can be driven to infinite
recursion, so it ought to have a check_stack_depth() call. This
covers the reported bug (portal trying to execute itself) and a bunch
of other cases that could perhaps arise somewhere.
Per bug #15428 from Malthe Borch. Back-patch to all supported branches.
Discussion: https://postgr.es/m/[email protected]
M src/backend/tcop/utility.c
Avoid duplicate XIDs at recovery when building initial snapshot
commit : d83dac37447cddfab8daf7fa1cbe6ec2d8887f6e
author : Michael Paquier <[email protected]>
date : Sun, 14 Oct 2018 22:23:48 +0900
committer: Michael Paquier <[email protected]>
date : Sun, 14 Oct 2018 22:23:48 +0900
On a primary, sets of XLOG_RUNNING_XACTS records are generated on a
periodic basis to allow recovery to build the initial state of
transactions for a hot standby. The set of transaction IDs is created
by scanning all the entries in ProcArray. However it happens that its
logic never counted on the fact that two-phase transactions finishing to
prepare can put ProcArray in a state where there are two entries with
the same transaction ID, one for the initial transaction which gets
cleared when prepare finishes, and a second, dummy, entry to track that
the transaction is still running after prepare finishes. This way
ensures a continuous presence of the transaction so as callers of for
example TransactionIdIsInProgress() are always able to see it as alive.
So, if a XLOG_RUNNING_XACTS takes a standby snapshot while a two-phase
transaction finishes to prepare, the record can finish with duplicated
XIDs, which is a state expected by design. If this record gets applied
on a standby to initial its recovery state, then it would simply fail,
so the odds of facing this failure are very low in practice. It would
be tempting to change the generation of XLOG_RUNNING_XACTS so as
duplicates are removed on the source, but this requires to hold on
ProcArrayLock for longer and this would impact all workloads,
particularly those using heavily two-phase transactions.
XLOG_RUNNING_XACTS is also actually used only to initialize the standby
state at recovery, so instead the solution is taken to discard
duplicates when applying the initial snapshot.
Diagnosed-by: Konstantin Knizhnik
Author: Michael Paquier
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 9.3
M src/backend/storage/ipc/procarray.c
Remove abstime, reltime, tinterval tables from old regression databases.
commit : 43cc4e49edff19e4d3b560c045bb42c5f97bcead
author : Tom Lane <[email protected]>
date : Fri, 12 Oct 2018 19:33:56 -0400
committer: Tom Lane <[email protected]>
date : Fri, 12 Oct 2018 19:33:56 -0400
In the back branches, drop these tables after the regression tests are
done with them. This fixes failures of cross-branch pg_upgrade testing
caused by these types having been removed in v12. We do lose the ability
to test dump/restore behavior with these types in the back branches, but
the actual loss of code coverage seems to be nil given that there's nothing
very special about these types.
Discussion: https://postgr.es/m/[email protected]
M src/test/regress/expected/horology.out
M src/test/regress/expected/sanity_check.out
M src/test/regress/sql/horology.sql
Back-patch addition of the ALLOCSET_FOO_SIZES macros.
commit : 1245561df4902a08a672bd451f5f2014e03c18a9
author : Tom Lane <[email protected]>
date : Fri, 12 Oct 2018 14:49:33 -0400
committer: Tom Lane <[email protected]>
date : Fri, 12 Oct 2018 14:49:33 -0400
These macros were originally added in commit ea268cdc9, and back-patched
into 9.6 before 9.6.0. However, some extensions would like to use them
in older branches, and there seems no harm in providing them. So add
them to all supported branches. Per suggestions from Christoph Berg and
Andres Freund.
Discussion: https://postgr.es/m/[email protected]
M src/include/utils/memutils.h
Fix logical decoding error when system table w/ toast is repeatedly rewritten.
commit : 0a0c25594243eb5b5d25a1e7716e0ab993b5dab9
author : Andres Freund <[email protected]>
date : Wed, 10 Oct 2018 13:53:03 -0700
committer: Andres Freund <[email protected]>
date : Wed, 10 Oct 2018 13:53:03 -0700
Repeatedly rewriting a mapped catalog table with VACUUM FULL or
CLUSTER could cause logical decoding to fail with:
ERROR, "could not map filenode \"%s\" to relation OID"
To trigger the problem the rewritten catalog had to have live tuples
with toasted columns.
The problem was triggered as during catalog table rewrites the
heap_insert() check that prevents logical decoding information to be
emitted for system catalogs, failed to treat the new heap's toast table
as a system catalog (because the new heap is not recognized as a
catalog table via RelationIsLogicallyLogged()). The relmapper, in
contrast to the normal catalog contents, does not contain historical
information. After a single rewrite of a mapped table the new relation
is known to the relmapper, but if the table is rewritten twice before
logical decoding occurs, the relfilenode cannot be mapped to a
relation anymore. Which then leads us to error out. This only
happens for toast tables, because the main table contents aren't
re-inserted with heap_insert().
The fix is simple, add a new heap_insert() flag that prevents logical
decoding information from being emitted, and accept during decoding
that there might not be tuple data for toast tables.
Unfortunately that does not fix pre-existing logical decoding
errors. Doing so would require not throwing an error when a filenode
cannot be mapped to a relation during decoding, and that seems too
likely to hide bugs. If it's crucial to fix decoding for an existing
slot, temporarily changing the ERROR in ReorderBufferCommit() to a
WARNING appears to be the best fix.
Author: Andres Freund
Discussion: https://postgr.es/m/[email protected]
Backpatch: 9.4-, where logical decoding was introduced
M contrib/test_decoding/expected/rewrite.out
M contrib/test_decoding/sql/rewrite.sql
M src/backend/access/heap/heapam.c
M src/backend/access/heap/rewriteheap.c
M src/backend/replication/logical/reorderbuffer.c
M src/include/access/heapam.h
Silence compiler warning in Assert()
commit : fd66ca083d460c2f759f99fb77b1fca7e1f3d682
author : Alvaro Herrera <[email protected]>
date : Mon, 8 Oct 2018 10:37:21 -0300
committer: Alvaro Herrera <[email protected]>
date : Mon, 8 Oct 2018 10:37:21 -0300
gcc 6.3 does not whine about this mistake I made in 39808e8868c8 but
evidently lots of other compilers do, according to Michael Paquier,
Peter Eisentraut, Arthur Zakirov, Tomas Vondra.
Discussion: too many to list
M src/backend/commands/event_trigger.c
Fix event triggers for partitioned tables
commit : a2a5159ed678f0e4a0efa7e8aabbd4c03eb36843
author : Alvaro Herrera <[email protected]>
date : Sat, 6 Oct 2018 19:17:46 -0300
committer: Alvaro Herrera <[email protected]>
date : Sat, 6 Oct 2018 19:17:46 -0300
Index DDL cascading on partitioned tables introduced a way for ALTER
TABLE to be called reentrantly. This caused an an important deficiency
in event trigger support to be exposed: on exiting the reentrant call,
the alter table state object was clobbered, causing a crash when the
outer alter table tries to finalize its processing. Fix the crash by
creating a stack of event trigger state objects. There are still ways
to cause things to misbehave (and probably other crashers) with more
elaborate tricks, but at least it now doesn't crash in the obvious
scenario.
Backpatch to 9.5, where DDL deparsing of event triggers was introduced.
Reported-by: Marco Slot
Authors: Michaël Paquier, Álvaro Herrera
Discussion: https://postgr.es/m/CANNhMLCpi+HQ7M36uPfGbJZEQLyTy7XvX=5EFkpR-b1bo0uJew@mail.gmail.com
M src/backend/catalog/index.c
M src/backend/commands/event_trigger.c
M src/backend/commands/indexcmds.c
M src/backend/commands/tablecmds.c
M src/backend/commands/view.c
M src/include/catalog/index.h
M src/include/tcop/deparse_utility.h
Propagate xactStartTimestamp and stmtStartTimestamp to parallel workers.
commit : 3c9dd963cec6d4c314bccf74256acc893108a4be
author : Tom Lane <[email protected]>
date : Sat, 6 Oct 2018 12:00:10 -0400
committer: Tom Lane <[email protected]>
date : Sat, 6 Oct 2018 12:00:10 -0400
Previously, a worker process would establish values for these based on
its own start time. In v10 and up, this can trivially be shown to cause
misbehavior of transaction_timestamp(), timestamp_in(), and related
functions which are (perhaps unwisely?) marked parallel-safe. It seems
likely that other behaviors might diverge from what happens in the parent
as well.
It's not as trivial to demonstrate problems in 9.6 or 9.5, but I'm sure
it's still possible, so back-patch to all branches containing parallel
worker infrastructure.
In HEAD only, mark now() and statement_timestamp() as parallel-safe
(other affected functions already were). While in theory we could
still squeeze that change into v11, it doesn't seem important enough
to force a last-minute catversion bump.
Konstantin Knizhnik, whacked around a bit by me
Discussion: https://postgr.es/m/[email protected]
M src/backend/access/transam/parallel.c
M src/backend/access/transam/xact.c
M src/include/access/xact.h
Allow btree comparison functions to return INT_MIN.
commit : 0dc6bf633a2857294cd0d1b9a74c7f49836d5898
author : Tom Lane <[email protected]>
date : Fri, 5 Oct 2018 16:01:30 -0400
committer: Tom Lane <[email protected]>
date : Fri, 5 Oct 2018 16:01:30 -0400
Historically we forbade datatype-specific comparison functions from
returning INT_MIN, so that it would be safe to invert the sort order
just by negating the comparison result. However, this was never
really safe for comparison functions that directly return the result
of memcmp(), strcmp(), etc, as POSIX doesn't place any such restriction
on those library functions. Buildfarm results show that at least on
recent Linux on s390x, memcmp() actually does return INT_MIN sometimes,
causing sort failures.
The agreed-on answer is to remove this restriction and fix relevant
call sites to not make such an assumption; code such as "res = -res"
should be replaced by "INVERT_COMPARE_RESULT(res)". The same is needed
in a few places that just directly negated the result of memcmp or
strcmp.
To help find places having this problem, I've also added a compile option
to nbtcompare.c that causes some of the commonly used comparators to
return INT_MIN/INT_MAX instead of their usual -1/+1. It'd likely be
a good idea to have at least one buildfarm member running with
"-DSTRESS_SORT_INT_MIN". That's far from a complete test of course,
but it should help to prevent fresh introductions of such bugs.
This is a longstanding portability hazard, so back-patch to all supported
branches.
Discussion: https://postgr.es/m/[email protected]
M contrib/ltree/ltree_op.c
M contrib/pgcrypto/imath.c
M src/backend/access/nbtree/nbtcompare.c
M src/backend/access/nbtree/nbtsearch.c
M src/backend/access/nbtree/nbtutils.c
M src/backend/executor/nodeIndexscan.c
M src/backend/executor/nodeMergeAppend.c
M src/bin/pg_rewind/filemap.c
M src/include/access/nbtree.h
M src/include/c.h
M src/include/utils/sortsupport.h
Set snprintf.c's maximum number of NL arguments to be 31.
commit : dee848810d8aed0e563686700fb73891591750c3
author : Tom Lane <[email protected]>
date : Tue, 2 Oct 2018 12:41:28 -0400
committer: Tom Lane <[email protected]>
date : Tue, 2 Oct 2018 12:41:28 -0400
Previously, we used the platform's NL_ARGMAX if any, otherwise 16.
The trouble with this is that the platform value is hugely variable,
ranging from the POSIX-minimum 9 to as much as 64K on recent FreeBSD.
Values of more than a dozen or two have no practical use and slow down
the initialization of the argtypes array. Worse, they cause snprintf.c
to consume far more stack space than was the design intention, possibly
resulting in stack-overflow crashes.
Standardize on 31, which is comfortably more than we need (it looks like
no existing translatable message has more than about 10 parameters).
I chose that, not 32, to make the array sizes powers of 2, for some
possible small gain in speed of the memset.
The lack of reported crashes suggests that the set of platforms we
use snprintf.c on (in released branches) may have no overlap with
the set where NL_ARGMAX has unreasonably large values. But that's
not entirely clear, so back-patch to all supported branches.
Per report from Mateusz Guzik (via Thomas Munro).
Discussion: https://postgr.es/m/CAEepm=3VF=PUp2f8gU8fgZB22yPE_KBS0+e1AHAtQ=09schTHg@mail.gmail.com
M src/port/snprintf.c
Fix corner-case failures in has_foo_privilege() family of functions.
commit : dad4df0fc8a13a8b68f2537d91133be07562408f
author : Tom Lane <[email protected]>
date : Tue, 2 Oct 2018 11:54:13 -0400
committer: Tom Lane <[email protected]>
date : Tue, 2 Oct 2018 11:54:13 -0400
The variants of these functions that take numeric inputs (OIDs or
column numbers) are supposed to return NULL rather than failing
on bad input; this rule reduces problems with snapshot skew when
queries apply the functions to all rows of a catalog.
has_column_privilege() had careless handling of the case where the
table OID didn't exist. You might get something like this:
select has_column_privilege(9999,'nosuchcol','select');
ERROR: column "nosuchcol" of relation "(null)" does not exist
or you might get a crash, depending on the platform's printf's response
to a null string pointer.
In addition, while applying the column-number variant to a dropped
column returned NULL as desired, applying the column-name variant
did not:
select has_column_privilege('mytable','........pg.dropped.2........','select');
ERROR: column "........pg.dropped.2........" of relation "mytable" does not exist
It seems better to make this case return NULL as well.
Also, the OID-accepting variants of has_foreign_data_wrapper_privilege,
has_server_privilege, and has_tablespace_privilege didn't follow the
principle of returning NULL for nonexistent OIDs. Superusers got TRUE,
everybody else got an error.
Per investigation of Jaime Casanova's report of a new crash in HEAD.
These behaviors have been like this for a long time, so back-patch to
all supported branches.
Patch by me; thanks to Stephen Frost for discussion and review
Discussion: https://postgr.es/m/CAJGNTeP=-6Gyqq5TN9OvYEydi7Fv1oGyYj650LGTnW44oAzYCg@mail.gmail.com
M src/backend/utils/adt/acl.c
M src/test/regress/expected/privileges.out
M src/test/regress/sql/privileges.sql
Fix documentation of pgrowlocks using "lock_type" instead of "modes"
commit : fa7039dd008adb83d6814b013c1f090b18434fae
author : Michael Paquier <[email protected]>
date : Tue, 2 Oct 2018 16:36:39 +0900
committer: Michael Paquier <[email protected]>
date : Tue, 2 Oct 2018 16:36:39 +0900
The example used in the documentation is outdated as well. This is an
oversight from 0ac5ad5, which bumped up pgrowlocks but forgot some bits
of the documentation.
Reported-by: Chris Wilson
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 9.3
M doc/src/sgml/pgrowlocks.sgml
Fix ALTER COLUMN TYPE to not open a relation without any lock.
commit : 0031e9d6ab8063f0c7fcf420270bd1e86abd7d18
author : Tom Lane <[email protected]>
date : Mon, 1 Oct 2018 11:39:14 -0400
committer: Tom Lane <[email protected]>
date : Mon, 1 Oct 2018 11:39:14 -0400
If the column being modified is referenced by a foreign key constraint
of another table, ALTER TABLE would open the other table (to re-parse
the constraint's definition) without having first obtained a lock on it.
This was evidently intentional, but that doesn't mean it's really safe.
It's especially not safe in 9.3, which pre-dates use of MVCC scans for
catalog reads, but even in current releases it doesn't seem like a good
idea.
We know we'll need AccessExclusiveLock shortly to drop the obsoleted
constraint, so just get that a little sooner to close the hole.
Per testing with a patch that complains if we open a relation without
holding any lock on it. I don't plan to back-patch that patch, but we
should close the holes it identifies in all supported branches.
Discussion: https://postgr.es/m/[email protected]
M src/backend/commands/tablecmds.c
Fix detection of the result type of strerror_r().
commit : 8b36dc588d100d1bc8007f21fd2c2a1504dbc4f7
author : Tom Lane <[email protected]>
date : Sun, 30 Sep 2018 16:24:56 -0400
committer: Tom Lane <[email protected]>
date : Sun, 30 Sep 2018 16:24:56 -0400
The method we've traditionally used, of redeclaring strerror_r() to
see if the compiler complains of inconsistent declarations, turns out
not to work reliably because some compilers only report a warning,
not an error. Amazingly, this has gone undetected for years, even
though it certainly breaks our detection of whether strerror_r
succeeded.
Let's instead test whether the compiler will take the result of
strerror_r() as a switch() argument. It's possible this won't
work universally either, but it's the best idea I could come up with
on the spur of the moment.
Back-patch of commit 751f532b9. Buildfarm results indicate that only
icc-on-Linux actually has an issue here; perhaps the lack of field
reports indicates that people don't build PG for production that way.
Discussion: https://postgr.es/m/[email protected]
M config/c-library.m4
M configure
M src/include/pg_config.h.in
M src/include/pg_config.h.win32
Fix assertion failure when updating full_page_writes for checkpointer.
commit : 85cc9c4e2da88d7a1d160e091ec41f3fed7d271b
author : Amit Kapila <[email protected]>
date : Fri, 28 Sep 2018 16:54:40 +0530
committer: Amit Kapila <[email protected]>
date : Fri, 28 Sep 2018 16:54:40 +0530
When the checkpointer receives a SIGHUP signal to update its configuration,
it may need to update the shared memory for full_page_writes and need to
write a WAL record for it. Now, it is quite possible that the XLOG
machinery has not been initialized by that time and it will lead to
assertion failure while doing that. Fix is to allow the initialization of
the XLOG machinery outside critical section.
This bug has been introduced by the commit 2c03216d83 which added the XLOG
machinery initialization in RecoveryInProgress code path.
Reported-by: Dilip Kumar
Author: Dilip Kumar
Reviewed-by: Michael Paquier and Amit Kapila
Backpatch-through: 9.5
Discussion: https://postgr.es/m/CAFiTN-u4BA8KXcQUWDPNgaKAjDXC=C2whnzBM8TAcv=stckYUw@mail.gmail.com
M src/backend/access/transam/xlog.c
Fix WAL recycling on standbys depending on archive_mode
commit : ed9d6d621a0933388aba3d3b150882b2ef6b8d01
author : Michael Paquier <[email protected]>
date : Fri, 28 Sep 2018 11:56:11 +0900
committer: Michael Paquier <[email protected]>
date : Fri, 28 Sep 2018 11:56:11 +0900
A restart point or a checkpoint recycling WAL segments treats segments
marked with neither ".done" (archiving is done) or ".ready" (segment is
ready to be archived) in archive_status the same way for archive_mode
being "on" or "always". While for a primary this is fine, a standby
running a restart point with archive_mode = on would try to mark such a
segment as ready for archiving, which is something that will never
happen except after the standby is promoted.
Note that this problem applies only to WAL segments coming from the
local pg_wal the first time archive recovery is run. Segments part of a
self-contained base backup are the most common case where this could
happen, however even in this case normally the .done markers would be
most likely part of the backup. Segments recovered from an archive are
marked as .ready or .done by the startup process, and segments finished
streaming are marked as such by the WAL receiver, so they are handled
already.
Reported-by: Haruka Takatsuka
Author: Michael Paquier
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 9.5, where archive_mode = always has been added.
M src/backend/access/transam/xlogarchive.c
Recurse to sequences on ownership change for all relkinds
commit : 992f8542a370d6885fc19e79e0fc46a1ebf902cb
author : Peter Eisentraut <[email protected]>
date : Thu, 14 Jun 2018 23:22:14 -0400
committer: Peter Eisentraut <[email protected]>
date : Thu, 14 Jun 2018 23:22:14 -0400
When a table ownership is changed, we must apply that also to any owned
sequences. (Otherwise, it would result in a situation that cannot be
restored, because linked sequences must have the same owner as the
table.) But this was previously only applied to regular tables and
materialized views. But it should also apply to at least foreign
tables. This patch removes the relkind check altogether, because it
doesn't save very much and just introduces the possibility of similar
omissions.
Bug: #15238
Reported-by: Christoph Berg <[email protected]>
M src/backend/commands/tablecmds.c
Rework activation of commit timestamps during recovery
commit : 69a5686368c9c5609fdb274714b39f7ded1b0b46
author : Michael Paquier <[email protected]>
date : Wed, 26 Sep 2018 10:30:38 +0900
committer: Michael Paquier <[email protected]>
date : Wed, 26 Sep 2018 10:30:38 +0900
The activation and deactivation of commit timestamp tracking has not
been handled consistently for a primary or standbys at recovery. The
facility can be activated at three different moments of recovery:
- The beginning, where a primary would use the GUC value for the
decision-making, and where a standby relies on the contents of the
control file.
- When replaying a XLOG_PARAMETER_CHANGE record at redo.
- The end, where both primary and standby rely on the GUC value.
Using the GUC value for a primary at the beginning of recovery causes
problems with commit timestamp access when doing crash recovery.
Particularly, when replaying transaction commits, it could be possible
that an attempt to read commit timestamps is done for a transaction
which committed at a moment when track_commit_timestamp was disabled.
A test case is added to reproduce the failure. The test works down to
v11 as it takes advantage of transaction commits within procedures.
Reported-by: Hailong Li
Author: Masahiko Sawasa, Michael Paquier
Reviewed-by: Kyotaro Horiguchi
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 9.5, where commit timestamps have been introduced.
M src/backend/access/transam/commit_ts.c
M src/backend/access/transam/xlog.c
Make some fixes to allow building Postgres on macOS 10.14 ("Mojave").
commit : 6dc28d291548a132d0dede79c30879ae9c6565e1
author : Tom Lane <[email protected]>
date : Tue, 25 Sep 2018 13:23:29 -0400
committer: Tom Lane <[email protected]>
date : Tue, 25 Sep 2018 13:23:29 -0400
Apple's latest rearrangements of the system-supplied headers have broken
building of PL/Perl and PL/Tcl. The only practical way to fix PL/Tcl is to
start using the "-isysroot" compiler flag to point to SDK-supplied headers,
as Apple expects. We must also start distinguishing where to find Perl's
headers from where to find its shared library; but that seems like good
cleanup anyway.
Extensions that formerly did something like -I$(perl_archlibexp)/CORE
should now do -I$(perl_includedir)/CORE instead. perl_archlibexp
is still the place to look for libperl.so, though.
If for some reason you don't like the default -isysroot setting, you can
override that by setting PG_SYSROOT in configure's arguments. I don't
currently think people would need to do so, unless maybe for cross-version
build purposes.
In addition, teach configure where to find tclConfig.sh. Our traditional
method of searching $auto_path hasn't worked for the last couple of macOS
releases, and it now seems clear that Apple's not going to change that.
The workaround of manually specifying --with-tclconfig was annoying
already, but Mojave's made it a lot more so because the sysroot path now
has to be included as well. Let's just wire the knowledge into configure
instead. To avoid breaking builds against non-default Tcl installations
(e.g. MacPorts) wherein the $auto_path method probably still works,
arrange to try the additional case only after all else has failed.
Back-patch to all supported versions, since at least the buildfarm
cares about that. The changes are set up to not do anything on macOS
releases that are old enough to not have functional sysroot trees.
M config/tcl.m4
M configure
M configure.in
M contrib/hstore_plperl/Makefile
M src/Makefile.global.in
M src/pl/plperl/GNUmakefile
M src/template/darwin
Fix over-allocation of space for array_out()'s result string.
commit : 6ed095edb77651108222c881574f35e3be8980e2
author : Tom Lane <[email protected]>
date : Mon, 24 Sep 2018 11:30:51 -0400
committer: Tom Lane <[email protected]>
date : Mon, 24 Sep 2018 11:30:51 -0400
array_out overestimated the space needed for its output, possibly by
a very substantial amount if the array is multi-dimensional, because
of wrong order of operations in the loop that counts the number of
curly-brace pairs needed. While the output string is normally
short-lived, this could still cause problems in extreme cases.
An additional minor error was that it counted one more delimiter than
is actually needed.
Repair those errors, add an Assert that the space is now correctly
calculated, and make some minor improvements in the comments.
I also failed to resist the temptation to get rid of an integer
modulus operation per array element; a simple comparison is sufficient.
This bug dates clear back to Berkeley days, so back-patch to all
supported versions.
Keiichi Hirobe, minor additional work by me
Discussion: https://postgr.es/m/CAH=EFxE9W0tRvQkixR2XJRRCToUYUEDkJZk6tnADXugPBRdcdg@mail.gmail.com
M src/backend/utils/adt/arrayfuncs.c
Initialize random() in bootstrap/stand-alone postgres and in initdb.
commit : d68d5adfdcaee2fac5dc47c90373a8813278ca92
author : Noah Misch <[email protected]>
date : Sun, 23 Sep 2018 22:56:39 -0700
committer: Noah Misch <[email protected]>
date : Sun, 23 Sep 2018 22:56:39 -0700
This removes a difference between the standard IsUnderPostmaster
execution environment and that of --boot and --single. In a stand-alone
backend, "SELECT random()" always started at the same seed.
On a system capable of using posix shared memory, initdb could still
conclude "selecting dynamic shared memory implementation ... sysv".
Crashed --boot or --single postgres processes orphaned shared memory
objects having names that collided with the not-actually-random names
that initdb probed. The sysv fallback appeared after ten crashes of
--boot or --single postgres. Since --boot and --single are rare in
production use, systems used for PostgreSQL development are the
principal candidate to notice this symptom.
Back-patch to 9.3 (all supported versions). PostgreSQL 9.4 introduced
dynamic shared memory, but 9.3 does share the "SELECT random()" problem.
Reviewed by Tom Lane and Kyotaro HORIGUCHI.
Discussion: https://postgr.es/m/[email protected]
M src/backend/utils/init/miscinit.c
M src/bin/initdb/initdb.c
Fix failure in WHERE CURRENT OF after rewinding the referenced cursor.
commit : c8a978bf4c7591a0eafeb19c11f9fc3c0246be18
author : Tom Lane <[email protected]>
date : Sun, 23 Sep 2018 16:05:45 -0400
committer: Tom Lane <[email protected]>
date : Sun, 23 Sep 2018 16:05:45 -0400
In a case where we have multiple relation-scan nodes in a cursor plan,
such as a scan of an inheritance tree, it's possible to fetch from a
given scan node, then rewind the cursor and fetch some row from an
earlier scan node. In such a case, execCurrent.c mistakenly thought
that the later scan node was still active, because ExecReScan hadn't
done anything to make it look not-active. We'd get some sort of
failure in the case of a SeqScan node, because the node's scan tuple
slot would be pointing at a HeapTuple whose t_self gets reset to
invalid by heapam.c. But it seems possible that for other relation
scan node types we'd actually return a valid tuple TID to the caller,
resulting in updating or deleting a tuple that shouldn't have been
considered current. To fix, forcibly clear the ScanTupleSlot in
ExecScanReScan.
Another issue here, which seems only latent at the moment but could
easily become a live bug in future, is that rewinding a cursor does
not necessarily lead to *immediately* applying ExecReScan to every
scan-level node in the plan tree. Upper-level nodes will think that
they can postpone that call if their child node is already marked
with chgParam flags. I don't see a way for that to happen today in
a plan tree that's simple enough for execCurrent.c's search_plan_tree
to understand, but that's one heck of a fragile assumption. So, add
some logic in search_plan_tree to detect chgParam flags being set on
nodes that it descended to/through, and assume that that means we
should consider lower scan nodes to be logically reset even if their
ReScan call hasn't actually happened yet.
Per bug #15395 from Matvey Arye. This has been broken for a long time,
so back-patch to all supported branches.
Discussion: https://postgr.es/m/[email protected]
M src/backend/executor/execCurrent.c
M src/backend/executor/execScan.c
M src/test/regress/expected/portals.out
M src/test/regress/sql/portals.sql
docs: remove use of escape strings and use bytea hex output
commit : ed6755bae23b4958ce706d8b027eb8284be8e2d3
author : Bruce Momjian <[email protected]>
date : Fri, 21 Sep 2018 19:55:06 -0400
committer: Bruce Momjian <[email protected]>
date : Fri, 21 Sep 2018 19:55:06 -0400
standard_conforming_strings defaulted to 'on' in PG 9.1.
bytea_output defaulted to 'hex' in PG 9.0.
Reported-by: André Hänsel
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 9.3
M doc/src/sgml/array.sgml
M doc/src/sgml/datatype.sgml
M doc/src/sgml/func.sgml
M doc/src/sgml/lobj.sgml
M doc/src/sgml/rowtypes.sgml
Error out for clang on x86-32 without SSE2 support, no -fexcess-precision.
commit : dbbc98a9ef67b350caf1bf02ad549f238853faed
author : Andres Freund <[email protected]>
date : Thu, 20 Sep 2018 18:11:04 -0700
committer: Andres Freund <[email protected]>
date : Thu, 20 Sep 2018 18:11:04 -0700
As clang currently doesn't support -fexcess-precision=standard,
compiling x86-32 code with SSE2 disabled, can lead to problems with
floating point overflow checks and the like.
This issue was noticed because clang, on at least some BSDs, defaults
to i386 compatibility, whereas it defaults to pentium4 on Linux. Our
forced usage of __builtin_isinf() lead to some overflow checks not
triggering when compiling for i386, e.g. when the result of the
calculation didn't overflow in 80bit registers, but did so in 64bit.
While we could just fall back to a non-builtin isinf, it seems likely
that the use of 80bit registers leads to other problems (which is why
we force the flag for GCC already). Therefore error out when
detecting clang in that situation.
Reported-By: Victor Wagner
Analyzed-By: Andrew Gierth and Andres Freund
Author: Andres Freund
Discussion: https://postgr.es/m/[email protected]
Backpatch: 9.3-, all supported versions are affected
M configure
M configure.in
Allow DSM allocation to be interrupted.
commit : fb389498be5c2cb4c694dfe347f6736fda0960aa
author : Thomas Munro <[email protected]>
date : Tue, 18 Sep 2018 22:56:36 +1200
committer: Thomas Munro <[email protected]>
date : Tue, 18 Sep 2018 22:56:36 +1200
Chris Travers reported that the startup process can repeatedly try to
cancel a backend that is in a posix_fallocate()/EINTR loop and cause it
to loop forever. Teach the retry loop to give up if an interrupt is
pending. Don't actually check for interrupts in that loop though,
because a non-local exit would skip some clean-up code in the caller.
Back-patch to 9.4 where DSM was added (and posix_fallocate() was later
back-patched).
Author: Chris Travers
Reviewed-by: Ildar Musin, Murat Kabilov, Oleksii Kliukin
Tested-by: Oleksii Kliukin
Discussion: https://postgr.es/m/CAN-RpxB-oeZve_J3SM_6%3DHXPmvEG%3DHX%2B9V9pi8g2YR7YW0rBBg%40mail.gmail.com
M src/backend/storage/ipc/dsm_impl.c
Fix failure with initplans used conditionally during EvalPlanQual rechecks.
commit : 9b14bbd52c8caf5ac92b0e8088684fc72f070c33
author : Tom Lane <[email protected]>
date : Sat, 15 Sep 2018 13:42:34 -0400
committer: Tom Lane <[email protected]>
date : Sat, 15 Sep 2018 13:42:34 -0400
The EvalPlanQual machinery assumes that any initplans (that is,
uncorrelated sub-selects) used during an EPQ recheck would have already
been evaluated during the main query; this is implicit in the fact that
execPlan pointers are not copied into the EPQ estate's es_param_exec_vals.
But it's possible for that assumption to fail, if the initplan is only
reached conditionally. For example, a sub-select inside a CASE expression
could be reached during a recheck when it had not been previously, if the
CASE test depends on a column that was just updated.
This bug is old, appearing to date back to my rewrite of EvalPlanQual in
commit 9f2ee8f28, but was not detected until Kyle Samson reported a case.
To fix, force all not-yet-evaluated initplans used within the EPQ plan
subtree to be evaluated at the start of the recheck, before entering the
EPQ environment. This could be inefficient, if such an initplan is
expensive and goes unused again during the recheck --- but that's piling
one layer of improbability atop another. It doesn't seem worth adding
more complexity to prevent that, at least not in the back branches.
It was convenient to use the new-in-v11 ExecEvalParamExecParams function
to implement this, but I didn't like either its name or the specifics of
its API, so revise that.
Back-patch all the way. Rather than rewrite the patch to avoid depending
on bms_next_member() in the oldest branches, I chose to back-patch that
function into 9.4 and 9.3. (This isn't the first time back-patches have
needed that, and it exhausted my patience.) I also chose to back-patch
some test cases added by commits 71404af2a and 342a1ffa2 into 9.4 and 9.3,
so that the 9.x versions of eval-plan-qual.spec are all the same.
Andrew Gierth diagnosed the problem and contributed the added test cases,
though the actual code changes are by me.
Discussion: https://postgr.es/m/[email protected]
M src/backend/executor/execMain.c
M src/backend/executor/nodeSubplan.c
M src/include/executor/nodeSubplan.h
M src/test/isolation/expected/eval-plan-qual.out
M src/test/isolation/specs/eval-plan-qual.spec
Attach FPI to the first record after full_page_writes is turned on.
commit : 47a589c1fe35176b38ffcdb2a95b4fa2ef45add2
author : Amit Kapila <[email protected]>
date : Thu, 13 Sep 2018 16:10:59 +0530
committer: Amit Kapila <[email protected]>
date : Thu, 13 Sep 2018 16:10:59 +0530
XLogInsert fails to attach a required FPI to the first record after
full_page_writes is turned on by the last checkpoint. This bug got
introduced in 9.5 due to code rearrangement in commits 2c03216d83 and
2076db2aea. Fix it by ensuring that XLogInsertRecord performs a
recomputation when the given record is generated with FPW as off but
found that the flag has been turned on while actually inserting the
record.
Reported-by: Kyotaro Horiguchi
Author: Kyotaro Horiguchi
Reviewed-by: Amit Kapila
Backpatch-through: 9.5 where this problem was introduced
Discussion: https://postgr.es/m/[email protected]
M src/backend/access/transam/xlog.c
doc: Update broken links
commit : 93a508efb2456517af6d8756ddff4a427aee4a0c
author : Peter Eisentraut <[email protected]>
date : Tue, 14 Aug 2018 22:54:52 +0200
committer: Peter Eisentraut <[email protected]>
date : Tue, 14 Aug 2018 22:54:52 +0200
Discussion: https://www.postgresql.org/message-id/flat/153044458767.13254.16049977382403131287%40wrigleys.postgresql.org
M doc/src/sgml/libpq.sgml
M doc/src/sgml/pgcrypto.sgml
M doc/src/sgml/runtime.sgml
Repair bug in regexp split performance improvements.
commit : 77c2663de779f702dbe3fe6e05213c2eca14fcf5
author : Andrew Gierth <[email protected]>
date : Wed, 12 Sep 2018 19:31:06 +0100
committer: Andrew Gierth <[email protected]>
date : Wed, 12 Sep 2018 19:31:06 +0100
Commit c8ea87e4b introduced a temporary conversion buffer for
substrings extracted during regexp splits. Unfortunately the code that
sized it was failing to ignore the effects of ignored degenerate
regexp matches, so for regexp_split_* calls it could under-size the
buffer in such cases.
Fix, and add some regression test cases (though those will only catch
the bug if run in a multibyte encoding).
Backpatch to 9.3 as the faulty code was.
Thanks to the PostGIS project, Regina Obe and Paul Ramsey for the
report (via IRC) and assistance in analysis. Patch by me.
M src/backend/utils/adt/regexp.c
M src/test/regress/expected/strings.out
M src/test/regress/sql/strings.sql
Support building with Visual Studio 2017
commit : f6c268c4894bba9d1bbc5338407febaaad0dbd04
author : Andrew Dunstan <[email protected]>
date : Mon, 25 Sep 2017 08:03:05 -0400
committer: Andrew Dunstan <[email protected]>
date : Mon, 25 Sep 2017 08:03:05 -0400
Haribabu Kommi, reviewed by Takeshi Ideriha and Christian Ullrich
Backpatch to 9.6
M doc/src/sgml/install-windows.sgml
M src/tools/msvc/MSBuildProject.pm
M src/tools/msvc/README
M src/tools/msvc/Solution.pm
M src/tools/msvc/VSObjectFactory.pm
Fix past pd_upper write in ginRedoRecompress()
commit : e950c6c9db0ee54c7693bfaf73ea766021b404e3
author : Alexander Korotkov <[email protected]>
date : Sun, 9 Sep 2018 21:19:29 +0300
committer: Alexander Korotkov <[email protected]>
date : Sun, 9 Sep 2018 21:19:29 +0300
ginRedoRecompress() replays actions over compressed segments of posting list
in-place. However, it might lead to write past pg_upper, because intermediate
state during playing the changes can take more space than both original state
and final state. This commit fixes that by refuse from in-place modification.
Instead page tail is copied once modification is started, and then it's used
as the source of original segments. Backpatch to 9.4 where posting list
compression was introduced.
Reported-by: Sivasubramanian Ramasubramanian
Discussion: https://postgr.es/m/1536091151804.6588%40amazon.com
Author: Alexander Korotkov based on patch from and ideas by Sivasubramanian Ramasubramanian
Review: Sivasubramanian Ramasubramanian
Backpatch-through: 9.4
M src/backend/access/gin/ginxlog.c
Save/restore SPI's global variables in SPI_connect() and SPI_finish().
commit : 0254aa83b57abb4e971f6b225cc4678c782fdf51
author : Tom Lane <[email protected]>
date : Fri, 7 Sep 2018 20:09:57 -0400
committer: Tom Lane <[email protected]>
date : Fri, 7 Sep 2018 20:09:57 -0400
This patch removes two sources of interference between nominally
independent functions when one SPI-using function calls another,
perhaps without knowing that it does so.
Chapman Flack pointed out that xml.c's query_to_xml_internal() expects
SPI_tuptable and SPI_processed to stay valid across datatype output
function calls; but it's possible that such a call could involve
re-entrant use of SPI. It seems likely that there are similar hazards
elsewhere, if not in the core code then in third-party SPI users.
Previously SPI_finish() reset SPI's API globals to zeroes/nulls, which
would typically make for a crash in such a situation. Restoring them
to the values they had at SPI_connect() seems like a considerably more
useful behavior, and it still meets the design goal of not leaving any
dangling pointers to tuple tables of the function being exited.
Also, cause SPI_connect() to reset these variables to zeroes/nulls after
saving them. This prevents interference in the opposite direction: it's
possible that a SPI-using function that's only ever been tested standalone
contains assumptions that these variables start out as zeroes. That was
the case as long as you were the outermost SPI user, but not so much for
an inner user. Now it's consistent.
Report and fix suggestion by Chapman Flack, actual patch by me.
Back-patch to all supported branches.
Discussion: https://postgr.es/m/[email protected]
M src/backend/executor/spi.c
M src/include/executor/spi_priv.h
Limit depth of forced recursion for CLOBBER_CACHE_RECURSIVELY.
commit : cc4e99546ede50f1074e9c9459361b3166ca4d0a
author : Tom Lane <[email protected]>
date : Fri, 7 Sep 2018 18:13:29 -0400
committer: Tom Lane <[email protected]>
date : Fri, 7 Sep 2018 18:13:29 -0400
It's somewhat surprising that we got away with this before. (Actually,
since nobody tests this routinely AFAIK, it might've been broken for
awhile. But it's definitely broken in the wake of commit f868a8143.)
It seems sufficient to limit the forced recursion to a small number
of levels.
Back-patch to all supported branches, like the preceding patch.
Discussion: https://postgr.es/m/[email protected]
M src/backend/utils/cache/inval.c
Fix longstanding recursion hazard in sinval message processing.
commit : 66321ae61baf66da6fef1e4dc47e527b458dca34
author : Tom Lane <[email protected]>
date : Fri, 7 Sep 2018 18:04:38 -0400
committer: Tom Lane <[email protected]>
date : Fri, 7 Sep 2018 18:04:38 -0400
LockRelationOid and sibling routines supposed that, if our session already
holds the lock they were asked to acquire, they could skip calling
AcceptInvalidationMessages on the grounds that we must have already read
any remote sinval messages issued against the relation being locked.
This is normally true, but there's a critical special case where it's not:
processing inside AcceptInvalidationMessages might attempt to access system
relations, resulting in a recursive call to acquire a relation lock.
Hence, if the outer call had acquired that same system catalog lock, we'd
fall through, despite the possibility that there's an as-yet-unread sinval
message for that system catalog. This could, for example, result in
failure to access a system catalog or index that had just been processed
by VACUUM FULL. This is the explanation for buildfarm failures we've been
seeing intermittently for the past three months. The bug is far older
than that, but commits a54e1f158 et al added a new recursion case within
AcceptInvalidationMessages that is apparently easier to hit than any
previous case.
To fix this, we must not skip calling AcceptInvalidationMessages until
we have *finished* a call to it since acquiring a relation lock, not
merely acquired the lock. (There's already adequate logic inside
AcceptInvalidationMessages to deal with being called recursively.)
Fortunately, we can implement that at trivial cost, by adding a flag
to LOCALLOCK hashtable entries that tracks whether we know we have
completed such a call.
There is an API hazard added by this patch for external callers of
LockAcquire: if anything is testing for LOCKACQUIRE_ALREADY_HELD,
it might be fooled by the new return code LOCKACQUIRE_ALREADY_CLEAR
into thinking the lock wasn't already held. This should be a fail-soft
condition, though, unless something very bizarre is being done in
response to the test.
Also, I added an additional output argument to LockAcquireExtended,
assuming that that probably isn't called by any outside code given
the very limited usefulness of its additional functionality.
Back-patch to all supported branches.
Discussion: https://postgr.es/m/[email protected]
M src/backend/storage/ipc/standby.c
M src/backend/storage/lmgr/lmgr.c
M src/backend/storage/lmgr/lock.c
M src/include/storage/lock.h
Make contrib/unaccent's unaccent() function work when not in search path.
commit : c79b39fb1c5bbb5a8e2f86a2187b31b2c3b3ae96
author : Tom Lane <[email protected]>
date : Thu, 6 Sep 2018 10:49:45 -0400
committer: Tom Lane <[email protected]>
date : Thu, 6 Sep 2018 10:49:45 -0400
Since the fixes for CVE-2018-1058, we've advised people to schema-qualify
function references in order to fix failures in code that executes under
a minimal search_path setting. However, that's insufficient to make the
single-argument form of unaccent() work, because it looks up the "unaccent"
text search dictionary using the search path.
The most expedient answer seems to be to remove the search_path dependency
by making it look in the same schema that the unaccent() function itself
is declared in. This will definitely work for the normal usage of this
function with the unaccent dictionary provided by the extension.
It's barely possible that there are people who were relying on the
search-path-dependent behavior to select other dictionaries with the same
name; but if there are any such people at all, they can still get that
behavior by writing unaccent('unaccent', ...), or possibly
unaccent('unaccent'::text::regdictionary, ...) if the lookup has to be
postponed to runtime.
Per complaint from Gunnlaugur Thor Briem. Back-patch to all supported
branches.
Discussion: https://postgr.es/m/CAPs+M8LCex6d=DeneofdsoJVijaG59m9V0ggbb3pOH7hZO4+cQ@mail.gmail.com
M contrib/unaccent/unaccent.c
M doc/src/sgml/unaccent.sgml
Make argument names of pg_get_object_address consistent, and fix docs.
commit : ccd9a4dbc8806806e82e764e91263383741a782a
author : Tom Lane <[email protected]>
date : Wed, 5 Sep 2018 13:47:16 -0400
committer: Tom Lane <[email protected]>
date : Wed, 5 Sep 2018 13:47:16 -0400
pg_get_object_address and pg_identify_object_as_address are supposed
to be inverses, but they disagreed as to the names of the arguments
representing the textual form of an object address. Moreover, the
documented argument names didn't agree with reality at all, either
for these functions or pg_identify_object.
In HEAD and v11, I think we can get away with renaming the input
arguments of pg_get_object_address to match the outputs of
pg_identify_object_as_address. In theory that might break queries
using named-argument notation to call pg_get_object_address, but
it seems really unlikely that anybody is doing that, or that they'd
have much trouble adjusting if they were. In older branches, we'll
just live with the lack of consistency.
Aside from fixing the documentation of these functions to match reality,
I couldn't resist the temptation to do some copy-editing.
Per complaint from Jean-Pierre Pelletier. Back-patch to 9.5 where these
functions were introduced. (Before v11, this is a documentation change
only.)
Discussion: https://postgr.es/m/CANGqjDnWH8wsTY_GzDUxbt4i=y-85SJreZin4Hm8uOqv1vzRQA@mail.gmail.com
M doc/src/sgml/func.sgml
docs: improve AT TIME ZONE description
commit : 4693ea6220b82fd1f9b2199486d726db1986bbc3
author : Bruce Momjian <[email protected]>
date : Tue, 4 Sep 2018 22:34:07 -0400
committer: Bruce Momjian <[email protected]>
date : Tue, 4 Sep 2018 22:34:07 -0400
The previous description was unclear. Also add a third example, change
use of time zone acronyms to more verbose descriptions, and add a
mention that using 'time' with AT TIME ZONE uses the current time zone
rules.
Backpatch-through: 9.3
M doc/src/sgml/func.sgml
Fix initial sync of slot parent directory when restoring status
commit : 02b1b01d8ed4fad10ad4560604dc45b06968f64a
author : Michael Paquier <[email protected]>
date : Sun, 2 Sep 2018 12:40:58 -0700
committer: Michael Paquier <[email protected]>
date : Sun, 2 Sep 2018 12:40:58 -0700
At the beginning of recovery, information from replication slots is
recovered from disk to memory. In order to ensure the durability of the
information, the status file as well as its parent directory are
synced. It happens that the sync on the parent directory was done
directly using the status file path, which is logically incorrect, and
the current code has been doing a sync on the same object twice in a
row.
Reported-by: Konstantin Knizhnik
Diagnosed-by: Konstantin Knizhnik
Author: Michael Paquier
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 9.4-
M src/backend/replication/slot.c
Doc: fix oversights in "Client/Server Character Set Conversions" table.
commit : d368c6c711d03b8bb674274b2b3653985f305248
author : Tom Lane <[email protected]>
date : Sat, 1 Sep 2018 16:02:47 -0400
committer: Tom Lane <[email protected]>
date : Sat, 1 Sep 2018 16:02:47 -0400
This table claimed that JOHAB could be used as a server encoding, which
was true originally but hasn't been true since 8.3. It also lacked
entries for EUC_JIS_2004 and SHIFT_JIS_2004.
JOHAB problem noted by Lars Kanis, the others by me.
Discussion: https://postgr.es/m/[email protected]
M doc/src/sgml/charset.sgml
Avoid using potentially-under-aligned page buffers.
commit : 03ffe5553c1d6238dc235e8d5e8f1295734e5c79
author : Tom Lane <[email protected]>
date : Sat, 1 Sep 2018 15:27:13 -0400
committer: Tom Lane <[email protected]>
date : Sat, 1 Sep 2018 15:27:13 -0400
There's a project policy against using plain "char buf[BLCKSZ]" local
or static variables as page buffers; preferred style is to palloc or
malloc each buffer to ensure it is MAXALIGN'd. However, that policy's
been ignored in an increasing number of places. We've apparently got
away with it so far, probably because (a) relatively few people use
platforms on which misalignment causes core dumps and/or (b) the
variables chance to be sufficiently aligned anyway. But this is not
something to rely on. Moreover, even if we don't get a core dump,
we might be paying a lot of cycles for misaligned accesses.
To fix, invent new union types PGAlignedBlock and PGAlignedXLogBlock
that the compiler must allocate with sufficient alignment, and use
those in place of plain char arrays.
I used these types even for variables where there's no risk of a
misaligned access, since ensuring proper alignment should make
kernel data transfers faster. I also changed some places where
we had been palloc'ing short-lived buffers, for coding style
uniformity and to save palloc/pfree overhead.
Since this seems to be a live portability hazard (despite the lack
of field reports), back-patch to all supported versions.
Patch by me; thanks to Michael Paquier for review.
Discussion: https://postgr.es/m/[email protected]
M contrib/pg_prewarm/pg_prewarm.c
M src/backend/access/gin/ginentrypage.c
M src/backend/access/gin/ginfast.c
M src/backend/access/hash/hashpage.c
M src/backend/access/heap/heapam.c
M src/backend/access/heap/visibilitymap.c
M src/backend/access/transam/xlog.c
M src/backend/access/transam/xloginsert.c
M src/backend/access/transam/xlogreader.c
M src/backend/commands/tablecmds.c
M src/backend/replication/walsender.c
M src/backend/storage/file/buffile.c
M src/backend/storage/freespace/freespace.c
M src/bin/pg_basebackup/receivelog.c
M src/bin/pg_resetxlog/pg_resetxlog.c
M src/bin/pg_rewind/copy_fetch.c
M src/include/c.h
Ignore server-side delays when enforcing wal_sender_timeout.
commit : e3eca937c7432bdbb72cb3033585512cd4438806
author : Noah Misch <[email protected]>
date : Fri, 31 Aug 2018 22:59:58 -0700
committer: Noah Misch <[email protected]>
date : Fri, 31 Aug 2018 22:59:58 -0700
Healthy clients of servers having poor I/O performance, such as
buildfarm members hamster and tern, saw unexpected timeouts. That
disagreed with documentation. This fix adds one gettimeofday() call
whenever ProcessRepliesIfAny() finds no client reply messages.
Back-patch to 9.4; the bug's symptom is rare and mild, and the code all
moved between 9.3 and 9.4.
Discussion: https://postgr.es/m/[email protected]
M src/backend/replication/walsender.c
Ensure correct minimum consistent point on standbys
commit : f3520ff6fbf1e213069ec6ee0d02d2a9bdbc19de
author : Michael Paquier <[email protected]>
date : Fri, 31 Aug 2018 11:04:46 -0700
committer: Michael Paquier <[email protected]>
date : Fri, 31 Aug 2018 11:04:46 -0700
Startup process has improved its calculation of incorrect minimum
consistent point in 8d68ee6, which ensures that all WAL available gets
replayed when doing crash recovery, and has introduced an incorrect
calculation of the minimum recovery point for non-startup processes,
which can cause incorrect page references on a standby when for example
the background writer flushed a couple of pages on-disk but was not
updating the control file to let a subsequent crash recovery replay to
where it should have.
The only case where this has been reported to be a problem is when a
standby needs to calculate the latest removed xid when replaying a btree
deletion record, so one would need connections on a standby that happen
just after recovery has thought it reached a consistent point. Using a
background worker which is started after the consistent point is reached
would be the easiest way to get into problems if it connects to a
database. Having clients which attempt to connect periodically could
also be a problem, but the odds of seeing this problem are much lower.
The fix used is pretty simple, as the idea is to give access to the
minimum recovery point written in the control file to non-startup
processes so as they use a reference, while the startup process still
initializes its own references of the minimum consistent point so as the
original problem with incorrect page references happening post-promotion
with a crash do not show up.
Reported-by: Alexander Kukushkin
Diagnosed-by: Alexander Kukushkin
Author: Michael Paquier
Reviewed-by: Kyotaro Horiguchi, Alexander Kukushkin
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 9.3
M src/backend/access/transam/xlog.c
Enforce cube dimension limit in all cube construction functions
commit : b187dae9d0416423b206ec25941353561a688c9b
author : Alexander Korotkov <[email protected]>
date : Thu, 30 Aug 2018 14:18:53 +0300
committer: Alexander Korotkov <[email protected]>
date : Thu, 30 Aug 2018 14:18:53 +0300
contrib/cube has a limit to 100 dimensions for cube datatype. However, it's
not enforced everywhere, and one can actually construct cube with more than
100 dimensions having then trouble with dump/restore. This commit add checks
for dimensions limit in all functions responsible for cube construction.
Backpatch to all supported versions.
Reported-by: Andrew Gierth
Discussion: https://postgr.es/m/87va7uybt4.fsf%40news-spur.riddles.org.uk
Author: Andrey Borodin with small additions by me
Review: Tom Lane
Backpatch-through: 9.3
M contrib/cube/cube.c
M contrib/cube/expected/cube.out
M contrib/cube/sql/cube.sql
Split contrib/cube platform-depended checks into separate test
commit : 26cbd23259403b27641d6c5a2798052aa3854e01
author : Alexander Korotkov <[email protected]>
date : Thu, 30 Aug 2018 14:09:25 +0300
committer: Alexander Korotkov <[email protected]>
date : Thu, 30 Aug 2018 14:09:25 +0300
We're currently maintaining two outputs for cube regression test. But that
appears to be unsuitable, because these outputs are different in out few checks
involving scientific notation. So, split checks involving scientific notation
into separate test, making contrib/cube easier to maintain. Backpatch to all
supported versions in order to make further backpatching easier.
Discussion: https://postgr.es/m/CAPpHfdvJgWjxHsJTtT%2Bo1tz3OR8EFHcLQjhp-d3%2BUcmJLh-fQA%40mail.gmail.com
Author: Alexander Korotkov
Backpatch-through: 9.3
M contrib/cube/Makefile
M contrib/cube/expected/cube.out
D contrib/cube/expected/cube_1.out
D contrib/cube/expected/cube_2.out
D contrib/cube/expected/cube_3.out
A contrib/cube/expected/cube_sci.out
A contrib/cube/expected/cube_sci_1.out
A contrib/cube/expected/cube_sci_2.out
A contrib/cube/expected/cube_sci_3.out
M contrib/cube/sql/cube.sql
A contrib/cube/sql/cube_sci.sql
Make checksum_impl.h safe to compile with -fstrict-aliasing.
commit : 853af991e35a0355bbb3ac9e941ac044beb89a0e
author : Tom Lane <[email protected]>
date : Fri, 31 Aug 2018 12:26:20 -0400
committer: Tom Lane <[email protected]>
date : Fri, 31 Aug 2018 12:26:20 -0400
In general, Postgres requires -fno-strict-aliasing with compilers that
implement C99 strict aliasing rules. There's little hope of getting
rid of that overall. But it seems like it would be a good idea if
storage/checksum_impl.h in particular didn't depend on it, because
that header is explicitly intended to be included by external programs.
We don't have a lot of control over the compiler switches that an
external program might use, as shown by Michael Banck's report of
failure in a privately-modified version of pg_verify_checksums.
Hence, switch to using a union in place of willy-nilly pointer casting
inside this file. I think this makes the code a bit more readable
anyway.
checksum_impl.h hasn't changed since it was introduced in 9.3,
so back-patch all the way.
Discussion: https://postgr.es/m/[email protected]
M src/include/storage/checksum_impl.h
Stop bgworkers during fast shutdown with postmaster in startup phase
commit : 32f2792eb6163ce7265b22dad4a20ddd1b81c5eb
author : Michael Paquier <[email protected]>
date : Wed, 29 Aug 2018 17:11:40 -0700
committer: Michael Paquier <[email protected]>
date : Wed, 29 Aug 2018 17:11:40 -0700
When a postmaster gets into its phase PM_STARTUP, it would start
background workers using BgWorkerStart_PostmasterStart mode immediately,
which would cause problems for a fast shutdown as the postmaster forgets
to send SIGTERM to already-started background workers. With smart and
immediate shutdowns, this correctly happened, and fast shutdown is the
only mode missing the shot.
Author: Alexander Kukushkin
Reviewed-by: Michael Paquier
Discussion: https://postgr.es/m/CAFh8B=mvnD8+DZUfzpi50DoaDfZRDfd7S=gwj5vU9GYn8UvHkA@mail.gmail.com
Backpatch-through: 9.5
M src/backend/postmaster/postmaster.c
Make pg_restore's identify_locking_dependencies() more bulletproof.
commit : aac21f11df0dbe6ee32ac8151bd1ea2c7987f683
author : Tom Lane <[email protected]>
date : Tue, 28 Aug 2018 19:46:59 -0400
committer: Tom Lane <[email protected]>
date : Tue, 28 Aug 2018 19:46:59 -0400
This function had a blacklist of dump object types that it believed
needed exclusive lock ... but we hadn't maintained that, so that it
was missing ROW SECURITY, POLICY, and INDEX ATTACH items, all of
which need (or should be treated as needing) exclusive lock.
Since the same oversight seems likely in future, let's reverse the
sense of the test so that the code has a whitelist of safe object
types; better to wrongly assume a command can't be run in parallel
than the opposite. Currently the only POST_DATA object type that's
safe is CREATE INDEX ... and that list hasn't changed in a long time.
Back-patch to 9.5 where RLS came in.
Discussion: https://postgr.es/m/[email protected]
M src/bin/pg_dump/pg_backup_archiver.c
Avoid quadratic slowdown in regexp match/split functions.
commit : 41cfae1f37187ecff15b4eba5b732ba350801228
author : Andrew Gierth <[email protected]>
date : Tue, 28 Aug 2018 09:52:25 +0100
committer: Andrew Gierth <[email protected]>
date : Tue, 28 Aug 2018 09:52:25 +0100
regexp_matches, regexp_split_to_table and regexp_split_to_array all
work by compiling a list of match positions as character offsets (NOT
byte positions) in the source string.
Formerly, they then used text_substr to extract the matched text; but
in a multi-byte encoding, that counts the characters in the string,
and the characters needed to reach the starting byte position, on
every call. Accordingly, the performance degraded as the product of
the input string length and the number of match positions, such that
splitting a string of a few hundred kbytes could take many minutes.
Repair by keeping the wide-character copy of the input string
available (only in the case where encoding_max_length is not 1) after
performing the match operation, and extracting substrings from that
instead. This reduces the complexity to being linear in the number of
result bytes, discounting the actual regexp match itself (which is not
affected by this patch).
In passing, remove cleanup using retail pfree() which was obsoleted by
commit ff428cded (Feb 2008) which made cleanup of SRF multi-call
contexts automatic. Also increase (to ~134 million) the maximum number
of matches and provide an error message when it is reached.
Backpatch all the way because this has been wrong forever.
Analysis and patch by me; review by Kaiting Chen.
Discussion: https://postgr.es/m/[email protected]
see also https://postgr.es/m/[email protected]
M src/backend/utils/adt/regexp.c
Fix missing dependency for pg_dump's ENABLE ROW LEVEL SECURITY items.
commit : 3998e55af0505458e99b11bb0b77bb528e647696
author : Tom Lane <[email protected]>
date : Mon, 27 Aug 2018 15:11:12 -0400
committer: Tom Lane <[email protected]>
date : Mon, 27 Aug 2018 15:11:12 -0400
The archive should show a dependency on the item's table, but it failed
to include one. This could cause failures in parallel restore due to
emitting ALTER TABLE ... ENABLE ROW LEVEL SECURITY before restoring
the table's data. In practice the odds of a problem seem low, since
you would typically need to have set FORCE ROW LEVEL SECURITY as well,
and you'd also need a very high --jobs count to have any chance of this
happening. That probably explains the lack of field reports.
Still, it's a bug, so back-patch to 9.5 where RLS was introduced.
Discussion: https://postgr.es/m/[email protected]
M src/bin/pg_dump/pg_dump.c
Make syslogger more robust against failures in opening CSV log files.
commit : 8895daf1bdb206f374b50a723dd9a8e944b74c25
author : Tom Lane <[email protected]>
date : Sun, 26 Aug 2018 14:21:55 -0400
committer: Tom Lane <[email protected]>
date : Sun, 26 Aug 2018 14:21:55 -0400
The previous coding figured it'd be good enough to postpone opening
the first CSV log file until we got a message we needed to write there.
This is unsafe, though, because if the open fails we end up in infinite
recursion trying to report the failure. Instead make the CSV log file
management code look as nearly as possible like the longstanding logic
for the stderr log file. In particular, open it immediately at postmaster
startup (if enabled), or when we get a SIGHUP in which we find that
log_destination has been changed to enable CSV logging.
It seems OK to fail if a postmaster-start-time open attempt fails, as
we've long done for the stderr log file. But we can't die if we fail
to open a CSV log file during SIGHUP, so we're still left with a problem.
In that case, write any output meant for the CSV log file to the stderr
log file. (This will also cover race-condition cases in which backends
send CSV log data before or after we have the CSV log file open.)
This patch also fixes an ancient oversight that, if CSV logging was
turned off during a SIGHUP, we never actually closed the last CSV
log file.
In passing, remember to reset whereToSendOutput = DestNone during syslogger
start, since (unlike all other postmaster children) it's forked before the
postmaster has done that. This made for a platform-dependent difference
in error reporting behavior between the syslogger and other children:
except on Windows, it'd report problems to the original postmaster stderr
as well as the normal error log file(s). It's barely possible that that
was intentional at some point; but it doesn't seem likely to be desirable
in production, and the platform dependency definitely isn't desirable.
Per report from Alexander Kukushkin. It's been like this for a long time,
so back-patch to all supported branches.
Discussion: https://postgr.es/m/CAFh8B==iLUD_gqC-dAENS0V+kVrCeGiKujtKqSQ7++S-caaChw@mail.gmail.com
M src/backend/postmaster/syslogger.c
doc: "Latest checkpoint location" will not match in pg_upgrade
commit : 3e8382996ffaea16e4202172d32ca72b672056b4
author : Bruce Momjian <[email protected]>
date : Sat, 25 Aug 2018 13:35:14 -0400
committer: Bruce Momjian <[email protected]>
date : Sat, 25 Aug 2018 13:35:14 -0400
Mention that "Latest checkpoint location" will not match in pg_upgrade
if the standby server is still running during the upgrade, which is
possible. "Match" text first appeared in PG 9.5.
Reported-by: Paul Bonaud
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 9.5
M doc/src/sgml/ref/pgupgrade.sgml
doc: add doc link for 'applicable_roles'
commit : 56c1d751cf16d7be72131085d70fb027f83d2e1a
author : Bruce Momjian <[email protected]>
date : Sat, 25 Aug 2018 13:01:24 -0400
committer: Bruce Momjian <[email protected]>
date : Sat, 25 Aug 2018 13:01:24 -0400
Reported-by: Ashutosh Sharma
Discussion: https://postgr.es/m/CAE9k0PnhnL6MNDLuvkk8USzOa_DpzDzFQPAM_uaGuXbh9HMKYw@mail.gmail.com
Author: Ashutosh Sharma
Backpatch-through: 9.3
M doc/src/sgml/information_schema.sgml
docs: clarify plpython SD and GD dictionary behavior
commit : 028f855845a5dde3d44ac02dc27a3c6b14dad01e
author : Bruce Momjian <[email protected]>
date : Sat, 25 Aug 2018 11:52:29 -0400
committer: Bruce Momjian <[email protected]>
date : Sat, 25 Aug 2018 11:52:29 -0400
Reported-by: Adam Bielański
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 9.3
M doc/src/sgml/plpython.sgml
Fix lexing of standard multi-character operators in edge cases.
commit : af988d13012f899631d41ab5120e36d8069b1444
author : Andrew Gierth <[email protected]>
date : Thu, 23 Aug 2018 18:29:18 +0100
committer: Andrew Gierth <[email protected]>
date : Thu, 23 Aug 2018 18:29:18 +0100
Commits c6b3c939b (which fixed the precedence of >=, <=, <> operators)
and 865f14a2d (which added support for the standard => notation for
named arguments) created a class of lexer tokens which look like
multi-character operators but which have their own token IDs distinct
from Op. However, longest-match rules meant that following any of
these tokens with another operator character, as in (1<>-1), would
cause them to be incorrectly returned as Op.
The error here isn't immediately obvious, because the parser would
usually still find the correct operator via the Op token, but there
were more subtle problems:
1. If immediately followed by a comment or +-, >= <= <> would be given
the old precedence of Op rather than the correct new precedence;
2. If followed by a comment, != would be returned as Op rather than as
NOT_EQUAL, causing it not to be found at all;
3. If followed by a comment or +-, the => token for named arguments
would be lexed as Op, causing the argument to be mis-parsed as a
simple expression, usually causing an error.
Fix by explicitly checking for the operators in the {operator} code
block in addition to all the existing special cases there.
Backpatch to 9.5 where the problem was introduced.
Analysis and patch by me; review by Tom Lane.
Discussion: https://postgr.es/m/[email protected]
M src/backend/parser/scan.l
M src/bin/psql/psqlscan.l
M src/interfaces/ecpg/preproc/pgc.l
M src/test/regress/expected/create_operator.out
M src/test/regress/expected/polymorphism.out
M src/test/regress/sql/create_operator.sql
M src/test/regress/sql/polymorphism.sql
Reduce an unnecessary O(N^3) loop in lexer.
commit : ad871a9d78841592938a0b24cc961fd1d4185607
author : Andrew Gierth <[email protected]>
date : Thu, 23 Aug 2018 20:00:12 +0100
committer: Andrew Gierth <[email protected]>
date : Thu, 23 Aug 2018 20:00:12 +0100
The lexer's handling of operators contained an O(N^3) hazard when
dealing with long strings of + or - characters; it seems hard to
prevent this case from being O(N^2), but the additional N multiplier
was not needed.
Backpatch all the way since this has been there since 7.x, and it
presents at least a mild hazard in that trying to do Bind, PREPARE or
EXPLAIN on a hostile query could take excessive time (without
honouring cancels or timeouts) even if the query was never executed.
M src/backend/parser/scan.l
M src/bin/psql/psqlscan.l
M src/interfaces/ecpg/preproc/pgc.l
Fix set of NLS translation issues
commit : 6120f2234d7699849a429e5881fdb242fb6b941e
author : Michael Paquier <[email protected]>
date : Tue, 21 Aug 2018 15:18:14 +0900
committer: Michael Paquier <[email protected]>
date : Tue, 21 Aug 2018 15:18:14 +0900
While monitoring the code, a couple of issues related to string
translation has showed up:
- Some routines for auto-updatable views return an error string, which
sometimes missed the shot. A comment regarding string translation is
added for each routine to help with future features.
- GSSAPI authentication missed two translations.
- vacuumdb handles non-translated strings.
Reported-by: Kyotaro Horiguchi
Author: Kyotaro Horiguchi
Reviewed-by: Michael Paquier, Tom Lane
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 9.3
M src/backend/commands/tablecmds.c
M src/backend/commands/view.c
M src/backend/libpq/auth.c
M src/backend/rewrite/rewriteHandler.c
M src/bin/scripts/vacuumdb.c
Ensure schema qualification in pg_restore DISABLE/ENABLE TRIGGER commands.
commit : 3998dfe1b5107e6c39e9c90ca856144e1094385a
author : Tom Lane <[email protected]>
date : Fri, 17 Aug 2018 17:12:21 -0400
committer: Tom Lane <[email protected]>
date : Fri, 17 Aug 2018 17:12:21 -0400
Previously, this code blindly followed the common coding pattern of
passing PQserverVersion(AH->connection) as the server-version parameter
of fmtQualifiedId. That works as long as we have a connection; but in
pg_restore with text output, we don't. Instead we got a zero from
PQserverVersion, which fmtQualifiedId interpreted as "server is too old to
have schemas", and so the name went unqualified. That still accidentally
managed to work in many cases, which is probably why this ancient bug went
undetected for so long. It only became obvious in the wake of the changes
to force dump/restore to execute with restricted search_path.
In HEAD/v11, let's deal with this by ripping out fmtQualifiedId's server-
version behavioral dependency, and just making it schema-qualify all the
time. We no longer support pg_dump from servers old enough to need the
ability to omit schema name, let alone restoring to them. (Also, the few
callers outside pg_dump already didn't work with pre-schema servers.)
In older branches, that's not an acceptable solution, so instead just
tweak the DISABLE/ENABLE TRIGGER logic to ensure it will schema-qualify
its output regardless of server version.
Per bug #15338 from Oleg somebody. Back-patch to all supported branches.
Discussion: https://postgr.es/m/[email protected]
M src/bin/pg_dump/pg_backup_archiver.c
Set scan direction appropriately for SubPlans (bug #15336)
commit : d2ecc27c374ad04b06fc62f365ff9445854153fd
author : Andrew Gierth <[email protected]>
date : Fri, 17 Aug 2018 15:04:26 +0100
committer: Andrew Gierth <[email protected]>
date : Fri, 17 Aug 2018 15:04:26 +0100
When executing a SubPlan in an expression, the EState's direction
field was left alone, resulting in an attempt to execute the subplan
backwards if it was encountered during a backwards scan of a cursor.
Also, though much less likely, it was possible to reach the execution
of an InitPlan while in backwards-scan state.
Repair by saving/restoring estate->es_direction and forcing forward
scan mode in the relevant places.
Backpatch all the way, since this has been broken since 8.3 (prior to
commit c7ff7663e, SubPlans had their own EStates rather than sharing
the parent plan's, so there was no confusion over scan direction).
Per bug #15336 reported by Vladimir Baranoff; analysis and patch by
me, review by Tom Lane.
Discussion: https://postgr.es/m/[email protected]
M src/backend/executor/nodeSubplan.c
M src/test/regress/expected/subselect.out
M src/test/regress/sql/subselect.sql
pg_upgrade: issue helpful error message for use on standbys
commit : 30f480141b646b7ebb86ba1bd880ffa0df503db1
author : Bruce Momjian <[email protected]>
date : Fri, 17 Aug 2018 10:25:48 -0400
committer: Bruce Momjian <[email protected]>
date : Fri, 17 Aug 2018 10:25:48 -0400
Commit 777e6ddf1723306bd2bf8fe6f804863f459b0323 checked for a shut down
message from a standby and allowed it to continue. This patch reports a
helpful error message in these cases, suggesting to use rsync as
documented.
Diagnosed-by: Martín Marqués
Discussion: https://postgr.es/m/CAPdiE1xYCow-reLjrhJ9DqrMu-ppNq0ChUUEvVdxhdjGRD5_eA@mail.gmail.com
Backpatch-through: 9.3
M src/bin/pg_upgrade/controldata.c
Mention ownership requirements for REFRESH MATERIALIZED VIEW in docs
commit : 82784f088986140bc08ab22ae34f4b1cbce58eae
author : Michael Paquier <[email protected]>
date : Fri, 17 Aug 2018 11:29:15 +0900
committer: Michael Paquier <[email protected]>
date : Fri, 17 Aug 2018 11:29:15 +0900
Author: Dian Fay
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 9.3
M doc/src/sgml/ref/refresh_materialized_view.sgml
Close the file descriptor in ApplyLogicalMappingFile
commit : 864ecd716a0dd191e587dd09e24992be5e720b26
author : Tomas Vondra <[email protected]>
date : Thu, 16 Aug 2018 16:49:10 +0200
committer: Tomas Vondra <[email protected]>
date : Thu, 16 Aug 2018 16:49:10 +0200
The function was forgetting to close the file descriptor, resulting
in failures like this:
ERROR: 53000: exceeded maxAllocatedDescs (492) while trying to open
file "pg_logical/mappings/map-4000-4eb-1_60DE1E08-5376b5-537c6b"
LOCATION: OpenTransientFile, fd.c:2161
Simply close the file at the end, and backpatch to 9.4 (where logical
decoding was introduced). While at it, fix a nearby typo.
Discussion: https://www.postgresql.org/message-id/flat/738a590a-2ce5-9394-2bef-7b1caad89b37%402ndquadrant.com
M src/backend/replication/logical/reorderbuffer.c
Make snprintf.c follow the C99 standard for snprintf's result value.
commit : 8e9f229d2bf668e780ce10d511925b11855afd2c
author : Tom Lane <[email protected]>
date : Wed, 15 Aug 2018 17:25:23 -0400
committer: Tom Lane <[email protected]>
date : Wed, 15 Aug 2018 17:25:23 -0400
C99 says that the result should be the number of bytes that would have
been emitted given a large enough buffer, not the number we actually
were able to put in the buffer. It's time to make our substitute
implementation comply with that. Not doing so results in inefficiency
in buffer-enlargement cases, and also poses a portability hazard for
third-party code that might expect C99-compliant snprintf behavior
within Postgres.
In passing, remove useless tests for str == NULL; neither C99 nor
predecessor standards ever allowed that except when count == 0,
so I see no reason to expend cycles on making that a non-crash case
for this implementation. Also, don't waste a byte in pg_vfprintf's
local I/O buffer; this might have performance benefits by allowing
aligned writes during flushbuffer calls.
Back-patch of commit 805889d7d. There was some concern about this
possibly breaking code that assumes pre-C99 behavior, but there is
much more risk (and reality, in our own code) of code that assumes
C99 behavior and hence fails to detect buffer overrun without this.
Discussion: https://postgr.es/m/[email protected]
M src/port/snprintf.c
Clean up assorted misuses of snprintf()'s result value.
commit : c81062e8e12f4186a4d7d95e07541883f4e1d87e
author : Tom Lane <[email protected]>
date : Wed, 15 Aug 2018 16:29:32 -0400
committer: Tom Lane <[email protected]>
date : Wed, 15 Aug 2018 16:29:32 -0400
Fix a small number of places that were testing the result of snprintf()
but doing so incorrectly. The right test for buffer overrun, per C99,
is "result >= bufsize" not "result > bufsize". Some places were also
checking for failure with "result == -1", but the standard only says
that a negative value is delivered on failure.
(Note that this only makes these places correct if snprintf() delivers
C99-compliant results. But at least now these places are consistent
with all the other places where we assume that.)
Also, make psql_start_test() and isolation_start_test() check for
buffer overrun while constructing their shell commands. There seems
like a higher risk of overrun, with more severe consequences, here
than there is for the individual file paths that are made elsewhere
in the same functions, so this seemed like a worthwhile change.
Also fix guc.c's do_serialize() to initialize errno = 0 before
calling vsnprintf. In principle, this should be unnecessary because
vsnprintf should have set errno if it returns a failure indication ...
but the other two places this coding pattern is cribbed from don't
assume that, so let's be consistent.
These errors are all very old, so back-patch as appropriate. I think
that only the shell command overrun cases are even theoretically
reachable in practice, but there's not much point in erroneous error
checks.
Discussion: https://postgr.es/m/[email protected]
M src/backend/libpq/ip.c
M src/backend/postmaster/pgstat.c
M src/backend/utils/misc/guc.c
M src/interfaces/ecpg/pgtypeslib/common.c
M src/port/getaddrinfo.c
M src/test/isolation/isolation_main.c
M src/test/regress/pg_regress.c
M src/test/regress/pg_regress_main.c
pg_upgrade: fix shutdown check for standby servers
commit : dcca996270529b4a4b2cf16bb03e0d524d80b1c0
author : Bruce Momjian <[email protected]>
date : Tue, 14 Aug 2018 17:19:02 -0400
committer: Bruce Momjian <[email protected]>
date : Tue, 14 Aug 2018 17:19:02 -0400
Commit 244142d32afd02e7408a2ef1f249b00393983822 only tested for the
pg_controldata output for primary servers, but standby servers have
different "Database cluster state" output, so check for that too.
Diagnosed-by: Michael Paquier
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 9.3
M src/bin/pg_upgrade/controldata.c
docs: Only first instance of a PREPARE parameter sets data type
commit : 69467eb38358192580ae47a8ef6459f133d9baba
author : Bruce Momjian <[email protected]>
date : Thu, 9 Aug 2018 10:13:15 -0400
committer: Bruce Momjian <[email protected]>
date : Thu, 9 Aug 2018 10:13:15 -0400
If the first reference to $1 is "($1 = col) or ($1 is null)", the data
type can be determined, but not for "($1 is null) or ($1 = col)". This
change documents this.
Reported-by: Morgan Owens
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 9.3
M doc/src/sgml/ref/prepare.sgml
Don't run atexit callbacks in quickdie signal handlers.
commit : f318f7fdf85a269ed652e16f67015c3dde960754
author : Heikki Linnakangas <[email protected]>
date : Wed, 8 Aug 2018 19:08:10 +0300
committer: Heikki Linnakangas <[email protected]>
date : Wed, 8 Aug 2018 19:08:10 +0300
exit() is not async-signal safe. Even if the libc implementation is, 3rd
party libraries might have installed unsafe atexit() callbacks. After
receiving SIGQUIT, we really just want to exit as quickly as possible, so
we don't really want to run the atexit() callbacks anyway.
The original report by Jimmy Yih was a self-deadlock in startup_die().
However, this patch doesn't address that scenario; the signal handling
while waiting for the startup packet is more complicated. But at least this
alleviates similar problems in the SIGQUIT handlers, like that reported
by Asim R P later in the same thread.
Backpatch to 9.3 (all supported versions).
Discussion: https://www.postgresql.org/message-id/CAOMx_OAuRUHiAuCg2YgicZLzPVv5d9_H4KrL_OFsFP%3DVPekigA%40mail.gmail.com
M src/backend/postmaster/bgworker.c
M src/backend/postmaster/bgwriter.c
M src/backend/postmaster/checkpointer.c
M src/backend/postmaster/startup.c
M src/backend/postmaster/walwriter.c
M src/backend/replication/walreceiver.c
M src/backend/tcop/postgres.c
Don't record FDW user mappings as members of extensions.
commit : 74c877e8db23df20004f80dd11e383da8cc187a2
author : Tom Lane <[email protected]>
date : Tue, 7 Aug 2018 16:32:50 -0400
committer: Tom Lane <[email protected]>
date : Tue, 7 Aug 2018 16:32:50 -0400
CreateUserMapping has a recordDependencyOnCurrentExtension call that's
been there since extensions were introduced (very possibly my fault).
However, there's no support anywhere else for user mappings as members
of extensions, nor are they listed as a possible member object type in
the documentation. Nor does it really seem like a good idea for user
mappings to belong to extensions when roles don't. Hence, remove the
bogus call.
(As we saw in bug #15310, the lack of any pg_dump support for this case
ensures that any such membership record would silently disappear during
pg_upgrade. So there's probably no need for us to do anything else
about cleaning up after this mistake.)
Discussion: https://postgr.es/m/[email protected]
M src/backend/commands/foreigncmds.c
Fix incorrect initialization of BackendActivityBuffer.
commit : 0667d889ea9b9ae298ca899fa53484703bc8fdaf
author : Tom Lane <[email protected]>
date : Tue, 7 Aug 2018 16:00:44 -0400
committer: Tom Lane <[email protected]>
date : Tue, 7 Aug 2018 16:00:44 -0400
Since commit c8e8b5a6e, this has been zeroed out using the wrong length.
In practice the length would always be too small, leading to not zeroing
the whole buffer rather than clobbering additional memory; and that's
pretty harmless, both because shmem would likely start out as zeroes
and because we'd reinitialize any given entry before use. Still,
it's bogus, so fix it.
Reported by Petru-Florin Mihancea (bug #15312)
Discussion: https://postgr.es/m/[email protected]
M src/backend/postmaster/pgstat.c
Fix pg_upgrade to handle event triggers in extensions correctly.
commit : 91f6ec2994ff7a86a1bb37c92937c51d07c77422
author : Tom Lane <[email protected]>
date : Tue, 7 Aug 2018 15:43:49 -0400
committer: Tom Lane <[email protected]>
date : Tue, 7 Aug 2018 15:43:49 -0400
pg_dump with --binary-upgrade must emit ALTER EXTENSION ADD commands
for all objects that are members of extensions. It forgot to do so for
event triggers, as per bug #15310 from Nick Barnes. Back-patch to 9.3
where event triggers were introduced.
Haribabu Kommi
Discussion: https://postgr.es/m/[email protected]
M src/bin/pg_dump/pg_dump.c
Ensure pg_dump_sort.c sorts null vs non-null namespace consistently.
commit : f3f6558b5d767317baad6934c6bd0def3bd601bd
author : Tom Lane <[email protected]>
date : Tue, 7 Aug 2018 13:13:42 -0400
committer: Tom Lane <[email protected]>
date : Tue, 7 Aug 2018 13:13:42 -0400
The original coding here (which is, I believe, my fault) supposed that
it didn't need to concern itself with the possibility that one object
of a given type-priority has a namespace while another doesn't. But
that's not reliably true anymore, if it ever was; and if it does happen
then it's possible that DOTypeNameCompare returns self-inconsistent
comparison results. That leads to unspecified behavior in qsort()
and a resultant weird output order from pg_dump.
This should end up being only a cosmetic problem, because any ordering
constraints that actually matter should be enforced by the later
dependency-based sort. Still, it's a bug, so back-patch.
Report and fix by Jacob Champion, though I editorialized on his
patch to the extent of making NULL sort after non-NULL, for consistency
with our usual sorting definitions.
Discussion: https://postgr.es/m/CABAq_6Hw+V-Kj7PNfD5tgOaWT_-qaYkc+SRmJkPLeUjYXLdxwQ@mail.gmail.com
M src/bin/pg_dump/pg_dump_sort.c